GNU bug report logs - #66196
30.0.50; Address defcustom :type warnings

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66196 in the body.
You can then email your comments to 66196 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; Address defcustom :type warnings
Date: Mon, 25 Sep 2023 21:25:33 +0200

[Message part 1 (text/plain, inline)]

Severity: minor
Tags: patch

Building master, I see the following (abridged) warnings:

     diary-lib.el: ‘diary-display-function’     : misplaced :tag keyword in ‘const’ type
     icalendar.el: ‘icalendar-export-alarms’    : misplaced :tag keyword in ‘const’ type
         elint.el: ‘elint-ignored-warnings’     : misplaced :tag keyword in ‘const’ type
     mm-decode.el: ‘mm-text-html-renderer’      : misplaced :tag keyword in ‘const’ type
       message.el: ‘message-send-mail-function’ : misplaced :tag keyword in ‘function-item’ type
                   ‘message-tool-bar’           : duplicated :type keyword argument
      sendmail.el: ‘send-mail-function’         : misplaced :tag keyword in ‘function-item’ type
        gnutls.el: ‘gnutls-verify-error’        : misplaced :tag keyword in ‘const’ type
       idlwave.el: ‘idlwave-begin-line-comment’ : type should not be quoted: regexp
       ps-mode.el: ‘ps-mode-paper-size’         : duplicated value in ‘choice’: ‘(612 936)’
glyphless-mode.el: ‘glyphless-mode-types’       : duplicated value in ‘choice’: ‘no-font’

The warnings appear only on master, but their underlying cause can be
fixed on emacs-29.

Is the attached patch okay for emacs-29?

Thanks,
-- 
Basil

[0001-Address-defcustom-type-warnings.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.17.8, Xaw3d scroll bars) of 2023-09-21 built on tia
Repository revision: 57c6c067d35e519bc3787966cd6346904bc75e16
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101008
System Description: Debian GNU/Linux trixie/sid

Configured using:
 'configure 'CFLAGS=-O2 -ggdb3' -C --prefix=/home/blc/.local
 --enable-checking=structs --with-file-notification=yes
 --with-x-toolkit=lucid --with-x'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XAW3D XDBE XIM XINPUT2 XPM
LUCID ZLIB

Important settings:
  value of $LANG: en_IE.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  minibuffer-regexp-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search time-date subr-x mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset
image regexp-opt fringe tabulated-list replace newcomment text-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo x-toolkit
xinput2 x multi-tty move-toolbar make-network-process emacs)

Memory information:
((conses 16 38028 9284) (symbols 48 5209 0) (strings 32 14018 1699)
 (string-bytes 1 384875) (vectors 16 10297)
 (vector-slots 8 156208 14956) (floats 8 23 23) (intervals 56 259 0)
 (buffers 992 10))

Message #8 received at 66196 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 66196 <at> debbugs.gnu.org
Subject: Re: bug#66196: 30.0.50; Address defcustom :type warnings
Date: Tue, 26 Sep 2023 05:46:06 +0300

> Date: Mon, 25 Sep 2023 21:25:33 +0200
> From:  "Basil L. Contovounesios" via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> The warnings appear only on master, but their underlying cause can be
> fixed on emacs-29.
> 
> Is the attached patch okay for emacs-29?

Please install on master, and thanks.

Message #13 received at 66196-done <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 66196-done <at> debbugs.gnu.org
Subject: Re: bug#66196: 30.0.50; Address defcustom :type warnings
Date: Tue, 26 Sep 2023 09:33:58 +0200

close 66196 30.1
quit

Eli Zaretskii [2023-09-26 05:46 +0300] wrote:

>> Date: Mon, 25 Sep 2023 21:25:33 +0200
>> From:  "Basil L. Contovounesios" via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> 
>> The warnings appear only on master, but their underlying cause can be
>> fixed on emacs-29.
>> 
>> Is the attached patch okay for emacs-29?
>
> Please install on master, and thanks.

Done, thanks.

Address defcustom :type warnings
ff2a02afa63 2023-09-26 09:29:39 +0200
https://git.sv.gnu.org/cgit/emacs.git/commit/?id=ff2a02afa63

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.