GNU bug report logs - #66191
erc-ibuffer.el: suspicious use of hash-table-size

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Subject: bug#66191: closed (Re: bug#66191: erc-ibuffer.el: suspicious use
 of hash-table-size)
Date: Tue, 03 Oct 2023 01:21:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#66191: erc-ibuffer.el: suspicious use of hash-table-size

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 66191 <at> debbugs.gnu.org.

-- 
66191: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66191
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "J.P." <jp <at> neverwas.me>
To: 66191-done <at> debbugs.gnu.org
Cc: Mattias Engdegård <mattias.engdegard <at> gmail.com>,
 emacs-erc <at> gnu.org
Subject: Re: bug#66191: erc-ibuffer.el: suspicious use of hash-table-size
Date: Mon, 02 Oct 2023 18:20:21 -0700

"J.P." <jp <at> neverwas.me> writes:

> If no one says anything, I will add it or something similar in a few
> days.

I ended up only installing the bug fix portions, but I may open another
report for the feature parts eventually. Thanks and closing.

[Message part 3 (message/rfc822, inline)]

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Emacs Bug Report <bug-gnu-emacs <at> gnu.org>
Cc: "J.P." <jp <at> neverwas.me>
Subject: erc-ibuffer.el: suspicious use of hash-table-size
Date: Mon, 25 Sep 2023 11:45:16 +0200

In erc-ibuffer.el:

(define-ibuffer-column
 erc-members (:name "Users")
  (if (and (eq major-mode 'erc-mode)
	   (boundp 'erc-channel-users)
	   (hash-table-p erc-channel-users)
	   (> (hash-table-size erc-channel-users) 0))
     (number-to-string (hash-table-size erc-channel-users))
    ""))

Perhaps I'm mistaken but shouldn't hash-table-size be hash-table-count here?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.