Subject: bug#66191: closed (Re: bug#66191: erc-ibuffer.el: suspicious use of hash-table-size)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 03 Oct 2023 01:21:02 +0000

Your bug report

#66191: erc-ibuffer.el: suspicious use of hash-table-size

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
66191: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66191
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#66191: erc-ibuffer.el: suspicious use of hash-table-size
From: "J.P." <[email-masked]>
To: [email-masked]
Cc: Mattias Engdegård <[email-masked]>, [email-masked]
Date: Mon, 02 Oct 2023 18:20:21 -0700
List-Id: <debbugs-submit.debbugs.gnu.org>

"J.P." <[email-masked]> writes:

> If no one says anything, I will add it or something similar in a few
> days.

I ended up only installing the bug fix portions, but I may open another
report for the feature parts eventually. Thanks and closing.

Subject: erc-ibuffer.el: suspicious use of hash-table-size
From: Mattias Engdegård <[email-masked]>
To: Emacs Bug Report <[email-masked]>
Cc: "J.P." <[email-masked]>
Date: Mon, 25 Sep 2023 11:45:16 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

In erc-ibuffer.el:

(define-ibuffer-column
 erc-members (:name "Users")
  (if (and (eq major-mode 'erc-mode)
	   (boundp 'erc-channel-users)
	   (hash-table-p erc-channel-users)
	   (> (hash-table-size erc-channel-users) 0))
     (number-to-string (hash-table-size erc-channel-users))
    ""))

Perhaps I'm mistaken but shouldn't hash-table-size be hash-table-count here?