From unknown Tue Jun 17 20:27:06 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#66181 <66181@debbugs.gnu.org> To: bug#66181 <66181@debbugs.gnu.org> Subject: Status: Subject: 29.1; Occur changes don't affect Dired buffer Reply-To: bug#66181 <66181@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:27:06 +0000 retitle 66181 Subject: 29.1; Occur changes don't affect Dired buffer reassign 66181 emacs submitter 66181 Maske severity 66181 normal tag 66181 confirmed thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 24 10:51:10 2023 Received: (at submit) by debbugs.gnu.org; 24 Sep 2023 14:51:10 +0000 Received: from localhost ([127.0.0.1]:43405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkQRw-0003gc-NM for submit@debbugs.gnu.org; Sun, 24 Sep 2023 10:51:10 -0400 Received: from lists.gnu.org ([2001:470:142::17]:55600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkNQs-0006vI-Nw for submit@debbugs.gnu.org; Sun, 24 Sep 2023 07:37:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkNQa-0002rC-KQ for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2023 07:37:32 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qkNQY-0004Ng-Ix for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2023 07:37:32 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-31dcf18f9e2so4547905f8f.0 for ; Sun, 24 Sep 2023 04:37:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695555448; x=1696160248; darn=gnu.org; h=to:subject:content-language:user-agent:mime-version:date:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=6XK14KwJjmn9vKDCnPAVjir2XkQMdoAi3cL3kJgP75I=; b=KEJ3M5nkHUTfkQUR3u1QjOgOAH97A4BGOx5fAjbOdjVNiQPBv5G29itaoJNndUi4y0 0K8d5TsT2PiXbWqMQJTihEIlAzkZEYwIjAp2cKWGGkozmDbHSfhrYQc2fi3zwRGrspli G83v9WdiV1eutyLhc5Fy6mLeABOk8KDC4Umh4TPnY1lOxnBbtWi/ERnizsV9A6pu4yAv S7iVHRTvNUT3wj6PsREx/ZkdqGDO7Cc7/N5hXxQiQgmQH1k47zZN+vZFfmOPaFBt/BXu lnFtPpzoWneji93nKP0LrtQ9H4xQvMuYBjAxlEeW/IWmUIYOIZ/RcdEfBgYOd+Su7wMy GhVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695555448; x=1696160248; h=to:subject:content-language:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6XK14KwJjmn9vKDCnPAVjir2XkQMdoAi3cL3kJgP75I=; b=kXMQG3S7lKwqn64LFzMxmEiZSMTapH2BH+BCsRyFP2xHS46Djg/V7bQTlRr24hOtWa 47Jqn2Hr8WZjDDbUpPGsmVbrIS+AmRxR03JPlCS28BdJzP8raNX7WeJG3lEO7PBQQW1v 95Zsw6NRodlJ3Vux7Dx6Hn2D/9/gJI/wpgEEn6VOgHWFWpyx6h0iw74Q536mvNAYW3Ij O1AvE5RHpMeXM29EJ6hltZVsfdzEx4I3FhRuPmBUTkKcYieby2kZxRQqZ9UpGKijVN2Y XDL5O7os6mbMt5Hx6Yej8CZNcpuBBHSBK93tEr7heShRmyFD1wbgtwJyZj34t/S7GCeu +09Q== X-Gm-Message-State: AOJu0Yx/43UhJIvTCPQpTITXaBtNZUOuS54XIjxQ9605GNSIpD9THf+B 1tIXGj7W0WqPywjrygt5/CdTDbi9+ZE= X-Google-Smtp-Source: AGHT+IFU8kzRqsTLaVs7XdRNtMfLfXaIj9yvymQSEdUB7Utr9I7VOMNT2gTlrlufnBAU4JhIKq13Qw== X-Received: by 2002:adf:e945:0:b0:317:7062:32d2 with SMTP id m5-20020adfe945000000b00317706232d2mr3829923wrn.54.1695555448145; Sun, 24 Sep 2023 04:37:28 -0700 (PDT) Received: from [192.168.0.97] ([47.63.54.35]) by smtp.gmail.com with ESMTPSA id o11-20020a056000010b00b0031c52e81490sm9137086wrx.72.2023.09.24.04.37.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Sep 2023 04:37:27 -0700 (PDT) From: Maske X-Google-Original-From: Maske Content-Type: multipart/alternative; boundary="------------isfydWi8K3pY7UO5Oegrz6Oo" Message-ID: Date: Sun, 24 Sep 2023 13:32:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Content-Language: en-GB Subject: Subject: 29.1; Occur changes don't affect Dired buffer To: bug-gnu-emacs@gnu.org Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=kediez@gmail.com; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 24 Sep 2023 10:51:07 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a multi-part message in MIME format. --------------isfydWi8K3pY7UO5Oegrz6Oo Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I read a post, where Occur is used to edit a Dired buffer. Well, it doesn't work: - Tested in emacs -q - Make Dired buffer writable - Launch Occur - Make Occur buffer editable - Make changes in Occur buffer - Changes are not saved in Dired buffer. The mentioned post: https://emacs.ch/@ramin_hal9001/110933437057616428 --------------isfydWi8K3pY7UO5Oegrz6Oo Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

I read a post, where Occur is used to edit a Dired buffer. Well, it
doesn't work:

- Tested in emacs -q
- Make Dired buffer writable
- Launch Occur
- Make Occur buffer editable
- Make changes in Occur buffer
- Changes are not saved in Dired buffer.

The mentioned post: https://emacs.ch/@ramin_hal9001/110933437057616428


--------------isfydWi8K3pY7UO5Oegrz6Oo-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 24 14:01:36 2023 Received: (at 66181) by debbugs.gnu.org; 24 Sep 2023 18:01:36 +0000 Received: from localhost ([127.0.0.1]:43579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkTQE-0003EN-J1 for submit@debbugs.gnu.org; Sun, 24 Sep 2023 14:01:35 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:57055) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkRrJ-0006Cc-2X for 66181@debbugs.gnu.org; Sun, 24 Sep 2023 12:21:26 -0400 Received: by mail.gandi.net (Postfix) with ESMTPA id A5608E0005; Sun, 24 Sep 2023 16:21:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=garjola.net; s=gm1; t=1695572466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iQfL/dX/gerSR6HvHteBqoYAL0LP47XEbcOibQZWrRU=; b=BH5+MRZhKfqKMEibnmQRhrqbhp+0CTmh5y6pkqbq1ONzk7CtZLnbCie0C8Yw1ukQOrKAEE NbSDpqy/5RXs3gXCXrLOCsGa6iiHGtppgJ2oxU6tT1ZDjjCMI2iWwKLhsq66uMYId5Hb/s /ohIGMjlSxjKRa86mebImK1kuv36QpR+4AkLD5i+nfoNVa1KsvE9BIpy97DT9axD146aGp 4acoWLP2iQqoOScWNWndN7qdmUbZjseJodgojxjxM17RFod/KZ7gAGBz16w9eRuv8W06QO fymbktdRz4+zItGOIRzvUcdwjcCgyhqVdXCVsLpIaMBdugWKfXadI1LA71y2dA== From: Garjola Dindi To: 66181@debbugs.gnu.org Subject: Re: bug#66181: Subject: 29.1; Occur changes don't affect Dired buffer In-Reply-To: (Maske's message of "Sun, 24 Sep 2023 13:32:04 +0200") References: Date: Sun, 24 Sep 2023 18:21:03 +0200 Message-ID: <87y1gv4k5s.fsf@pc-117-162.gandi.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: garjola@garjola.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 66181 X-Mailman-Approved-At: Sun, 24 Sep 2023 14:01:33 -0400 Cc: Maske X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun 24-Sep-2023 at 13:32:04 +02, Maske wrote: > I read a post, where Occur is used to edit a Dired buffer. Well, it > doesn't work: > > - Tested in emacs -q > - Make Dired buffer writable > - Launch Occur > - Make Occur buffer editable > - Make changes in Occur buffer > - Changes are not saved in Dired buffer. > > The mentioned post: https://emacs.ch/@ramin_hal9001/110933437057616428 Confirmed with GNU Emacs 30.0.50 (build 7, x86_64-pc-linux-gnu, GTK+ Version 3.24.37, cairo version 1.16.0) of 2023-09-16 From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 24 14:01:36 2023 Received: (at control) by debbugs.gnu.org; 24 Sep 2023 18:01:36 +0000 Received: from localhost ([127.0.0.1]:43581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkTQG-0003EQ-03 for submit@debbugs.gnu.org; Sun, 24 Sep 2023 14:01:36 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:47071) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkRta-0006Gi-PG for control@debbugs.gnu.org; Sun, 24 Sep 2023 12:23:47 -0400 Received: by mail.gandi.net (Postfix) with ESMTPA id 7BB751BF203 for ; Sun, 24 Sep 2023 16:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=garjola.net; s=gm1; t=1695572608; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=LTb6OwPkEm9b1uChcFGOyR2WmqRE4ITBXiyPr9/4F10=; b=MU1mptUhJYpnzozCf+XE3or0cQZZ2oAkJ8lzKGLUoEojt+fk1YlNDfVCzcsL42x7hdUZEY ERerDeAVCxvo7WZ9AEXiH/+0JSfxIJB+eCG7pPdSsgOLKAQVQJammEKmjrP6MmgU+H1Bol Yvawh6o2a9iPjHNdYpDuwbH6zZIFYsritic6dkcD2paJCjTgEDtAl2hBIzVUtC5BzSGQVo z9Zb8nNq6hrV9r3KvSeGocpk9IVXH43Gg+vw7Z7Ml4zHe+xuIhVjWaldDDzYY6G1rgl0t7 JOCSOKpd+tNYR50CbYeNmHPgoP0xIs1+ZUSBU1OJaCEBl1mGup99NqO2Qbmb5Q== From: Garjola Dindi To: control@debbugs.gnu.org Subject: control message for bug #66181 Date: Sun, 24 Sep 2023 18:23:26 +0200 Message-ID: <87ttrj4k1t.fsf@pc-117-162.gandi.net> MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: garjola@garjola.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-Mailman-Approved-At: Sun, 24 Sep 2023 14:01:33 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) tags 66181 + confirmed quit -- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 25 03:30:14 2023 Received: (at 66181) by debbugs.gnu.org; 25 Sep 2023 07:30:14 +0000 Received: from localhost ([127.0.0.1]:44023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkg2o-0005Jy-87 for submit@debbugs.gnu.org; Mon, 25 Sep 2023 03:30:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkg2k-0005Ic-F6 for 66181@debbugs.gnu.org; Mon, 25 Sep 2023 03:30:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkg2S-0002z8-OP; Mon, 25 Sep 2023 03:29:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xE0GJJwmoB2BvI8sVwx22B9sC2QyVngVf/NsZL5bpB4=; b=jAg1uhMBUPza IqNgCszQXGKX0gJDaApWdLAqNLYkboDcyIwXMq55CPiihbaDjI58w+rBjM4dSe5gIassGV6Ke9FWH U5f+licWvdKZKA30uZkv8BzgdnP13Ou9kkJWs0IcC0bFb/Nb3bDr3ojvkqWuEmE6WBZ5Ohdjp3Au/ HDxDew8OG2gQAX5b2doRQ/sIvCb60tCwJtFJ/gqF1jjAt14HHCecvtx+Evf8hZPKRKz08u6qbJyoi lgzUBRV0lHZI+HpIih2T9ood4T9EpSu3GT+PVSE2nlsfMvfju5Ra3xXcQlx3lD9OzPCBNkGZ6HfWy FnKe3WCGNibq8Gy5ilOLUg==; Date: Mon, 25 Sep 2023 10:29:17 +0300 Message-Id: <83bkdq3e42.fsf@gnu.org> From: Eli Zaretskii To: Maske In-Reply-To: (message from Maske on Sun, 24 Sep 2023 13:32:04 +0200) Subject: Re: bug#66181: Subject: 29.1; Occur changes don't affect Dired buffer References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66181 Cc: 66181@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Maske > Date: Sun, 24 Sep 2023 13:32:04 +0200 > > I read a post, where Occur is used to edit a Dired buffer. Well, it > doesn't work: > > - Tested in emacs -q > - Make Dired buffer writable > - Launch Occur > - Make Occur buffer editable > - Make changes in Occur buffer > - Changes are not saved in Dired buffer. The last item is inaccurate. The changes in the Occur buffer _are_ reflected in the Dired buffer, but typing "C-c C-c" in the Dired buffer doesn't commit the changes to disk; instead it says "No changes to be performed" and reverts to the previous display of Dired. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 25 04:43:20 2023 Received: (at 66181) by debbugs.gnu.org; 25 Sep 2023 08:43:20 +0000 Received: from localhost ([127.0.0.1]:44134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkhBY-0007Hu-AR for submit@debbugs.gnu.org; Mon, 25 Sep 2023 04:43:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkhBW-0007Hh-0F for 66181@debbugs.gnu.org; Mon, 25 Sep 2023 04:43:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkhBD-0008Ay-To; Mon, 25 Sep 2023 04:42:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Qypdlp9dhNEPisTDbJ9CQ/IE7ByqKLMSfr20qHaNMMs=; b=hXElt+Q7EJnJ o4EOFhQ37FyCUIgHFVbq5Gdl9oUlwQUXAUkrruYRfRfviNo3EFUe0RYfMQl3XKy4bpM4rXSEKr9to 5Zg6jsRFoXu9Lp1lSDLQGKjrNa2kixw/ChyVELrV910+mtMhpK324RBigN+Hg0V9Y22NmSe5dkbW2 1FrxylsISAckCleHi0Fg13wh6vzxs/ccmf8iQt/eITJ0aXjxBNVdHH79xUmO/gjAUsPFru8y+60Dv QCM7YzHpyEjmWoQyGFcnzK/CW3lmHxCwUUMgQ5Q2FZrxqsYR8PYWAY0EX58rNTDgp19+Qb/AohFXB D+1V2OiMFgNMeA3wZMDVlQ==; Date: Mon, 25 Sep 2023 11:42:28 +0300 Message-Id: <837coe3aq3.fsf@gnu.org> From: Eli Zaretskii To: kediez@gmail.com, Stefan Monnier In-Reply-To: <83bkdq3e42.fsf@gnu.org> (message from Eli Zaretskii on Mon, 25 Sep 2023 10:29:17 +0300) Subject: Re: bug#66181: Subject: 29.1; Occur changes don't affect Dired buffer References: <83bkdq3e42.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66181 Cc: 66181@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 66181@debbugs.gnu.org > Date: Mon, 25 Sep 2023 10:29:17 +0300 > From: Eli Zaretskii > > > From: Maske > > Date: Sun, 24 Sep 2023 13:32:04 +0200 > > > > I read a post, where Occur is used to edit a Dired buffer. Well, it > > doesn't work: > > > > - Tested in emacs -q > > - Make Dired buffer writable > > - Launch Occur > > - Make Occur buffer editable > > - Make changes in Occur buffer > > - Changes are not saved in Dired buffer. > > The last item is inaccurate. The changes in the Occur buffer _are_ > reflected in the Dired buffer, but typing "C-c C-c" in the Dired > buffer doesn't commit the changes to disk; instead it says "No changes > to be performed" and reverts to the previous display of Dired. This happens because WDired relies on before-change-functions to mark the portions of the Dired buffer which were edited. But Occur Edit mode modifies the target buffer from an after-change function, so buffer-modification hooks are disabled when the modifications are performed, and the before-change function installed by WDired isn't called. Which also means that any mode that relies on buffer-modification hooks will fail with the same symptoms when its buffer is edited indirectly via Occur Edit. Stefan, do we have any safe means of running the hooks in this case? I thought about running the buffer-local values of before- and after-change-functions by hand from occur-after-change-function, skipping the t entry, but I'm not sure this is safe. It is certainly messy, so if there's a more elegant way, I'd like to know. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 25 09:08:08 2023 Received: (at 66181) by debbugs.gnu.org; 25 Sep 2023 13:08:08 +0000 Received: from localhost ([127.0.0.1]:44557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qklJn-0000Ow-QT for submit@debbugs.gnu.org; Mon, 25 Sep 2023 09:08:08 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:45380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qklJi-0000OO-Js for 66181@debbugs.gnu.org; Mon, 25 Sep 2023 09:08:05 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id DEFBC80595; Mon, 25 Sep 2023 09:07:44 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1695647263; bh=GDcIg6Cb+4x1GlAwfqiZG4hjquT5RUsRlgiLSCBfjY0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Q7AcHvZoFkHJWRxuqBagN4PC4LfJkQq/aH2XEXsCWjmXKYeSor/JDFoc5ulvprWDu BiGbpcgtnfIUXXp1pz6Y65SaDtv0rS3h+y8aBZQVZdLKK9s5DlI2nKZnHSMI4lmWU9 enqrd/v6e1ArnCYfc/PNPXZbEsCYDntcD1e2knF8GLOTYV+fRF0DWek657a4+2H83D qQpPros1JKks6MF2UAFm9hWk9ooVSJFHcLjV9KHdX40Dz6Uce1pcPrN1oYARxU5TVi i566Gnqhe9aUggSGRNByGte2Y+6qmZ0fbqdSgbQs0WvXjgbkuxLoUgL9ezwQflnB2l LMMC1KD8JjA+Q== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 98E33803A6; Mon, 25 Sep 2023 09:07:43 -0400 (EDT) Received: from pastel (unknown [45.72.200.56]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3DDAF120224; Mon, 25 Sep 2023 09:07:43 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#66181: Subject: 29.1; Occur changes don't affect Dired buffer In-Reply-To: <837coe3aq3.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 25 Sep 2023 11:42:28 +0300") Message-ID: References: <83bkdq3e42.fsf@gnu.org> <837coe3aq3.fsf@gnu.org> Date: Mon, 25 Sep 2023 09:07:42 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66181 Cc: 66181@debbugs.gnu.org, kediez@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Stefan, do we have any safe means of running the hooks in this case? > I thought about running the buffer-local values of before- and > after-change-functions by hand from occur-after-change-function, > skipping the t entry, but I'm not sure this is safe. It is certainly > messy, so if there's a more elegant way, I'd like to know. Arguably, the `inhibit-modification-hooks` let-binding that surrounds code run from within modification hooks should be buffer-local, which would solve these problems, AFAIK. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 25 09:30:41 2023 Received: (at 66181) by debbugs.gnu.org; 25 Sep 2023 13:30:41 +0000 Received: from localhost ([127.0.0.1]:44577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qklfU-0000xY-1c for submit@debbugs.gnu.org; Mon, 25 Sep 2023 09:30:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qklfN-0000xE-3x for 66181@debbugs.gnu.org; Mon, 25 Sep 2023 09:30:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qklf3-0000vU-77; Mon, 25 Sep 2023 09:30:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=5HxHnYQxgWR1nIccynxq0ly4T6DFeKb+e+sWRlnFS8c=; b=arvki1W+3DjK e3ZGKOfpMGDi8ttIIcLVUmOV3AMdaSLZNiK9iK3rcwfaTbeYkw/3L8jvgaWPSe+g/ahlyNW5Om+Zj uNnD5pfvu1O8LUkrm4ezc1M0jKMostVhr4ovHg26iO6tHFcC5cgRqVWjDCMTis/j1W+5lbnZgkN7v Wb2MJvIbRqzIFNH7nuXIlUczMRqEiR1+ZItm69zQAjIozm86SqCHGdkMv7eLO6qSkoA8Euoh3KEc+ jDmzoV0TI7KRIYI4ebKCDXUXk+c2H6zYqTQQT+OMoKU1JMTm30koG8uMCDGiNteYtote2AVURsYGr 3DcUACuUMrel1G1gNk8XZQ==; Date: Mon, 25 Sep 2023 16:29:34 +0300 Message-Id: <83y1gu1iv5.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Mon, 25 Sep 2023 09:07:42 -0400) Subject: Re: bug#66181: Subject: 29.1; Occur changes don't affect Dired buffer References: <83bkdq3e42.fsf@gnu.org> <837coe3aq3.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66181 Cc: 66181@debbugs.gnu.org, kediez@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: kediez@gmail.com, 66181@debbugs.gnu.org > Date: Mon, 25 Sep 2023 09:07:42 -0400 > > > Stefan, do we have any safe means of running the hooks in this case? > > I thought about running the buffer-local values of before- and > > after-change-functions by hand from occur-after-change-function, > > skipping the t entry, but I'm not sure this is safe. It is certainly > > messy, so if there's a more elegant way, I'd like to know. > > Arguably, the `inhibit-modification-hooks` let-binding that surrounds > code run from within modification hooks should be buffer-local, which > would solve these problems, AFAIK. Not sure I understand: we let-bind inhibit-modification-hooks in C, via specbind, and that binds the global value, since inhibit-modification-hooks is not a per-buffer variable. Or am I missing something. Do you mean we should add a new specbind_local function that makes only a buffer-local let-binding? From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 25 09:52:59 2023 Received: (at 66181) by debbugs.gnu.org; 25 Sep 2023 13:52:59 +0000 Received: from localhost ([127.0.0.1]:44592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkm1D-0001Z1-AF for submit@debbugs.gnu.org; Mon, 25 Sep 2023 09:52:59 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:34491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkm1A-0001Yl-6x for 66181@debbugs.gnu.org; Mon, 25 Sep 2023 09:52:58 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1DB15805E6; Mon, 25 Sep 2023 09:52:38 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1695649957; bh=cLvdEWrGhkbObqTwLl1ZVeVtZnKMlwlRtTmWmme12uU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ijsYxUKGGhnbylazB7jZCecPj39Q60c6/7rSXvN4AmNNH/3uy/2NCeKs+DBX8ir4W 8gKN4kbpKJYP2gLIrFLrnrFm3uFzcJt+2pMUgAMINMpMfPTum5gwKIrxup44auwKE+ d5+8CrS24U84/3tFnyeO8LawstqnkKrIh+eMpgXiHpo3w+h2835D5z9ckKZRIGU1p3 jWt/SCeymuxOcqGbfoEiseQ2jP02+Y3ErSiM8daK11UYLLD+7o972CvV5S+qCgcySN 8A1oF+EdoDz1Z9epZ9PudyRnUIJWcIGqAUjZ6Z94O6wd9g8YjnwvBYSPHuvX8Vt05v pXFxCwFkntU+A== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 0CD818036F; Mon, 25 Sep 2023 09:52:37 -0400 (EDT) Received: from pastel (unknown [45.72.200.56]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D31271203C3; Mon, 25 Sep 2023 09:52:36 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#66181: Subject: 29.1; Occur changes don't affect Dired buffer In-Reply-To: <83y1gu1iv5.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 25 Sep 2023 16:29:34 +0300") Message-ID: References: <83bkdq3e42.fsf@gnu.org> <837coe3aq3.fsf@gnu.org> <83y1gu1iv5.fsf@gnu.org> Date: Mon, 25 Sep 2023 09:52:36 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66181 Cc: 66181@debbugs.gnu.org, kediez@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> > Stefan, do we have any safe means of running the hooks in this case? >> > I thought about running the buffer-local values of before- and >> > after-change-functions by hand from occur-after-change-function, >> > skipping the t entry, but I'm not sure this is safe. It is certainly >> > messy, so if there's a more elegant way, I'd like to know. >> >> Arguably, the `inhibit-modification-hooks` let-binding that surrounds >> code run from within modification hooks should be buffer-local, which >> would solve these problems, AFAIK. > > Not sure I understand: we let-bind inhibit-modification-hooks in C, > via specbind, and that binds the global value, since > inhibit-modification-hooks is not a per-buffer variable. Or am I > missing something. You're right that's what we currently do. > Do you mean we should add a new specbind_local function that makes > only a buffer-local let-binding? For example, yes. Or we could call `Fmake_local_variable` before the `specbind`, or we could make `inhibit-modification-hooks` into one of those vars that are "really always" buffer-local, like `major-mode`, `buffer-file-name` and a few others. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 25 12:40:21 2023 Received: (at 66181) by debbugs.gnu.org; 25 Sep 2023 16:40:21 +0000 Received: from localhost ([127.0.0.1]:46512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkodB-00018v-Af for submit@debbugs.gnu.org; Mon, 25 Sep 2023 12:40:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkod8-00018e-Lt for 66181@debbugs.gnu.org; Mon, 25 Sep 2023 12:40:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkocq-00051p-AB; Mon, 25 Sep 2023 12:40:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3t2V1SefkS2CDIGF9Lz2aSPLBkulD/5Emj5PIl9iNPY=; b=LhXuuuNkCqob xntMSb4UnFS30GC1dK/GHF+xQnXZKGfKtwmY3FqIbdJgIlRm4+ZwEPkuQVCZrQAKEOLb0nD5JbgmV MoHOHv1DXrnAjcozhbUl8uZFmlcTJ+gzPaLOT+xp3qEKKaPLkbTj/aTlE9fw1s8tD2X3PJ0B25PaR mkpoQvVXTdBeLUNH8pQDRs3UWQGE4dx5eJW5eriMmbe1woKR9xA52IR0PspLm5Ru7WvxieM99IyRm S7V4B25o/AotaAm/WvZUF2VunYPJB1k4wHEnmviJLqo4ihPyz6bgh/aP8P0Rh/iiXio3LHjexrJNy zI74R1XHis/6d2jslwPP1A==; Date: Mon, 25 Sep 2023 19:39:25 +0300 Message-Id: <83ttri1a2q.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Mon, 25 Sep 2023 09:52:36 -0400) Subject: Re: bug#66181: Subject: 29.1; Occur changes don't affect Dired buffer References: <83bkdq3e42.fsf@gnu.org> <837coe3aq3.fsf@gnu.org> <83y1gu1iv5.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66181 Cc: 66181@debbugs.gnu.org, kediez@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: kediez@gmail.com, 66181@debbugs.gnu.org > Date: Mon, 25 Sep 2023 09:52:36 -0400 > > >> > Stefan, do we have any safe means of running the hooks in this case? > >> > I thought about running the buffer-local values of before- and > >> > after-change-functions by hand from occur-after-change-function, > >> > skipping the t entry, but I'm not sure this is safe. It is certainly > >> > messy, so if there's a more elegant way, I'd like to know. > >> > >> Arguably, the `inhibit-modification-hooks` let-binding that surrounds > >> code run from within modification hooks should be buffer-local, which > >> would solve these problems, AFAIK. > > > > Not sure I understand: we let-bind inhibit-modification-hooks in C, > > via specbind, and that binds the global value, since > > inhibit-modification-hooks is not a per-buffer variable. Or am I > > missing something. > > You're right that's what we currently do. > > > Do you mean we should add a new specbind_local function that makes > > only a buffer-local let-binding? > > For example, yes. Or we could call `Fmake_local_variable` before the > `specbind`, or we could make `inhibit-modification-hooks` into one of > those vars that are "really always" buffer-local, like `major-mode`, > `buffer-file-name` and a few others. Would it work (and be okay) to make inhibit-modification-hooks buffer-local in a buffer in which occur-edit-mode is turned on? From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 25 13:06:32 2023 Received: (at 66181) by debbugs.gnu.org; 25 Sep 2023 17:06:32 +0000 Received: from localhost ([127.0.0.1]:46539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkp2W-0001uf-E1 for submit@debbugs.gnu.org; Mon, 25 Sep 2023 13:06:32 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:52064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkp2U-0001uP-8H for 66181@debbugs.gnu.org; Mon, 25 Sep 2023 13:06:31 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0C20644234F; Mon, 25 Sep 2023 13:06:12 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1695661570; bh=CXWfl30pxgU/oo+tAvE5/D4UHtLXHVqKYSJA+aHCnaE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=kjOcBwT0DSYjcwiOPmF0HuOVoXP23FPZZ/2NAn+OMZH6eVW8vjVWI59Li528ciAkh Z2QSAwHpCBlCp/7WKk/aIMFQauiQkUhf6CsbXz4Cdq6t6cH+Y7uCxsd+O4FlyRYGJy y2dDEhPaBK1daA7lsIdC3N5dMMHZTC9xeObYIJaApVfj+Aom0X1R4yMrtTrVEwdw2X aQ5hV6rwvvD8MY1JXrAo6H2z1XToqoL20RmS+pnme84myg8yf7DNGaVRWcMFU3fspK O7JE+pVoM4iPZONUaCY4rLwbukUExewBLQYbZRQMQjBqcPSpu/9ZJDG75+/pNkagXV Ai3SyE167yRcQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D84F644151E; Mon, 25 Sep 2023 13:06:10 -0400 (EDT) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BC88212022E; Mon, 25 Sep 2023 13:06:10 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#66181: Subject: 29.1; Occur changes don't affect Dired buffer In-Reply-To: <83ttri1a2q.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 25 Sep 2023 19:39:25 +0300") Message-ID: References: <83bkdq3e42.fsf@gnu.org> <837coe3aq3.fsf@gnu.org> <83y1gu1iv5.fsf@gnu.org> <83ttri1a2q.fsf@gnu.org> Date: Mon, 25 Sep 2023 13:04:45 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.106 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66181 Cc: 66181@debbugs.gnu.org, kediez@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> For example, yes. Or we could call `Fmake_local_variable` before the >> `specbind`, or we could make `inhibit-modification-hooks` into one of >> those vars that are "really always" buffer-local, like `major-mode`, >> `buffer-file-name` and a few others. > Would it work (and be okay) to make inhibit-modification-hooks > buffer-local in a buffer in which occur-edit-mode is turned on? It should, yes (tho it will fix only this situation, obviously). Stefan