GNU bug report logs - #66180
[PATCH 00/19] Sort packages in node-xyz.scm

Previous Next

Package: guix-patches;

Reported by: Nicolas Graves <ngraves <at> ngraves.fr>

Date: Sun, 24 Sep 2023 12:49:01 UTC

Severity: normal

Tags: patch

Done: Sharlatan Hellseher <sharlatanus <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#66180: closed ([PATCH 00/19] Sort packages in node-xyz.scm)
Date: Sun, 18 Feb 2024 13:08:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sun, 18 Feb 2024 13:06:12 +0000
with message-id <87ttm5ly63.fsf <at> gmail.com>
and subject line [PATCH 00/19] Sort packages in node-xyz.scm
has caused the debbugs.gnu.org bug report #66180,
regarding [PATCH 00/19] Sort packages in node-xyz.scm
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
66180: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66180
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Nicolas Graves <ngraves <at> ngraves.fr>
To: guix-patches <at> gnu.org
Cc: ngraves <at> ngraves.fr
Subject: [PATCH 00/19] Sort packages in node-xyz.scm
Date: Sun, 24 Sep 2023 14:47:41 +0200
This patch series roughly sorts the whole node-xyz.scm file, and adds
a reminder header to add packages in the alphabetical order.

Nicolas Graves (19):
  gnu: node-bindings: Move package in alphabetical order.
  gnu: node-util-deprecate: Move package in alphabetical order.
  gnu: node-once: Move package in alphabetical order.
  gnu: node-ieee754: Move package in alphabetical order.
  gnu: node-inherits: Move package in alphabetical order.
  gnu: node-safe-buffer: Move package in alphabetical order.
  gnu: node-string-decoder: Move package in alphabetical order.
  gnu: node-readable-stream: Move package in alphabetical order.
  gnu: node-irc and node-irc-colors: Move in alphabetical order.
  gnu: node-nan: Move package in alphabetical order.
  gnu: node-addon-api: Move package in alphabetical order.
  gnu: node-sqlite3: Move package in alphabetical order.
  gnu: node-file-uri-to-path: Move package in alphabetical order.
  gnu: node-segfault-handler: Move package in alphabetical order.
  gnu: node-ms: Move package in alphabetical order.
  gnu: node-debug: Move package in alphabetical order.
  gnu: node-serialport packages: Move packages in alphabetical order.
  gnu: node-semver: Move package in alphabetical order.
  gnu: packages: node-xyz: Add alphatical order header.

 gnu/packages/node-xyz.scm | 1480 +++++++++++++++++++------------------
 1 file changed, 742 insertions(+), 738 deletions(-)


base-commit: 792a20ab93cf88feae119296b0d2db58dccf3732
-- 
2.41.0



[Message part 3 (message/rfc822, inline)]
From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 66180-done <at> debbugs.gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: [PATCH 00/19] Sort packages in node-xyz.scm
Date: Sun, 18 Feb 2024 13:06:12 +0000
[Message part 4 (text/plain, inline)]
Hi Nicolas,

I've checked packages order once again and found that some of them still
need to be re-allocated but due to inheritance it can't be done easily.

e.g. package node-serialport needs to be the one from the rest are inheritated.

- node-serialport-binding-abstract
- node-serialport-bindings
- node-serialport-parser-byte-length
- node-serialport-parser-cctalk
- node-serialport-parser-delimiter
- node-serialport-parser-inter-byte-timeout
- node-serialport-parser-readline
- node-serialport-parser-ready
- node-serialport-parser-regex
- node-serialport-stream

May you check it please in the next round?

I've used Emacs' occur, search for define-public, copied to an empty
buffer A and in buffer B sorted lines, then run buffer-diff on A and B.
--8<---------------cut here---------------start------------->8---
diff -u --label \#\<buffer\ \*new\*\<3\>\> --label \#\<buffer\ \*new\*\<4\>\> /tmp/buffer-content-SbBuJ0 /tmp/buffer-content-bu3SO4
--- #<buffer *new*<3>>
+++ #<buffer *new*<4>>
@@ -30,17 +30,17 @@
 define-public node-safe-stable-stringify
 define-public node-segfault-handler
 define-public node-semver
+define-public node-serialport
 define-public node-serialport-binding-abstract
+define-public node-serialport-bindings
+define-public node-serialport-parser-byte-length
+define-public node-serialport-parser-cctalk
 define-public node-serialport-parser-delimiter
+define-public node-serialport-parser-inter-byte-timeout
 define-public node-serialport-parser-readline
-define-public node-serialport-bindings
-define-public node-serialport-parser-regex
 define-public node-serialport-parser-ready
-define-public node-serialport-parser-inter-byte-timeout
-define-public node-serialport-parser-cctalk
-define-public node-serialport-parser-byte-length
+define-public node-serialport-parser-regex
 define-public node-serialport-stream
-define-public node-serialport
 define-public node-sqlite3
 define-public node-stack-trace
 define-public node-statsd-parser
--8<---------------cut here---------------end--------------->8---

Your servcie is pushed as aede3fa122..345a54ff4c to master.

--
Oleg
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 1 year and 93 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.