From unknown Wed Jun 18 23:11:48 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#66171 <66171@debbugs.gnu.org> To: bug#66171 <66171@debbugs.gnu.org> Subject: Status: [PATCH] gnu: git: Install shell completions. Reply-To: bug#66171 <66171@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:11:48 +0000 retitle 66171 [PATCH] gnu: git: Install shell completions. reassign 66171 guix-patches submitter 66171 Liliana Marie Prikler severity 66171 normal tag 66171 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 23 15:45:04 2023 Received: (at submit) by debbugs.gnu.org; 23 Sep 2023 19:45:04 +0000 Received: from localhost ([127.0.0.1]:40667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qk8Yq-00032I-3i for submit@debbugs.gnu.org; Sat, 23 Sep 2023 15:45:04 -0400 Received: from lists.gnu.org ([2001:470:142::17]:55690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qk8Yl-00031T-SJ for submit@debbugs.gnu.org; Sat, 23 Sep 2023 15:45:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qk8YU-0003H1-Ps for guix-patches@gnu.org; Sat, 23 Sep 2023 15:44:42 -0400 Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qk8YS-0001vX-Us for guix-patches@gnu.org; Sat, 23 Sep 2023 15:44:42 -0400 Received: by mail-ej1-x644.google.com with SMTP id a640c23a62f3a-9adb9fa7200so978137566b.0 for ; Sat, 23 Sep 2023 12:44:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695498278; x=1696103078; darn=gnu.org; h=to:content-transfer-encoding:mime-version:subject:date:from :message-id:from:to:cc:subject:date:message-id:reply-to; bh=keyLN0IrQN2qxVdOdKn2dO5sSACp6G78JT5XQzio9YI=; b=GlQH+vBJPp1u7329y3ui7qURethHYip4kdz8OLCs0vrY/OeU1fti7VHv2+vTAxyuIZ ucAowH9G1BeJrgXR+8hMVFGM3IL+ojS1VaW27jN5o+iX0q1eKPArgASJKMEzVBv4koEK BmE25UVamjM+zdReDYKs48TUQReHjfIJWKhd04HiuCtsZZur4W8XXpx8qx1ZzAgw6Q3u MNXh4aWRu2yWp04MUXKkGYLWcp8vecPUxTgqmLmzfa6un9Fq2DziPABjKyL8zTWmDZch RFM88cFuTpSnixdFb8lr74+EFapKlgirFh2ypA/g9MTOb9AYMB6qgNbH23InEPUBnhu3 ctlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695498278; x=1696103078; h=to:content-transfer-encoding:mime-version:subject:date:from :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=keyLN0IrQN2qxVdOdKn2dO5sSACp6G78JT5XQzio9YI=; b=rTeqCL1TS4FmCyctLeq+Iwx7LXwynydZCzELycV/NBoPSOJYyXvdvjVoXDOHjjxlNC qcka5HCEOb0Nzl3fjp8NvaX4Qvj3VScckLDXL7sAo9UhHPcXNxRnSE+0CQOJNSXyC+2S axtVmlor0pBKsbLhaNn3atPQtZ2AXm7bbloV4HG7onu3Vvu7ir4IpvqoolQsV3j0pR4X qU0PO417Dgxa2/xOIOyEmqH3B+1Dkwa6uUeM9Z3JSvnjzH/XH4FmtErV/a9Gd8ZvmpDx qhXYtL4T6PObWTZndMWm2fxk0wLv5+UI+/uNlllGVmLByQ5mSSuP1Um87/6H8x82sAMx taww== X-Gm-Message-State: AOJu0YwtCKWd6Q6BpEr+U8vTCs469VvfM4IBFUp+NChY9GPsGWBDP2La 5DtCDSoN2FIHaUdW2m8Oep5Doqgw9oOsXuXK X-Google-Smtp-Source: AGHT+IHlCF8WGxZda2Jr8aKPPTwxoN2/JUR4qZznNepmJA7I3s63aVgJ/GFDTqxp8URo34KK3VrJWQ== X-Received: by 2002:a17:907:868f:b0:9a5:962c:cb6c with SMTP id qa15-20020a170907868f00b009a5962ccb6cmr9946032ejc.31.1695498278192; Sat, 23 Sep 2023 12:44:38 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id ha26-20020a170906a89a00b009930308425csm4238319ejb.31.2023.09.23.12.44.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Sep 2023 12:44:36 -0700 (PDT) Message-ID: From: Liliana Marie Prikler Date: Sat, 23 Sep 2023 21:43:07 +0200 Subject: [PATCH] gnu: git: Install shell completions. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit to: guix-patches@gnu.org Received-SPF: pass client-ip=2a00:1450:4864:20::644; envelope-from=liliana.prikler@gmail.com; helo=mail-ej1-x644.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/version-control.scm (git)[outputs]: Add “completion”. [#:phases]: Add ‘install-completion’. --- gnu/packages/version-control.scm | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index 9716a6f27a..54b2ed74fb 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -303,6 +303,7 @@ (define-public git "credential-netrc" ; git-credential-netrc "credential-libsecret" ; git-credential-libsecret "subtree" ; git-subtree + "completion" ; git-completion and git-prompt "gui")) ; gitk, git gui (arguments `(#:make-flags `("V=1" ;more verbose compilation @@ -482,6 +483,20 @@ (define-public git (string-append subtree "/bin")) (install-file "contrib/subtree/git-subtree.1" (string-append subtree "/share/man/man1"))))) + (add-after 'install 'install-completion + (lambda* (#:key outputs #:allow-other-keys) + (let ((completion (assoc-ref outputs "completion"))) + (define (install-as file storename) + (let ((storename (string-append completion storename))) + (mkdir-p (dirname storename)) + (copy-file file storename))) + (with-directory-excursion "contrib/completion" + (for-each (cut apply install-as <>) + `(("git-prompt.sh" "/bin/git-prompt") + ("git-completion.bash" + "/share/bash-completion/completions/_git") + ("git-completion.zsh" + "/share/zsh/site-functions/_git"))))))) (add-after 'install 'restore-sample-hooks-shebang (lambda* (#:key outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) base-commit: 4f35ff1275e05be31f5d41464ccf147e9dbfd016 prerequisite-patch-id: ee5d7299c5790d77e0d409f34165063fcff10a8b -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 25 07:15:28 2023 Received: (at 66171) by debbugs.gnu.org; 25 Sep 2023 11:15:28 +0000 Received: from localhost ([127.0.0.1]:44468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkjYl-0000OR-M4 for submit@debbugs.gnu.org; Mon, 25 Sep 2023 07:15:28 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:39240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkjYh-0000O5-Ms for 66171@debbugs.gnu.org; Mon, 25 Sep 2023 07:15:26 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-40594a6d1ecso2403065e9.1 for <66171@debbugs.gnu.org>; Mon, 25 Sep 2023 04:15:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695640505; x=1696245305; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=cL03RsQhLespo6VzpX9inkG9zEVqxYpTBjhztJRi9s0=; b=MQVBNoC1KRdFxpz6IUjQxDDvBzYzSCThr26kHvzs3eSx49FPJTT4UuFSjz9kKXSpYb Ljk9C8Fo9QcZgu27psl2XYhSyqtx0e3DEOtlFvHmW0xIFvMzapoIhAigQ9ZSVh/m2jNT 6SwJx54w0DP7+CGiCcyQaYvEM8vYOhw+UADT32Xgia93tsENZEMPGvGfLBAiY78SNJ3H jfRz9jcd13z9ZHOc7WxQFBSHDEm09OZzl3tXShFiembhsgthRy/lhwITKzdPzb2CuffV 6b0YEEThCF98PP1ZghltcfcXSJnRvJPEc5FFXMSSc6ESUtmgFQIqNWwQP+iy0TPs1BQi H8Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695640505; x=1696245305; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=cL03RsQhLespo6VzpX9inkG9zEVqxYpTBjhztJRi9s0=; b=LAIVBmEFEp2w65Ebr0bI1CZgxcyHNfdyi8RjmPapDr4TExxWSf+K14apnI7TgrTuX4 Kw4qaA5g85sm0IZ1Uomkw958sumVDlec/qt2I6xubvjvI0FK18wvGC1vxmhR5EIvcqSQ A7DmeGaDyoDlVgbTpSgzogXIUPSHiPXkM10JkVsfHVGCmxrGmVkZ67eKtiWkLrPp6GVd cASEHu6GdYj4leP7aafkuB1wkm4b6IWAJivi3wx8/5Plfw9v8dF3K/R7P1kPaE8l/1xj zT2aAscTpDrE2kuw4RIU2ZdjtCFsw5DU0DL8TwSlgajcIbmtn+zmYwvRNsm1/2Y3uwLh 67Aw== X-Gm-Message-State: AOJu0YynT+8ZANR71bXbKFL39yvy665dauht/+pNl6ABuKzbWbWGiEKi I8lHWCj20w/FsMQb39ZJgBKP5eJYJMc= X-Google-Smtp-Source: AGHT+IFcQOoCuNqsbzxBbqV78VDKvl4tdfEZXwsnjlsffIFEp+N/9Gu/n141KrkWG6+Fiqk/+ju6eQ== X-Received: by 2002:a05:600c:6029:b0:405:4127:f471 with SMTP id az41-20020a05600c602900b004054127f471mr6109673wmb.1.1695640505365; Mon, 25 Sep 2023 04:15:05 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id y2-20020adffa42000000b0031423a8f4f7sm11716325wrr.56.2023.09.25.04.15.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 04:15:05 -0700 (PDT) From: Simon Tournier To: Liliana Marie Prikler , 66171@debbugs.gnu.org Subject: Re: [bug#66171] [PATCH] gnu: git: Install shell completions. In-Reply-To: References: Date: Mon, 25 Sep 2023 13:12:52 +0200 Message-ID: <87r0mm5wwb.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66171 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Sat, 23 Sep 2023 at 21:43, Liliana Marie Prikler wrote: > * gnu/packages/version-control.scm (git)[outputs]: Add =E2=80=9Ccompletio= n=E2=80=9D. > [#:phases]: Add =E2=80=98install-completion=E2=80=99. Naive question: this also adds =E2=80=9Ccompletion=E2=80=9D to git-minimal,= no? I mean, does the phase need to be deleted in git-minimal? Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 25 12:56:41 2023 Received: (at 66171) by debbugs.gnu.org; 25 Sep 2023 16:56:41 +0000 Received: from localhost ([127.0.0.1]:46528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkosu-0001d8-9I for submit@debbugs.gnu.org; Mon, 25 Sep 2023 12:56:41 -0400 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]:58570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkosp-0001cq-Ae for 66171@debbugs.gnu.org; Mon, 25 Sep 2023 12:56:35 -0400 Received: by mail-ed1-x541.google.com with SMTP id 4fb4d7f45d1cf-533edb5ac54so3630710a12.0 for <66171@debbugs.gnu.org>; Mon, 25 Sep 2023 09:56:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695660973; x=1696265773; darn=debbugs.gnu.org; h=cc:to:content-transfer-encoding:mime-version:subject:date:from :message-id:from:to:cc:subject:date:message-id:reply-to; bh=FIrqiEEIrQ9gQhPuCpk+k8U176yVyvv+AoXOwh8uuiI=; b=d+swICkV+I11+EOYywgfkeW9fYUWLeuivMOxG6rtylQ5R452ws9Ip0llyMnfkwtHCo pC6yjhw/tLkl4tIvniN1LeTPd6hPt6HTEwSl8dKXRxyq4aUFwb8aLphrJMRC9Rhzqdhh eBcmt52e14aC8UuqyaNjziPP4HRUPwruVW0mmpIiwDM5jRNN0ywjEnGWew+EeHGidNyC gwa8jGKZ+RE4Kt9un+Yf4QjkztZrVOvp9E1MfyUx5wJfxT+T6XM4592sQKbh2pZvYNYl 2swmJk0iOoCwW9oNpPdAwAGLRgoh4dceRvljOLImhOVOD9chAjTKMtpz3gqX4t9YS6Vt bD6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695660973; x=1696265773; h=cc:to:content-transfer-encoding:mime-version:subject:date:from :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FIrqiEEIrQ9gQhPuCpk+k8U176yVyvv+AoXOwh8uuiI=; b=GQBirLncXjMDdXJH7RlFmu+JvkTkXSs2UPeaH4sru6c3eo1y4fa4Cl0pGG5asjeGqE VwmNwvdxuzp4yBaJMK+qKbj2HnIGajvdbfnNFH9+UF8SxvBEi5MRHaFh0HODng5WfTmK dgRMk4X8JS7UN0lKVuUVgpZmjXL1WZeZ2LSmzZx9ZKQGFbUSvYoQJIYAjku4VY2SzE34 oXjJdhdcmD/UO7H+ADIn7oD+CoZKEXvo+iChrKNaSdTKd5tZ0EFKrNeV1umPW7tRz4Ye IAvCBraRHbMkIPAm5gfQhjhD7VFh5T4Ek6YSAu+UCD8fxJdjjp3KaysWwSMpnZbyVwDY z73A== X-Gm-Message-State: AOJu0YzY0EkQWj1sTBHKsg8ubs67B08o00e/GV7x60E52wzupAx1nDb9 A0IA+5bsY6pJSJUQKF9mLOO56Io3e1rHog== X-Google-Smtp-Source: AGHT+IGClI58ouozqF09RpvRKhMYPgpFa5x4XI6N51Lso/u++MyxMLjXy1A/16+XyteP7pXGAkmPkQ== X-Received: by 2002:a17:906:cc0c:b0:9ae:6919:813 with SMTP id ml12-20020a170906cc0c00b009ae69190813mr6153039ejb.17.1695660972814; Mon, 25 Sep 2023 09:56:12 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id ox12-20020a170907100c00b00988f168811bsm6576593ejb.135.2023.09.25.09.56.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 09:56:11 -0700 (PDT) Message-ID: <7be0975a4d30362dec08c3115e68c992e58ab549.1695660890.git.liliana.prikler@gmail.com> From: Liliana Marie Prikler Date: Sat, 23 Sep 2023 21:43:07 +0200 Subject: [PATCH v2] gnu: git: Install shell completions. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit to: 66171@debbugs.gnu.org X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 66171 Cc: Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) * gnu/packages/version-control.scm (git)[outputs]: Add “completion”. [#:phases]: Add ‘install-completion’. (git-minimal)[#:phases]: Adjust accordingly. --- Am Montag, dem 25.09.2023 um 13:12 +0200 schrieb Simon Tournier: > Naive question: this also adds “completion” to git-minimal, no? I mean, > does the phase need to be deleted in git-minimal? Indeed it does; updated the patch accordingly. Cheers gnu/packages/version-control.scm | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index 9716a6f27a..35d17d434e 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -303,6 +303,7 @@ (define-public git "credential-netrc" ; git-credential-netrc "credential-libsecret" ; git-credential-libsecret "subtree" ; git-subtree + "completion" ; git-completion and git-prompt "gui")) ; gitk, git gui (arguments `(#:make-flags `("V=1" ;more verbose compilation @@ -482,6 +483,20 @@ (define-public git (string-append subtree "/bin")) (install-file "contrib/subtree/git-subtree.1" (string-append subtree "/share/man/man1"))))) + (add-after 'install 'install-completion + (lambda* (#:key outputs #:allow-other-keys) + (let ((completion (assoc-ref outputs "completion"))) + (define (install-as file storename) + (let ((storename (string-append completion storename))) + (mkdir-p (dirname storename)) + (copy-file file storename))) + (with-directory-excursion "contrib/completion" + (for-each (cut apply install-as <>) + `(("git-prompt.sh" "/bin/git-prompt") + ("git-completion.bash" + "/share/bash-completion/completions/_git") + ("git-completion.zsh" + "/share/zsh/site-functions/_git"))))))) (add-after 'install 'restore-sample-hooks-shebang (lambda* (#:key outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) @@ -639,6 +654,7 @@ (define-public git-minimal (delete 'install-subtree) (delete 'install-credential-netrc) (delete 'install-credential-libsecret) + (delete 'install-completion) (add-after 'install 'remove-unusable-perl-commands (lambda* (#:key outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) base-commit: e134686cead6db62ea8b941b2ed7c0bd660804da -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 25 13:52:04 2023 Received: (at 66171) by debbugs.gnu.org; 25 Sep 2023 17:52:04 +0000 Received: from localhost ([127.0.0.1]:46591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkpka-0003K8-Ep for submit@debbugs.gnu.org; Mon, 25 Sep 2023 13:52:04 -0400 Received: from mail-qv1-xf35.google.com ([2607:f8b0:4864:20::f35]:51231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkpkY-0003JR-DW for 66171@debbugs.gnu.org; Mon, 25 Sep 2023 13:52:02 -0400 Received: by mail-qv1-xf35.google.com with SMTP id 6a1803df08f44-6563c23b356so38747966d6.2 for <66171@debbugs.gnu.org>; Mon, 25 Sep 2023 10:51:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695664304; x=1696269104; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=G+UoQNGzz3INuO0xK7tX5Gf6u471ZPjatSydcPU120Q=; b=V2+pDRxHkUfPdehwTgzls8wotNYhT2F2cDnt4bb0lXAMhLuaVLpbMinFvAjzcWlZMC J/0WvEGbiNQXiksKIwJ4RyMZlar7FrVAlhGj0+mqotHNG+nBlW2x44X47vNKjsnfSQ20 bxZ1c7n3Efjk+nmKySaEXb3KCB6+vtDfBJdGJdF/dC/F/HK2Htam4mqNdwTR33XfqkJH bW/ieg03JSYrEC0FarpFU6jK/sE8OmvZxOZTsIVNKzx6hr8ho+MhL01Al176/rgsnZWm 0A/xRd92LXVVKfJk4mXOtOOaZokILopA3BfeQLaG3lbd7kwRpwOyIqsuYF1qq64O5vmo /RLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695664304; x=1696269104; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=G+UoQNGzz3INuO0xK7tX5Gf6u471ZPjatSydcPU120Q=; b=apJE/1THxIiNAlsBQKsW4O0QC14xZxTnnfvTGlajfw+o6sRVB1lQun5w52hIH0P0FH zYm5WS8RChoHjrEly9eJt+bq1cDT5r2WjZrn35+bwgxkZ5/wZtTcxw/RfWgFRTtBNGmP Qdq+azVDaTPVP+BkvOvRul/dxO0OtZkukJdEOhLBFeogpxqaI9yeJNpsKyG8f9RIXBeO bdWK+njAjbFT5Uiw1q+g0nF2EXLZKC5yp/rGuQtRUefCttTm4opzuXz28plV6ix8Bq7H x5mrNhufVOiJ/ym11dN1b9TnFtGPAUGPQy2Z3kDwmo3X/9/Z/xpntZXpVkhp/krnRDmh Qe/A== X-Gm-Message-State: AOJu0Yw4GkFldje26GiLTeLmrNf0sP+PX+m7XaC7qHceH5yY5pbqM0BT EIop6o5WPsjxNlBrhen7D/m7ehUuC1E= X-Google-Smtp-Source: AGHT+IGico+UcBEVxjl7PS2EVq9q/SNW5WzBbUohOI9uJR/fV5YIYIfQTbv3a87p+iRPj7qhMfZzfw== X-Received: by 2002:ad4:5142:0:b0:65b:896:a5bb with SMTP id g2-20020ad45142000000b0065b0896a5bbmr3887239qvq.34.1695664304230; Mon, 25 Sep 2023 10:51:44 -0700 (PDT) Received: from hurd (dsl-10-130-229.b2b2c.ca. [72.10.130.229]) by smtp.gmail.com with ESMTPSA id d2-20020a0cf0c2000000b0063d162a8b8bsm1669609qvl.19.2023.09.25.10.51.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 10:51:43 -0700 (PDT) From: Maxim Cournoyer To: Liliana Marie Prikler Subject: Re: bug#66171: [PATCH] gnu: git: Install shell completions. References: <7be0975a4d30362dec08c3115e68c992e58ab549.1695660890.git.liliana.prikler@gmail.com> Date: Mon, 25 Sep 2023 13:51:42 -0400 In-Reply-To: <7be0975a4d30362dec08c3115e68c992e58ab549.1695660890.git.liliana.prikler@gmail.com> (Liliana Marie Prikler's message of "Sat, 23 Sep 2023 21:43:07 +0200") Message-ID: <877coe2lap.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66171 Cc: 66171@debbugs.gnu.org, Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Liliana Marie Prikler writes: > * gnu/packages/version-control.scm (git)[outputs]: Add =E2=80=9Ccompletio= n=E2=80=9D. > [#:phases]: Add =E2=80=98install-completion=E2=80=99. > (git-minimal)[#:phases]: Adjust accordingly. Did something change in git? I've always had completion in git, so I'm not sure what this extra phase does, or when it's useful? Does it add *extra* completion or... ? Also, a completion output seems a bit over the top. I doubt its weigh justifies the annoyance of special casing it. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 25 14:41:30 2023 Received: (at 66171) by debbugs.gnu.org; 25 Sep 2023 18:41:30 +0000 Received: from localhost ([127.0.0.1]:46657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkqWQ-0001dv-67 for submit@debbugs.gnu.org; Mon, 25 Sep 2023 14:41:30 -0400 Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]:61608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkqWL-0001dd-Mj for 66171@debbugs.gnu.org; Mon, 25 Sep 2023 14:41:29 -0400 Received: by mail-ej1-x644.google.com with SMTP id a640c23a62f3a-99c1c66876aso870519966b.2 for <66171@debbugs.gnu.org>; Mon, 25 Sep 2023 11:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695667267; x=1696272067; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=POohiJ7mTpL/2lOo76EkSRiVZgbKqa1S65CdRnljJyI=; b=g1u/OW5pvjkCq0SwD7WhHammVybAZjqqATvFsHIw2dECMSINB08T1y/mOHVkEBCgCu gPiBmzjDQKMPy2pDYvNt1OSLNYyRqA4VH/XdZ0bdVdaf2V+ZlSZAOXL1iqRn0FzhVQi3 Bh0P9/nOgLTl/ALr6s7nMx/NjJxsj5kFwQGuu/4fl+6QOoG1aoGRmXVyDnKlfi/cRYGc 7q2qGgFHs+rfZQD56Wi/x71T7EP4nySwBwfcXr348HyPglQ3mkF4bkjSo4wqDVtdTUMs 6rq3lwGUwRjKRV/NSwCBtwuZga+h6P+DuIhzYBhK5ofcYtcZd4pY4g3bEKO5Puhqe7NR yplw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695667267; x=1696272067; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=POohiJ7mTpL/2lOo76EkSRiVZgbKqa1S65CdRnljJyI=; b=Eex1GVG0jRM/qM4LtJO1Fj4q7iyWyARVqrTUM3IYOla+saItGQHr4rO3haGG9nFigH a7DQl1LYWs3f2WQ8V/x8/lQLj2BRqXCYNNQU6LJKxh7uOSgTsXBhBITAg26hN398i24V 1eagD563LQSxIv5NqU0W+ENU3EiTg885vTjRGiXkYSdD552E+841U7Kb0A0pjcyZ798q ytToilUPS1GdObCWiwfBQOvhrGcx/FcBxXUb0gMHDsiNv1hcHxySmHspX4bOex09NqzG AcE0wKxC+JSeM58jhy3NXNrCvNmsd4vzTzRBe7SqFNowK7trygys+MIKEkrZhFpF3rH/ QJ7w== X-Gm-Message-State: AOJu0YxWhIeBAimSjtYgc1tOGZ5FZ7OXAO78yB0rB/axnU26/EZW5REu bc8tbX/U36Y426ymWCyvEPo2SKN1BuHLHg== X-Google-Smtp-Source: AGHT+IHLfLlYbFKdf/2OqqGXSG91Kj5JHPv64M8uufRQqc5ocmvcJ0M4Oqs9+nISYOUy/HpMPm4T5w== X-Received: by 2002:a17:906:209:b0:9a9:d5f4:1a0d with SMTP id 9-20020a170906020900b009a9d5f41a0dmr6502083ejd.45.1695667267170; Mon, 25 Sep 2023 11:41:07 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id md1-20020a170906ae8100b009a1be9c29d7sm6720579ejb.179.2023.09.25.11.41.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 11:41:06 -0700 (PDT) Message-ID: <7659d2d5a891bb3ee81e87ab484924f3337cae81.camel@gmail.com> Subject: Re: bug#66171: [PATCH] gnu: git: Install shell completions. From: Liliana Marie Prikler To: Maxim Cournoyer Date: Mon, 25 Sep 2023 20:41:05 +0200 In-Reply-To: <877coe2lap.fsf_-_@gmail.com> References: <7be0975a4d30362dec08c3115e68c992e58ab549.1695660890.git.liliana.prikler@gmail.com> <877coe2lap.fsf_-_@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66171 Cc: 66171@debbugs.gnu.org, Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Montag, dem 25.09.2023 um 13:51 -0400 schrieb Maxim Cournoyer: > Hello, >=20 > Liliana Marie Prikler writes: >=20 > > * gnu/packages/version-control.scm (git)[outputs]: Add > > =E2=80=9Ccompletion=E2=80=9D. > > [#:phases]: Add =E2=80=98install-completion=E2=80=99. > > (git-minimal)[#:phases]: Adjust accordingly. >=20 > Did something change in git?=C2=A0 I've always had completion in git, so > I'm not sure what this extra phase does, or when it's useful?=C2=A0 Does > it add *extra* completion or... ? Which shell are you using? If it's zsh, then the completion is baked in. If it's bash, idk, I haven't tried. I personally use this for the included git-prompt, which allows me to have my prompt look like the following: \u@\h /path/to/guix [$branch env] ($SHLVL) \$ > Also, a completion output seems a bit over the top.=C2=A0 I doubt its > weigh justifies the annoyance of special casing it. I special-cased it because it *is* a contrib script, but also as it might be able to conflict with whatever shell builtins you have. Now it isn't particularly likely to do so given that other distros include it as part of their git-core, but I prefer safe over sorry. That being said, I could just write it to out if you prefer that. Cheers From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 26 12:36:34 2023 Received: (at 66171) by debbugs.gnu.org; 26 Sep 2023 16:36:34 +0000 Received: from localhost ([127.0.0.1]:49632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlB34-0001cq-Hc for submit@debbugs.gnu.org; Tue, 26 Sep 2023 12:36:34 -0400 Received: from mail-qk1-x72a.google.com ([2607:f8b0:4864:20::72a]:50189) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlB30-0001ca-2b for 66171@debbugs.gnu.org; Tue, 26 Sep 2023 12:36:33 -0400 Received: by mail-qk1-x72a.google.com with SMTP id af79cd13be357-7741bffd123so537973885a.0 for <66171@debbugs.gnu.org>; Tue, 26 Sep 2023 09:36:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695746171; x=1696350971; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=iBh9TUkll7dpNnz6uC2XweKwsIBqHOawqqdnwjtiuFQ=; b=fgFuZQSoq1LFZrkAjtHaA8sZ88MNZFsnTRb8BC851/UzyzxtpOx4Y+b2HYuMKuUNd2 jNFcM2Kc4iOTngo7Er3UGuIRclg2vuhIbqW8sp+kuVitFu5bcDgoj69WlsiboRqbLfrB Y6a8BJVsCuTPu01xblpM9gnLtah+1+p1LY3kngNi7OtZoPj9V77Ro9F+iVx2ESkV/ipy 7S2C8f2Z13Y588eACviBYrVrisKwJ/19NBOY7Sh9lAfUuBBKBRAuEh2lu76jjF8Bnmpt i3CTGegM+gpnnA1TPaVSh5N15hhqn4KEMGGfAtwliKcsSx/DXcTZB3tdQmN8fJSrMBeE 2OEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695746171; x=1696350971; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=iBh9TUkll7dpNnz6uC2XweKwsIBqHOawqqdnwjtiuFQ=; b=nMy3wHmDoM08Ixh6VeFh6MV1IWcCL1xQOP6srLM4edtONVOI5lnWQsRDNVQsYtx0Pr PF3Rybvs1qylSs3ILU5eh89mg4invGor7EXGqAv4kMgkLZwYkJZ6Kb1eJkBxue48PAd2 loCXAdseRu4AGl9XE2jv2tnulC9UcFjlPzPeU1f8t8xtO5uFcQ0LaPAhT+27VrM96pSg rlO1ZHt4kwzkNKm0TbGkCI1moP8J/k96XjomRqvj6euJ6dOimhOZx3k+4/VyPYzWQsX5 NOYi0AsKZzaGL7pzN0gBn2E6RxVneRLyUH1VQMzjZJ/93B0ay2YdhbJX+h7g/hwNs45e H84A== X-Gm-Message-State: AOJu0Yw/rNcSNDWpZnXw751Au77Lron+KF9yNT0MxMLUKZQM4GaObih7 /Q8gTE1C1hlysyMJVlNhn2kW4SjfzxM= X-Google-Smtp-Source: AGHT+IF1JRvQtbj+zg2IIsD75JcQdLow4/TqLG7PeCaVNIOqfEMkFB0PgP6kN6vCtdFytZn136wREA== X-Received: by 2002:a05:620a:4593:b0:774:220c:154f with SMTP id bp19-20020a05620a459300b00774220c154fmr13604586qkb.42.1695746171284; Tue, 26 Sep 2023 09:36:11 -0700 (PDT) Received: from hurd (dsl-10-130-229.b2b2c.ca. [72.10.130.229]) by smtp.gmail.com with ESMTPSA id p22-20020ac87416000000b00419576c7b75sm350625qtq.23.2023.09.26.09.36.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 09:36:10 -0700 (PDT) From: Maxim Cournoyer To: Liliana Marie Prikler Subject: Re: bug#66171: [PATCH] gnu: git: Install shell completions. References: <7be0975a4d30362dec08c3115e68c992e58ab549.1695660890.git.liliana.prikler@gmail.com> <877coe2lap.fsf_-_@gmail.com> <7659d2d5a891bb3ee81e87ab484924f3337cae81.camel@gmail.com> Date: Tue, 26 Sep 2023 12:36:09 -0400 In-Reply-To: <7659d2d5a891bb3ee81e87ab484924f3337cae81.camel@gmail.com> (Liliana Marie Prikler's message of "Mon, 25 Sep 2023 20:41:05 +0200") Message-ID: <87ttrgzybq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66171 Cc: 66171@debbugs.gnu.org, Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Liliana Marie Prikler writes: > Am Montag, dem 25.09.2023 um 13:51 -0400 schrieb Maxim Cournoyer: >> Hello, >>=20 >> Liliana Marie Prikler writes: >>=20 >> > * gnu/packages/version-control.scm (git)[outputs]: Add >> > =E2=80=9Ccompletion=E2=80=9D. >> > [#:phases]: Add =E2=80=98install-completion=E2=80=99. >> > (git-minimal)[#:phases]: Adjust accordingly. >>=20 >> Did something change in git?=C2=A0 I've always had completion in git, so >> I'm not sure what this extra phase does, or when it's useful?=C2=A0 Does >> it add *extra* completion or... ? > Which shell are you using? If it's zsh, then the completion is baked > in. If it's bash, idk, I haven't tried. I personally use this for the > included git-prompt, which allows me to have my prompt look like the > following: > > \u@\h /path/to/guix [$branch env] ($SHLVL) \$ I see. I use Bash. > >> Also, a completion output seems a bit over the top.=C2=A0 I doubt its >> weigh justifies the annoyance of special casing it. > I special-cased it because it *is* a contrib script, but also as it > might be able to conflict with whatever shell builtins you have. Now > it isn't particularly likely to do so given that other distros include > it as part of their git-core, but I prefer safe over sorry. Ah, if it's just a contrib I guess a dedicated output is fine, although i'd perhaps call such output 'contrib', as completions seem to imply that without it there are no auto-completion support, which is clearly not the case, at least for Bash. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 28 10:41:44 2023 Received: (at 66171) by debbugs.gnu.org; 28 Sep 2023 14:41:44 +0000 Received: from localhost ([127.0.0.1]:54373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlsD2-0007pS-3S for submit@debbugs.gnu.org; Thu, 28 Sep 2023 10:41:44 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:62566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlsCz-0007p8-7q for 66171@debbugs.gnu.org; Thu, 28 Sep 2023 10:41:42 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-405505b07dfso67870775e9.0 for <66171@debbugs.gnu.org>; Thu, 28 Sep 2023 07:41:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695912081; x=1696516881; darn=debbugs.gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=sNkIw6oKwU2TOeGTCibsGa7HP390I6KDV0x5HFkxAIg=; b=lr/hZqfdR6XGI+LDDUfc8vnJsbwGGFMuK6Qb2jOOtzK/tDwjRtivVHX/TFgyhYj8S7 34H+TJhngOByaK4Yod9WkALsqMqWCbbad4ClQULwifEQ+60mG8T8fxa9G3qv40IV5fjr 03d0FCxWe1cq5MvodFs+iUYjK81IS9cxIGB/w/8WEiAlv2aUIIPRRjX7m7nI5ci2MnFX Qtw8zXAOjwh0dLmoRJHpXYhpBjZVkLFzkHcBljZxl6DA5msjnjXLPw7skw6oG7G4GVEH nVZY5r7d/WbE4bTbb47syqLqFQV9ZFwawoatNndpWtUq71Eqr1zXOstxYNcGx+6vOjIq i5Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695912081; x=1696516881; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sNkIw6oKwU2TOeGTCibsGa7HP390I6KDV0x5HFkxAIg=; b=LHSC4J2KJTF/uJqXnvwrOCOJNBFNdW94KdAeygCPnoaDe1pjBw1FUEikGKQfAR5L8e e/W922tdv4tWsRr8rei9edbfE1ZNz6ScpW7m2kaSDKZHeLVsq1+UkmQ6B9KS1hQR9oa9 x4+v2lUj6UcvOv0zFp69QK6dr3T+eSstQrd3mrQJPw2Zmiv84eCfmow8ZY48yAF9inK5 cZUS5QoxbXvfckDuG2ppioIozSb1+3oI+z/15QMO911NN7i4bqcwYhU6MgUDMwd45Z7+ mkQnY90WJ2x60RUtzO6+jeDeJavpuQHLcqFSTCeniATf5m+wNRr8Fhnbg2guNxoQMlo0 MGMw== X-Gm-Message-State: AOJu0YzJWNI8Ohu7zt+j66LyMMY27Y6Suv/45QrVITwBK+40pWQ+aXFt LbfL+fc/lWU/Je+CyuEyKGc= X-Google-Smtp-Source: AGHT+IGon7osH3Q/qorxGO06MlzJ44lXIDc15600gzV3Q7v7tJ+wkkWamL7IfvWJ8QztqHmeDA2V+Q== X-Received: by 2002:a5d:6404:0:b0:320:6d6:315b with SMTP id z4-20020a5d6404000000b0032006d6315bmr1443951wru.29.1695912080992; Thu, 28 Sep 2023 07:41:20 -0700 (PDT) Received: from localhost ([2a02:ed3:916:6300:c3db:b80e:a694:a54f]) by smtp.gmail.com with ESMTPSA id bt14-20020a056000080e00b003200c918c81sm13141220wrb.112.2023.09.28.07.41.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 07:41:20 -0700 (PDT) Date: Thu, 28 Sep 2023 17:41:18 +0300 From: Efraim Flashner To: Liliana Marie Prikler Subject: Re: [bug#66171] [PATCH] gnu: git: Install shell completions. Message-ID: Mail-Followup-To: Efraim Flashner , Liliana Marie Prikler , Maxim Cournoyer , 66171@debbugs.gnu.org, Simon Tournier References: <7be0975a4d30362dec08c3115e68c992e58ab549.1695660890.git.liliana.prikler@gmail.com> <877coe2lap.fsf_-_@gmail.com> <7659d2d5a891bb3ee81e87ab484924f3337cae81.camel@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qn0rKT3kVHRBiqsL" Content-Disposition: inline In-Reply-To: <7659d2d5a891bb3ee81e87ab484924f3337cae81.camel@gmail.com> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 66171 Cc: 66171@debbugs.gnu.org, Maxim Cournoyer , Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --qn0rKT3kVHRBiqsL Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 25, 2023 at 08:41:05PM +0200, Liliana Marie Prikler wrote: > Am Montag, dem 25.09.2023 um 13:51 -0400 schrieb Maxim Cournoyer: > > Hello, > >=20 > > Liliana Marie Prikler writes: > >=20 > > > * gnu/packages/version-control.scm (git)[outputs]: Add > > > =E2=80=9Ccompletion=E2=80=9D. > > > [#:phases]: Add =E2=80=98install-completion=E2=80=99. > > > (git-minimal)[#:phases]: Adjust accordingly. > >=20 > > Did something change in git?=C2=A0 I've always had completion in git, so > > I'm not sure what this extra phase does, or when it's useful?=C2=A0 Does > > it add *extra* completion or... ? > Which shell are you using? If it's zsh, then the completion is baked > in. If it's bash, idk, I haven't tried. I personally use this for the > included git-prompt, which allows me to have my prompt look like the > following: >=20 > \u@\h /path/to/guix [$branch env] ($SHLVL) \$ /gnu/store/p7zln1rzsccq8vgpnrm4ibz5hcgxrqd9-git-2.41.0/etc/bash_completion.= d/git It looks like there is a bash completion from git. I thought maybe it was from the bash-completions package. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --qn0rKT3kVHRBiqsL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmUVkIsACgkQQarn3Mo9 g1ErNQ/6A+R0hpBSs9j/+sdd/FkfugWTfoxaQf6n6Eg8DO4MdDO7yHG+g5Wu6VVY EWD1CxMYDiLzJlDhWGzeXt1yrTpz3A0ENQXmbA/srmwCSl8Exuh57pcSfc384K5r UQ7XPDv79GwgMe3LzZNFHjS0/9rHRqC3JXPH0CSSti/AWDbQ/ftBw5Gb1rx3efEW TRuvfGTTgeTKpzb83Px6MvuwFRXqa4PPgO1B1R+8ZsIpvNZnRRauZEHv6+zwVCfw vq4bIhRye6IG2Tmhaq96T1VW3QtYSBkQs/h80O2EJ9mhFX2YbuK5Xz1tNWGZXSIJ uvQizyJ0DlNFA/mabOBOJCUqfJ2hkKdYMhfbs9yakYS3x+HX1vppC5FMU4MC/ibS FsUzRtGLJfeWMLLTufHUhDuK+FYRb9seJNzCO1ZY6rmWtuMptxLlNj/NNVvsBInv 1JL70WxrhIG8CRVqnLPLaAjk0A4J8RP1R3o+Av2zKXEpcmzN6PkdyLKshj2x6EvN wgVqv3wZmhk4r9egJyYEWjQhD78N1GAc/+9JaCywAaIPuLRHuW2SXCqW6Bxc7VyQ RyUeu/vGEmyod3WKCXX3083NhPs9yaqfoLWSd2K0cvshjR9itv5N6But6czXLWRQ FIBnsQe8bOTR1WdZ0Sc5N6gBCyWxEixT0CIiA6H3DySR6J8hHbk= =qFhd -----END PGP SIGNATURE----- --qn0rKT3kVHRBiqsL-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 28 14:53:34 2023 Received: (at 66171) by debbugs.gnu.org; 28 Sep 2023 18:53:34 +0000 Received: from localhost ([127.0.0.1]:54501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlw8k-0007ZF-3D for submit@debbugs.gnu.org; Thu, 28 Sep 2023 14:53:34 -0400 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]:61789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlw8g-0007Yv-9t for 66171@debbugs.gnu.org; Thu, 28 Sep 2023 14:53:32 -0400 Received: by mail-ed1-x543.google.com with SMTP id 4fb4d7f45d1cf-5363227cc80so1414627a12.3 for <66171@debbugs.gnu.org>; Thu, 28 Sep 2023 11:53:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695927190; x=1696531990; darn=debbugs.gnu.org; h=mime-version:cc:to:subject:date:from:message-id:from:to:cc:subject :date:message-id:reply-to; bh=xRmPsG7Tm/6N2LZvxMmofgaI07StOCgvmpkG2VSTVgw=; b=CGVqa+IzT7Fk+7uNbEPDOP8tz8bm2RVPQSCXkmmNiyOyWN/bAto+9TQuErzZLoG4bz nRCDlNdQvpqS3fmZFzJqtrMn/XbaS5eKRu/z5rFR6BM9LZqoLy9NEnPwE8Kh55U++v2U ytLYIgf8bAXOxxoRRlQHfES5tg1YFfHbx/6pEtlgZCgkVSI/XP4ULv0YPBO1cbKaJAqd V7LcNsLMXvff2vqZDIxxuT3rJJKFskzNDBE+398ZMki34Vt/+AUeEd7On2obBQfh3iV1 hOyN+0sQDq4RhDZYAnQhanzUUDJHyG1w/ID72GVso3t2v6aUaHWtY4rNwM8UBodXBTvl wxzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695927190; x=1696531990; h=mime-version:cc:to:subject:date:from:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=xRmPsG7Tm/6N2LZvxMmofgaI07StOCgvmpkG2VSTVgw=; b=TPKIEafBP7fZ2VgNq0hg6sXkMYGrldpxgzTjsGOgIDXJWjoAaSUtRLJ9jSXUDI6hGW rEvL7vBlsGzsT/gGIR1RuYXDkHEm+fOD1NgNLedz399kyQ6LFU6OXoESvaXHKUcq5wWx DH18Zjqa3xfzU81fNtX7nyZykh4qzCW6LW6pD9c/p2tbm26BKE6gqXAkzJMKRT4pbjFq lvUeHaTzBZIP1msgVG7lcgBj8loAYoibR+aggRLsCWDUyxI4WhuYdaD0xn9Ek9ROj2Se 7OL7CYctb+b0vBC5EcY8zcJhVFF3x5fRxnJEO39WDWCeFWxnDDgoTVOxmrvAll7oQYQU Ns4w== X-Gm-Message-State: AOJu0YwCK9CXmXwcS3eL09T25Vnce3Xr6V+OC0WFfaOwihzR3/f6ckdN 9Ga+nGI0DlD54Xed5PHSGtFk8n2QzWuAOw== X-Google-Smtp-Source: AGHT+IEpolu9H4hJLMiVwzAC17he8QIB7Q0fZq0/KsAsODMzMOykMcM83sY2vN3hFfaf+DYrWEAdkQ== X-Received: by 2002:a05:6402:8d8:b0:523:100b:462b with SMTP id d24-20020a05640208d800b00523100b462bmr2243050edz.5.1695927189696; Thu, 28 Sep 2023 11:53:09 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id eg42-20020a05640228aa00b00533dad8a9c5sm6949654edb.38.2023.09.28.11.53.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 11:53:08 -0700 (PDT) Message-ID: <00b2291bb7eaa66b3f62ea4d94e44bf85ec62b51.1695927171.git.liliana.prikler@gmail.com> From: Liliana Marie Prikler Date: Sat, 23 Sep 2023 21:43:07 +0200 Subject: [PATCH v3] gnu: git: Install zsh completions and git-prompt. to: 66171@debbugs.gnu.org MIME-Version: 1.0 X-Spam-Score: 2.1 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/version-control.scm (git)[#:phases]: Also install git-prompt and zsh _git site function. --- gnu/packages/version-control.scm | 15 ++++++++++----- 1 file chang [...] Content analysis details: (2.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.1 DATE_IN_PAST_96_XX Date: is 96 hours or more before Received: date 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (liliana.prikler[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:543 listed in] [list.dnswl.org] X-Debbugs-Envelope-To: 66171 Cc: Efraim Flashner , Maxim Cournoyer , Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/version-control.scm (git)[#:phases]: Also install git-prompt and zsh _git site function. --- gnu/packages/version-control.scm | 15 ++++++++++----- 1 file chang [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:543 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 2.1 DATE_IN_PAST_96_XX Date: is 96 hours or more before Received: date 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (liliana.prikler[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager * gnu/packages/version-control.scm (git)[#:phases]: Also install git-prompt and zsh _git site function. --- gnu/packages/version-control.scm | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index 9716a6f27a..d8c9bf4009 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -448,12 +448,17 @@ (define-public git "DOCBOOK2X_TEXI=docbook2texi" "PERL_PATH=perl"))) (add-after 'install 'install-shell-completion (lambda* (#:key outputs #:allow-other-keys) - (let* ((out (assoc-ref outputs "out")) - (completions (string-append out "/etc/bash_completion.d"))) - ;; TODO: Install the tcsh and zsh completions in the right place. - (mkdir-p completions) + (let* ((out (assoc-ref outputs "out")) + (bash (string-append out "/etc/bash_completion.d")) + (zsh (string-append out "/share/zsh/site-functions"))) + ;; TODO: Install the tcsh completions in the right place. + (for-each mkdir-p (list bash zsh)) (copy-file "contrib/completion/git-completion.bash" - (string-append completions "/git"))))) + (string-append bash "/git")) + (copy-file "contrib/completion/git-prompt.sh" + (string-append out "/bin/git-prompt")) + (copy-file "contrib/completion/git-completion.zsh" + (string-append zsh "/_git"))))) (add-after 'install 'install-credential-netrc (lambda* (#:key outputs #:allow-other-keys) (let* ((netrc (assoc-ref outputs "credential-netrc"))) base-commit: ce0cc6137df81919389f61671096a6ce701c0889 prerequisite-patch-id: ee5d7299c5790d77e0d409f34165063fcff10a8b prerequisite-patch-id: 369548fa905a48e7e2164ca4b6c9897e392a5025 prerequisite-patch-id: 7650e691c505ecc63e3b1a1265b3cb3a2869443e prerequisite-patch-id: 5e7e47f338fa42c4f5c654a803f062b5e3f757a6 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 01 23:35:22 2023 Received: (at 66171) by debbugs.gnu.org; 2 Oct 2023 03:35:22 +0000 Received: from localhost ([127.0.0.1]:35613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qn9iL-0005oj-Ub for submit@debbugs.gnu.org; Sun, 01 Oct 2023 23:35:22 -0400 Received: from mail-qv1-xf35.google.com ([2607:f8b0:4864:20::f35]:50321) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qn9iK-0005oS-F4 for 66171@debbugs.gnu.org; Sun, 01 Oct 2023 23:35:20 -0400 Received: by mail-qv1-xf35.google.com with SMTP id 6a1803df08f44-65d0da28fa8so27827766d6.0 for <66171@debbugs.gnu.org>; Sun, 01 Oct 2023 20:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696217698; x=1696822498; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=49oZXWbjEc+i0FxamlYfxit0dO5kynbFEOjFUrG3zBM=; b=jCW7+sz//ntMeBQJSeoy2XseVbVymofDBkPtg8dRA2dMb+YMug5oIxxtA3lTU3ownG 7y0h4Ctuxj36dOkIEOCIXv7fknrP65j5o806FIjBoUj3kMksIzGgW6pbRPDX2hGF+dGn 7P2QtcYApx2NfMitJjDsKgjm8zmKt90TAEw59/8yNi/69Sr6g9CH/rJB0y58B3Cto2Ic 3G8hv3vby0r/RyojBeJEKhlkNwdeUSaGXBB1sT0hj2E/Zr8VEYwBZemy4ECLNZjJsOp6 kmW0bpb2qbhG4wUom0cRakNuzk4X+40Rlw5UEmqlMCQKUYyuj64odPpJwOur4A6sjNOd RXuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696217698; x=1696822498; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=49oZXWbjEc+i0FxamlYfxit0dO5kynbFEOjFUrG3zBM=; b=b852HloXKnetIIHpG7VVwQGKxoMOjqeOA0nIuOq8l6RCPCiJQNNsVoDugMTtRut6tH beTNXkVGl0kBl3IdA/woqcdKjfpSFSs2XcI57EJa27SlBJ8MMbfsnIlzYi4lOLe4Gz6s imbj/SRrfddLqOBP8f2qma+C0kA86zeV2U3kZh7JyRa6VaMF9RxHp5CamszqmIhVS6k4 rdEc1OLw6S5zSwUQnf0AndQUveXTpI5bteUJRdvdP1KASw+xwZqjuErkUuFnpnY/Dpgu +Yn09xbmA+gQUYB3cLnyWmQbiJ/PJt5FINpmoxmuCha4y0KSJLZB3abWBhjZhOC3KSqU iEKA== X-Gm-Message-State: AOJu0YwufZRbUJM7WCPBe2nrs+ZXDOL6e9LqJIHljhJB5FZg/sPlhmvn RKfptwhirn1MLNVt/IHyX88= X-Google-Smtp-Source: AGHT+IHl2XMifnTYtp+6vtkZWbPn50xcaYWxKRpDDCk09/06qlcyk0c40ioCc5rNwVidJDee/FsJiA== X-Received: by 2002:a05:6214:3f87:b0:658:22d8:9 with SMTP id ow7-20020a0562143f8700b0065822d80009mr11152132qvb.61.1696217698431; Sun, 01 Oct 2023 20:34:58 -0700 (PDT) Received: from hurd (dsl-10-136-90.b2b2c.ca. [72.10.136.90]) by smtp.gmail.com with ESMTPSA id t9-20020a0cde09000000b0065d0dcc28e3sm3068776qvk.73.2023.10.01.20.34.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Oct 2023 20:34:58 -0700 (PDT) From: Maxim Cournoyer To: Liliana Marie Prikler Subject: Re: [PATCH v3] gnu: git: Install zsh completions and git-prompt. References: <00b2291bb7eaa66b3f62ea4d94e44bf85ec62b51.1695927171.git.liliana.prikler@gmail.com> Date: Sun, 01 Oct 2023 23:34:56 -0400 In-Reply-To: <00b2291bb7eaa66b3f62ea4d94e44bf85ec62b51.1695927171.git.liliana.prikler@gmail.com> (Liliana Marie Prikler's message of "Sat, 23 Sep 2023 21:43:07 +0200") Message-ID: <875y3p66jj.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66171 Cc: Efraim Flashner , 66171@debbugs.gnu.org, Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Liliana, Liliana Marie Prikler writes: > * gnu/packages/version-control.scm (git)[#:phases]: > Also install git-prompt and zsh _git site function. > --- > gnu/packages/version-control.scm | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm > index 9716a6f27a..d8c9bf4009 100644 > --- a/gnu/packages/version-control.scm > +++ b/gnu/packages/version-control.scm > @@ -448,12 +448,17 @@ (define-public git > "DOCBOOK2X_TEXI=docbook2texi" "PERL_PATH=perl"))) > (add-after 'install 'install-shell-completion > (lambda* (#:key outputs #:allow-other-keys) > - (let* ((out (assoc-ref outputs "out")) > - (completions (string-append out "/etc/bash_completion.d"))) > - ;; TODO: Install the tcsh and zsh completions in the right place. > - (mkdir-p completions) > + (let* ((out (assoc-ref outputs "out")) > + (bash (string-append out "/etc/bash_completion.d")) > + (zsh (string-append out "/share/zsh/site-functions"))) > + ;; TODO: Install the tcsh completions in the right place. > + (for-each mkdir-p (list bash zsh)) > (copy-file "contrib/completion/git-completion.bash" > - (string-append completions "/git"))))) > + (string-append bash "/git")) > + (copy-file "contrib/completion/git-prompt.sh" > + (string-append out "/bin/git-prompt")) > + (copy-file "contrib/completion/git-completion.zsh" > + (string-append zsh "/_git"))))) > (add-after 'install 'install-credential-netrc > (lambda* (#:key outputs #:allow-other-keys) > (let* ((netrc (assoc-ref outputs "credential-netrc"))) Sorry if my previous reply was not clear, but with your clarifications I think it'd be best to keep the 'contrib' output, perhaps documenting in the description that it contains the 'git-prompt' command as well as completions for Zsh? -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 02 00:31:27 2023 Received: (at 66171) by debbugs.gnu.org; 2 Oct 2023 04:31:27 +0000 Received: from localhost ([127.0.0.1]:35661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnAad-0001el-6v for submit@debbugs.gnu.org; Mon, 02 Oct 2023 00:31:27 -0400 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:58758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnAab-0001eW-Vs for 66171@debbugs.gnu.org; Mon, 02 Oct 2023 00:31:26 -0400 Received: by mail-wm1-x344.google.com with SMTP id 5b1f17b1804b1-4065f29e933so25902415e9.1 for <66171@debbugs.gnu.org>; Sun, 01 Oct 2023 21:31:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696221063; x=1696825863; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=kS4ZS3PfoZc93n0PEvpxIVuk3JU1H05zZ/7Gc4Oq53Y=; b=mnSXnBc8SddwCH4sYm/Xye0vLXjVkTJbDD5nKyleUwrjuoho543X50g3XoFgh3zgsi NTXLcQUsoaqnj7XE2gdBJ8R2r31oSQrPC13EkYS196cPwZy1oV9AlrNI0O8w+N2c9uhW cGbV2TBMGMyZkEZNOQnyADyA2IGnTz4WPihgr7e2zgg0P3Fokz6AYi0VY+A08sTDg9/j oklWwTXn+s8hFeGOCJn2XEguw0ESlUL5JwCykKHBIpiSnJGJDNha8tDQ3Oy0qPfC6F+A 90wIKvlrBk0PW9/46n/KeP/zDLWWQV8sZ4E5fS/DsjSOxUbJmFBDazGRhCYkwlVJa7F9 5j+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696221063; x=1696825863; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kS4ZS3PfoZc93n0PEvpxIVuk3JU1H05zZ/7Gc4Oq53Y=; b=aeHGoHrM52KECx0eY0orSoOrChYhoHqeCL8VGoLgFigs2J/O6AyQt+SzUdh7EwlW86 KHhsCIPwci1rTIFpBS3Bt15Eu0wXXFxoUzhB4bdLLNRSjad/Bqv3/+znE+Ihx4PCk/wy XaQI4N/xbnj6s9+bNToST1EZPkLdoAZSP6k2HCJ6laa/CsbLusliqN5heX/OuH7DeyEh x/6KjrP5415Xa+echs/JdBPYWizWA3KK5MLoeU3eszPknA/elrIzigJot6WW1L7UN29x 8fXNgVzfD9JGYzqZ8/xVEm9nX62rBAH2jkAofeLodxwqGo6V4Fs/AOJz0exu5K89p3C3 F0jg== X-Gm-Message-State: AOJu0YxuNHKOGk5p5bdfp/+RcfS11YbowpYHyGjh39KlVwQ83d7E+Ors HIIXGPuQh9hiVS7mgUbnhxc= X-Google-Smtp-Source: AGHT+IHQL3VGjkRevxw3eaBR6+ufDm3xkEUQMPDtKhxKBntOdF4iek7g0BGI2fo5dhy8+yYJlKd3gw== X-Received: by 2002:a5d:44cb:0:b0:317:df82:2868 with SMTP id z11-20020a5d44cb000000b00317df822868mr9635092wrr.26.1696221063384; Sun, 01 Oct 2023 21:31:03 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id bv19-20020a0560001f1300b0032327b70ef6sm18510243wrb.70.2023.10.01.21.31.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Oct 2023 21:31:02 -0700 (PDT) Message-ID: <9829503773a753da78f3e18add0833a6d115305c.camel@gmail.com> Subject: Re: [PATCH v3] gnu: git: Install zsh completions and git-prompt. From: Liliana Marie Prikler To: Maxim Cournoyer Date: Mon, 02 Oct 2023 06:30:59 +0200 In-Reply-To: <875y3p66jj.fsf@gmail.com> References: <00b2291bb7eaa66b3f62ea4d94e44bf85ec62b51.1695927171.git.liliana.prikler@gmail.com> <875y3p66jj.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66171 Cc: Efraim Flashner , 66171@debbugs.gnu.org, Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Sonntag, dem 01.10.2023 um 23:34 -0400 schrieb Maxim Cournoyer: > Hi Liliana, >=20 > Liliana Marie Prikler writes: >=20 > > [...] > Sorry if my previous reply was not clear, but with your > clarifications I think it'd be best to keep the 'contrib' output, > perhaps documenting in the description that it contains the 'git- > prompt' command as well as completions for Zsh? IMHO, a =E2=80=98contrib=E2=80=99 output would be silly, since so much of w= hat we install in other outputs are part of contrib. The name lacks meaning. As for why I put it in =E2=80=98out=E2=80=99 instead of =E2=80=98completion= =E2=80=99, I did miss the fact that we already install git completions for bash, so not that I know, I just extended the phase that does that. Cheers From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 02 05:12:36 2023 Received: (at 66171) by debbugs.gnu.org; 2 Oct 2023 09:12:36 +0000 Received: from localhost ([127.0.0.1]:36022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnEyi-0007Ax-2H for submit@debbugs.gnu.org; Mon, 02 Oct 2023 05:12:36 -0400 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]:58871) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnEyg-0007Aj-Rn for 66171@debbugs.gnu.org; Mon, 02 Oct 2023 05:12:35 -0400 Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-99c3c8adb27so2301256466b.1 for <66171@debbugs.gnu.org>; Mon, 02 Oct 2023 02:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696237932; x=1696842732; darn=debbugs.gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=rqZFRj4uW+PkwEpejiddjAcw4tUQ4+/NOENC7eTNEew=; b=nCALqwx9sDnpQvUfLnMn7CTM+4/7rdfCaFvA2CMBo7EurwhkvcfTYo/dKHd4ZoGyxX /YIaDMOH0+rlBwRt7XdawEtt51bqvAUSjqSI6k5MP7BAGOQ1GD+JSYbVJUDz+Oc/55ge GJ9YzfnvMB6hNDon3mpwsw4UVJZKycC6f9LVFqYmvKqigTyFYl9jwIYANLeiKPrGSdqR z7yd/kWcr82vrzmFMBDjoPOcjeKSAz9kNsVkS1yXozTBJu8rakhKcPNxjqgnyvTpIbKC v5dGM1DyFOTzJyK4bxT5/O9HtvR9bm95K5uv4Bl9mUbvcwE2HGbqdQPJ7uQ+0AIuaNiA Fr2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696237932; x=1696842732; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rqZFRj4uW+PkwEpejiddjAcw4tUQ4+/NOENC7eTNEew=; b=DQ0PwHWKSL61gkCE6CNhHHOgQPa45RW0RllFt6OYuNHbgMCDauQGeFuwzVc41jYEP5 GHtVHcqnrixtC7gbdbeLNgkC2ZAX4riqBHAtAtj0SazP0NNd0hnKqN+ssQ7NiFeedh4a R4a720ZmTGG+t2QG2QCJHCORbsH5ywiGvo2MgzLP75jVd0nxcsaWTy63KkrmVjkAjN10 MEbhxgJ/BkQt1bUsq3p3XR6s7/NFeu+AS4iO0/6z4so7h1FjZhRnNuIzvEVYDVBxTNR5 i2VMgR9XB/eLu0DbqNO6owXM6wZv/RIlULVMhGWSUcT8PGDaMlY7H6ci+PaeUgNnNh0V Hv0w== X-Gm-Message-State: AOJu0YxrnIGIBqSafZOCoXtznkCFNlOnX5YqG8O3LjkhJH9D+Ko86mHE qYID0e7D+KE/Q9UexCJsoFM= X-Google-Smtp-Source: AGHT+IE99w1axoCy6gsJrIjJMBAUiPgj0rgin1icW8SfeTB9l2UrpJdSe9viTiCEYYC2O4a8hBzgTA== X-Received: by 2002:a17:907:762d:b0:9a1:c357:c743 with SMTP id jy13-20020a170907762d00b009a1c357c743mr9365285ejc.52.1696237932184; Mon, 02 Oct 2023 02:12:12 -0700 (PDT) Received: from localhost ([2a02:ed3:916:6300:c3db:b80e:a694:a54f]) by smtp.gmail.com with ESMTPSA id p8-20020a170906614800b009828e26e519sm16497815ejl.122.2023.10.02.02.12.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 02:12:11 -0700 (PDT) Date: Mon, 2 Oct 2023 12:12:10 +0300 From: Efraim Flashner To: Liliana Marie Prikler Subject: Re: [PATCH v3] gnu: git: Install zsh completions and git-prompt. Message-ID: Mail-Followup-To: Efraim Flashner , Liliana Marie Prikler , Maxim Cournoyer , 66171@debbugs.gnu.org, Simon Tournier References: <00b2291bb7eaa66b3f62ea4d94e44bf85ec62b51.1695927171.git.liliana.prikler@gmail.com> <875y3p66jj.fsf@gmail.com> <9829503773a753da78f3e18add0833a6d115305c.camel@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cQBMk4WaJh/xkpbi" Content-Disposition: inline In-Reply-To: <9829503773a753da78f3e18add0833a6d115305c.camel@gmail.com> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 66171 Cc: 66171@debbugs.gnu.org, Maxim Cournoyer , Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --cQBMk4WaJh/xkpbi Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 02, 2023 at 06:30:59AM +0200, Liliana Marie Prikler wrote: > Am Sonntag, dem 01.10.2023 um 23:34 -0400 schrieb Maxim Cournoyer: > > Hi Liliana, > >=20 > > Liliana Marie Prikler writes: > >=20 > > > [...] > > Sorry if my previous reply was not clear, but with your > > clarifications I think it'd be best to keep the 'contrib' output, > > perhaps documenting in the description that it contains the 'git- > > prompt' command as well as completions for Zsh? > IMHO, a =E2=80=98contrib=E2=80=99 output would be silly, since so much of= what we > install in other outputs are part of contrib. The name lacks meaning. >=20 > As for why I put it in =E2=80=98out=E2=80=99 instead of =E2=80=98completi= on=E2=80=99, I did miss the > fact that we already install git completions for bash, so not that I > know, I just extended the phase that does that. It's not uncommon to see shell completions in a contrib directory. I think it'd make more sense to install them to a 'completions' output than to a 'contrib' output, but I think it would make the most sense to just install them to the 'out' output. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --cQBMk4WaJh/xkpbi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmUaiWoACgkQQarn3Mo9 g1HsgA//aQMaHFN58e08ltX26pKC+tZ89vbll339GCSYZBza0GFNfog7RhWoj0nh VEtD/lidJ/vwzpxY7xzxO32yYK4w4tz0nO+5Ky5X/J0UhmAYlLUImPqAWhj5mppK KdE7V4YSenWEQwZlh+EkcUI2uFDo7UDxZoyOLY86i19iypFkfXFOZeZr+eek3j7e bMy6j1+LEioEmSSV1/5jqj2DJjUFWQBXfvj+PN2q37ju2CSRNi9WQKycfq3uJcq0 zGeyQ+PtfKEs5sBaR7g9wADV2oAyY+qEGAlNDTipyKFsz9+Lw+uh/i6gosyp8J/h 67UdNud5X1IZDVsL7Kqz4ORH/bnCPxDZd/xltnWTOseZX27Z2TKi8s6Zpb9f2oWs LkF67F8aitimOTPhkc8io4iM3a9+2XjT6LrQzw8DcdTP2oZzlm+CAN1oPzNNtaxS WM4eY8IVIcHDv5Z4l6vit2vOXs1txGibInlu6vSbjgz7cf2McD0LxmXvtKwDesSh 5x753t4xqLLNlg4P/AZ29pFIb0bZivN8NXVPiv+YmUF/3Fw//2CJ8dAwWIlmt7MJ kfyG7+R6Zqv4HSrKQWKTwlNQgX2KlINjVVcqZgdoYBZZgxHgH+/xSK+LaoE4mfl4 ItODyONAPjBDRO1UMwRIuT2Uh7erynL88VYVqXy75eWeeV9r0YA= =pfPr -----END PGP SIGNATURE----- --cQBMk4WaJh/xkpbi-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 03 20:36:10 2023 Received: (at 66171) by debbugs.gnu.org; 4 Oct 2023 00:36:10 +0000 Received: from localhost ([127.0.0.1]:40972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnps2-0005tH-Ei for submit@debbugs.gnu.org; Tue, 03 Oct 2023 20:36:10 -0400 Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]:58415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnps0-0005t0-40 for 66171@debbugs.gnu.org; Tue, 03 Oct 2023 20:36:08 -0400 Received: by mail-qk1-x735.google.com with SMTP id af79cd13be357-77421a47db6so104524985a.0 for <66171@debbugs.gnu.org>; Tue, 03 Oct 2023 17:35:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696379745; x=1696984545; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=a/ZBXw9V7XrCRww2+oS6k9skhGVV5j9ItCAOzham5Tk=; b=ZP/h3vc/75AebAno8+rY5NOFdRgnwfjWH5jzks3HFiuOSmNykNZ89cy4LSOdbNPyan tBxmckLs2VO+shCJS4k/VamvAgqfFb1o1MH/tn23NUetReMz6h6ptWjlWinobUEl/Go5 xsQzkSJ6023hhfEX5T2uFdUbKl0U3V+G+uq5++z7OQ9iO9tuqxyJyRMBQ1lDBU1g6kc1 zl+bjG6dc+KaoBKxXYBaEnwdfsJrybIsTiv7zRi6/+gkR/fEgofIorOODHS++zxIBnVC 2PX/am1BWow+I4dc3yoB44SujGayjAn6GQ6XQbLwXOlHXGtEsMGr2E1MlOIqr0BjVEY3 todA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696379745; x=1696984545; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=a/ZBXw9V7XrCRww2+oS6k9skhGVV5j9ItCAOzham5Tk=; b=tTzWZVulDc4FGt/SObuGjyuaE3P55HI/5QGz+xt7TGNGwoVTSdRgY3HpQISfEhMHk1 KS8ewu2osVsncFVlqyJWO+zrwAnfAh5K7fzJlDjzBgnMyG7bGkd3uE4ujbA3W42vxWb0 IqD4B38GkIkPrY8NSbQEVark4sGSkGvPXMyGKUWAVqH3mlzTyKkjCbGRa6JxRjUChfVN PvkEZiPROy/cGvyZE08wWPk1zx+3iwI1eqgYLt7Sc7vj4J9LIWrrvWHBa9G153jG5foR ocwFV8WXhFfMUD6jl7nnWqH74kzFF56NJEsuLpVvoqUh2kkj2pYVild2IqcFzHQMuQ7r XAPg== X-Gm-Message-State: AOJu0YxwBRqs1BX+FKiEcyE087tdZK5PEpHPowkDe6v2UR/4Rt0h7Pob EWeDFCtvJilBiBxCh6fsLgM= X-Google-Smtp-Source: AGHT+IGZ28xo9Qq3EOg1DSzRX++Dymd5m1i2ZALDt15emVVoBJL9oLE/GFH4UBu4JX5XDyjiPTksyg== X-Received: by 2002:a05:620a:8da:b0:774:cf9:b206 with SMTP id z26-20020a05620a08da00b007740cf9b206mr1027619qkz.42.1696379744891; Tue, 03 Oct 2023 17:35:44 -0700 (PDT) Received: from hurd (dsl-141-24.b2b2c.ca. [66.158.141.24]) by smtp.gmail.com with ESMTPSA id s28-20020a05620a031c00b00767d2870e39sm882104qkm.41.2023.10.03.17.35.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 17:35:44 -0700 (PDT) From: Maxim Cournoyer To: Efraim Flashner Subject: Re: [PATCH v3] gnu: git: Install zsh completions and git-prompt. References: <00b2291bb7eaa66b3f62ea4d94e44bf85ec62b51.1695927171.git.liliana.prikler@gmail.com> <875y3p66jj.fsf@gmail.com> <9829503773a753da78f3e18add0833a6d115305c.camel@gmail.com> Date: Tue, 03 Oct 2023 20:35:43 -0400 In-Reply-To: (Efraim Flashner's message of "Mon, 2 Oct 2023 12:12:10 +0300") Message-ID: <87r0mb6x7k.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66171 Cc: Liliana Marie Prikler , 66171@debbugs.gnu.org, Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Efraim Flashner writes: > On Mon, Oct 02, 2023 at 06:30:59AM +0200, Liliana Marie Prikler wrote: >> Am Sonntag, dem 01.10.2023 um 23:34 -0400 schrieb Maxim Cournoyer: >> > Hi Liliana, >> >=20 >> > Liliana Marie Prikler writes: >> >=20 >> > > [...] >> > Sorry if my previous reply was not clear, but with your >> > clarifications I think it'd be best to keep the 'contrib' output, >> > perhaps documenting in the description that it contains the 'git- >> > prompt' command as well as completions for Zsh? >> IMHO, a =E2=80=98contrib=E2=80=99 output would be silly, since so much o= f what we >> install in other outputs are part of contrib. The name lacks meaning. >>=20 >> As for why I put it in =E2=80=98out=E2=80=99 instead of =E2=80=98complet= ion=E2=80=99, I did miss the >> fact that we already install git completions for bash, so not that I >> know, I just extended the phase that does that. > > It's not uncommon to see shell completions in a contrib directory. I > think it'd make more sense to install them to a 'completions' output > than to a 'contrib' output, but I think it would make the most sense to > just install them to the 'out' output. Sounds good! --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 09 23:33:50 2023 Received: (at 66171-done) by debbugs.gnu.org; 10 Oct 2023 03:33:50 +0000 Received: from localhost ([127.0.0.1]:33720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qq3VF-0001rI-PP for submit@debbugs.gnu.org; Mon, 09 Oct 2023 23:33:50 -0400 Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]:52581) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qq3V9-0001r1-Tc for 66171-done@debbugs.gnu.org; Mon, 09 Oct 2023 23:33:48 -0400 Received: by mail-qt1-x831.google.com with SMTP id d75a77b69052e-4181bd07f25so36990131cf.1 for <66171-done@debbugs.gnu.org>; Mon, 09 Oct 2023 20:33:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696908797; x=1697513597; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=l7swJe1sAfExWu5jOP7VIX3vlRRh6Vpda7IdEzFT/2M=; b=BZ6lYCwqVKOw2137avke9No285NI/TDRPf2hCMHMxuyWV8ZpFKph67y0sgoryvbjoC 0xYcUlyAtlnCnaaW118zcDRHGdYF8Nbv4rJucMjhphLStZTo1DVx2rO4UJYXH/FqiYeM vtHUYv3MWBzrAIxpEFz9YkROkMZuVkpGYq+adeYYDax5S2A+yM/2rTccJAgFJcjlMo2T qahTcpMubKPCnwn/VFSfKgPDdSixcKN4DOoAVSeH78n/VkMPShUsnko6iZ8oxHf/qRs+ vuPM52BbMydzxJrv0yUe+YdQRhEYTHIQBYGLAALOrWG/dxb72iv0AGnDHF0sQR9bVKYK VZbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696908797; x=1697513597; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=l7swJe1sAfExWu5jOP7VIX3vlRRh6Vpda7IdEzFT/2M=; b=GvyxZ7dBV/DyJPcLCAuai8ywBeqmNq9mw3ghhtByn6YsoRkezyllNNB0ij/vRMU/kY VhR2DG/RzD9P7yIN66IkkdRmGiwpahrS0wLq203f6y/d3StcLp37sdXm2NNuiKvKfqpQ yEzaoEuoSE+T4LCgOmz1EpIofZj+f3H/31joPEEL8YyWE/i89xr+sRE0ZbsLcQhj97eM R7Y+Kkz7FsmhIdPxEI6KBQyz+K+nqQhw8JGGq8wSNyYVXENnLleNYcJq2Z48G7B+/hOk xe+2F7i4r5fpTKSQQqJabkrRiScddsriMMkCxzKuFcPbb/Fsovt++S8gEIjLDYPymTBv pJAA== X-Gm-Message-State: AOJu0YxP0oRSW4dp9TowdHGhNl31W1+Uzlx3ZhkWnPP9qs2XSeifO++R TXrlSYxCbHkAuoudBH43ry8= X-Google-Smtp-Source: AGHT+IG2TqM9ffPiYHrwzTocp4VSLeg+AUQizZBtSQaZDFNnoru8UJBrgrlnaeiTn2V86V3C0qneMg== X-Received: by 2002:a05:622a:199d:b0:418:ff8:3833 with SMTP id u29-20020a05622a199d00b004180ff83833mr21250837qtc.52.1696908797176; Mon, 09 Oct 2023 20:33:17 -0700 (PDT) Received: from hurd (dsl-10-149-16.b2b2c.ca. [72.10.149.16]) by smtp.gmail.com with ESMTPSA id l4-20020ac87244000000b0041b0b869511sm3090117qtp.65.2023.10.09.20.33.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 20:33:16 -0700 (PDT) From: Maxim Cournoyer To: Liliana Marie Prikler Subject: Re: [bug#66171] [PATCH v3] gnu: git: Install zsh completions and git-prompt. In-Reply-To: <00b2291bb7eaa66b3f62ea4d94e44bf85ec62b51.1695927171.git.liliana.prikler@gmail.com> (Liliana Marie Prikler's message of "Sat, 23 Sep 2023 21:43:07 +0200") References: <00b2291bb7eaa66b3f62ea4d94e44bf85ec62b51.1695927171.git.liliana.prikler@gmail.com> Date: Mon, 09 Oct 2023 23:33:15 -0400 Message-ID: <8734yj883o.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66171-done Cc: Efraim Flashner , 66171-done@debbugs.gnu.org, Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Liliana Marie Prikler writes: > * gnu/packages/version-control.scm (git)[#:phases]: > Also install git-prompt and zsh _git site function. Applied to core-updates, after resolving the conflict. -- Thanks, Maxim From unknown Wed Jun 18 23:11:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 07 Nov 2023 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator