From unknown Fri Sep 05 19:41:19 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#6617 <6617@debbugs.gnu.org> To: bug#6617 <6617@debbugs.gnu.org> Subject: Status: linux kernel C style (fwd) Reply-To: bug#6617 <6617@debbugs.gnu.org> Date: Sat, 06 Sep 2025 02:41:19 +0000 retitle 6617 linux kernel C style (fwd) reassign 6617 emacs,cc-mode submitter 6617 Dimitrios Apostolou severity 6617 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 12 06:35:09 2010 Received: (at submit) by debbugs.gnu.org; 12 Jul 2010 10:35:09 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYGLs-0006YK-Sj for submit@debbugs.gnu.org; Mon, 12 Jul 2010 06:35:09 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYFuk-0006Kx-22 for submit@debbugs.gnu.org; Mon, 12 Jul 2010 06:07:06 -0400 Received: from lists.gnu.org ([199.232.76.165]:54553) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OYFum-000326-Hm for submit@debbugs.gnu.org; Mon, 12 Jul 2010 06:07:08 -0400 Received: from [140.186.70.92] (port=46025 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OYFuh-0000e1-AV for bug-gnu-emacs@gnu.org; Mon, 12 Jul 2010 06:07:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OYFuf-0001h0-Tz for bug-gnu-emacs@gnu.org; Mon, 12 Jul 2010 06:07:03 -0400 Received: from mail.gmx.net ([213.165.64.20]:60083) by eggs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1OYFuf-0001gS-HA for bug-gnu-emacs@gnu.org; Mon, 12 Jul 2010 06:07:01 -0400 Received: (qmail invoked by alias); 12 Jul 2010 10:06:58 -0000 Received: from unknown (EHLO thanos-desktop.ics.forth.gr) [139.91.92.11] by mail.gmx.net (mp041) with SMTP; 12 Jul 2010 12:06:58 +0200 X-Authenticated: #4463548 X-Provags-ID: V01U2FsdGVkX18xbTAziYsxtTPzL7fkkEo+r9QAgTaUlGkyVNR6vN lYlYCZYDo2nAQE Date: Mon, 12 Jul 2010 13:08:42 +0300 (EEST) From: Dimitrios Apostolou X-X-Sender: jimis@localhost.localdomain To: bug-gnu-emacs@gnu.org Subject: linux kernel C style (fwd) Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 12 Jul 2010 06:35:06 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) Hi, I sent the following to help-gnu-emacs and got no reply, maybe this list is more relevant. ---------- Forwarded message ---------- Date: Thu, 8 Jul 2010 21:56:09 +0300 (EEST) From: Dimitrios Apostolou To: help-gnu-emacs@gnu.org Subject: linux kernel C style Hello list, is the "linux" c-style supposed to be compliant to the linux kernel style guidelines? I just realised that all this time emacs was indenting my code slightly wrong, specifically the use of spaces is forbidden, even when continuing the argument list of a function. I use the following lines in my .emacs, taken from Documentation/CodingStyle of the kernel tree. Perhaps they should be added to "linux" style? (defun c-lineup-arglist-tabs-only (ignored) "Line up argument lists by tabs, not spaces" (let* ((anchor (c-langelem-pos c-syntactic-element)) (column (c-langelem-2nd-pos c-syntactic-element)) (offset (- (1+ column) anchor)) (steps (floor offset c-basic-offset))) (* (max steps 1) c-basic-offset))) ;; Add kernel style (c-add-style "linux-tabs-only" '("linux" (c-offsets-alist (arglist-cont-nonempty c-lineup-gcc-asm-reg c-lineup-arglist-tabs-only)))) (custom-set-variables '(c-default-style "linux-tabs-only") ) Thanks, Dimitris From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 13 04:51:15 2010 Received: (at 6617) by debbugs.gnu.org; 13 Jul 2010 08:51:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYbCs-0008Dx-Sk for submit@debbugs.gnu.org; Tue, 13 Jul 2010 04:51:15 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYbCq-0008Ds-Nw for 6617@debbugs.gnu.org; Tue, 13 Jul 2010 04:51:13 -0400 Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OYbCv-0004nK-Hh; Tue, 13 Jul 2010 04:51:17 -0400 To: Dimitrios Apostolou Subject: Re: bug#6617: linux kernel C style (fwd) References: From: Dan Nicolaescu X-Debbugs-No-Ack: yes Date: Tue, 13 Jul 2010 04:51:17 -0400 In-Reply-To: (Dimitrios Apostolou's message of "Mon\, 12 Jul 2010 13\:08\:42 +0300 \(EEST\)") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 6617 Cc: 6617@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) Dimitrios Apostolou writes: > Hi, I sent the following to help-gnu-emacs and got no reply, maybe > this list is more relevant. > > ---------- Forwarded message ---------- > Date: Thu, 8 Jul 2010 21:56:09 +0300 (EEST) > From: Dimitrios Apostolou > To: help-gnu-emacs@gnu.org > Subject: linux kernel C style > > Hello list, > > is the "linux" c-style supposed to be compliant to the linux kernel > style guidelines? I just realised that all this time emacs was > indenting my code slightly wrong, specifically the use of spaces is > forbidden, even when continuing the argument list of a function. Is that really the case? Is this requirement documented anywhere? Looking at a random file in the linux-2.6.34.1 kernel: kernel/sched.c one can see: static void update_group_shares_cpu(struct task_group *tg, int cpu, unsigned long sd_shares, unsigned long sd_rq_weight, unsigned long *usd_rq_weight) { [snip] The arguments starting from sd_shares are indented using a few tabs followed by a few spaces. The above is not the only occurrence, there are many others in the same file. Another point: to enforce the use of the correct style, a file called .dir-locals.el should be placed at the top level of the kernel tree with the following [completely untested] contents: ((c-mode . ((c-file-style . "linux") (tab-width . 8) (indent-tabs-mode . t)))) With this users of emacs-23+ will get the correct settings for editing the kernel by default. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 13 06:17:19 2010 Received: (at 6617) by debbugs.gnu.org; 13 Jul 2010 10:17:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYcYA-0000OC-Fb for submit@debbugs.gnu.org; Tue, 13 Jul 2010 06:17:19 -0400 Received: from mailout-de.gmx.net ([213.165.64.23] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1OYbaU-0008Os-K0 for 6617@debbugs.gnu.org; Tue, 13 Jul 2010 05:15:39 -0400 Received: (qmail invoked by alias); 13 Jul 2010 09:15:42 -0000 Received: from unknown (EHLO thanos-desktop.ics.forth.gr) [139.91.92.11] by mail.gmx.net (mp007) with SMTP; 13 Jul 2010 11:15:42 +0200 X-Authenticated: #4463548 X-Provags-ID: V01U2FsdGVkX1+qlhMNNbyqkvDCSYnJ5UxGG/PblKOgo4Dlvt5qBS QnQJzar6IDuSUf Date: Tue, 13 Jul 2010 12:17:38 +0300 (EEST) From: Dimitrios Apostolou X-X-Sender: jimis@localhost.localdomain To: Dan Nicolaescu Subject: Re: bug#6617: linux kernel C style (fwd) In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Y-GMX-Trusted: 0 X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 6617 X-Mailman-Approved-At: Tue, 13 Jul 2010 06:17:17 -0400 Cc: 6617@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) On Tue, 13 Jul 2010, Dan Nicolaescu wrote: > Dimitrios Apostolou writes: > >> Hi, I sent the following to help-gnu-emacs and got no reply, maybe >> this list is more relevant. >> >> ---------- Forwarded message ---------- >> Date: Thu, 8 Jul 2010 21:56:09 +0300 (EEST) >> From: Dimitrios Apostolou >> To: help-gnu-emacs@gnu.org >> Subject: linux kernel C style >> >> Hello list, >> >> is the "linux" c-style supposed to be compliant to the linux kernel >> style guidelines? I just realised that all this time emacs was >> indenting my code slightly wrong, specifically the use of spaces is >> forbidden, even when continuing the argument list of a function. > > Is that really the case? Is this requirement documented anywhere? In the file Documentation/CodingStyle search for "emacs". Warning: the language is a bit toxic for emacs devs/users. There is also another point which is not clear but says the following: Statements longer than 80 columns will be broken into sensible chunks. Descendants are always substantially shorter than the parent and are placed substantially to the right. The same applies to function headers with a long argument list. Long strings are as well broken into shorter strings. The only exception to this is where exceeding 80 columns significantly increases readability and does not hide information. It is then followed by an example which is is indented only with tabs. > Looking at a random file in the linux-2.6.34.1 kernel: kernel/sched.c > one can see: > > static void update_group_shares_cpu(struct task_group *tg, int cpu, > unsigned long sd_shares, > unsigned long sd_rq_weight, > unsigned long *usd_rq_weight) > { > [snip] > > The arguments starting from sd_shares are indented using a few tabs > followed by a few spaces. > The above is not the only occurrence, there are many others in the same file. My guess is that those are inconsistencies caused by the current "linux" style in emacs, but perhaps this should be posted to LKML to verify. > > > Another point: to enforce the use of the correct style, a file called > .dir-locals.el should be placed at the top level of the kernel tree > with the following [completely untested] contents: > > ((c-mode . ((c-file-style . "linux") > (tab-width . 8) > (indent-tabs-mode . t)))) > > With this users of emacs-23+ will get the correct settings for editing > the kernel by default. > > Thanks, Dimitris From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 13 08:51:26 2010 Received: (at 6617) by debbugs.gnu.org; 13 Jul 2010 12:51:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYexK-00028l-A3 for submit@debbugs.gnu.org; Tue, 13 Jul 2010 08:51:26 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYexI-00028e-UG for 6617@debbugs.gnu.org; Tue, 13 Jul 2010 08:51:25 -0400 Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OYexO-0007dl-99; Tue, 13 Jul 2010 08:51:30 -0400 To: Dimitrios Apostolou Subject: Re: bug#6617: linux kernel C style (fwd) References: From: Dan Nicolaescu X-Debbugs-No-Ack: yes Date: Tue, 13 Jul 2010 08:51:30 -0400 In-Reply-To: (Dimitrios Apostolou's message of "Tue\, 13 Jul 2010 12\:17\:38 +0300 \(EEST\)") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 6617 Cc: 6617@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) Dimitrios Apostolou writes: > On Tue, 13 Jul 2010, Dan Nicolaescu wrote: >> Dimitrios Apostolou writes: >> >>> Hi, I sent the following to help-gnu-emacs and got no reply, maybe >>> this list is more relevant. >>> >>> ---------- Forwarded message ---------- >>> Date: Thu, 8 Jul 2010 21:56:09 +0300 (EEST) >>> From: Dimitrios Apostolou >>> To: help-gnu-emacs@gnu.org >>> Subject: linux kernel C style >>> >>> Hello list, >>> >>> is the "linux" c-style supposed to be compliant to the linux kernel >>> style guidelines? I just realised that all this time emacs was >>> indenting my code slightly wrong, specifically the use of spaces is >>> forbidden, even when continuing the argument list of a function. >> >> Is that really the case? Is this requirement documented anywhere? > > In the file Documentation/CodingStyle search for "emacs". Warning: the > language is a bit toxic for emacs devs/users. There's code there that seems to do what you stated, but there seems to be no text that actually describes that... > There is also another point which is not clear but says the following: > > Statements longer than 80 columns will be broken into sensible > chunks. Descendants are always substantially shorter than the parent > and are placed substantially to the right. The same applies to > function headers with a long argument list. Long strings are as well > broken into shorter strings. The only exception to this is where > exceeding 80 columns significantly increases readability and does not > hide information. > > > It is then followed by an example which is is indented only with tabs. > > >> Looking at a random file in the linux-2.6.34.1 kernel: >> kernel/sched.c one can see: >> >> static void update_group_shares_cpu(struct task_group *tg, int cpu, >> unsigned long sd_shares, >> unsigned long sd_rq_weight, >> unsigned long *usd_rq_weight) >> { >> [snip] >> >> The arguments starting from sd_shares are indented using a few tabs >> followed by a few spaces. >> The above is not the only occurrence, there are many others in the same file. > > My guess is that those are inconsistencies caused by the current > "linux" style in emacs, but perhaps this should be posted to LKML to > verify. Please do that and report the conclusion here. >> Another point: to enforce the use of the correct style, a file called >> .dir-locals.el should be placed at the top level of the kernel tree >> with the following [completely untested] contents: >> >> ((c-mode . ((c-file-style . "linux") >> (tab-width . 8) >> (indent-tabs-mode . t)))) >> >> With this users of emacs-23+ will get the correct settings for editing >> the kernel by default. >> >> > > > > Thanks, > Dimitris From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 08 04:40:43 2021 Received: (at 6617) by debbugs.gnu.org; 8 Sep 2021 08:40:44 +0000 Received: from localhost ([127.0.0.1]:58562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNt8N-0007Mg-Md for submit@debbugs.gnu.org; Wed, 08 Sep 2021 04:40:43 -0400 Received: from quimby.gnus.org ([95.216.78.240]:57250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNt8L-0007MM-BP for 6617@debbugs.gnu.org; Wed, 08 Sep 2021 04:40:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UgbROa49DeBSitBzdz/cwwBkXsxmiADYBYN4s0ZYHEA=; b=iKHjIYck/ip1/IIdv8LT93WSCZ sPg62f5pkUjet8YEjWXNSPIqVS/+Q2+31b1pQAZlNXywTSagx7Sf2OEKKfJgzV6QzHd6TN7ar+HA4 O94/kPtJ1gF7WvUX906sj3yGq3lH7dPBKCIM3Xzd8yqkz3pnUf8r+lSiJ2e1lHji4YDs=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNt8C-0000sJ-2l; Wed, 08 Sep 2021 10:40:34 +0200 From: Lars Ingebrigtsen To: Dan Nicolaescu Subject: Re: bug#6617: linux kernel C style (fwd) References: Date: Wed, 08 Sep 2021 10:40:31 +0200 In-Reply-To: (Dan Nicolaescu's message of "Tue, 13 Jul 2010 04:51:17 -0400") Message-ID: <87ee9z4g00.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dan Nicolaescu writes: > Statements longer than 80 columns will be broken into sensible > chunks. Descendants are always substantially shorter than the parent > and are placed substantially to the right. The same applies to [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 6617 Cc: Alan Mackenzie , Dimitrios Apostolou , 6617@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Dan Nicolaescu writes: > Statements longer than 80 columns will be broken into sensible > chunks. Descendants are always substantially shorter than the parent > and are placed substantially to the right. The same applies to > function headers with a long argument list. Long strings are as well > broken into shorter strings. The only exception to this is where > exceeding 80 columns significantly increases readability and does not > hide information. > > It is then followed by an example which is is indented only with tabs. > >> Looking at a random file in the linux-2.6.34.1 kernel: >> kernel/sched.c one can see: >> >> static void update_group_shares_cpu(struct task_group *tg, int cpu, >> unsigned long sd_shares, >> unsigned long sd_rq_weight, >> unsigned long *usd_rq_weight) >> { (I'm going through old bug reports that unfortunately weren't resolved at the time.) It still seems to be the case that the "linux" style indents using both tabs and spaces in Emacs 28. I don't know what the Linux kernel style is these days, but the suggestion in this bug report is to add a tab-only variant. Alan, do you have any comments about this? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 08 14:29:21 2021 Received: (at 6617) by debbugs.gnu.org; 8 Sep 2021 18:29:21 +0000 Received: from localhost ([127.0.0.1]:33551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mO2K0-0005oy-QT for submit@debbugs.gnu.org; Wed, 08 Sep 2021 14:29:21 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:57003) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mO2Jy-0005ol-OJ for 6617@debbugs.gnu.org; Wed, 08 Sep 2021 14:29:20 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id CB37732009F2; Wed, 8 Sep 2021 14:29:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 08 Sep 2021 14:29:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=IAwlpMchgqLYKj2Cza7P2v3LGW aItt7s3BwDyb3UZwI=; b=YeJHbB+wTtUFLzy71dcEVdIyyexJ1LsQI+07l9fMMc KxTUaDGDP7738gTQXpKrIwRQo1g4G+EJBajdIvNvG37XMrxmPGUeQvowv3pjEC72 TJRUq3+x3kJp22lE9TVyHvuC2rrL9HQ2yFBTjrL5v3+tTYMV8ThyRdi+NBDclTpL +K2DKM9tqLTGvk6YKJIVeRcsm48D9JoCv5cYagy0Z3gGAtOrX411AMnm2BVj80Fw cQlBfnO4UK6fK75c98WQ9lkkgtLK8PYZ99WZL+GBLiA+vpi7cXy9c/LwZm4vJZM8 qeOiw0fKdXRHjkT7AWrSecUoSB3JJ9IHZCCUXVVKrqoA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=IAwlpM chgqLYKj2Cza7P2v3LGWaItt7s3BwDyb3UZwI=; b=I6jyp+aeq+3/NzU48Sp9gW DW1Jm8JLSi9/BzWs2VejvhbEk7p4GlDBWJKKNJ2wHjLsNhMU3S6EN+jWLOnLdYZg EDe+i+lXIlheAyB8r/1iMuuZFkHn51IaGxfwUXxKWrHaceTLnWTchoAHbmmXtZh5 7UkFYToFFuHuq2fG/0WlqzK57umVQkMNMvPipBO6788FcEljy6MgfjVNfbpZBYEA 6pQ77T6ANQbGGChAgS4CpmS9QZRXOQt1lYc7bKvQrtkxgpYLYNKKqMuOVX6f0ujl qgq2UDi01cG3RdMk5svhMNkFeeR1pKqfbzWc2NtlXxmc6L+86j+YxAQb1TgjX9qQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudefjedguddvhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffgffkfggtgesthdtredttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpeeivdefueefkeefhfeggeelleefhfdvhfduleehheegtdel iedtffehieejkeegueenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Sep 2021 14:29:11 -0400 (EDT) Received: by hephaestus.arizona.edu (Postfix, from userid 1000) id 358467E1ECA; Wed, 8 Sep 2021 11:29:10 -0700 (MST) From: Sean Whitton To: Lars Ingebrigtsen , Dan Nicolaescu Subject: Re: bug#6617: linux kernel C style (fwd) In-Reply-To: <87ee9z4g00.fsf@gnus.org> References: <87ee9z4g00.fsf@gnus.org> User-Agent: Notmuch/0.31.4 (https://notmuchmail.org) Emacs/28.0.50 (x86_64-pc-linux-gnu) Date: Wed, 08 Sep 2021 11:29:10 -0700 Message-ID: <871r5yyl8p.fsf@melete.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 6617 Cc: Alan Mackenzie , Dimitrios Apostolou , 6617@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Wed 08 Sep 2021 at 10:40AM +02, Lars Ingebrigtsen wrote: > Dan Nicolaescu writes: > >> Statements longer than 80 columns will be broken into sensible >> chunks. Descendants are always substantially shorter than the parent >> and are placed substantially to the right. The same applies to >> function headers with a long argument list. Long strings are as well >> broken into shorter strings. The only exception to this is where >> exceeding 80 columns significantly increases readability and does not >> hide information. >> >> It is then followed by an example which is is indented only with tabs. >> >>> Looking at a random file in the linux-2.6.34.1 kernel: >>> kernel/sched.c one can see: >>> >>> static void update_group_shares_cpu(struct task_group *tg, int cpu, >>> unsigned long sd_shares, >>> unsigned long sd_rq_weight, >>> unsigned long *usd_rq_weight) >>> { > > (I'm going through old bug reports that unfortunately weren't resolved > at the time.) > > It still seems to be the case that the "linux" style indents using both > tabs and spaces in Emacs 28. I don't know what the Linux kernel style > is these days, but the suggestion in this bug report is to add a > tab-only variant. Alan, do you have any comments about this? The Linux kernel style is tabs only. I think that Emacs DTRT if indent-tabs-mode is t. So, currently I have this fix in my init file: (c-add-style "linux-tabs" '("linux" (indent-tabs-mode . t))) (setq c-default-style "linux-tabs") -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 09 10:00:21 2021 Received: (at 6617) by debbugs.gnu.org; 9 Sep 2021 14:00:21 +0000 Received: from localhost ([127.0.0.1]:35861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOKbF-0005GS-9b for submit@debbugs.gnu.org; Thu, 09 Sep 2021 10:00:21 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOKbC-0005G9-EO for 6617@debbugs.gnu.org; Thu, 09 Sep 2021 10:00:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sh+3xYPZuewMG3mJpB5iWwjr2ew16D+pwvW6JK6RlX8=; b=VixbiqSurT0Hs8QYc5dlqmKZze CrS0KqsKxMuHdFbUlzuB+6DTwKl1bEWvOBW47rsxRQZ2yfevN8OlcxiWy7Da983TlqNpBKrzcCooX NZeKeTqXnhveyvzlrorgNlBAsg7MCwrMXxQdtEwMNC2XpVGXREahALlBDHEGHZlQ5pXM=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mOKb3-0007d7-FQ; Thu, 09 Sep 2021 16:00:12 +0200 From: Lars Ingebrigtsen To: Sean Whitton Subject: Re: bug#6617: linux kernel C style (fwd) References: <87ee9z4g00.fsf@gnus.org> <871r5yyl8p.fsf@melete.silentflame.com> Date: Thu, 09 Sep 2021 16:00:09 +0200 In-Reply-To: <871r5yyl8p.fsf@melete.silentflame.com> (Sean Whitton's message of "Wed, 08 Sep 2021 11:29:10 -0700") Message-ID: <874katvogm.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Sean Whitton writes: > The Linux kernel style is tabs only. I think that Emacs DTRT if > indent-tabs-mode is t. So, currently I have this fix in my init file: > > (c-add-style "linux-tabs" '("linux" (indent-tabs-mode . t) [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 6617 Cc: Dan Nicolaescu , Dimitrios Apostolou , 6617@debbugs.gnu.org, Alan Mackenzie X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Sean Whitton writes: > The Linux kernel style is tabs only. I think that Emacs DTRT if > indent-tabs-mode is t. So, currently I have this fix in my init file: > > (c-add-style "linux-tabs" '("linux" (indent-tabs-mode . t))) > (setq c-default-style "linux-tabs") Right. Alan, would it make sense to add this style to c-mode? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 18 14:30:13 2022 Received: (at 6617) by debbugs.gnu.org; 18 Apr 2022 18:30:13 +0000 Received: from localhost ([127.0.0.1]:40753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngW8a-0006pS-OE for submit@debbugs.gnu.org; Mon, 18 Apr 2022 14:30:12 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:52915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngW8Z-0006o2-0h for 6617@debbugs.gnu.org; Mon, 18 Apr 2022 14:30:11 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id E75B65C0196; Mon, 18 Apr 2022 14:30:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 18 Apr 2022 14:30:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1650306605; x=1650393005; bh=GI 8owC0jtVSZCDHzC2A+FqTL0Up+BX9qT3w5WxCSg3w=; b=mbKNSA/k1TKIaiw1mF mR3jLK68UL1gY5s08w+zsei7VIxbEwkEw26HsGL3T1lKjYgE7A4XSliCcAKElDGa pH2InjBNbDMJb4nVPycmpFByC+8kOXCoN71MQuaK1SIJ3Ut1+3gp87KekRuX0T9g DmQS0e2nmvVFoQLFgpYZqaGHYWhS1XOMD4SazoCZ5X5eWCRRl7TO/4g+65OBMksG Dyr0Wtb0PqqxfLn9H4i2u4TGlj1kaXelkAizDbm73VBqPwSbz7i41E+XJ6Icyip5 tM1e3fyjzauHKw71c8KhluH/vArPr+tlLA+I8dzZrZi14TMYLcmobeUpZflEncOw aJ7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1650306605; x= 1650393005; bh=GI8owC0jtVSZCDHzC2A+FqTL0Up+BX9qT3w5WxCSg3w=; b=D dfCTp3qSfpeuVX20eWtbOMmkFM8mAxW5p9+379Z8BBjq8DKvOHndDhEECXFpQlqZ 8nBrc6cxNH4O9cdxN/PogJV3kisANhuEzPW1EIXC2QlhUspsQAG8Dehkbo1U+Ly+ PMoVUg9liQs8nS5L871JogrihhcV9z7LE6ul+pivvgh4t/cBsu6B1L6MLOgBX9Q0 ui+yMcmGOFX8bs6DunMZ28o2F+v17Zw2d+/0Vof1mhBQVXNM2uVIcXH6/A4CBYDP tiYUByYYfFaXTYhAMSIn8MnBoj0z3GPZRdWRAs5nncKR6OBMCyJvnlEMMFhehyJz y5Rk7RBVWxbsg69dUuI/w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrvddtuddguddviecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffgffkfggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpeelgeeggfdvieejvdfhudfggeetgfekkeeuieeljeejhedu geegfeetgefhueffkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Apr 2022 14:30:05 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id CC1E17E4A56; Mon, 18 Apr 2022 11:30:04 -0700 (MST) From: Sean Whitton To: Lars Ingebrigtsen Subject: Re: bug#6617: linux kernel C style (fwd) In-Reply-To: <874katvogm.fsf@gnus.org> References: <87ee9z4g00.fsf@gnus.org> <871r5yyl8p.fsf@melete.silentflame.com> <874katvogm.fsf@gnus.org> User-Agent: Emacs/29.0.50 (x86_64-pc-linux-gnu) Date: Mon, 18 Apr 2022 11:30:04 -0700 Message-ID: <87r15uxn0z.fsf@melete.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 6617 Cc: Dan Nicolaescu , Dimitrios Apostolou , 6617@debbugs.gnu.org, Alan Mackenzie X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Thu 09 Sep 2021 at 04:00PM +02, Lars Ingebrigtsen wrote: > Sean Whitton writes: > >> The Linux kernel style is tabs only. I think that Emacs DTRT if >> indent-tabs-mode is t. So, currently I have this fix in my init file: >> >> (c-add-style "linux-tabs" '("linux" (indent-tabs-mode . t))) >> (setq c-default-style "linux-tabs") > > Right. Alan, would it make sense to add this style to c-mode? Were you thinking it would be too much of a compat break to just edit the linux style to include setting indent-tabs-mode? I think that would be a lot more useful. Anyone who actually wants the Linux kernel's style would want (what I've called) linux-tabs. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 24 10:50:51 2022 Received: (at 6617) by debbugs.gnu.org; 24 Apr 2022 14:50:51 +0000 Received: from localhost ([127.0.0.1]:59911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nidZb-00046K-B3 for submit@debbugs.gnu.org; Sun, 24 Apr 2022 10:50:51 -0400 Received: from colin.muc.de ([193.149.48.1]:12648 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1nidZZ-000465-Ac for 6617@debbugs.gnu.org; Sun, 24 Apr 2022 10:50:49 -0400 Received: (qmail 42044 invoked by uid 3782); 24 Apr 2022 14:50:43 -0000 Received: from acm.muc.de (p2e5d583a.dip0.t-ipconnect.de [46.93.88.58]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 24 Apr 2022 16:50:42 +0200 Received: (qmail 5703 invoked by uid 1000); 24 Apr 2022 14:50:42 -0000 Date: Sun, 24 Apr 2022 14:50:42 +0000 To: Sean Whitton Subject: Re: bug#6617: linux kernel C style (fwd) Message-ID: References: <87ee9z4g00.fsf@gnus.org> <871r5yyl8p.fsf@melete.silentflame.com> <874katvogm.fsf@gnus.org> <87r15uxn0z.fsf@melete.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r15uxn0z.fsf@melete.silentflame.com> X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 6617 Cc: Dan Nicolaescu , Lars Ingebrigtsen , Dimitrios Apostolou , 6617@debbugs.gnu.org, acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Sean. On Mon, Apr 18, 2022 at 11:30:04 -0700, Sean Whitton wrote: > Hello, > On Thu 09 Sep 2021 at 04:00PM +02, Lars Ingebrigtsen wrote: > > Sean Whitton writes: > >> The Linux kernel style is tabs only. I think that Emacs DTRT if > >> indent-tabs-mode is t. So, currently I have this fix in my init file: > >> (c-add-style "linux-tabs" '("linux" (indent-tabs-mode . t))) > >> (setq c-default-style "linux-tabs") > > Right. Alan, would it make sense to add this style to c-mode? > Were you thinking it would be too much of a compat break to just edit > the linux style to include setting indent-tabs-mode? I think that would > be a lot more useful. Anyone who actually wants the Linux kernel's > style would want (what I've called) linux-tabs. After a bit of thought, I agree with you. I think here it is better just to add the setting of indent-tabs-mode to the "linux" style. Most users of "linux" will have that variable set to t one way or another, and so won't notice. There will be a few users using the style for non-Linux projects, who will be used to indent-tabs-mode being nil. That is just unfortunate. I think the balance of benefits and problems comes down on the side of this abrupt change. I intend to apply the following patch to cc-styles.el soon. If you want to test it you're very welcome, but please note that since it changes a variable, the amended CC Mode should be the first CC Mode you load in the Emacs session. (Otherwise, you'll need to do fancy things with `makunbound' before loading the new CC Mode.) diff -r 8fd64e3084ac cc-styles.el --- a/cc-styles.el Sat Apr 23 19:17:52 2022 +0000 +++ b/cc-styles.el Sun Apr 24 14:36:46 2022 +0000 @@ -187,6 +187,7 @@ (inclass . +) (inline-open . 0)))) ("linux" + (indent-tabs-mode . t) (c-basic-offset . 8) (c-comment-only-line-offset . 0) (c-hanging-braces-alist . ((brace-list-open) > -- > Sean Whitton -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 24 17:16:33 2022 Received: (at 6617) by debbugs.gnu.org; 24 Apr 2022 21:16:33 +0000 Received: from localhost ([127.0.0.1]:60246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nijaq-0003ol-W9 for submit@debbugs.gnu.org; Sun, 24 Apr 2022 17:16:33 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:54297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nijap-0003oY-Ct for 6617@debbugs.gnu.org; Sun, 24 Apr 2022 17:16:31 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 117263200AC9; Sun, 24 Apr 2022 17:16:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 24 Apr 2022 17:16:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1650834984; x=1650921384; bh=al 32g7yvEbRs6IiHFExT9nlt5QrZl3opXL5yozrxRDk=; b=PT2FFMyUi9+nqHjjh0 KZItJS9gm5zww7kOWqbE5zLystOmz8xYcSRJuRvq7NQFOMmy5mlYkUb7x+yRwI8z 97Who7JTcICcLZAP2bawMdn2Rjn61qIOm56gKGNbp6/jo8kY+1uqXShVK0E/c4St yk4xg698MCNzQsmmFWUD0y2tss1Bdcs3pNwyTqKy4Q6iJc28E+fe6ajd7rpeqzij UHEbeiaTPlyqAYjiEYTaf807Rkt8cffGEPSUj/Ob/iT8zAdkdfdT307NFe7vOAju fLD9+25IxjkciAYXZSY1/tV1NjvXaiMNWMFXAmdw8U68BSLMMZlz2IJAcSa6kIn8 w4aw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1650834984; x= 1650921384; bh=al32g7yvEbRs6IiHFExT9nlt5QrZl3opXL5yozrxRDk=; b=N sdt0AngX9KrxekQj0jZEYPF0lAdmkxxSg1c4+XC+WLHr3LOAIdfaT6peNdSNsr1k oHaJW28J9eELlkW2myR9CCUJdPQuL1dXVHwScTcYlcsjjp/eC9WrJ5HatCeLW5Ha QeHE7kjagurilcJlih4URozfmTmc4r/Y+CgldSgJha3mRsh6DRjnlo8yJNKmyXqv Xb03lfvG5RrXdqIf4oUOmtFYQGFnGSEYY4J8pbfdPk2z3N7lXE7Q8RvePqYYujVx yC+g17MybGAoSpQiypvpLhY6EK+d1tzLkQj5ToGnq8o6kNJSfPLo2KQ6Gp/5e9VS obRQVLSXBeM/wASb3SfvQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrtdelgdduiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffgffkfggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedvjeettdeiteejgeejkefggfehtdekledtfedtteekgfeu keeftdduhfetleejkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 24 Apr 2022 17:16:24 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 41B347E59CC; Sun, 24 Apr 2022 14:16:23 -0700 (MST) From: Sean Whitton To: Alan Mackenzie Subject: Re: bug#6617: linux kernel C style (fwd) In-Reply-To: References: <87ee9z4g00.fsf@gnus.org> <871r5yyl8p.fsf@melete.silentflame.com> <874katvogm.fsf@gnus.org> <87r15uxn0z.fsf@melete.silentflame.com> User-Agent: Notmuch/0.35 Emacs/29.0.50 (x86_64-pc-linux-gnu) Date: Sun, 24 Apr 2022 14:16:23 -0700 Message-ID: <8735i241y0.fsf@melete.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 6617 Cc: Dan Nicolaescu , Lars Ingebrigtsen , Dimitrios Apostolou , 6617@debbugs.gnu.org, acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Alan, On Sun 24 Apr 2022 at 02:50PM GMT, Alan Mackenzie wrote: > After a bit of thought, I agree with you. I think here it is better > just to add the setting of indent-tabs-mode to the "linux" style. Most > users of "linux" will have that variable set to t one way or another, > and so won't notice. > > There will be a few users using the style for non-Linux projects, who > will be used to indent-tabs-mode being nil. That is just unfortunate. > I think the balance of benefits and problems comes down on the side of > this abrupt change. Right. > I intend to apply the following patch to cc-styles.el soon. If you > want to test it you're very welcome, but please note that since it > changes a variable, the amended CC Mode should be the first CC Mode > you load in the Emacs session. (Otherwise, you'll need to do fancy > things with `makunbound' before loading the new CC Mode.) I'm not in the middle of any C projects using the Linux style atm, so I don't think I'll be able to test, but your patch looks basically equivalent to the "linux-tabs" thing I was doing, so probably doesn't need a lot of testing. Thanks for thinking this one over! -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 27 15:18:02 2022 Received: (at 6617-done) by debbugs.gnu.org; 27 Apr 2022 19:18:03 +0000 Received: from localhost ([127.0.0.1]:44437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njnAo-0008IN-O5 for submit@debbugs.gnu.org; Wed, 27 Apr 2022 15:18:02 -0400 Received: from colin.muc.de ([193.149.48.1]:25453 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1njnAm-0008Hk-02 for 6617-done@debbugs.gnu.org; Wed, 27 Apr 2022 15:18:01 -0400 Received: (qmail 14016 invoked by uid 3782); 27 Apr 2022 19:17:53 -0000 Received: from acm.muc.de (p4fe15b5b.dip0.t-ipconnect.de [79.225.91.91]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 27 Apr 2022 21:17:53 +0200 Received: (qmail 14655 invoked by uid 1000); 27 Apr 2022 19:17:52 -0000 Date: Wed, 27 Apr 2022 19:17:52 +0000 To: Sean Whitton Subject: Re: bug#6617: linux kernel C style (fwd) Message-ID: References: <87ee9z4g00.fsf@gnus.org> <871r5yyl8p.fsf@melete.silentflame.com> <874katvogm.fsf@gnus.org> <87r15uxn0z.fsf@melete.silentflame.com> <8735i241y0.fsf@melete.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8735i241y0.fsf@melete.silentflame.com> X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 6617-done Cc: Dan Nicolaescu , Lars Ingebrigtsen , acm@muc.de, Dimitrios Apostolou , 6617-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, everybody. On Sun, Apr 24, 2022 at 14:16:23 -0700, Sean Whitton wrote: > Hello Alan, > On Sun 24 Apr 2022 at 02:50PM GMT, Alan Mackenzie wrote: > > After a bit of thought, I agree with you. I think here it is better > > just to add the setting of indent-tabs-mode to the "linux" style. Most > > users of "linux" will have that variable set to t one way or another, > > and so won't notice. > > There will be a few users using the style for non-Linux projects, who > > will be used to indent-tabs-mode being nil. That is just unfortunate. > > I think the balance of benefits and problems comes down on the side of > > this abrupt change. > Right. > > I intend to apply the following patch to cc-styles.el soon. If you > > want to test it you're very welcome, but please note that since it > > changes a variable, the amended CC Mode should be the first CC Mode > > you load in the Emacs session. (Otherwise, you'll need to do fancy > > things with `makunbound' before loading the new CC Mode.) > I'm not in the middle of any C projects using the Linux style atm, so I > don't think I'll be able to test, but your patch looks basically > equivalent to the "linux-tabs" thing I was doing, so probably doesn't > need a lot of testing. Thanks for thinking this one over! I've now committed the change to cc-styles.el, and am closing the bug with this post. > -- > Sean Whitton -- Alan Mackenzie (Nuremberg, Germany). From unknown Fri Sep 05 19:41:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 26 May 2022 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator