From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 23 03:56:13 2023 Received: (at submit) by debbugs.gnu.org; 23 Sep 2023 07:56:13 +0000 Received: from localhost ([127.0.0.1]:37697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjxUq-00059S-Kn for submit@debbugs.gnu.org; Sat, 23 Sep 2023 03:56:13 -0400 Received: from lists.gnu.org ([2001:470:142::17]:39962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjxUo-000596-5c for submit@debbugs.gnu.org; Sat, 23 Sep 2023 03:56:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjxUX-0001Iv-Fk for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2023 03:55:53 -0400 Received: from mail-dm6nam10olkn20823.outbound.protection.outlook.com ([2a01:111:f400:7e88::823] helo=NAM10-DM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjxUV-0006sG-9e for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2023 03:55:53 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bKzvCzCf1GUOzFTQejshy5fXz5cHeLHr4Xbu6ojj3t1tBjbdqU4coqiTp+VznAFW6T85MXgv+7PBOTxGhLZR8m+3FfNZ5eepiI30EsfzK2b6k5gHyxa5iFJV7Gze6iIXtG65JhzTjjn94ZHgkSWW4lo7d6nL4+FO8AczIlDT/m/qymHWaflk+DTBX0pATH5oSdxiy4rdb6v7/9vSScHtdKwtr3RIw9CXZV4hoU9AvBmXQBmJtAjCHimyBfGID+GgNsbdweBVq6/JWjC4zAAnzT6cvcGa7c/v24PaekU2SxILjvUcsmQ9xRa/k016h2sW+O6WTGWKkOMy5ICYhUdGYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ktKfvliP3oNXYZPdMh8ACyXI4l1ykAhowYFhVXwrZ4Q=; b=gFQh/Sh7jqoksN2xxIjB83NtdRWajNwzQnPmEe5mBpK9cOLRgYrxq92M+xEO5Q3YpoUJ568+XDz61K2hpH8JuDMnCJbQjqzsjlk6hL9D58YZxAdOilfVWC7IBogqIEl2FjAOvYrgO6cjhiBpAhYEnbVdqYx/chssIUmq4hmLGDSu8NI86QB+x/fc+c0hj+SJx5bgbPjUlgQQxWdhV38lV9sIwzugdLDR/m5y9tDLQAIck1wLNVF/C6El8Wa0FktENiMsZmYrMDyAcIgN4rvMqS1dmyGBvG3HwMzrdz+UHrFAOEbp2R5saa8SNBbzntfnsYTL92bvpaiYJkceFMwblg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ktKfvliP3oNXYZPdMh8ACyXI4l1ykAhowYFhVXwrZ4Q=; b=FuEZBWofx9kivCz2MlAmoZvs6SzqFli712wNj0+Yk9duGp4tdgz/ijxFt3ot6JNb9DbBodff/OCZAKOWE4wOFOuhGvBP6ODLEMRWqusxHUvYMx3kzApWIpLcKbKnT2teLPTTsi0PhFcQlWQFQDu3g+hm4epAtWgx++bQRPgYyhluiP8uRHNmUZMptdrtsgO6SBzxSKXp7Pc19iB5qf3/ggA5mdtxz4ojL2aHrTHIpJodo0e3EYHROVR97BDaVo9wvlIqQMtsrgum90awPw42IqLiv7b/q/MMcRAt5dTFNYYwTBS72BP9xiB4kZD+YLfDy06n7jECNu6ooXPPVSNfHA== Received: from CY8PR19MB7083.namprd19.prod.outlook.com (2603:10b6:930:55::19) by IA1PR19MB6203.namprd19.prod.outlook.com (2603:10b6:208:3ed::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.23; Sat, 23 Sep 2023 07:50:45 +0000 Received: from CY8PR19MB7083.namprd19.prod.outlook.com ([fe80::80d8:668e:ba9f:5716]) by CY8PR19MB7083.namprd19.prod.outlook.com ([fe80::80d8:668e:ba9f:5716%4]) with mapi id 15.20.6792.026; Sat, 23 Sep 2023 07:50:45 +0000 From: Gabriel To: bug-gnu-emacs@gnu.org Subject: 30.0.50; [PATCH] Consider outline-heading-end-regexp in outline-font-lock-keywords Date: Sat, 23 Sep 2023 04:50:38 -0300 Message-ID: Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [H7rK0DPQEcq9VzguUA4v+hGBWnj04QrQA5hSCR73QdZesmWa6mD2djwg1KIUyEyW] X-ClientProxiedBy: CPYP284CA0006.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:68::11) To CY8PR19MB7083.namprd19.prod.outlook.com (2603:10b6:930:55::19) X-Microsoft-Original-Message-ID: <871qepjpkh.fsf@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR19MB7083:EE_|IA1PR19MB6203:EE_ X-MS-Office365-Filtering-Correlation-Id: f520b624-2f49-4ed6-48eb-08dbbc09caca X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VzAJfQ9Dfamyqr/ivDMlpGmrLs8+L25kDPTJ5oHEBjFjLX0mRx9uinhiYholEb23D8TLtEWli1J7Tpc1+38y3v259QNcScaMJfb/braZCQ/zYzzOCEUr7LPhJjGEY0wEeIcVgi76jdcjYEDL3Jq0GQh9RYod7fuzxH93Np8jFESkfecbD8PV82EJKewXW+nd7aQistfci5vEu16iMwprY8Z9pg0aU9+C8QIj0eeL6n6TL5s6XnHm9YqGw/x9oLd5ojVpOnfEZH0nxkox+2JhuY1vF3c3Lys0niuX0azVxxtDBzBtwduOkFVxOLeYen8SLw9lP7VD5WG4nBxT1sVqSlOOJjYTRlSRc5n++cJXp+4znS9tdv+odvdAfsZKDalWVlh1odkBC/p8kmr76YyJ4eTiQdn4i09ZUMWSazKtx6kdvtZ+5S0avQI5M4825pPQtVrzS86IpgutORbVGrUR4UcCGhlPyXUUBU+32CAuVSsPJoY8nDajyrIK+LTpgp6gIZkGbatm0y0MGjkoN451o28dWoemj3ceMkeSIaF5jJYi9rL/In/lLYkcEPOlpUvb X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xTDYYq1S1yhd2Q34NSoPKYglTtKNK0jMGfEQvkOgRxIH2F6CpXb7sZ76s198?= =?us-ascii?Q?rXF8cWYCipJdfZ0yGcxza2DGKo44wWKJDvc7ryk/ZDm7PnTmSO8V8TwkL/7U?= =?us-ascii?Q?vNwJ4Ia1sew5XrRMK7JY+P2QgHLn7lFYnj65C0ZqHig99aL58oaOaDxxRHdi?= =?us-ascii?Q?IpZI7KSzNr4RRSVt36/gSorzu9wt+XkeChCX1OQUrAtAJuw0CbhcBvyxs0ol?= =?us-ascii?Q?xBkrwR1AiJeXMHsQ4jr5RTtx3fKPg8Hx7urrfqrGZDbuzzbH/HIXv4HHtPJx?= =?us-ascii?Q?M9JIuifTw3AKY07V6kb2WS4Ip1ZBNNFDNg0TfpG0FdFjMb/4iTJddoWT9SMf?= =?us-ascii?Q?d5+f+ulI5BkzMgLe1T8nLfUyfZtYcMaXpK93Elvu//JfpbJPXlzImwBj4PJg?= =?us-ascii?Q?hSIXXQo8XQMMVfcYAJpHC8fy4f9Oa1IqyAZC0OLvCOZk6aX6JH+F5vGlmZPU?= =?us-ascii?Q?DDbVJvcN0kQ6Yuh3nxNl6DL887pGZnPRqlSvL+AbRKZad0Trswyi6iAavfgL?= =?us-ascii?Q?UD9qyq5ihCNudvab+DahH/sOXP6MdziB/W5YC3XVi9gJTldFtnGD6SvsA8ka?= =?us-ascii?Q?RsWKvs4mAeYpejHq8kgxF0bka1Nxoy5nOjftkZhTew52RXDv4q/lQGaC+NTq?= =?us-ascii?Q?BUEJD90/kn0r0vZDJ3OE0Zf+OofsTt4a/nDlWsxV6PdzFd95NL3Y4Z4CwO5n?= =?us-ascii?Q?aEL8ty7OlXm9SjW/rsgwn3sWmUw3ZpCgXozuoKzxUBDw54kXEKFaQo5kqlWf?= =?us-ascii?Q?BHXwGMBaW8TlgzWc7d8shudrFubxEg8r3mqcCtP4uIUkA3ZI+WGw1FQisGVQ?= =?us-ascii?Q?DqvH0x+kma1nrPa+T9TKySG5w0pLCn47RPLIHg0c+VikuVDRSudvbODyz2Oo?= =?us-ascii?Q?aGVuRAcnVi6clHk0b2wi1PTIEFQThXjiW9peTM7tNtXi9+qpVwEB2oPRybuD?= =?us-ascii?Q?CKxTRYqPbOIDnwyt4aQGbKI8VlxvUwUlPVfsAOaVatt/M3M+ZmyQQ9RvbBGz?= =?us-ascii?Q?W+cmFHDBrwZlAQcKt3Rewwd/+s2QHklLSxiXlX1Q+mHNnGXtfdDYK1zkNaBC?= =?us-ascii?Q?ncb3mbCOmsCL7tzMLLsw4r2TvMQ8ylxPloSQNd80xgUo59S4OufiMprI60ZZ?= =?us-ascii?Q?rlMbI6OQ9qXxF2A6gWEckVEhHIJjzpWwXxVx1YAVO1I5009nEjkOcfyXnZYZ?= =?us-ascii?Q?PGVFrdLllbMwnb+BzVX/Wz7Z0AO7t5HoWt3VHHHsvsdnBx5rY6zgEKhFMXxM?= =?us-ascii?Q?KSrqe6lhVEfUWYJX+VX62JPw6P7snmUI+x8f/dnGufY6yuigt1cj1JH41F6W?= =?us-ascii?Q?uIc=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-e7757.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: f520b624-2f49-4ed6-48eb-08dbbc09caca X-MS-Exchange-CrossTenant-AuthSource: CY8PR19MB7083.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2023 07:50:45.0747 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR19MB6203 Received-SPF: pass client-ip=2a01:111:f400:7e88::823; envelope-from=gabriel376@hotmail.com; helo=NAM10-DM6-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Consider outline-heading-end-regexp in outline-font-lock-keywords. Example of use case: 1) emacs -Q 2) in *scratch* buffer, type ";;; Hello" in a new line, plus some line breaks 3) eval: (setq-local outline-regexp ";;;*") (setq-local outline-heading-end-regexp "\n") [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (gabriel376[at]hotmail.com) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (gabriel376[at]hotmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom; id=gabriel376%40hotmail.com; ip=2001%3A470%3A142%3A%3A17; r=debbugs.gnu.org] 0.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --=-=-= Content-Type: text/plain Consider outline-heading-end-regexp in outline-font-lock-keywords. Example of use case: 1) emacs -Q 2) in *scratch* buffer, type ";;; Hello" in a new line, plus some line breaks 3) eval: (setq-local outline-regexp ";;;*") (setq-local outline-heading-end-regexp "\n") (setq-local outline-minor-mode-highlight 'override) (custom-set-faces '(outline-1 ((t :background "red" :extend t)))) (outline-minor-mode 1) 4) expected: since the outline-1 face has the extend attribute and the heading regexp ends in a line break, the outline-1 face on ";;; Hello" should be applied until the line break (extended) Patch: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Consider-outline-heading-end-regexp-in-outline-font-.patch >From 5d56f04e4f59e8fef9f4521901f527db09004534 Mon Sep 17 00:00:00 2001 From: Gabriel Date: Sat, 23 Sep 2023 04:32:02 -0300 Subject: [PATCH 1/1] Consider outline-heading-end-regexp in outline-font-lock-keywords * lisp/outline.el (outline-font-lock-keywords): Add outline-heading-end-regexp to regexp. --- lisp/outline.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/outline.el b/lisp/outline.el index d8dd491212e..7f826a4ece2 100644 --- a/lisp/outline.el +++ b/lisp/outline.el @@ -260,7 +260,7 @@ outline-font-lock-keywords '( ;; Highlight headings according to the level. (eval . (list (or outline-search-function - (concat "^\\(?:" outline-regexp "\\).*")) + (concat "^\\(?:" outline-regexp "\\).*" outline-heading-end-regexp)) 0 '(if outline-minor-mode (if outline-minor-mode-highlight (list 'face (outline-font-lock-face))) -- 2.34.1 --=-=-= Content-Type: text/plain --- Gabriel --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 23 13:39:40 2023 Received: (at 66166) by debbugs.gnu.org; 23 Sep 2023 17:39:40 +0000 Received: from localhost ([127.0.0.1]:40582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qk6bT-0007uW-SH for submit@debbugs.gnu.org; Sat, 23 Sep 2023 13:39:40 -0400 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]:43029) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qk6bH-0007tn-TR for 66166@debbugs.gnu.org; Sat, 23 Sep 2023 13:39:31 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 7F93E2000A; Sat, 23 Sep 2023 17:39:07 +0000 (UTC) From: Juri Linkov To: Gabriel Subject: Re: bug#66166: 30.0.50; [PATCH] Consider outline-heading-end-regexp in outline-font-lock-keywords In-Reply-To: (Gabriel's message of "Sat, 23 Sep 2023 04:50:38 -0300") Organization: LINKOV.NET References: Date: Sat, 23 Sep 2023 20:33:37 +0300 Message-ID: <86wmwgvlou.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 66166 Cc: 66166@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Consider outline-heading-end-regexp in outline-font-lock-keywords. > > Example of use case: > 1) emacs -Q > 2) in *scratch* buffer, type ";;; Hello" in a new line, plus some line breaks > 3) eval: > (setq-local outline-regexp ";;;*") > (setq-local outline-heading-end-regexp "\n") > (setq-local outline-minor-mode-highlight 'override) > (custom-set-faces '(outline-1 ((t :background "red" :extend t)))) > (outline-minor-mode 1) > 4) expected: since the outline-1 face has the extend attribute and the > heading regexp ends in a line break, the outline-1 face on ";;; Hello" > should be applied until the line break (extended) > > Patch: > - (concat "^\\(?:" outline-regexp "\\).*")) > + (concat "^\\(?:" outline-regexp "\\).*" outline-heading-end-regexp)) Thanks, your patch looks right. I wonder if it might break something, maybe need more testing. Then it will fix the extend attribute only when outlines are expanded. But when collapsed, changes in the display engine are required to support the extend attribute over the ellipsis (bug#65896). From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 23 15:01:43 2023 Received: (at 66166) by debbugs.gnu.org; 23 Sep 2023 19:01:43 +0000 Received: from localhost ([127.0.0.1]:40623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qk7st-0001qf-5I for submit@debbugs.gnu.org; Sat, 23 Sep 2023 15:01:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qk7sr-0001qQ-AM for 66166@debbugs.gnu.org; Sat, 23 Sep 2023 15:01:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qk7sZ-0001x0-N2; Sat, 23 Sep 2023 15:01:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2qHl/Gy+zdKisv7zq0HYfVYFdKdRRNl2IAAbCPD2JLU=; b=jD3Y6x7/r4BJ 6GoZAMztyHSLP6XOWpXVyLhtAIWLLqeephF08cWI+uzwinJn5WVFbv/vaXqocX+BIYk7cYW6Kd8bd 0GQTirkZHQKpO2euhJD2S73mkyXsWyBLX+ubgPBj5z1gGDoARqAxsvE+Ml7jOcnqP3O0tw0QiHNn1 Jer9Bu91/3GMmc3MgO3htBnbCnQTlXl2S+HizwboHJACQJ/M61M+aV7NB1MgdvGRme6jDCPHRFvMt COhSYsfToeoFcl+9l7kEL0KlmAKFyRidxrsQGDRHQJnr5hnplOuKSSJtOiNb1WBP9mnl9Hs+axtrX n2FfpB6wISom8BCfAaxl7w==; Date: Sat, 23 Sep 2023 22:01:20 +0300 Message-Id: <83fs344su7.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <86wmwgvlou.fsf@mail.linkov.net> (message from Juri Linkov on Sat, 23 Sep 2023 20:33:37 +0300) Subject: Re: bug#66166: 30.0.50; [PATCH] Consider outline-heading-end-regexp in outline-font-lock-keywords References: <86wmwgvlou.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66166 Cc: gabriel376@hotmail.com, 66166@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 66166@debbugs.gnu.org > From: Juri Linkov > Date: Sat, 23 Sep 2023 20:33:37 +0300 > > But when collapsed, changes in the display engine are required > to support the extend attribute over the ellipsis (bug#65896). Changes that no one could yet define in a way that doesn't break other uses of faces. So it isn't yet established that changes in the display engine are required, or even possible. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 10 16:30:48 2024 Received: (at 66166) by debbugs.gnu.org; 10 Jan 2024 21:30:48 +0000 Received: from localhost ([127.0.0.1]:43339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNg9v-0005d4-QY for submit@debbugs.gnu.org; Wed, 10 Jan 2024 16:30:48 -0500 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:57744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNg9u-0005RJ-91 for 66166@debbugs.gnu.org; Wed, 10 Jan 2024 16:30:47 -0500 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-5574feb7958so5487245a12.3 for <66166@debbugs.gnu.org>; Wed, 10 Jan 2024 13:30:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704922241; x=1705527041; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=yrRr4Qh9jhquAo1mfXpfcfSD0OY/EIPHxkMyZKSp52k=; b=Igt+pIZr+o4fMBx7WM2swC9B8e63dKo87lKC4E2ZcJ+UgzWK9/hrLI+xioptfBv1TK 3tNxV+squLZz/EH6BZkfykSRSujt9pKE+VuN9qlzjpXSD6EXxvL6fn/GiTqZjGngIixR 2rDzcIILcv+ygV4ihpCRPgLJOZ7WfCR+bB+8k9Yl0Wzsi0GNbJFSVC/6TVHJ49pQHhi+ z969ah5RAUR2P4wrfeKC2NFHwkv7BsOsnjKdTmuJbrZU3BNMhx1WIR8aYlrBZ7gGp5ek z2iMaN4kL7+7VKwhpjkVx5AGE9+S9iPzJYhdLwWBg+VDSswSmjQmo4i3/O1lnZnGWkOq 3NjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704922241; x=1705527041; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yrRr4Qh9jhquAo1mfXpfcfSD0OY/EIPHxkMyZKSp52k=; b=EYvWE3DwLgfdRHrOu2FsxLhJElaHRuTd9BY4QP5FJY87k7FPB/9V8aHhrM3UhIufvh hRj/d1FCBwOoRgVOaHtImPqGv/AJoqkNkflsP0FCjnw9HJo8JiG035Koj9Zc/RN7ppbP 74QVXkylbeztk6t8blRnXblG6oqR4yeFaSljLZa+V2RI174YoQjGdgUIN/TCAXAdyVy5 CSjbLfSm/0SUbv82f7AaQ5g/uDPxvThdQDBy0npdsgabRVLV2AEjIFRusKRS2anyp8O9 g/L8TnYs2qiz0l5V8KOZEkeoIwIlU5Nq4eCnM5hlTfz23K9dQbJR1o8OH/Au1gJZfotn P4Fg== X-Gm-Message-State: AOJu0Yxg+faFhizBvB/K3vvbkXUcB/IZ6DpaeAWTE2XfB+Kvjx8PuOjQ wSuQIBd7EZVngOqSNRWcw5bVlk3VrLHWUBDRm+Q= X-Google-Smtp-Source: AGHT+IH3JFFOSQDoiw/nS3FTbFB6Pz2abaa81zPJA+GcWG/vuuLfERFTmvOadJTtAp5ADIvh/TXa4OJhwyKUveS6BzM= X-Received: by 2002:aa7:c459:0:b0:557:8a58:ebdc with SMTP id n25-20020aa7c459000000b005578a58ebdcmr52111edr.9.1704922241389; Wed, 10 Jan 2024 13:30:41 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 10 Jan 2024 13:30:41 -0800 From: Stefan Kangas In-Reply-To: <86wmwgvlou.fsf@mail.linkov.net> (Juri Linkov's message of "Sat, 23 Sep 2023 20:33:37 +0300") References: <86wmwgvlou.fsf@mail.linkov.net> MIME-Version: 1.0 Date: Wed, 10 Jan 2024 13:30:41 -0800 Message-ID: Subject: Re: bug#66166: 30.0.50; [PATCH] Consider outline-heading-end-regexp in outline-font-lock-keywords To: Juri Linkov Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66166 Cc: Gabriel , 66166@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: >> Consider outline-heading-end-regexp in outline-font-lock-keywords. >> >> Example of use case: >> 1) emacs -Q >> 2) in *scratch* buffer, type ";;; Hello" in a new line, plus some line breaks >> 3) eval: >> (setq-local outline-regexp ";;;*") >> (setq-local outline-heading-end-regexp "\n") >> (setq-local outline-minor-mode-highlight 'override) >> (custom-set-faces '(outline-1 ((t :background "red" :extend t)))) >> (outline-minor-mode 1) >> 4) expected: since the outline-1 face has the extend attribute and the >> heading regexp ends in a line break, the outline-1 face on ";;; Hello" >> should be applied until the line break (extended) >> >> Patch: >> - (concat "^\\(?:" outline-regexp "\\).*")) >> + (concat "^\\(?:" outline-regexp "\\).*" outline-heading-end-regexp)) > > Thanks, your patch looks right. I wonder if it might break something, > maybe need more testing. Did you have a chance to do more testing here? Should this patch be installed? Thanks in advance. > Then it will fix the extend attribute only when outlines are expanded. > But when collapsed, changes in the display engine are required > to support the extend attribute over the ellipsis (bug#65896). From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 11 02:12:55 2024 Received: (at 66166) by debbugs.gnu.org; 11 Jan 2024 07:12:56 +0000 Received: from localhost ([127.0.0.1]:58576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNpFH-0003Wg-Jr for submit@debbugs.gnu.org; Thu, 11 Jan 2024 02:12:55 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:47899) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNpFF-0003WP-LZ; Thu, 11 Jan 2024 02:12:54 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 252C7240002; Thu, 11 Jan 2024 07:12:48 +0000 (UTC) From: Juri Linkov To: Stefan Kangas Subject: Re: bug#66166: 30.0.50; [PATCH] Consider outline-heading-end-regexp in outline-font-lock-keywords In-Reply-To: (Stefan Kangas's message of "Wed, 10 Jan 2024 13:30:41 -0800") Organization: LINKOV.NET References: <86wmwgvlou.fsf@mail.linkov.net> Date: Thu, 11 Jan 2024 09:12:02 +0200 Message-ID: <86mstcny2l.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 66166 Cc: Gabriel , 66166@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 66166 30.0.50 thanks >>> Consider outline-heading-end-regexp in outline-font-lock-keywords. >>> >>> Example of use case: >>> 1) emacs -Q >>> 2) in *scratch* buffer, type ";;; Hello" in a new line, plus some line breaks >>> 3) eval: >>> (setq-local outline-regexp ";;;*") >>> (setq-local outline-heading-end-regexp "\n") >>> (setq-local outline-minor-mode-highlight 'override) >>> (custom-set-faces '(outline-1 ((t :background "red" :extend t)))) >>> (outline-minor-mode 1) >>> 4) expected: since the outline-1 face has the extend attribute and the >>> heading regexp ends in a line break, the outline-1 face on ";;; Hello" >>> should be applied until the line break (extended) >>> >>> Patch: >>> - (concat "^\\(?:" outline-regexp "\\).*")) >>> + (concat "^\\(?:" outline-regexp "\\).*" outline-heading-end-regexp)) >> >> Thanks, your patch looks right. I wonder if it might break something, >> maybe need more testing. > > Did you have a chance to do more testing here? Should this patch be > installed? Thanks in advance. I have used this change all the time from September 2023 without any problems. So now this is installed in master. >> Then it will fix the extend attribute only when outlines are expanded. >> But when collapsed, changes in the display engine are required >> to support the extend attribute over the ellipsis (bug#65896). This could be implemented in another bug report. From unknown Tue Jun 17 01:46:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 08 Feb 2024 12:24:14 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator