From unknown Sat Aug 16 13:39:33 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#66158 <66158@debbugs.gnu.org> To: bug#66158 <66158@debbugs.gnu.org> Subject: Status: [PATCH] gnu: node-lts: Update to 18.18.0. Reply-To: bug#66158 <66158@debbugs.gnu.org> Date: Sat, 16 Aug 2025 20:39:33 +0000 retitle 66158 [PATCH] gnu: node-lts: Update to 18.18.0. reassign 66158 guix-patches submitter 66158 jlicht@fsfe.org severity 66158 normal tag 66158 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 22 14:13:56 2023 Received: (at submit) by debbugs.gnu.org; 22 Sep 2023 18:13:56 +0000 Received: from localhost ([127.0.0.1]:37297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjkf6-0000Dg-1E for submit@debbugs.gnu.org; Fri, 22 Sep 2023 14:13:56 -0400 Received: from lists.gnu.org ([2001:470:142::17]:60916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjkf0-0000DQ-N3 for submit@debbugs.gnu.org; Fri, 22 Sep 2023 14:13:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjkej-000899-Pd for guix-patches@gnu.org; Fri, 22 Sep 2023 14:13:33 -0400 Received: from mail1.fsfe.org ([217.69.89.151]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjkeh-0007TY-Lf for guix-patches@gnu.org; Fri, 22 Sep 2023 14:13:33 -0400 From: jlicht@fsfe.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021100501; t=1695406400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=NfiWLDLa7XLXNoPhs/VsAzFx0u5pFY8Ot4DHkjn7j9U=; b=qOxhU9AgClFXQCgGUqfEUOnD0a6HJ2UhaNn7dJLWZ1DxyB2n7rQ9M1Atl1eTFtrDgVKI6X NFhxMjDRAQZT9P22dDPDBBF9RfXDzEpQzUYoJHAZsLzc/xqjaICTBqsoRzwOeRNIItlLdn /oUHIkSbI+BPyTf5PXy1Ljq23+zk+QI= To: guix-patches@gnu.org Subject: [PATCH] gnu: node-lts: Update to 18.18.0. Date: Fri, 22 Sep 2023 20:13:13 +0200 Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=217.69.89.151; envelope-from=jlicht@fsfe.org; helo=mail1.fsfe.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Jelle Licht X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) From: Jelle Licht * gnu/packages/node.scm (node-lts): Update to 18.18.0. --- gnu/packages/node.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm index d769066dc4..a933a83e98 100644 --- a/gnu/packages/node.scm +++ b/gnu/packages/node.scm @@ -738,14 +738,14 @@ (define-public llhttp-bootstrap (define-public node-lts (package (inherit node) - (version "18.17.1") + (version "18.18.0") (source (origin (method url-fetch) (uri (string-append "https://nodejs.org/dist/v" version "/node-v" version ".tar.gz")) (sha256 (base32 - "0dachvhf5jxrb1av8mn2dikbhwklxsgc9y2zg4h50fcwh5d54mqi")) + "0z54vhfbb6g8j92z21xh8yg7rb48lqwxjw45g0qnwpxnw1z4spsw")) (modules '((guix build utils))) (snippet '(begin base-commit: ec130e1a1b7f3b87b1a6e626754f7e7a07f6b717 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 06 11:59:53 2023 Received: (at 66158) by debbugs.gnu.org; 6 Oct 2023 15:59:53 +0000 Received: from localhost ([127.0.0.1]:52473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qonF3-0005we-1W for submit@debbugs.gnu.org; Fri, 06 Oct 2023 11:59:53 -0400 Received: from mail3.fsfe.org ([31.24.147.90]:42666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qonEx-0005wR-CK for 66158@debbugs.gnu.org; Fri, 06 Oct 2023 11:59:51 -0400 From: Jelle Licht DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2023072501; t=1696608009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s/gFbpd0h8sLUxxRMT5i7rojEawjtypHRPT4AEGpKEQ=; b=LnY0navujMZjk5MGVtrbw6OyGvUToFQoH1ZaomkiJM52WW3R8ZzkX32xVObeBSrcssjKuk nThlczan2dF9yy5/Gv9KJgzw5Uu10nA/Yp8jRqE/0TXgXCgvh6grwhpehuKSlj93Dakdkn JEZsCE8NSrlRVJJWxpPbRDIVYS+Hfe4= To: 66158@debbugs.gnu.org Subject: Re: [PATCH] gnu: node-lts: Update to 18.18.0. In-Reply-To: References: Date: Fri, 06 Oct 2023 17:59:25 +0200 Message-ID: <87r0m7vj1e.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66158 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) jlicht@fsfe.org writes: > From: Jelle Licht > > * gnu/packages/node.scm (node-lts): Update to 18.18.0. > --- > > gnu/packages/node.scm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm > index d769066dc4..a933a83e98 100644 > --- a/gnu/packages/node.scm > +++ b/gnu/packages/node.scm > @@ -738,14 +738,14 @@ (define-public llhttp-bootstrap > (define-public node-lts > (package > (inherit node) > - (version "18.17.1") > + (version "18.18.0") > (source (origin > (method url-fetch) > (uri (string-append "https://nodejs.org/dist/v" version > "/node-v" version ".tar.gz")) > (sha256 > (base32 > - "0dachvhf5jxrb1av8mn2dikbhwklxsgc9y2zg4h50fcwh5d54mqi")) > + "0z54vhfbb6g8j92z21xh8yg7rb48lqwxjw45g0qnwpxnw1z4spsw")) > (modules '((guix build utils))) > (snippet > '(begin > > base-commit: ec130e1a1b7f3b87b1a6e626754f7e7a07f6b717 > -- > 2.41.0 Heads up: this breaks our node-openzwave-shared build, which happens due to a breaking change in the NPM that is shipped along with node. It will not work for many local `npm run build' scripts that use node-gyp for the same reason, so I don't think this should be merged as-is. I'm keeping an eye on https://github.com/npm/cli/issues/6842 for a proper fix, but if nobody objects, I'd like to try my hand at a custom generated wrapper script in `$output/lib/node_modules/npm/bin/node-gyp' that restores the older behaviour. We can revert this hack once there's a proper fix in upstream. Any thoughts? - Jelle From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 24 11:42:36 2023 Received: (at 66158) by debbugs.gnu.org; 24 Oct 2023 15:42:36 +0000 Received: from localhost ([127.0.0.1]:56354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvJYB-000440-RW for submit@debbugs.gnu.org; Tue, 24 Oct 2023 11:42:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvJY9-00043n-Jq for 66158@debbugs.gnu.org; Tue, 24 Oct 2023 11:42:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvJXa-0007qH-KK; Tue, 24 Oct 2023 11:41:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=MSCnPbcHXurvWpd54ujNF8SnrY0mp/zuJBaX0Q5u90M=; b=KtuLGDR+dqBcrX7RZqoQ TgEhKhJvUyFJtcNLH64oEVZcsID1EwmvPIM88k2MA8OH3EtvCUENi28Ct6Y48XZE6i9rES/URbz+f FRQzR1YbWCZZ1BXPraZV8uv01vNVSPelnjAdg9IdzhrZf3JPthaWckdbKv1AG8L4UxrkWQBYmyOl+ JMwlofLwtH2Av6TUgIdh9FKHzlE4siccMC++2hIaaA7jhk/N20VPVgnUYaIidMnvegE9xIC8MjWKt hGPM7V03c9tnV6CewFw/40ztt2cUezskc5o4hPyuQ1nCQtACRepdQ5ZFVQfJCl5KW55pPfEsqO49j OCzaBFA7lJ0BcA==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Jelle Licht Subject: Re: [bug#66158] [PATCH] gnu: node-lts: Update to 18.18.0. In-Reply-To: <87r0m7vj1e.fsf@fsfe.org> (Jelle Licht's message of "Fri, 06 Oct 2023 17:59:25 +0200") References: <87r0m7vj1e.fsf@fsfe.org> Date: Tue, 24 Oct 2023 17:41:56 +0200 Message-ID: <87zg086n97.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66158 Cc: 66158@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Jelle Licht skribis: > jlicht@fsfe.org writes: > >> From: Jelle Licht >> >> * gnu/packages/node.scm (node-lts): Update to 18.18.0. >> --- >> >> gnu/packages/node.scm | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm >> index d769066dc4..a933a83e98 100644 >> --- a/gnu/packages/node.scm >> +++ b/gnu/packages/node.scm >> @@ -738,14 +738,14 @@ (define-public llhttp-bootstrap >> (define-public node-lts >> (package >> (inherit node) >> - (version "18.17.1") >> + (version "18.18.0") >> (source (origin >> (method url-fetch) >> (uri (string-append "https://nodejs.org/dist/v" version >> "/node-v" version ".tar.gz")) >> (sha256 >> (base32 >> - "0dachvhf5jxrb1av8mn2dikbhwklxsgc9y2zg4h50fcwh5d54mqi")) >> + "0z54vhfbb6g8j92z21xh8yg7rb48lqwxjw45g0qnwpxnw1z4spsw")) >> (modules '((guix build utils))) >> (snippet >> '(begin >> >> base-commit: ec130e1a1b7f3b87b1a6e626754f7e7a07f6b717 >> --=20 >> 2.41.0 > > Heads up: this breaks our node-openzwave-shared build, which happens due > to a breaking change in the NPM that is shipped along with node. It will > not work for many local `npm run build' scripts that use node-gyp for > the same reason, so I don't think this should be merged as-is. > > I'm keeping an eye on https://github.com/npm/cli/issues/6842 for a > proper fix, but if nobody objects, I'd like to try my hand at a custom > generated wrapper script in `$output/lib/node_modules/npm/bin/node-gyp' > that restores the older behaviour. We can revert this hack once there's > a proper fix in upstream. > > Any thoughts? None, but please do whatever you think is appropriate so we can push this upgrade forward! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 27 12:03:12 2023 Received: (at 66158) by debbugs.gnu.org; 27 Oct 2023 16:03:12 +0000 Received: from localhost ([127.0.0.1]:36903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qwPIl-0003lR-K3 for submit@debbugs.gnu.org; Fri, 27 Oct 2023 12:03:12 -0400 Received: from mail2.fsfe.org ([213.95.165.55]:37150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qwPIi-0003lC-RO for 66158@debbugs.gnu.org; Fri, 27 Oct 2023 12:03:11 -0400 From: jlicht@fsfe.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021081301; t=1698422555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=431TUeo6oxZF4fErqeVOOOeXJXq501xvwWTZuCpRxZ4=; b=LDR6RYAS/K2dIvSbxJzVQ+7JCprRO+HEZLKz9EJy7FD1PdukR+J93cZxO9srClSerTotz0 0MX9spHoyn1jOA6FknHgY8uIA5RMa9bTsDznqtz4mzNAxCuHLCcs06bAIjB3OOWNzsgJLh C+/9PYZG4uEx2TNTUGHSYdVCM0p8YP4= To: 66158@debbugs.gnu.org Subject: [PATCH v2] gnu: node-lts: Update to 18.18.2. Date: Fri, 27 Oct 2023 18:02:29 +0200 Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 66158 Cc: Jelle Licht X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) From: Jelle Licht * gnu/packages/node.scm (node-lts): Update to 18.18.2. [arguments]: Add 'install-node-gyp-wrapper phase. Change-Id: I6b17de33313505558a8fa9560126adef486fd0e3 --- I tried my hand at introducing a small wrapper script that works around the node-gyp regression introduced in the version of npm bundled with node 18.18.2. It's not quite clear yet whether upstream considers this a regression that will still be fixed or just behaviour that be kept as-is going forward. This patch series also leaves Node vulnerable to a recently reported CVE in many HTTP2 server implementations, such as nghttp2, but I believe this can be addressed by https://issues.guix.gnu.org/issue/66658 Changes in v2: - Re-bump from 18.18.0 to 18.18.2 - Fix 'node-gyp' regression. gnu/packages/node.scm | 25 ++++++++++++++++++++++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm index d769066dc4..6e30ad486a 100644 --- a/gnu/packages/node.scm +++ b/gnu/packages/node.scm @@ -738,14 +738,14 @@ (define-public llhttp-bootstrap (define-public node-lts (package (inherit node) - (version "18.17.1") + (version "18.18.2") (source (origin (method url-fetch) (uri (string-append "https://nodejs.org/dist/v" version "/node-v" version ".tar.gz")) (sha256 (base32 - "0dachvhf5jxrb1av8mn2dikbhwklxsgc9y2zg4h50fcwh5d54mqi")) + "0ci1faxjsbp0lv05kskh5anfljn6zawqcf7dawiby5d5qg7x572h")) (modules '((guix build utils))) (snippet '(begin @@ -903,7 +903,26 @@ (define-public node-lts "/lib/node_modules/npm/node_modules" "/tar/lib/write-entry.js"))) (substitute* file - (("this.stat.nlink > 1") "false"))))))))) + (("this.stat.nlink > 1") "false"))))) + (add-after 'install 'install-node-gyp-wrapper + (lambda* (#:key inputs outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (dir (string-append out "/lib/node_modules/npm/bin/node-gyp-bin")) + (file (string-append dir "/node-gyp"))) + (mkdir-p dir) + ;; See https://github.com/npm/cli/issues/6842 + (call-with-output-file file + (lambda (port) + (format port "#!~a/bin/sh +if [ \"x$npm_config_node_gyp\" = \"x\" ]; then + ~a/bin/node \"~a/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js\" \"$@\" +else + \"$npm_config_node_gyp\" \"$@\" +fi" + (assoc-ref inputs "bash") + out + out))) + (chmod file #o555)))))))) (native-inputs (list ;; Runtime dependencies for binaries used as a bootstrap. c-ares-for-node base-commit: 2ff8de3657a5c9d0abf67bb4705251b23d97702e -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 03 05:54:59 2023 Received: (at submit) by debbugs.gnu.org; 3 Nov 2023 09:54:59 +0000 Received: from localhost ([127.0.0.1]:56836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qyqtG-00029r-K8 for submit@debbugs.gnu.org; Fri, 03 Nov 2023 05:54:59 -0400 Received: from lists.gnu.org ([2001:470:142::17]:33432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qyqtE-00029V-Iz for submit@debbugs.gnu.org; Fri, 03 Nov 2023 05:54:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qyqsZ-0007fu-QY for guix-patches@gnu.org; Fri, 03 Nov 2023 05:54:15 -0400 Received: from mira.cbaines.net ([212.71.252.8]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qyqsY-00047F-7z for guix-patches@gnu.org; Fri, 03 Nov 2023 05:54:15 -0400 Received: from localhost (unknown [193.96.224.61]) by mira.cbaines.net (Postfix) with ESMTPSA id 5928827BBE2; Fri, 3 Nov 2023 09:54:13 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id bd6e9c18; Fri, 3 Nov 2023 09:54:12 +0000 (UTC) References: User-agent: mu4e 1.10.7; emacs 29.1 From: Christopher Baines To: jlicht@fsfe.org Subject: Re: [bug#66158] [PATCH v2] gnu: node-lts: Update to 18.18.2. Date: Fri, 03 Nov 2023 09:53:24 +0000 In-reply-to: Message-ID: <87cywrnovx.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: 66158@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain jlicht@fsfe.org writes: > From: Jelle Licht > > * gnu/packages/node.scm (node-lts): Update to 18.18.2. > [arguments]: Add 'install-node-gyp-wrapper phase. > > Change-Id: I6b17de33313505558a8fa9560126adef486fd0e3 > --- > I tried my hand at introducing a small wrapper script that works around the > node-gyp regression introduced in the version of npm bundled with node 18.18.2. > > It's not quite clear yet whether upstream considers this a regression that > will still be fixed or just behaviour that be kept as-is going forward. > > This patch series also leaves Node vulnerable to a recently reported CVE in > many HTTP2 server implementations, such as nghttp2, but I believe this can be > addressed by https://issues.guix.gnu.org/issue/66658 > > Changes in v2: > - Re-bump from 18.18.0 to 18.18.2 > - Fix 'node-gyp' regression. > > gnu/packages/node.scm | 25 ++++++++++++++++++++++--- > 1 file changed, 22 insertions(+), 3 deletions(-) Looking at QA, there seems to be some issues on aarch64-linux. The build logs do differ between the failed builds, so I've submitted a few more. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmVEw0JfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XeM3BAAiumVvHqjytyDPFBAQaqyRO6+uJaTgtvO BZoR5aXWzgMNqSD77pnNtqoRukMiVdHTApt2sjScentcNpOdNxTKcm5rD7NnRO+H JolVrHQHoRrMNoGWjey0ikVU5cO8INhu+OiqDotCGsZFo524lmwiN/Tfhmp4mT/j pmHaZZhGcK1h+WX8rHN2Gvqux0cb+JNkrm6UHUma1UKIqGjPRMszg0hOTN0TDvS5 jMll+oiCani1dDqLjbMh8pD21iGhJajpgORKilJa9e1iICin5+BzF8WkULCEfK8L gg5U95fIKcg9Z0B4nc6nVXAR1TpHcsIR0EkDxwZjaUV0DyLbQzFqpeMKxpip7D9+ 58soWTTZXiHoXq0QJ+mZD0Dwlwa69k9pWoTnMSHUJ5TgJ82u3sTlz0W/4crk7TGI AzslbLKpXi3tOJg5idFDBkd6hZ97XacMC5Y6U87fV04Re/yG/NTpxtgGVUGzUmAH Vq5lI7R8smi7Yei7NcGCkK+q/BxcH4kZFW2TRyzF5bb+DV2HPp4CgMyBwuOw80af g1IUGFC+fj0EwauqRtp9JSOmwTInbSbWejGEf55C3zBX5ae3Jem2ovLRf4qOH4/y q52n3YUGHQ28EMAtr3VoF0brKdvBnPE5ev7rRRzkb64gX4FoONi3X77BOLqvraOU AYCbNmMr43I= =8eTc -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 05 08:43:00 2023 Received: (at 66158-done) by debbugs.gnu.org; 5 Nov 2023 13:43:00 +0000 Received: from localhost ([127.0.0.1]:36315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzdP1-0000jl-Oh for submit@debbugs.gnu.org; Sun, 05 Nov 2023 08:43:00 -0500 Received: from mail2.fsfe.org ([213.95.165.55]:43174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzdOy-0000jb-K6 for 66158-done@debbugs.gnu.org; Sun, 05 Nov 2023 08:42:58 -0500 From: Jelle Licht DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021081301; t=1699191737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jjnQP/f4CuYPp8Z3UFI1MKssgkdPpfRyQpkYKDfv7m8=; b=jU08E5lpJShmAiPJm6NOW34Y3wxqrY1SZuBamN1jRy7p3SD9Awjp/ms5PB+5kEZ2TJEO2k 46ss5duQTcJal5AVXppLM7Zjt/l4UV6Wl5ps4/I4KYWqeBfF1hya4FsG0ureLqpSFr59Os bwiXp1fAm85e62Sg8B7jCnA5RGH0y10= To: Christopher Baines Subject: Re: [bug#66158] [PATCH v2] gnu: node-lts: Update to 18.18.2. In-Reply-To: <87cywrnovx.fsf@cbaines.net> References: <87cywrnovx.fsf@cbaines.net> Date: Sun, 05 Nov 2023 14:42:14 +0100 Message-ID: <87msvss4eh.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 66158-done Cc: 66158-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Christopher Baines writes: > jlicht@fsfe.org writes: > >> From: Jelle Licht >> >> * gnu/packages/node.scm (node-lts): Update to 18.18.2. >> [arguments]: Add 'install-node-gyp-wrapper phase. >> >> Change-Id: I6b17de33313505558a8fa9560126adef486fd0e3 >> --- >> I tried my hand at introducing a small wrapper script that works around the >> node-gyp regression introduced in the version of npm bundled with node 18.18.2. >> >> It's not quite clear yet whether upstream considers this a regression that >> will still be fixed or just behaviour that be kept as-is going forward. >> >> This patch series also leaves Node vulnerable to a recently reported CVE in >> many HTTP2 server implementations, such as nghttp2, but I believe this can be >> addressed by https://issues.guix.gnu.org/issue/66658 >> >> Changes in v2: >> - Re-bump from 18.18.0 to 18.18.2 >> - Fix 'node-gyp' regression. >> >> gnu/packages/node.scm | 25 ++++++++++++++++++++++--- >> 1 file changed, 22 insertions(+), 3 deletions(-) > > Looking at QA, there seems to be some issues on aarch64-linux. The build > logs do differ between the failed builds, so I've submitted a few more. Pushed to master as ab94e80601a5b23f44e7455b3443457b4a99a1e5. At least the aarch64-linux build seems to have worked out. I've locally verified that things build for i686-linux too. Please Cc me if there are still any issues with it. - Jelle From unknown Sat Aug 16 13:39:33 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 04 Dec 2023 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator