Subject: bug#66150: 30.0.50; Duplicate :tag in remote-file-name-inhibit-cache

From: Eli Zaretskii <[email-masked]>
Date: Fri, 22 Sep 2023 14:37:51 +0300

> Cc: Michael Albinus <[email-masked]>
> Date: Fri, 22 Sep 2023 11:41:32 +0200
> From:  "Basil L. Contovounesios" via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <[email-masked]>
> 
> Building master, I see the following warning:
> 
>   In toplevel form:
>   files.el:1327:12: Warning: in defcustom for ‘remote-file-name-inhibit-cache’:
>   duplicated :tag string in ‘choice’: "Do not use file name cache"
> 
> Is the following patch acceptable?

With changes, see below.

> -	  (const   :tag "Do not inhibit file name cache" nil)
> -	  (const   :tag "Do not use file name cache" t)
> -	  (integer :tag "Do not use file name cache"
> -		   :format "Do not use file name cache older then %v seconds"
> +          (const   :tag "Inhibit remote file cache" t)
> +          (const   :tag "Cache remote file attributes" nil)
> +          (integer :tag "Cache remote file attributes with expiration"
> +                   :format "Cache expiry in seconds: %v"
>  		   :value 10)))

Let's be consistent.  Either (a) the t value should have the tag of
"Do not cache remote file attributes", or (b) the nil and the integer
values should have the tag "Do not inhibit remote file cache" and
"Inhibit file cache if expired", respectively.  OK?

> If it's acceptable, does it belong on master or emacs-29?

emacs-29, please.