From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 22 05:42:05 2023 Received: (at submit) by debbugs.gnu.org; 22 Sep 2023 09:42:05 +0000 Received: from localhost ([127.0.0.1]:35333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjcfk-0000qc-KJ for submit@debbugs.gnu.org; Fri, 22 Sep 2023 05:42:05 -0400 Received: from lists.gnu.org ([2001:470:142::17]:48772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjcff-0000q6-Tq for submit@debbugs.gnu.org; Fri, 22 Sep 2023 05:42:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjcfQ-00085N-01 for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 05:41:44 -0400 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjcfL-0005AS-NE for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 05:41:43 -0400 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-99c3c8adb27so240764266b.1 for ; Fri, 22 Sep 2023 02:41:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1695375695; x=1695980495; darn=gnu.org; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=LjBikb3cxVmJWWHvYBLNyUNLTUJAvYy0JJqou3VCE7o=; b=BR9vT4ymf3f/raXTo1SAejX0aNIRCKRqBr9r9PsVz5IrQef29omIu4R0RMy5JYcxR6 R6hAvPKtTSB2PBA440x/ZmfcMxG6EXN9HxOS+tpoe8d7bdxqa1mx2EyM1ZaEzXf9kp8h n9cqSH+m7v9lnxymq1+HR+hyt1oXVubjkErnvrmRkrkcg/ejSISdbXwlpo8QQTrlaDxV /M588f0y4qtn7NoQ2PlCU9sgBu9zsnYVM9ylN2seAMQWdzmnSLTDdqzvPgZ1a3s9ffx5 hnL3JvfYK/XEZJK3HiW6m0poZReaBFJEsidz8Su74ZUwDVKA6egkrz6Y6JTXfZ97KYNF Cj8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695375695; x=1695980495; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LjBikb3cxVmJWWHvYBLNyUNLTUJAvYy0JJqou3VCE7o=; b=dYFKHZBTaxfQeuyeID+FroxA16L8L8NmUPCwu9kXdXQ+9Peq+5FmclUwKwHgxEDnP+ 25dgTBZhVzzIhJJ9lAsEBC/AP6r3UyVC6rIQ++4VYHJmIN9uck1bx+YM2oxHXmiWcb2w J1gMwu8UOVAIlvVYR+nCEFfnOPAQkk6pf7uG9um5SrJrsdRTkL1QlqlH70EaG6lbSVZm NscMLZb3I+oF9HBPuaDMMY7pAQFs0Ud4MrC0i9qHbrcpb8uxrQrlWisc6irtk2dfGFhv AJ9Ihb0kUgMFHGt25v02dSfk7Qf14rSTAqYtd8Hi8HPC0Izb7yve0YgL3R3LC6OL9yqr NKJg== X-Gm-Message-State: AOJu0YwBFw35ySs6MRYuuWzBhC9XntDTib1eqnXQj5VocZi94wFFSodA SgKWVs7U4LSeUhJDXIRDT2vv9QuVQrJ+wsHfcqa2HA== X-Google-Smtp-Source: AGHT+IEj5XfTU7GIh7OhGlKv46mogV/jJ1Y2kFavTgYwAUnhvfUZYr4uVLf5YLLH+IQ17PpUo2X2bQ== X-Received: by 2002:a17:906:cc13:b0:9ae:540c:90ef with SMTP id ml19-20020a170906cc1300b009ae540c90efmr5374958ejb.18.1695375695281; Fri, 22 Sep 2023 02:41:35 -0700 (PDT) Received: from localhost (vpn-254-222.epfl.ch. [128.179.254.222]) by smtp.gmail.com with ESMTPSA id va1-20020a17090711c100b0099d9dee8108sm2463099ejb.149.2023.09.22.02.41.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 02:41:34 -0700 (PDT) From: "Basil L. Contovounesios" To: bug-gnu-emacs@gnu.org Subject: 30.0.50; Duplicate :tag in remote-file-name-inhibit-cache X-Debbugs-Cc: Michael Albinus Date: Fri, 22 Sep 2023 11:41:32 +0200 Message-ID: <87wmwimto3.fsf@epfl.ch> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=contovob@tcd.ie; helo=mail-ej1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Severity: minor Tags: patch Building master, I see the following warning: In toplevel form: files.el:1327:12: Warning: in defcustom for =E2=80=98remote-file-name-inh= ibit-cache=E2=80=99: duplicated :tag string in =E2=80=98choice=E2=80=99: "Do not use file name= cache" Is the following patch acceptable? It tries to improve on the following points: - Avoid too much negation - Fix then/than typo - Avoid mid-sentence %v :format since it extends to eol --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Improve-remote-file-name-inhibit-cache-type.patch >From cd861f4e80b9bd0d656b024834ea49dbbd02f399 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Fri, 22 Sep 2023 11:27:29 +0200 Subject: [PATCH] Improve remote-file-name-inhibit-cache :type * lisp/files.el (remote-file-name-inhibit-cache): Avoid duplicated :tag string. Try to clarify wording and formatting. --- lisp/files.el | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lisp/files.el b/lisp/files.el index b67482a2f74..3f351d2aff8 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -1322,10 +1322,10 @@ remote-file-name-inhibit-cache :group 'tramp :version "24.1" :type '(choice - (const :tag "Do not inhibit file name cache" nil) - (const :tag "Do not use file name cache" t) - (integer :tag "Do not use file name cache" - :format "Do not use file name cache older then %v seconds" + (const :tag "Inhibit remote file cache" t) + (const :tag "Cache remote file attributes" nil) + (integer :tag "Cache remote file attributes with expiration" + :format "Cache expiry in seconds: %v" :value 10))) (defcustom remote-file-name-access-timeout nil -- 2.40.1 --=-=-= Content-Type: text/plain If it's acceptable, does it belong on master or emacs-29? Thanks, -- Basil In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.17.8, Xaw3d scroll bars) of 2023-09-22 built on tia Repository revision: d71b9673a07da93cd7651540cd015636b8f66fda Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101008 System Description: Debian GNU/Linux trixie/sid Configured using: 'configure 'CFLAGS=-O2 -ggdb3' -C --prefix=/home/blc/.local --enable-checking=structs --with-file-notification=yes --with-x-toolkit=lucid --with-x' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XAW3D XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $LANG: en_IE.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo x-toolkit xinput2 x multi-tty move-toolbar make-network-process emacs) Memory information: ((conses 16 38057 8789) (symbols 48 5209 0) (strings 32 14031 1562) (string-bytes 1 382797) (vectors 16 10297) (vector-slots 8 156208 12401) (floats 8 23 23) (intervals 56 259 0) (buffers 992 10)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 22 06:01:34 2023 Received: (at 66150) by debbugs.gnu.org; 22 Sep 2023 10:01:35 +0000 Received: from localhost ([127.0.0.1]:35341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjcyb-0001Om-TW for submit@debbugs.gnu.org; Fri, 22 Sep 2023 06:01:34 -0400 Received: from mout.gmx.net ([212.227.17.21]:34937) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjcyW-0001OU-Bs for 66150@debbugs.gnu.org; Fri, 22 Sep 2023 06:01:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1695376870; x=1695981670; i=michael.albinus@gmx.de; bh=gH30+QgF+BJE9djWhR6yMiSliuUf3bh/j349vG9X5gE=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=LhNsTpoLPIJODLja0S/dDxy17SsNx8aJN+JjZI7bCXbgCSieJpiCG+EH7SpgVZSB4Gpq+i32jdw vht9LqXAlbbjGwURuLeLt8Eilk8qFdZb80jEn6siVnpdSyzS2GNnFAfEjkWq89sAxbABiwu2aED44 9G3Paq4GG3ebjNaf+sP6k6KfLhx0za0ECifWXF3Xzk29XgxY1i2HVf4p/u+hJydcV0ng9qtGyAgrW 58+S0GX+WV2SWit2GfX6PSoAswtVWpU6RW9o7UKW0ywi3CEbSkWxOqirKPOmuNjOWFwsMBGTgqHN5 ktQET0ypqgmd0e5Tf2+ONBM8fEoekc3t96SQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.17]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MgesG-1rK5Fq372S-00h9eA; Fri, 22 Sep 2023 12:01:10 +0200 From: Michael Albinus To: "Basil L. Contovounesios" Subject: Re: bug#66150: 30.0.50; Duplicate :tag in remote-file-name-inhibit-cache In-Reply-To: <87wmwimto3.fsf@epfl.ch> (Basil L. Contovounesios's message of "Fri, 22 Sep 2023 11:41:32 +0200") References: <87wmwimto3.fsf@epfl.ch> Date: Fri, 22 Sep 2023 12:01:10 +0200 Message-ID: <87o7hua5nd.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:eGYp39VJOJayDXvJWh4kFgZz6k7c39816UHrcHvW3KQREFKm5IL ZI6AJ5YbgR/F8Ak9I+rNU9NOudjRoBRuak3DRMqqQCGSm1dulO17d62qbvqjb9l4g+p9KhY yavdmv5A6oOIk/k05oWJKNzWo1aUGSRV6a1BNpUB/0XZfEKx4Zgb1gLSVwp21ezmxUgLfVm FigPuZPJ1II7WCi/Uz0Hw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:x2fee8+O+gM=;EDY08KXiLSP4GIv52yNpszpAGUg 1BRdeyvKsBwxbtVwW/cbzu4iGhYXZoVCqkwZL7yp1fHZ+cTXhQ3rtqHwKfeoPcHvOh0Sxf5xH Xte1ByvcqXYEco7q04Le6xZG0ZY3F+0BWo6ggulqTOBb2IqymS+63UVrrqXXNBMGul3pwd3t2 SxHNewXsjAjtI5dceizkX4uETj3lZ/9cuW4B7aoJG8Qt43YiaWVz4AteYVA7IiLwIwvn9oinN 3sJt8aEjL7YniFd/yFxW1wJWeaphH84A5d36iuGo/xqjnNIx9W631u7Vf3yd1+Si0eipACaKR /LAHbAivayZJI1zQZlilF5VVXdem/SQHLjGYutlFHeixpEKq/4pJAIaCGmhtEw0XXZEhROqs6 IW2DtBmKZozW6Il5ydUiYThBgqUVbDYl7jUjULLLL7f7DIp4T3ek4kamROrcmuWx431wE8Wuk jwxdy/6t44rD+pUhCsf97/O++qV2s/zKxbMbyA74Mth+dvBAduOgxgjLntb/rnSJUmQUsJ4gq qbO7FqkkOBTjMjmhV2apIRnz+JCGInI2VA/WojD4Js93cpJOJ9Wb4CkZYf2sZ8EQPY2F5NstB ZKd7Tj120hhLOTr0M7IQLr6yZFHtGXNSKDCbtb/VbQmyL/PSadSlC9DkrdfY4FVzR2g7Z7bn5 R2SfYfO4Gt/fiYZrw1BL0ZqbEudmT0HOEEqy+QUP5/FlB8GIkSYUvPggHK4UXn4PRoZDqDJzv q4PG7yQzzyv3hxx/wKHKwMJodOzpQAdIEA4kYaGMGntoUt8W++GBaNg8mO+SnEDXMTh5WXPi1 C8p0B5tP1Hz6CaQ8Fe5z99mMJVIZEyJh33/uMucKadrMBOjl+Ml84gOeoLlERmoX8hCSP68Be D/4FIIUh5dnAFsfuCjSYP3Uq9Li0jyp7AwND3L1kQMhndFkoQ4h6PUd4cmS/kZxTdqEsKAUEU ASRX+dh5uNkqQs4tOsvASiS/Fiw= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 66150 Cc: 66150@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) "Basil L. Contovounesios" writes: Hi Basil, > Is the following patch acceptable? > It tries to improve on the following points: > - Avoid too much negation > - Fix then/than typo > - Avoid mid-sentence %v :format since it extends to eol Sure. > If it's acceptable, does it belong on master or emacs-29? It changes only user prompts (strings), so I would say emacs-29. > Thanks, Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 22 06:01:44 2023 Received: (at 66150) by debbugs.gnu.org; 22 Sep 2023 10:01:44 +0000 Received: from localhost ([127.0.0.1]:35344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjcyl-0001PE-Vx for submit@debbugs.gnu.org; Fri, 22 Sep 2023 06:01:44 -0400 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:58590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjcyi-0001Ov-Mk for 66150@debbugs.gnu.org; Fri, 22 Sep 2023 06:01:42 -0400 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-533352059fdso2214991a12.0 for <66150@debbugs.gnu.org>; Fri, 22 Sep 2023 03:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1695376883; x=1695981683; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jau9h72GilyxIRet1Ltl18ilJJkfxVYMY33Phv82Hs4=; b=Mmg+qKku8RZmvswi59TJI/7cCXv6QsOvaL/zLisE/FFqez6CF0KWnHiMZBR++8PBhy YfCjKe3MV2c7fb+P5omSIrGUapVLtqP1bQpLVa2ZSqxCdRyhQDtBIBtJJTCBpCHO0pne hWpVvTnSTWoSq6gOBA5ssYelbMnNXemqENBpiZaQAB0AmdjlNSk6ExyyyywsiKm05DLR fUKB+FavOmpn1717F7BB/lTHaeP7WQUJ0HLs6vcV2X/t2STAYcIWe9M+MCD/R1cQPu0j FwG4fKtQr0QnTOkaZBGUHjH64WJgJwWWeoo0qgmDrtUV/hBIk8/txUYT+4G6dLw7fAu5 lTFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695376883; x=1695981683; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Jau9h72GilyxIRet1Ltl18ilJJkfxVYMY33Phv82Hs4=; b=PFP3Hj4MuUbEp97YxPOX9FmtSQvhG2G3YsUp/nS75q4LZdCOAwb30DOD4hVMAqKlyG sqDRS0ph9nXrt3sJPLb//x/Mdyg5tfkvxlYPnxrRCUDbs+RW0iSlO33VoEqcfuByeyEp 5lHD2VmjGIxUzztgcfaOgFGol3i8vV19UGI+WQmG29/sByMemhVaXOal1OcYyIw0DQWk a7GraxE/XKdDZvUexPNScTgOsdJNm0wSYqGPOsWRanaqHsyDhJqG7X0O8z3tkUMrXsUU 1/+CTN+xQKbgyZ6BhbnStUTUneCBf7nzsvsqXKQGF5azwPUTlbzN57FDbjfzre5R68os VHYg== X-Gm-Message-State: AOJu0YwqyfCmAgVFHldmZcmj0u3fyLisMXtUeyZ8uAcay1CbbKrSpU4p /AlxWWajtGE5f9oTHcmK15dgU4cbYOtpIJ7V+QfL1g== X-Google-Smtp-Source: AGHT+IGGwiuININXALve1VJyc2JtoPZs6BXvd85dKSrkUdj+jM8R4teNTUaUS45Ch6jv562B6UGkGA== X-Received: by 2002:a17:907:77c5:b0:9a1:eb67:c0cc with SMTP id kz5-20020a17090777c500b009a1eb67c0ccmr7412482ejc.34.1695376883516; Fri, 22 Sep 2023 03:01:23 -0700 (PDT) Received: from localhost (vpn-254-222.epfl.ch. [128.179.254.222]) by smtp.gmail.com with ESMTPSA id o26-20020a1709061b1a00b0099bc08862b6sm2513299ejg.171.2023.09.22.03.01.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 03:01:22 -0700 (PDT) From: "Basil L. Contovounesios" To: 66150@debbugs.gnu.org Subject: Re: bug#66150: 30.0.50; Duplicate :tag in remote-file-name-inhibit-cache In-Reply-To: <87wmwimto3.fsf@epfl.ch> (Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors's message of "Fri, 22 Sep 2023 11:41:32 +0200") References: <87wmwimto3.fsf@epfl.ch> Date: Fri, 22 Sep 2023 12:01:21 +0200 Message-ID: <875y42msr2.fsf@epfl.ch> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66150 Cc: Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Basil L. Contovounesios [2023-09-22 11:41 +0200] wrote: > Building master, I see the following warning: > > In toplevel form: > files.el:1327:12: Warning: in defcustom for =E2=80=98remote-file-name-i= nhibit-cache=E2=80=99: > duplicated :tag string in =E2=80=98choice=E2=80=99: "Do not use file na= me cache" > > Is the following patch acceptable? > > It tries to improve on the following points: > - Avoid too much negation > - Fix then/than typo > - Avoid mid-sentence %v :format since it extends to eol [...] > If it's acceptable, does it belong on master or emacs-29? Actually, shell-highlight-undef-remote-file-name-inhibit-cache exhibits the same issues, and that was added in 29.1, so perhaps any fix should go to emacs-29? Thanks, --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 22 07:24:34 2023 Received: (at 66150) by debbugs.gnu.org; 22 Sep 2023 11:24:34 +0000 Received: from localhost ([127.0.0.1]:35402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjeGw-0003fm-9r for submit@debbugs.gnu.org; Fri, 22 Sep 2023 07:24:34 -0400 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]:51500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjeGn-0003fF-6j for 66150@debbugs.gnu.org; Fri, 22 Sep 2023 07:24:32 -0400 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2bffd6c1460so31497921fa.3 for <66150@debbugs.gnu.org>; Fri, 22 Sep 2023 04:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695381848; x=1695986648; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=mKLSW1U3y8rA1loIUhxK9uxLld5BIXnyxjdcsMwuV+4=; b=cjWQlN2bJ9CndMVAqoXglFm24dDvyESm6EKVWQVjjaRjXHlKsSSxlyjUEOYfqgquvS YC3zIxO0Js5SQoK5TBJwrTcaOvoO8ZKFd0HK/Kw1/DF1XzrjISo4F2goU0mCw6LIrkFc iWbEjdAM7oPIex6uSeVa27CcA3vaX/XIFk3G2nPuo/oj17ENzk8efcPerGaE+yN2CBVO OToZ2oT3KEUniGrStz9w9iPENf5AotiYsPeLa8YM1WMK/+zIEH3dZM1i2dlB251Q8RYZ 4UOaZcDo9p3WtdbD9NAEHtEYwRZJwe9/BQf6auoudvQbywUOPbufeHsIhwYYjZy+fE2z PXug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695381848; x=1695986648; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mKLSW1U3y8rA1loIUhxK9uxLld5BIXnyxjdcsMwuV+4=; b=EmoBj0aO313bEMEzDkE/0b3iKU6BgQMBJg9BMly7RMHDcuAQ2az1d985Tam2TR9wHz +LX4wktmAOlWgxPJj78yNwoxS9P+qg+qO+UE1/odzwyQnliwH9oCG/QW7GLfeBbxkspD bXjbeuu8p23GBjHpeGrNF/CmuvS/O9ZCXbuSZcasmniB+hMxOtqYAVAAjMEfIi6MYPsz ixsX463Rbn1i9aPOYaJ6dp3kwVdg3GaCR90erC6Oc5diaMd8Kokq1bhF9UkvMCqnUxnX eoVA1yoVjMaMBoYDiFNqXxHpMrJOzA9unt2hs9nrIgJ5mutDfdHpAYCOkaLGqQA5YyL3 euyw== X-Gm-Message-State: AOJu0YwbbLYbzhzD/qS9JvQD368vAZCFYMZ6RFpCtv0rIttDaiuVGDEa gnkhQOYIlW4201u718ePEa+cvyS310uYFaJHSdo= X-Google-Smtp-Source: AGHT+IFGa98i2liFJITrUB5SHpL0jLf3+bs4aNHLnONvUppulAvcIy7UeRhE9OTXv6OfI+sYkr5FdfJe/MSkjm3qvDY= X-Received: by 2002:a2e:8eca:0:b0:2bb:c212:5589 with SMTP id e10-20020a2e8eca000000b002bbc2125589mr6872414ljl.17.1695381848353; Fri, 22 Sep 2023 04:24:08 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 22 Sep 2023 04:24:07 -0700 From: Stefan Kangas In-Reply-To: <87o7hua5nd.fsf@gmx.de> References: <87wmwimto3.fsf@epfl.ch> <87o7hua5nd.fsf@gmx.de> MIME-Version: 1.0 Date: Fri, 22 Sep 2023 04:24:07 -0700 Message-ID: Subject: Re: bug#66150: 30.0.50; Duplicate :tag in remote-file-name-inhibit-cache To: Michael Albinus , "Basil L. Contovounesios" Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66150 Cc: 66150@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Albinus writes: >> If it's acceptable, does it belong on master or emacs-29? > > It changes only user prompts (strings), so I would say emacs-29. Makes sense to me. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 22 07:38:06 2023 Received: (at 66150) by debbugs.gnu.org; 22 Sep 2023 11:38:06 +0000 Received: from localhost ([127.0.0.1]:35446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjeU1-0006i7-6C for submit@debbugs.gnu.org; Fri, 22 Sep 2023 07:38:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjeTt-0006hO-Vj for 66150@debbugs.gnu.org; Fri, 22 Sep 2023 07:38:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjeTd-00075A-75; Fri, 22 Sep 2023 07:37:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=AYtznCzIKPVnqEsDvOMgw6+e2TZfZHW4TL/8QoYsX9U=; b=VOWLjWk4v90Cf6b25DpZ 1eGVz+xWIaPT0cM2z3FupN+Ys3VNPeSM9JNlV19gICOA2RXaboiDB+xnAaZDVjCvMLuLiaL/ZC8cz 4rDurwbuoM22rqiO3uGctY7UAXqW0j4p1hwuqYjwEPnYtx9mkNbJ7RpqN2dMDTKHa0HEFJBR27TZP kwtISlh1S9NIpp4im8Q5W+wWb/SNbHhUOwWVt50RcWURIxdk5/1Dr3qM3fq6azmTlHVla7eL+jxbg KI+GiUQnT93BwGa0i63CjicuW4RtUjB3jUv19pNpakVkL/JDTTsjqTc3Ag9txtekp7mN3OOYF7UM0 Jpcn4MYiX5v1ow==; Date: Fri, 22 Sep 2023 14:37:51 +0300 Message-Id: <83pm2a781c.fsf@gnu.org> From: Eli Zaretskii To: "Basil L. Contovounesios" In-Reply-To: <87wmwimto3.fsf@epfl.ch> (bug-gnu-emacs@gnu.org) Subject: Re: bug#66150: 30.0.50; Duplicate :tag in remote-file-name-inhibit-cache References: <87wmwimto3.fsf@epfl.ch> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66150 Cc: 66150@debbugs.gnu.org, michael.albinus@gmx.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Michael Albinus > Date: Fri, 22 Sep 2023 11:41:32 +0200 > From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Building master, I see the following warning: > > In toplevel form: > files.el:1327:12: Warning: in defcustom for ‘remote-file-name-inhibit-cache’: > duplicated :tag string in ‘choice’: "Do not use file name cache" > > Is the following patch acceptable? With changes, see below. > - (const :tag "Do not inhibit file name cache" nil) > - (const :tag "Do not use file name cache" t) > - (integer :tag "Do not use file name cache" > - :format "Do not use file name cache older then %v seconds" > + (const :tag "Inhibit remote file cache" t) > + (const :tag "Cache remote file attributes" nil) > + (integer :tag "Cache remote file attributes with expiration" > + :format "Cache expiry in seconds: %v" > :value 10))) Let's be consistent. Either (a) the t value should have the tag of "Do not cache remote file attributes", or (b) the nil and the integer values should have the tag "Do not inhibit remote file cache" and "Inhibit file cache if expired", respectively. OK? > If it's acceptable, does it belong on master or emacs-29? emacs-29, please. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 22 09:20:11 2023 Received: (at control) by debbugs.gnu.org; 22 Sep 2023 13:20:11 +0000 Received: from localhost ([127.0.0.1]:35657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjg4c-0006KT-VR for submit@debbugs.gnu.org; Fri, 22 Sep 2023 09:20:11 -0400 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]:45268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjg4Y-0006K6-Nl for control@debbugs.gnu.org; Fri, 22 Sep 2023 09:19:58 -0400 Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-99357737980so265732166b.2 for ; Fri, 22 Sep 2023 06:19:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1695388778; x=1695993578; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=y6myA3SREu5qL57BubtdbxtQzwXugoKcePoXjiiVQWg=; b=dvteq+3ALYBMDBVinfmmLfeuKMiw1w1ezf3d/8PFgcM1jiRs/ygMXQv/R+hDp96iAR MsOvt8CeGofDmXYmSTQ2X5Q0cQPPPIdMRD0pyd50w/+B2CJwFWDCk5hYf3Ok9nmDsToz 5n2Td7abEGFgblB8VGKyXGp00ck0HrSFvG664M+pgPLFu6HF/MrMuV/Aqv3zAFW4YsSd SHPHn4jcUfc9HOIQaCbYQNh0xL25Sao6s6lL7pb3c7CrUhAVQLNoQ4+7oluPwxeqg+Rl 4lO0oDXuSuBF7IB3Zjqz2+yLncvdD3AggLFPanZR4bp3aksgMhIvEWUIgLIt1HCHY22O BoYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695388778; x=1695993578; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y6myA3SREu5qL57BubtdbxtQzwXugoKcePoXjiiVQWg=; b=kBTJJfieVCuS1wKwwoQNku4nuVOn1Mw+vKmjNkAtRUfDlY23Mjc9UvMdJSekrhqQbq A5t2vZqjDSTS4uKF4P8FFQYMlAnKwljdqkW5SQqdB4tjI39xbxvnfz7uwoq4NH2XWR1Q PgcHaZSPGzwwozv3t+ErycldZkC9t3iPk3+5eYav3dtI/u9fg2VQ7tt+1Aftq2mHyHkB abWOw8rkzH44gzS82Q3fO2lBEXhIi79i4ct7fGGoU97PFSuAdKXFvQ1en3XpY3pd9pDl dzimVfI71Ee+le+guvccUdSPVAo1r/v/x5ymZqIcfnV0+xPOzq7NAxVvms5bqqO6Ik1o aKZA== X-Gm-Message-State: AOJu0Yx7CKo8kSs9xRhsFAuO5qTW5dqhzzh0OsGTD68JLxXe9hYs+umV ZMunuXPAJk6eeFQnDjWr5ZUwAg== X-Google-Smtp-Source: AGHT+IFP4KH/flTfYUtf9b7sh0AXio0gq4+IfPs+pvaNepdBFOmusbYa1i+4QK5NxmOr0eeOexwGqA== X-Received: by 2002:a17:907:1df0:b0:9ae:57b8:ad1a with SMTP id og48-20020a1709071df000b009ae57b8ad1amr4851738ejc.29.1695388777811; Fri, 22 Sep 2023 06:19:37 -0700 (PDT) Received: from localhost (vpn-253-147.epfl.ch. [128.179.253.147]) by smtp.gmail.com with ESMTPSA id f12-20020a1709062c4c00b0099ca4f61a8bsm2732989ejh.92.2023.09.22.06.19.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 06:19:37 -0700 (PDT) From: "Basil L. Contovounesios" To: Eli Zaretskii Subject: Re: bug#66150: 30.0.50; Duplicate :tag in remote-file-name-inhibit-cache In-Reply-To: <83pm2a781c.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 22 Sep 2023 14:37:51 +0300") References: <87wmwimto3.fsf@epfl.ch> <83pm2a781c.fsf@gnu.org> Date: Fri, 22 Sep 2023 15:19:35 +0200 Message-ID: <87jzsiuyzc.fsf@epfl.ch> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: 66150-done@debbugs.gnu.org, michael.albinus@gmx.de, =?utf-8?Q?Miha_Rihtar=C5=A1i=C4=8D?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 66150 29.1 quit Eli Zaretskii [2023-09-22 14:37 +0300] wrote: >> Cc: Michael Albinus >> Date: Fri, 22 Sep 2023 11:41:32 +0200 >> From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> - (const :tag "Do not inhibit file name cache" nil) >> - (const :tag "Do not use file name cache" t) >> - (integer :tag "Do not use file name cache" >> - :format "Do not use file name cache older then %v seconds" >> + (const :tag "Inhibit remote file cache" t) >> + (const :tag "Cache remote file attributes" nil) >> + (integer :tag "Cache remote file attributes with expiration" >> + :format "Cache expiry in seconds: %v" >> :value 10))) > > Let's be consistent. Either (a) the t value should have the tag of > "Do not cache remote file attributes", or (b) the nil and the integer > values should have the tag "Do not inhibit remote file cache" and > "Inhibit file cache if expired", respectively. OK? Of course, thanks. I went with option (a) for both remote-file-name-inhibit-cache and shell-highlight-undef-remote-file-name-inhibit-cache. Installed on emacs-29, and closing. Improve remote-file-name-inhibit-cache :type e27ec0e4144 2023-09-22 15:15:36 +0200 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=e27ec0e4144 -- Basil From unknown Sat Jun 21 03:15:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 21 Oct 2023 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator