GNU bug report logs - #66144
29.1; eglot-shutdown request params violate JSONRPC spec

Previous Next

Package: emacs;

Reported by: Aaron Zeng <azeng <at> janestreet.com>

Date: Thu, 21 Sep 2023 21:00:01 UTC

Severity: normal

Found in version 29.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: João Távora <joaotavora <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Javier Olaechea <pirata <at> gmail.com>, 66144 <at> debbugs.gnu.org
Subject: bug#66144: 29.1; eglot-shutdown request params violate JSONRPC
Date: Sat, 14 Oct 2023 09:59:46 +0100

[Message part 1 (text/plain, inline)]
On Sat, Oct 14, 2023, 09:14 Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Javier Olaechea <pirata <at> gmail.com>
> > Date: Sat, 7 Oct 2023 22:42:47 -0500
> >
> > It seems that eglot used to send an empty object as the params but it
> got replaced by null to appease
> > gopls.
> >
> >
> https://github.com/joaotavora/eglot/commit/4f6e152e1c5efc39a888f747ecca313a58f4375e
> >
> > The fix would be replacing the call
> > (jsonrpc-request server :shutdown nil :timeout (or timeout 1.5))
> > with
> > (jsonrpc-request server :shutdown eglot--{} :timeout (or timeout 1.5))
>
> João, any comments?
>

Yes. What's the matter? What would the "fix" fix?

>

[Message part 2 (text/html, inline)]
This bug report was last modified 166 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.