GNU bug report logs - #66143
[PATCH]: Update emacs-slime and sbcl-slime-swank to 2.28-0.1e4b741

Previous Next

Full log

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: André A. Gomes <andremegafone <at> gmail.com>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 66143 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#66143] [PATCH]: Update emacs-slime and sbcl-slime-swank to
 2.28-0.1e4b741
Date: Tue, 26 Sep 2023 12:16:05 +0300

Christopher Baines <mail <at> cbaines.net> writes:

> It seems like you've attached two patches? It's useful to just send one
> patch per email, as lots of tooling expects that.

I'm more used to sending patches as email attachments, instead of using
git-send-email.  If Guix requires the latter then I'll adjust, but I've
been sending plenty of patches following the former approach.

> Looking at the first patch though, packaging anything but the latest
> release shouldn't be the norm [1].
>
> 1: https://guix.gnu.org/manual/en/guix.html#index-version-number_002c-for-VCS-snapshots
>
> You need to put the reasoning for updating these packages to these
> specific commits in to some comments. Depending on that justification as
> well, we need to decide whether to ship these versions in addition to
> the latest releases, or as you're doing currently to replace the latest
> releases with these snapshots.
>
> What approach to take depends on the justification, e.g. if the latest
> release is unusable or using it could be problematic, then replacing it
> with a snapshot seems better, otherwise, we should create package
> variants (e.g. emacs-slime-next) for these snapshots.

It makes no sense to have emacs-slime-next and cl-slime-swank-next.
I've bumped it because significant changes have been introduced since
the last tagged released.

In the meantime, I've kindly request a tagged release upstream.  Whether
I'll get a reply soon remains to be seen.

https://github.com/slime/slime/issues/792

With all respect to your work, Christopher Baines, I'd kindly suggest a
review by the Common Lisp team - Guillaume Le Vaillant, who has been
reviewing most of my patches lately.

Thanks!


-- 
André A. Gomes
"You cannot even find the ruins..."

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.