GNU bug report logs - #6613
23.2; bogus let bound var in gnus-delay.el

Previous Next

Packages: emacs, gnus;

Reported by: Leo <sdl.web <at> gmail.com>

Date: Sun, 11 Jul 2010 21:08:01 UTC

Severity: minor

Found in version 23.2

Done: Lars Magne Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6613 in the body.
You can then email your comments to 6613 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6613; Package emacs. (Sun, 11 Jul 2010 21:08:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Leo <sdl.web <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 11 Jul 2010 21:08:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.2; bogus let bound var in gnus-delay.el
Date: Sun, 11 Jul 2010 22:07:04 +0100

In the function `gnus-delay-article' in gnus-delay.el,

  (let ((group (format "nndraft:%s" gnus-delay-group)))
      (gnus-agent-queue-setup gnus-delay-group))

The let-bound var `group' is not used and in fact gnus-agent-queue-setup
takes care of formatting the group name already. So I think it should be
simplified to

  (gnus-agent-queue-setup gnus-delay-group)

Leo
Reply sent to Lars Magne Ingebrigtsen <larsi <at> gnus.org>:
You have taken responsibility. (Mon, 18 Oct 2010 20:45:02 GMT) Full text and rfc822 format available.
Notification sent to Leo <sdl.web <at> gmail.com>:
bug acknowledged by developer. (Mon, 18 Oct 2010 20:45:03 GMT) Full text and rfc822 format available.

Message #10 received at 6613-close <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Leo <sdl.web <at> gmail.com>
Cc: 6613-close <at> debbugs.gnu.org
Subject: Re: 23.2; bogus let bound var in gnus-delay.el
Date: Mon, 18 Oct 2010 22:48:19 +0200

Leo <sdl.web <at> gmail.com> writes:

> In the function `gnus-delay-article' in gnus-delay.el,
>
>   (let ((group (format "nndraft:%s" gnus-delay-group)))
>       (gnus-agent-queue-setup gnus-delay-group))
>
> The let-bound var `group' is not used and in fact gnus-agent-queue-setup
> takes care of formatting the group name already. So I think it should be
> simplified to
>
>   (gnus-agent-queue-setup gnus-delay-group)

This has now been fixed in git Gnus.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi <at> gnus.org * Lars Magne Ingebrigtsen
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 16 Nov 2010 12:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 14 years and 297 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.