GNU bug report logs - #66125
29.1; configure --with-small-ja-dic has no effect

Previous Next

Package: emacs;

Reported by: Ulrich Mueller <ulm <at> gentoo.org>

Date: Wed, 20 Sep 2023 16:17:01 UTC

Severity: normal

Found in version 29.1

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #43 received at 66125-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ulrich Mueller <ulm <at> gentoo.org>
Cc: 66125-done <at> debbugs.gnu.org
Subject: Re: bug#66125: 29.1; configure --with-small-ja-dic has no effect
Date: Sun, 24 Sep 2023 15:33:41 +0300
> From: Ulrich Mueller <ulm <at> gentoo.org>
> Cc: 66125 <at> debbugs.gnu.org
> Date: Sat, 23 Sep 2023 23:29:33 +0200
> 
> >>>>> On Sat, 23 Sep 2023, Eli Zaretskii wrote:
> 
> >> > (The "if test" part of the new target's rules could be updated to
> >> > check that the small-ja-dic-option file exists, and generate a
> >> > non-empty file if not.)
> >> 
> >> IMHO this would be cleaner.
> 
> > Can you try that and see if there are no other issues?
> 
> I did some tests and ended up replacing the small-ja-dic-option recipe
> in leim/Makefile.in with something very simple:
> 
> # This is used to support regeneration of ja-dic when the SMALL_JA_DIC
> # option is flipped by the configure-time option.
> small-ja-dic-option: ../config.status
> 	$(AM_V_GEN)echo "small ja-dic option: $(SMALL_JA_DIC)" > $@.$$$$ && \
> 	${top_srcdir}/build-aux/move-if-change $@.$$$$ $@
> 
> AFAICS this does what is intended, i.e. the detour via recording the
> option in ja-dic.el isn't even needed.

Thanks, I went with your suggestion in leim/Makefile.in.  But I kept
the recording of the value in ja-dic.el, as I think it's a good idea
nonetheless, for future investigations of possible issues.

And with that, I'm closing the bug.




This bug report was last modified 1 year and 244 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.