GNU bug report logs - #66117
30.0.50; `find-buffer-visiting' is slow when opening large number of buffers

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ihor Radchenko <yantar92 <at> posteo.net>
Cc: dmitry <at> gutov.dev, 66117 <at> debbugs.gnu.org, mattias.engdegard <at> gmail.com, monnier <at> iro.umontreal.ca
Subject: bug#66117: 30.0.50; `find-buffer-visiting' is slow when opening large number of buffers
Date: Sun, 17 Dec 2023 12:36:59 +0200

> From: Ihor Radchenko <yantar92 <at> posteo.net>
> Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, dmitry <at> gutov.dev,
>  66117 <at> debbugs.gnu.org, mattias.engdegard <at> gmail.com
> Date: Sun, 17 Dec 2023 10:31:50 +0000
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> AFAIK this is a purely internal change with no visible effect at the
> >> ELisp level
> 
> > It sounds like there will be some effect on some Lisp programs, at
> > least in some cases, and if so, we should mention those cases, even if
> > we think they are rare.
> 
> We have discussed a number of approaches to handle the let-binding
> performance and to handle sometimes-confusing behaviour of
> `case-fold-search'. Most of them had problems with breaking the existing
> behaviour or potentially causing unexpected side effects. Except the one
> I used in the patch.
> 
> The messages you linked to discuss problems with _other_ proposed
> approaches.

Maybe I'm confused, but won't this change have at least _some_ effect
on Lisp programs?  For example, what about this fragment from the
ELisp manual, which describes the effect of
make-variable-buffer-local:

     A peculiar wrinkle of this feature is that binding the variable
     (with ‘let’ or other binding constructs) does not create a
     buffer-local binding for it.  Only setting the variable (with ‘set’
     or ‘setq’), while the variable does not have a ‘let’-style binding
     that was made in the current buffer, does so.

Will this case work the same after the change as it did before?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.