From unknown Wed Jun 18 23:04:43 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#66115 <66115@debbugs.gnu.org> To: bug#66115 <66115@debbugs.gnu.org> Subject: Status: [PATCH] Ensure that directory is expanded in package-vc-checkout Reply-To: bug#66115 <66115@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:04:43 +0000 retitle 66115 [PATCH] Ensure that directory is expanded in package-vc-check= out reassign 66115 emacs submitter 66115 Joseph Turner severity 66115 normal tag 66115 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 20 03:16:18 2023 Received: (at submit) by debbugs.gnu.org; 20 Sep 2023 07:16:18 +0000 Received: from localhost ([127.0.0.1]:58184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qirRa-0002f6-Ed for submit@debbugs.gnu.org; Wed, 20 Sep 2023 03:16:18 -0400 Received: from lists.gnu.org ([2001:470:142::17]:48330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qirRY-0002eo-Er for submit@debbugs.gnu.org; Wed, 20 Sep 2023 03:16:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qirRJ-0006SY-Hv for bug-gnu-emacs@gnu.org; Wed, 20 Sep 2023 03:16:01 -0400 Received: from out-219.mta0.migadu.com ([91.218.175.219]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qirRD-0000xF-SY for bug-gnu-emacs@gnu.org; Wed, 20 Sep 2023 03:16:00 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1695194151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=C+T3WKBlfjVgzrdBzJ0rANBE1GU3UcBxm40cyIZ13UA=; b=LfvRqeGIUivU1HqVPFqYsgFew20warlfzUKbqOd1EbKArOFJnPTmnNzylMrs6QhkVB3AQz aAPwjRMp4WPNdr+2xGVCaiThuqBeBrFv9TBc4l/TiiKzh4StvuG9BDpuA9yStulmFsn132 ZO9hACVlg9aIDuJw+CxAcxqZlCmrg5U= From: Joseph Turner To: bug-gnu-emacs@gnu.org Subject: [PATCH] Ensure that directory is expanded in package-vc-checkout Date: Wed, 20 Sep 2023 00:14:02 -0700 X-Debbugs-CC: Philip Kaludercic Message-ID: <87a5thfh7i.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=91.218.175.219; envelope-from=joseph@breatheoutbreathe.in; helo=out-219.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Tags: patch Tags: patch This patch fixes a serious bug which caused package-vc-checkout to fail entirely when its second argument `directory' was not expanded. --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Ensure-that-directory-is-expanded-in-package-vc-chec.patch >From 75a6ec74ff5e31edc7592b68e7ad9d1ec26f515c Mon Sep 17 00:00:00 2001 From: Joseph Turner Date: Wed, 20 Sep 2023 00:12:10 -0700 Subject: [PATCH] Ensure that directory is expanded in package-vc-checkout * lisp/emacs-lisp/package-vc.el (package-vc-checkout) --- lisp/emacs-lisp/package-vc.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index 29b540d86b8..47d8c996ff0 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -834,6 +834,7 @@ for the last released version of the package." (setf dir subdir) (user-error "Directory not empty: %S" (expand-file-name dir))))) (list desc dir (and current-prefix-arg :last-release)))) + (setf directory (expand-file-name directory)) (package-vc--archives-initialize) (let ((pkg-spec (or (package-vc--desc->spec pkg-desc) (and-let* ((extras (package-desc-extras pkg-desc)) -- 2.41.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 22 04:18:06 2023 Received: (at 66115) by debbugs.gnu.org; 22 Sep 2023 08:18:06 +0000 Received: from localhost ([127.0.0.1]:35252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjbMU-0001oD-GD for submit@debbugs.gnu.org; Fri, 22 Sep 2023 04:18:06 -0400 Received: from mout02.posteo.de ([185.67.36.66]:38863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjbMR-0001nh-Uz for 66115@debbugs.gnu.org; Fri, 22 Sep 2023 04:18:05 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 46914240101 for <66115@debbugs.gnu.org>; Fri, 22 Sep 2023 10:17:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1695370667; bh=h2CmNmGcUALdirATzLHeIfR0YmeG/6rA8Bmn4rzPrJM=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=YMlmspT6Y22Ox+5NvNBM5xqEtANZdDtmNfcfeyBg1uiE3AmVC+NH3goQfOVjBKXWI E5/Z0QsRtEkBMrcUX+Wboutc6R44Ah+4fuQDwSOt5TToqKgvD1rtiNtbx1ryIWr4uR NM/noeP8/LYOH5POIeC/lEvLDhJ2++Nu37fS/y/60NmSKeyGpk0PAIWdzseJXgEE4X LmviBD+MRvxfYE1ngtbyXqcxgGFC89EgWGFC8yzxX09IKqg/Ls7FkNFYm7GDFRoT+1 TMOdYQ/wKHfV88sXU9JBU+JF9qCdPd921Cy8h4dBoaF8CDx7S4WjrXArg8OA0k/kFf I3RwDzg9fEHsw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RsQB25Bd5z9rxN; Fri, 22 Sep 2023 10:17:46 +0200 (CEST) From: Philip Kaludercic To: Joseph Turner Subject: Re: bug#66115: [PATCH] Ensure that directory is expanded in package-vc-checkout In-Reply-To: <87a5thfh7i.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Wed, 20 Sep 2023 00:14:02 -0700") References: <87a5thfh7i.fsf@breatheoutbreathe.in> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Fri, 22 Sep 2023 08:17:46 +0000 Message-ID: <87lecyvcyd.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66115 Cc: 66115@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Joseph Turner writes: > Tags: patch > > Tags: patch > > This patch fixes a serious bug which caused package-vc-checkout to fail > entirely when its second argument `directory' was not expanded. > > From 75a6ec74ff5e31edc7592b68e7ad9d1ec26f515c Mon Sep 17 00:00:00 2001 > From: Joseph Turner > Date: Wed, 20 Sep 2023 00:12:10 -0700 > Subject: [PATCH] Ensure that directory is expanded in package-vc-checkout > > * lisp/emacs-lisp/package-vc.el (package-vc-checkout) > --- > lisp/emacs-lisp/package-vc.el | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el > index 29b540d86b8..47d8c996ff0 100644 > --- a/lisp/emacs-lisp/package-vc.el > +++ b/lisp/emacs-lisp/package-vc.el > @@ -834,6 +834,7 @@ for the last released version of the package." > (setf dir subdir) > (user-error "Directory not empty: %S" (expand-file-name dir))))) > (list desc dir (and current-prefix-arg :last-release)))) > + (setf directory (expand-file-name directory)) > (package-vc--archives-initialize) > (let ((pkg-spec (or (package-vc--desc->spec pkg-desc) > (and-let* ((extras (package-desc-extras pkg-desc)) DIRECTORY is passed on to `package-vc--clone' and in turn `vc-clone'. Wouldn't it be more robust to ensure that `vc-clone' can handle unexpanded directory names, eg. like this: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 2f4b028bb4a..7f334397a5e 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -3676,8 +3676,7 @@ vc-clone checkout. If BACKEND is nil, iterate through every known backend in `vc-handled-backends' until one succeeds. If REV is non-nil, it indicates a specific revision to check out." - (unless directory - (setq directory default-directory)) + (setq directory (expand-file-name (or directory default-directory))) (if backend (progn (unless (memq backend vc-handled-backends) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 22 04:34:19 2023 Received: (at 66115) by debbugs.gnu.org; 22 Sep 2023 08:34:19 +0000 Received: from localhost ([127.0.0.1]:35286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjbcB-0002Fa-3i for submit@debbugs.gnu.org; Fri, 22 Sep 2023 04:34:19 -0400 Received: from out-218.mta0.migadu.com ([2001:41d0:1004:224b::da]:41432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjbc7-0002FM-HW for 66115@debbugs.gnu.org; Fri, 22 Sep 2023 04:34:18 -0400 References: <87a5thfh7i.fsf@breatheoutbreathe.in> <87lecyvcyd.fsf@posteo.net> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1695371641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YezTbSQzqzXGucaqGRpod2SEdOcM4hTiVMw0u83QpUU=; b=IaojodDdbQFFRfCjD8TNr1qmW28piy7eNjw+0V8YtgnfeZnOTqPkiRX6Dv7B3PCJExM2T9 yQhU7fcijhibHIH96e0Ck2jibxeH/z2v23IP9ihP99b+TDD6VrCaAcMi70nO3XEYgR/gw6 xGEEqIh8aeMUTUH/d8Ki4JqZS4Thl7w= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Joseph Turner To: Philip Kaludercic Subject: Re: bug#66115: [PATCH] Ensure that directory is expanded in package-vc-checkout Date: Fri, 22 Sep 2023 01:33:45 -0700 In-reply-to: <87lecyvcyd.fsf@posteo.net> Message-ID: <871qeqppxm.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66115 Cc: 66115@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Philip Kaludercic writes: > Joseph Turner writes: > >> Tags: patch >> >> Tags: patch >> >> This patch fixes a serious bug which caused package-vc-checkout to fail >> entirely when its second argument `directory' was not expanded. >> >> From 75a6ec74ff5e31edc7592b68e7ad9d1ec26f515c Mon Sep 17 00:00:00 2001 >> From: Joseph Turner >> Date: Wed, 20 Sep 2023 00:12:10 -0700 >> Subject: [PATCH] Ensure that directory is expanded in package-vc-checkout >> >> * lisp/emacs-lisp/package-vc.el (package-vc-checkout) >> --- >> lisp/emacs-lisp/package-vc.el | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el >> index 29b540d86b8..47d8c996ff0 100644 >> --- a/lisp/emacs-lisp/package-vc.el >> +++ b/lisp/emacs-lisp/package-vc.el >> @@ -834,6 +834,7 @@ for the last released version of the package." >> (setf dir subdir) >> (user-error "Directory not empty: %S" (expand-file-name dir))))) >> (list desc dir (and current-prefix-arg :last-release)))) >> + (setf directory (expand-file-name directory)) >> (package-vc--archives-initialize) >> (let ((pkg-spec (or (package-vc--desc->spec pkg-desc) >> (and-let* ((extras (package-desc-extras pkg-desc)) > > DIRECTORY is passed on to `package-vc--clone' and in turn `vc-clone'. > Wouldn't it be more robust to ensure that `vc-clone' can handle > unexpanded directory names, eg. like this: > > diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el > index 2f4b028bb4a..7f334397a5e 100644 > --- a/lisp/vc/vc.el > +++ b/lisp/vc/vc.el > @@ -3676,8 +3676,7 @@ vc-clone > checkout. If BACKEND is nil, iterate through every known backend > in `vc-handled-backends' until one succeeds. If REV is non-nil, > it indicates a specific revision to check out." > - (unless directory > - (setq directory default-directory)) > + (setq directory (expand-file-name (or directory default-directory))) > (if backend > (progn > (unless (memq backend vc-handled-backends) Yes, certainly. Your solution is better. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 22 06:51:36 2023 Received: (at 66115-done) by debbugs.gnu.org; 22 Sep 2023 10:51:36 +0000 Received: from localhost ([127.0.0.1]:35362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjdl2-0002rF-Bh for submit@debbugs.gnu.org; Fri, 22 Sep 2023 06:51:36 -0400 Received: from mout02.posteo.de ([185.67.36.66]:58719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjdkw-0002qw-QF for 66115-done@debbugs.gnu.org; Fri, 22 Sep 2023 06:51:34 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 5204A240104 for <66115-done@debbugs.gnu.org>; Fri, 22 Sep 2023 12:51:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1695379874; bh=feQ8uJiXM6ty0jdbZjtelvFVPKxLcjwkPTOWSJaL35s=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=QsqpC5gwgO2HUThQ27YsSb/0qH7iYY3kT7E7V27qvqIiL6T0zOajEM7ht7fv3y7sV uoFSq3vu78mshA02+etMpYZmItsSyKN3P1RZi+WuqcDbsiqGlfTltaitBimp9ZaTWp pM1SLaON8mdHQACU/czLHc5heVS25ClMpreIVtGo4kZ8Atj0jcWB1SoriU2MylPDqF oz/ac4ubsgVACDWkNKtz+NNd0wqK3UAhoj5cHgVIMKi19JZItVrJySdP4dWs6srrBS T9SpgO9/y22Xbbvsoi8aDWNtJ5BpwU+5nlDbG607/c0z6iQTtD2ektNZUmN0gVi6+S q2AhBfmwtf8Uw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RsTb5555dz9rxM; Fri, 22 Sep 2023 12:51:13 +0200 (CEST) From: Philip Kaludercic To: Joseph Turner Subject: Re: bug#66115: [PATCH] Ensure that directory is expanded in package-vc-checkout In-Reply-To: <871qeqppxm.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Fri, 22 Sep 2023 01:33:45 -0700") References: <87a5thfh7i.fsf@breatheoutbreathe.in> <87lecyvcyd.fsf@posteo.net> <871qeqppxm.fsf@breatheoutbreathe.in> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Fri, 22 Sep 2023 10:51:13 +0000 Message-ID: <875y42v5um.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66115-done Cc: 66115-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Joseph Turner writes: > Philip Kaludercic writes: > >> Joseph Turner writes: >> >>> Tags: patch >>> >>> Tags: patch >>> >>> This patch fixes a serious bug which caused package-vc-checkout to fail >>> entirely when its second argument `directory' was not expanded. >>> >>> From 75a6ec74ff5e31edc7592b68e7ad9d1ec26f515c Mon Sep 17 00:00:00 2001 >>> From: Joseph Turner >>> Date: Wed, 20 Sep 2023 00:12:10 -0700 >>> Subject: [PATCH] Ensure that directory is expanded in package-vc-checkout >>> >>> * lisp/emacs-lisp/package-vc.el (package-vc-checkout) >>> --- >>> lisp/emacs-lisp/package-vc.el | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el >>> index 29b540d86b8..47d8c996ff0 100644 >>> --- a/lisp/emacs-lisp/package-vc.el >>> +++ b/lisp/emacs-lisp/package-vc.el >>> @@ -834,6 +834,7 @@ for the last released version of the package." >>> (setf dir subdir) >>> (user-error "Directory not empty: %S" (expand-file-name dir))))) >>> (list desc dir (and current-prefix-arg :last-release)))) >>> + (setf directory (expand-file-name directory)) >>> (package-vc--archives-initialize) >>> (let ((pkg-spec (or (package-vc--desc->spec pkg-desc) >>> (and-let* ((extras (package-desc-extras pkg-desc)) >> >> DIRECTORY is passed on to `package-vc--clone' and in turn `vc-clone'. >> Wouldn't it be more robust to ensure that `vc-clone' can handle >> unexpanded directory names, eg. like this: >> >> diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el >> index 2f4b028bb4a..7f334397a5e 100644 >> --- a/lisp/vc/vc.el >> +++ b/lisp/vc/vc.el >> @@ -3676,8 +3676,7 @@ vc-clone >> checkout. If BACKEND is nil, iterate through every known backend >> in `vc-handled-backends' until one succeeds. If REV is non-nil, >> it indicates a specific revision to check out." >> - (unless directory >> - (setq directory default-directory)) >> + (setq directory (expand-file-name (or directory default-directory))) >> (if backend >> (progn >> (unless (memq backend vc-handled-backends) > > Yes, certainly. Your solution is better. OK, closing the issue. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 24 01:35:42 2023 Received: (at 66115-done) by debbugs.gnu.org; 24 Sep 2023 05:35:42 +0000 Received: from localhost ([127.0.0.1]:40892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkHmP-0002bC-UG for submit@debbugs.gnu.org; Sun, 24 Sep 2023 01:35:42 -0400 Received: from out-206.mta0.migadu.com ([2001:41d0:1004:224b::ce]:42021) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkHmN-0002b1-Nl for 66115-done@debbugs.gnu.org; Sun, 24 Sep 2023 01:35:41 -0400 References: <87a5thfh7i.fsf@breatheoutbreathe.in> <87lecyvcyd.fsf@posteo.net> <871qeqppxm.fsf@breatheoutbreathe.in> <875y42v5um.fsf@posteo.net> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1695533726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q4ucI8i17UnorFWSW5K3NZcNyJ9GrJQshCTUHKbTcA4=; b=frjzKgAuWo24BMzsbXGyuRNxGuUCSRmaAbYen+O1xNsSNj6ApYLwBNKpx9JUpraKhvc4Zc 1FH0shLZ1EWxtvOdt2sw4wRkLbqC48wXSpXVVfhjlUMopuqEw0rcp5/daE5fwKGdh2LoRJ auSyWSZvbF2C92KsLdaLiqOK116fMtM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Joseph Turner To: Philip Kaludercic Subject: Re: bug#66115: [PATCH] Ensure that directory is expanded in package-vc-checkout Date: Sat, 23 Sep 2023 22:34:24 -0700 In-reply-to: <875y42v5um.fsf@posteo.net> Message-ID: <877cogp205.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66115-done Cc: 66115-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) It appears that the fix was applied to master. Would it make sense to apply it to emacs-29? From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 24 02:55:29 2023 Received: (at 66115) by debbugs.gnu.org; 24 Sep 2023 06:55:29 +0000 Received: from localhost ([127.0.0.1]:40918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkJ1d-0004xV-2C for submit@debbugs.gnu.org; Sun, 24 Sep 2023 02:55:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkJ1X-0004xC-Jt for 66115@debbugs.gnu.org; Sun, 24 Sep 2023 02:55:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkJ1G-0007nA-90; Sun, 24 Sep 2023 02:55:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2dKWLGnVHTxMIamOMOgaF89Kge7wiNAa1wxEHKsmZB4=; b=B+uoZw+u+cvX 6fWkzJSV6DaSbIzw+vHsVCtWsFo88mIY4HBy7gNKqBI0xk9kT/MojYA0NwWTQcALLeo9eUIxfoGhg cDXOl24nvYtPIylwLYVMjonqEQoHRPWM1ZOaSMrn7n1S+xd4QWq4QyUcVgVmxAkX5QYoRXo330Smp hvvSgyKmZqMP59Z9V3KPmZmEcGScCf2G2EhJnLgNRlCC7t+6DimyKUiYQFVWBMz6O7BMUW1VLEPzl Pyg4PXF4i8dES0WeIMjYKXudK3Qp1eMXkgoXLUCL2tlZnNHYS2FB+ec+Jr3M9NbabRJgriy28aEnp sE6AMtxSvj2j5XlBlyU7fQ==; Date: Sun, 24 Sep 2023 09:54:38 +0300 Message-Id: <834jjk3vtd.fsf@gnu.org> From: Eli Zaretskii To: Joseph Turner In-Reply-To: <877cogp205.fsf@breatheoutbreathe.in> (bug-gnu-emacs@gnu.org) Subject: Re: bug#66115: [PATCH] Ensure that directory is expanded in package-vc-checkout References: <87a5thfh7i.fsf@breatheoutbreathe.in> <87lecyvcyd.fsf@posteo.net> <871qeqppxm.fsf@breatheoutbreathe.in> <875y42v5um.fsf@posteo.net> <877cogp205.fsf@breatheoutbreathe.in> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66115 Cc: 66115@debbugs.gnu.org, philipk@posteo.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 66115-done@debbugs.gnu.org > Date: Sat, 23 Sep 2023 22:34:24 -0700 > From: Joseph Turner via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > It appears that the fix was applied to master. Would it make sense to > apply it to emacs-29? The installed change affects much more than the original issue, so I'd prefer for it to stay on master. I'm okay with installing the original patch on emacs-29, but be sure to say "do not merge to master" in the commit log message if you do. From unknown Wed Jun 18 23:04:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 22 Oct 2023 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 12 17:00:28 2023 Received: (at control) by debbugs.gnu.org; 12 Nov 2023 22:00:28 +0000 Received: from localhost ([127.0.0.1]:57187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2IVH-000365-S3 for submit@debbugs.gnu.org; Sun, 12 Nov 2023 17:00:28 -0500 Received: from out-185.mta1.migadu.com ([2001:41d0:203:375::b9]:19733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2IVC-00035t-VQ for control@debbugs.gnu.org; Sun, 12 Nov 2023 17:00:26 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1699826380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=HMVL43aUjpdEi4qz6Hp0+uwFKN9K8TvRfkcS93jWOPg=; b=hYve8S0Icgzv82KlAVRNjvWMOzdhgGTS4ov/YXfHl02B61WYb3YMJ6hCCWhTy36YyMFO65 E3Kfv2mwk93aeTWeyP9Qm0j/BGRVMtufRsEJN52+0Np0qMWB4jravq4MEP/bKRdl9kbzMw OUkKgqNnYlYtsI70w4P1TYliY5xdOhI= From: Joseph Turner To: control@debbugs.gnu.org Subject: unarchive 66115 Date: Sun, 12 Nov 2023 13:59:29 -0800 Message-ID: <874jhqocon.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) unarchive 66115 From unknown Wed Jun 18 23:04:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Did not alter fixed versions and reopened. Date: Sun, 12 Nov 2023 22:02:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # Did not alter fixed versions and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 16 01:44:20 2023 Received: (at 66115) by debbugs.gnu.org; 16 Nov 2023 06:44:20 +0000 Received: from localhost ([127.0.0.1]:54345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3W6t-0000Kw-Km for submit@debbugs.gnu.org; Thu, 16 Nov 2023 01:44:19 -0500 Received: from mout02.posteo.de ([185.67.36.66]:55823) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3W6o-0000Kd-So for 66115@debbugs.gnu.org; Thu, 16 Nov 2023 01:44:17 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 2ECE3240101 for <66115@debbugs.gnu.org>; Thu, 16 Nov 2023 07:44:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1700117049; bh=IG/tv9/Fv0umKOlk9K5/KkX+WCFmu7onOMubwbKZ8oE=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=DZDTbg8NS1+01jV/i/icm1nFqtvgIJoyeGURHr9WUxbagxJIVqWOTv20Di5F5/7v2 3tIcSjcCwAGr5KLMUBMjadKWpO/DoAUt784VBGNFBL3yWCQIE8+fxQGhbW3C4ZwXT8 22fCJmgCKBhae7Z4JWdHZ91G/TB3fEhqGGrFf9PGYAAb3Mpell/UoKApDbAnecOpko sjt9wYrNMrAs3b2ONernwe8oGfFKjLts1no84SoxpkMl88IyL6kL0y9KiMw5XTSr+s Tlj06usBmTB8lrcSmv1bfUaZHY9z0pHsMjJ9xTRatg2MIAV9e4Z4FT7G6g4u4Ug+hw P8dawqJexZtjQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SW9Vc3X9xz6ty6; Thu, 16 Nov 2023 07:44:08 +0100 (CET) From: Philip Kaludercic To: Joseph Turner Subject: Re: bug#66115: [PATCH] Ensure that directory is expanded in package-vc-checkout In-Reply-To: <87msviogui.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Sun, 12 Nov 2023 12:29:12 -0800") References: <87a5thfh7i.fsf@breatheoutbreathe.in> <87lecyvcyd.fsf@posteo.net> <871qeqppxm.fsf@breatheoutbreathe.in> <875y42v5um.fsf@posteo.net> <877cogp205.fsf@breatheoutbreathe.in> <834jjk3vtd.fsf@gnu.org> <87msviogui.fsf@breatheoutbreathe.in> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Thu, 16 Nov 2023 06:44:07 +0000 Message-ID: <87y1ey9ozs.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66115 Cc: 66115@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Joseph Turner writes: > Eli Zaretskii writes: > >>> Cc: 66115-done@debbugs.gnu.org >>> Date: Sat, 23 Sep 2023 22:34:24 -0700 >>> From: Joseph Turner via "Bug reports for GNU Emacs, >>> the Swiss army knife of text editors" >>> >>> It appears that the fix was applied to master. Would it make sense to >>> apply it to emacs-29? >> >> The installed change affects much more than the original issue, so I'd >> prefer for it to stay on master. >> >> I'm okay with installing the original patch on emacs-29, but be sure >> to say "do not merge to master" in the commit log message if you do. > > Philip, shall we merge the original patch on emacs-29 with "do not merge > to master"? I don't object. > Thank you!! > > Joseph From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 19 17:18:24 2023 Received: (at 66115) by debbugs.gnu.org; 19 Nov 2023 22:18:24 +0000 Received: from localhost ([127.0.0.1]:52226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4q7T-0000Q5-Im for submit@debbugs.gnu.org; Sun, 19 Nov 2023 17:18:23 -0500 Received: from out-183.mta1.migadu.com ([2001:41d0:203:375::b7]:37819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4q7P-0000Pq-QQ for 66115@debbugs.gnu.org; Sun, 19 Nov 2023 17:18:21 -0500 References: <87a5thfh7i.fsf@breatheoutbreathe.in> <87lecyvcyd.fsf@posteo.net> <871qeqppxm.fsf@breatheoutbreathe.in> <875y42v5um.fsf@posteo.net> <877cogp205.fsf@breatheoutbreathe.in> <834jjk3vtd.fsf@gnu.org> <87msviogui.fsf@breatheoutbreathe.in> <87y1ey9ozs.fsf@posteo.net> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1700432296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hXQliVoy8+2ZnS2bdn2yQqjq7vGEdNNmU84nmHu18v4=; b=NRm0PYwW0rFmPYo744zAoYGvGKunPbVNsOwQi/JzY8mq5x8IZQui7VawKohIyOypqIHDPW t0IZxz0a2hV0OjzX5ujr/hJjQbXXgeqmNYZIVFG1xxgssSc+pkoqGYZKlDgtaxJSn4khrU 4ucRsVLakdpkKPYavjxLlAjmzmNG6pc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Joseph Turner To: Philip Kaludercic Subject: Re: bug#66115: [PATCH] Ensure that directory is expanded in package-vc-checkout Date: Sun, 19 Nov 2023 14:16:39 -0800 In-reply-to: <87y1ey9ozs.fsf@posteo.net> Message-ID: <87r0klmlp7.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66115 Cc: 66115@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Philip Kaludercic writes: > Joseph Turner writes: > >> Eli Zaretskii writes: >> >>>> Cc: 66115-done@debbugs.gnu.org >>>> Date: Sat, 23 Sep 2023 22:34:24 -0700 >>>> From: Joseph Turner via "Bug reports for GNU Emacs, >>>> the Swiss army knife of text editors" >>>> >>>> It appears that the fix was applied to master. Would it make sense to >>>> apply it to emacs-29? >>> >>> The installed change affects much more than the original issue, so I'd >>> prefer for it to stay on master. >>> >>> I'm okay with installing the original patch on emacs-29, but be sure >>> to say "do not merge to master" in the commit log message if you do. >> >> Philip, shall we merge the original patch on emacs-29 with "do not merge >> to master"? > > I don't object. Would you be willing to merge the attached patch? Thank you!! Joseph --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Ensure-that-directory-is-expanded-in-package-vc-chec.patch >From 75a6ec74ff5e31edc7592b68e7ad9d1ec26f515c Mon Sep 17 00:00:00 2001 From: Joseph Turner Date: Wed, 20 Sep 2023 00:12:10 -0700 Subject: [PATCH] Ensure that directory is expanded in package-vc-checkout * lisp/emacs-lisp/package-vc.el (package-vc-checkout) --- lisp/emacs-lisp/package-vc.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index 29b540d86b8..47d8c996ff0 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -834,6 +834,7 @@ for the last released version of the package." (setf dir subdir) (user-error "Directory not empty: %S" (expand-file-name dir))))) (list desc dir (and current-prefix-arg :last-release)))) + (setf directory (expand-file-name directory)) (package-vc--archives-initialize) (let ((pkg-spec (or (package-vc--desc->spec pkg-desc) (and-let* ((extras (package-desc-extras pkg-desc)) -- 2.41.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 25 05:17:23 2023 Received: (at 66115) by debbugs.gnu.org; 25 Nov 2023 10:17:23 +0000 Received: from localhost ([127.0.0.1]:37898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6pj0-0005Av-Qq for submit@debbugs.gnu.org; Sat, 25 Nov 2023 05:17:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6piz-0005Ad-0D for 66115@debbugs.gnu.org; Sat, 25 Nov 2023 05:17:22 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6pin-0007sc-Em; Sat, 25 Nov 2023 05:17:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LbT/+4ulflA+oqzbNoyQCMyEVb4mTtBrWvoLfTg8Lew=; b=pX70M8bOZenc cUI9Oq8Vgbl4HqKlfjdbGUM+Y1tx43lr4xHuO5/BktJhiHHAhFpIaYO+M6lgwVP2Hucadrck/Fp/P eW5qoXCIYVwU9R9stKFfdIViQiBBW/lv9H5iQy+FHpFwlYgPGChPQ21g5gvGzAKgXMGlRxsgeG2Vv AuKe/vcqcA14Vyath6SUe7k3GVBQBZZCp9vOIGJh/sbSsZPOzO1PdUspw+/7mKbif9m1DNQC5QZ6T 0SRWzT4BQDZfuzVO4zzxLdJuxXDBzFbi8cokQqvygJR08TJBSlCTCW2FVqXa1LuTPB/2aQBu35wus LYayz5ULJQYc0isb6IXyCQ==; Date: Sat, 25 Nov 2023 12:17:04 +0200 Message-Id: <83plzycf33.fsf@gnu.org> From: Eli Zaretskii To: Joseph Turner In-Reply-To: <87r0klmlp7.fsf@breatheoutbreathe.in> (message from Joseph Turner on Sun, 19 Nov 2023 14:16:39 -0800) Subject: Re: bug#66115: [PATCH] Ensure that directory is expanded in package-vc-checkout References: <87a5thfh7i.fsf@breatheoutbreathe.in> <87lecyvcyd.fsf@posteo.net> <871qeqppxm.fsf@breatheoutbreathe.in> <875y42v5um.fsf@posteo.net> <877cogp205.fsf@breatheoutbreathe.in> <834jjk3vtd.fsf@gnu.org> <87msviogui.fsf@breatheoutbreathe.in> <87y1ey9ozs.fsf@posteo.net> <87r0klmlp7.fsf@breatheoutbreathe.in> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66115 Cc: 66115@debbugs.gnu.org, philipk@posteo.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Joseph Turner > Cc: Eli Zaretskii , 66115@debbugs.gnu.org > Date: Sun, 19 Nov 2023 14:16:39 -0800 > > Philip Kaludercic writes: > > > Joseph Turner writes: > > > >> Eli Zaretskii writes: > >> > >>>> Cc: 66115-done@debbugs.gnu.org > >>>> Date: Sat, 23 Sep 2023 22:34:24 -0700 > >>>> From: Joseph Turner via "Bug reports for GNU Emacs, > >>>> the Swiss army knife of text editors" > >>>> > >>>> It appears that the fix was applied to master. Would it make sense to > >>>> apply it to emacs-29? > >>> > >>> The installed change affects much more than the original issue, so I'd > >>> prefer for it to stay on master. > >>> > >>> I'm okay with installing the original patch on emacs-29, but be sure > >>> to say "do not merge to master" in the commit log message if you do. > >> > >> Philip, shall we merge the original patch on emacs-29 with "do not merge > >> to master"? > > > > I don't object. > > Would you be willing to merge the attached patch? I tried, but it doesn't apply to emacs-29. Would you please submit a change relative to the emacs-29 branch? TIA From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 25 18:00:56 2023 Received: (at 66115) by debbugs.gnu.org; 25 Nov 2023 23:00:56 +0000 Received: from localhost ([127.0.0.1]:40448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r71dw-0001F6-3d for submit@debbugs.gnu.org; Sat, 25 Nov 2023 18:00:56 -0500 Received: from out-183.mta0.migadu.com ([2001:41d0:1004:224b::b7]:50242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r71du-0001Ew-4T for 66115@debbugs.gnu.org; Sat, 25 Nov 2023 18:00:55 -0500 References: <87a5thfh7i.fsf@breatheoutbreathe.in> <87lecyvcyd.fsf@posteo.net> <871qeqppxm.fsf@breatheoutbreathe.in> <875y42v5um.fsf@posteo.net> <877cogp205.fsf@breatheoutbreathe.in> <834jjk3vtd.fsf@gnu.org> <87msviogui.fsf@breatheoutbreathe.in> <87y1ey9ozs.fsf@posteo.net> <87r0klmlp7.fsf@breatheoutbreathe.in> <83plzycf33.fsf@gnu.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1700953247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bV6slkNgJS1O4TGygNKGNg/e7FC9eke4aV4mkHqa4bg=; b=ibDRGHDIGcEqK/c9ziVYKVWqKe4skptYw0iwY9NAPz8INaRcKMhhIdvT+347iueKJCNLan hw9NY8CKej0iyTtfPyrBpbX7rkw1HgrktKTvkgJwsQFGOJop1JBPstlcLXNdQjfE/QTVqi ituw0AKwwwtGjg/wshnIIIs32pT4Iz0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Joseph Turner To: Eli Zaretskii Subject: Re: bug#66115: [PATCH] Ensure that directory is expanded in package-vc-checkout Date: Sat, 25 Nov 2023 14:59:46 -0800 In-reply-to: <83plzycf33.fsf@gnu.org> Message-ID: <87zfz1mo9w.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66115 Cc: 66115@debbugs.gnu.org, philipk@posteo.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: > From: Joseph Turner >> Would you be willing to merge the attached patch? > > I tried, but it doesn't apply to emacs-29. Would you please submit a > change relative to the emacs-29 branch? Sorry about that! Here you go! Thanks, Joseph --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Ensure-that-directory-is-expanded-in-package-vc-chec.patch >From 49a94115d7f6bde1618f754265ec3ea8154dd922 Mon Sep 17 00:00:00 2001 From: Joseph Turner Date: Sat, 25 Nov 2023 14:57:45 -0800 Subject: [PATCH] Ensure that directory is expanded in package-vc-checkout * lisp/emacs-lisp/package-vc.el (package-vc-checkout) bug#66115 --- lisp/emacs-lisp/package-vc.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index c7a30736e32..2a5f14b3ee3 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -829,6 +829,7 @@ for the last released version of the package." (lambda (dir) (or (not (file-exists-p dir)) (directory-empty-p dir)))) (and current-prefix-arg :last-release)))) + (setf directory (expand-file-name directory)) (package-vc--archives-initialize) (let ((pkg-spec (or (package-vc--desc->spec pkg-desc) (and-let* ((extras (package-desc-extras pkg-desc)) -- 2.41.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 26 05:41:49 2023 Received: (at 66115-done) by debbugs.gnu.org; 26 Nov 2023 10:41:49 +0000 Received: from localhost ([127.0.0.1]:40763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7CaC-0007GV-Tc for submit@debbugs.gnu.org; Sun, 26 Nov 2023 05:41:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7CaB-0007GF-EP for 66115-done@debbugs.gnu.org; Sun, 26 Nov 2023 05:41:48 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r7Ca0-0006ry-C4; Sun, 26 Nov 2023 05:41:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/lU8Q9fV9F99K9GQYrhuOHmJBsqYVTTRA+3Kc4ueY00=; b=dobahxdmosZI 7WiLYpNzCmNKSubIXJtMTbcP+D3gx27MCEhsg9+SyaslAxh7SJnbZM0q5t/pNwgkdYfGZfjJqK3da NSWPtGKdYbddE+QtEheM3L3kirvbBILxEgVPZOTiVUDlK+JlPC3oRztNVKqJzguKrkAnzuJG0fem2 w1ietB/ZxZE7GtiHkbmp4SaIJani80DaChaE4Gq4P3RBtCSRyr/FVLfYn0Qae8rkv4OBu/jHKexfm /EcpmBtZ54HhdGaWVJ83YeQ0C42K/lDea/GJ7v/wYjfnN7JXcw8GyytmsLquqK41wN4Xkg8dn+wir Ll+sOS1XhzAjwyO16moTeA==; Date: Sun, 26 Nov 2023 12:41:18 +0200 Message-Id: <835y1obxv5.fsf@gnu.org> From: Eli Zaretskii To: Joseph Turner In-Reply-To: <87zfz1mo9w.fsf@breatheoutbreathe.in> (message from Joseph Turner on Sat, 25 Nov 2023 14:59:46 -0800) Subject: Re: bug#66115: [PATCH] Ensure that directory is expanded in package-vc-checkout References: <87a5thfh7i.fsf@breatheoutbreathe.in> <87lecyvcyd.fsf@posteo.net> <871qeqppxm.fsf@breatheoutbreathe.in> <875y42v5um.fsf@posteo.net> <877cogp205.fsf@breatheoutbreathe.in> <834jjk3vtd.fsf@gnu.org> <87msviogui.fsf@breatheoutbreathe.in> <87y1ey9ozs.fsf@posteo.net> <87r0klmlp7.fsf@breatheoutbreathe.in> <83plzycf33.fsf@gnu.org> <87zfz1mo9w.fsf@breatheoutbreathe.in> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66115-done Cc: 66115-done@debbugs.gnu.org, philipk@posteo.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Joseph Turner > Cc: philipk@posteo.net, 66115@debbugs.gnu.org > Date: Sat, 25 Nov 2023 14:59:46 -0800 > > Eli Zaretskii writes: > > > From: Joseph Turner > >> Would you be willing to merge the attached patch? > > > > I tried, but it doesn't apply to emacs-29. Would you please submit a > > change relative to the emacs-29 branch? > > Sorry about that! Here you go! Thanks, installed on the emacs-29 branch, and closing the bug. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 26 15:40:39 2023 Received: (at 66115-done) by debbugs.gnu.org; 26 Nov 2023 20:40:39 +0000 Received: from localhost ([127.0.0.1]:42768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7Lvi-0002Zs-R0 for submit@debbugs.gnu.org; Sun, 26 Nov 2023 15:40:39 -0500 Received: from out-176.mta1.migadu.com ([2001:41d0:203:375::b0]:56397) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7Lvg-0002Zh-3v for 66115-done@debbugs.gnu.org; Sun, 26 Nov 2023 15:40:37 -0500 References: <87a5thfh7i.fsf@breatheoutbreathe.in> <87lecyvcyd.fsf@posteo.net> <871qeqppxm.fsf@breatheoutbreathe.in> <875y42v5um.fsf@posteo.net> <877cogp205.fsf@breatheoutbreathe.in> <834jjk3vtd.fsf@gnu.org> <87msviogui.fsf@breatheoutbreathe.in> <87y1ey9ozs.fsf@posteo.net> <87r0klmlp7.fsf@breatheoutbreathe.in> <83plzycf33.fsf@gnu.org> <87zfz1mo9w.fsf@breatheoutbreathe.in> <835y1obxv5.fsf@gnu.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1701031228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kK9IkBiuOKeL73cmgk3JkOUOcFNCcKAYjEMM17dT6e4=; b=QYH2Wdv3zzc5cHv2VP/ZFtdue8IEh7GE7b2HtttZhImONwTbIaQ+3/9J9TFLkoQ74TRP0m IT/rQheIfgfPzVT2MHx+7J9SpIzLF5dANh0diVyqq6PMG/xoBA08dB+OxWA8I/prlXbQ1y 3YJEyFVpcQ2tV8FnRG2V04jaZZnQDz4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Joseph Turner To: Eli Zaretskii Subject: Re: bug#66115: [PATCH] Ensure that directory is expanded in package-vc-checkout Date: Sun, 26 Nov 2023 12:39:34 -0800 In-reply-to: <835y1obxv5.fsf@gnu.org> Message-ID: <87wmu4p7t2.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66115-done Cc: 66115-done@debbugs.gnu.org, philipk@posteo.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Joseph Turner >> Cc: philipk@posteo.net, 66115@debbugs.gnu.org >> Date: Sat, 25 Nov 2023 14:59:46 -0800 >> >> Eli Zaretskii writes: >> >> > From: Joseph Turner >> >> Would you be willing to merge the attached patch? >> > >> > I tried, but it doesn't apply to emacs-29. Would you please submit a >> > change relative to the emacs-29 branch? >> >> Sorry about that! Here you go! > > Thanks, installed on the emacs-29 branch, and closing the bug. Thank you, Eli! I made a mistake - I forgot to add "Do not merge into master" in the commit message. Do we need to add a commit on the master branch which reverts this one? Joseph From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 27 07:01:52 2023 Received: (at 66115-done) by debbugs.gnu.org; 27 Nov 2023 12:01:52 +0000 Received: from localhost ([127.0.0.1]:43384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7aJE-0002yz-4x for submit@debbugs.gnu.org; Mon, 27 Nov 2023 07:01:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7aJB-0002ym-FV for 66115-done@debbugs.gnu.org; Mon, 27 Nov 2023 07:01:50 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r7aIy-00011z-Nq; Mon, 27 Nov 2023 07:01:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=FubbKz4bx8zMBFhPJ1whaBIrZnU5/SyWrR325ToH/hE=; b=UzM9Yuqgi2bR F6OICmsFkHTUJ/ZeN1X6GQRhSI8LuFdYrLriwgsd6RpHgSH2yMbiUFu/RfjlpjqpM7vOCij+NZHE3 v8/eCZ32eZy0UhY7m+EQE6yHehVCumKjejZigG2Q5sSQt3g8EB7H6anCrn3+BF/AF4cmgkXNDmPRZ AmaRh0DkX2Hb1qFlvpkliK2gLUNflKZEPuOuSxRwZ01Xo3UlveLRNQh6QTHhjE8+CN7y7Ns/isiYR /CNvOrmHNsatWw1VA/zHgAyJj32SRNRHEa3RPikJnwY1tjJG+z6mRKHpjMQnmN9zJbQAGhIJhA7mK z6SseFQazMqYePpi5Zbv2A==; Date: Mon, 27 Nov 2023 14:01:19 +0200 Message-Id: <83fs0r9zhs.fsf@gnu.org> From: Eli Zaretskii To: Joseph Turner In-Reply-To: <87wmu4p7t2.fsf@breatheoutbreathe.in> (message from Joseph Turner on Sun, 26 Nov 2023 12:39:34 -0800) Subject: Re: bug#66115: [PATCH] Ensure that directory is expanded in package-vc-checkout References: <87a5thfh7i.fsf@breatheoutbreathe.in> <87lecyvcyd.fsf@posteo.net> <871qeqppxm.fsf@breatheoutbreathe.in> <875y42v5um.fsf@posteo.net> <877cogp205.fsf@breatheoutbreathe.in> <834jjk3vtd.fsf@gnu.org> <87msviogui.fsf@breatheoutbreathe.in> <87y1ey9ozs.fsf@posteo.net> <87r0klmlp7.fsf@breatheoutbreathe.in> <83plzycf33.fsf@gnu.org> <87zfz1mo9w.fsf@breatheoutbreathe.in> <835y1obxv5.fsf@gnu.org> <87wmu4p7t2.fsf@breatheoutbreathe.in> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66115-done Cc: 66115-done@debbugs.gnu.org, philipk@posteo.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Joseph Turner > Cc: philipk@posteo.net, 66115-done@debbugs.gnu.org > Date: Sun, 26 Nov 2023 12:39:34 -0800 > > > Thanks, installed on the emacs-29 branch, and closing the bug. > > Thank you, Eli! I made a mistake - I forgot to add "Do not merge into > master" in the commit message. Do we need to add a commit on the master > branch which reverts this one? Yes, after the next merge from emacs-29 to master. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 08 05:26:03 2023 Received: (at 66115-done) by debbugs.gnu.org; 8 Dec 2023 10:26:03 +0000 Received: from localhost ([127.0.0.1]:43897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBY3W-0000Mp-OE for submit@debbugs.gnu.org; Fri, 08 Dec 2023 05:26:03 -0500 Received: from out-186.mta0.migadu.com ([91.218.175.186]:54811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBY3U-0000MC-4c for 66115-done@debbugs.gnu.org; Fri, 08 Dec 2023 05:26:01 -0500 References: <87a5thfh7i.fsf@breatheoutbreathe.in> <87lecyvcyd.fsf@posteo.net> <871qeqppxm.fsf@breatheoutbreathe.in> <875y42v5um.fsf@posteo.net> <877cogp205.fsf@breatheoutbreathe.in> <834jjk3vtd.fsf@gnu.org> <87msviogui.fsf@breatheoutbreathe.in> <87y1ey9ozs.fsf@posteo.net> <87r0klmlp7.fsf@breatheoutbreathe.in> <83plzycf33.fsf@gnu.org> <87zfz1mo9w.fsf@breatheoutbreathe.in> <835y1obxv5.fsf@gnu.org> <87wmu4p7t2.fsf@breatheoutbreathe.in> <83fs0r9zhs.fsf@gnu.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1702031145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xlBNoWvNlQxkU1lbbNiLfsDpbzhY9oSg4TvENUGZxCo=; b=fb3AZOAKJzMdpE4yIhNrdYFWZkdHiXcGIyJYJcWkk4FOxaYt3n6mow8JXX+q1FIcB05EVa Vm1NjGE6oQy2fd0b+6St3rgiKRy3ZwaA4h2uMYa18zjCIi7VwbBeN4fl6/m3Tn4I9d0MaE ldIr4ZzWBduxbBctNRBN7+ak4cKLOpM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Joseph Turner To: Eli Zaretskii Subject: Re: bug#66115: [PATCH] Ensure that directory is expanded in package-vc-checkout Date: Fri, 08 Dec 2023 02:25:19 -0800 In-reply-to: <83fs0r9zhs.fsf@gnu.org> Message-ID: <87v899ousa.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66115-done Cc: 66115-done@debbugs.gnu.org, philipk@posteo.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Joseph Turner >> Cc: philipk@posteo.net, 66115-done@debbugs.gnu.org >> Date: Sun, 26 Nov 2023 12:39:34 -0800 >> >> > Thanks, installed on the emacs-29 branch, and closing the bug. >> >> Thank you, Eli! I made a mistake - I forgot to add "Do not merge into >> master" in the commit message. Do we need to add a commit on the master >> branch which reverts this one? > > Yes, after the next merge from emacs-29 to master. I see that you've done this already. Thank you! From unknown Wed Jun 18 23:04:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 05 Jan 2024 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator