GNU bug report logs - #66114
[PATCH] Fix interactive prompt for selecting checkout directory

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#66114: closed ([PATCH] Fix interactive prompt for selecting
 checkout directory)
Date: Wed, 14 Feb 2024 16:55:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 14 Feb 2024 16:54:15 +0000
with message-id <87eddfgf60.fsf <at> posteo.net>
and subject line Re: bug#66114: [PATCH] Fix interactive prompt for selecting checkout directory
has caused the debbugs.gnu.org bug report #66114,
regarding [PATCH] Fix interactive prompt for selecting checkout directory
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
66114: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66114
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Joseph Turner <joseph <at> breatheoutbreathe.in>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix interactive prompt for selecting checkout directory
Date: Wed, 20 Sep 2023 00:02:43 -0700

[Message part 3 (text/plain, inline)]

Tags: patch

This patch fixes the interactive prompt in package-vc-checkout. See
commit message for details.

[0001-Fix-interactive-prompt-for-selecting-checkout-direct.patch (text/patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Philip Kaludercic <philipk <at> posteo.net>
To: Joseph Turner <joseph <at> breatheoutbreathe.in>
Cc: 66114-done <at> debbugs.gnu.org
Subject: Re: bug#66114: [PATCH] Fix interactive prompt for selecting
 checkout directory
Date: Wed, 14 Feb 2024 16:54:15 +0000

Joseph Turner <joseph <at> breatheoutbreathe.in> writes:

> Joseph Turner <joseph <at> breatheoutbreathe.in> writes:
>
>> Philip Kaludercic <philipk <at> posteo.net> writes:
>>
>>> Joseph Turner <joseph <at> breatheoutbreathe.in> writes:
>>>
>>>>                                                  However, the behavior of
>>>> read-file-name is unspecified when a MUSTMATCH function returns nil:
>>>>
>>>> - a function, which will be called with the input as the
>>>>   argument.  If the function returns a non-nil value, the
>>>>   minibuffer is exited with that argument as the value.
>>>>
>>>> Is this a bug, a case of under-documentation, or do I misunderstand something?
>>>>
>>>> I'm happy to post this in a separate bug thread if you think it's worth it.
>>>
>>> Perhaps that would be worth doing, that way the people who know more
>>> about completion than I do would be more likely to see it and help
>>> out.
>>
>> Okay, thanks! I'll do that.
>
> Now that #66187
> (<https://yhetil.org/emacs-bugs/87cytlqmqh.fsf <at> breatheoutbreathe.in/>)
> and bug#68815
> (<https://yhetil.org/emacs-bugs/8734ufyxoy.fsf <at> breatheoutbreathe.in/>)
> are fixed on emacs-29, I'm revisiting this issue.
>
> With the following patch, the interactive prompt in package-vc-checkout
> now offers all directory for completion (empty or not), but only exits
> when the minibuffer contains an empty directory or nonexistent filename.
>
> Testing this patch requires checking out emacs-29 after e6c82fe35e3.

LGTM, I've pushed it to emacs-29.  Thanks!

> Thanks!
>
> Joseph

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.