GNU bug report logs - #66099
[PATCH gnome-team 0/3] Update upower

Previous Next

Full log

Message #167 received at 66099 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Vivien Kraus <vivien <at> planete-kraus.eu>
Cc: 66099 <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 rg <at> raghavgururajan.name
Subject: Re: [PATCH gnome-team v7 2/5] services: udev: unify udev-rule and
 file->udev-rule.
Date: Thu, 05 Oct 2023 09:30:35 -0400

Hi,

Vivien Kraus <vivien <at> planete-kraus.eu> writes:

> * gnu/services/base.scm (udev-rule): Implements in terms of file->udev-rule.
> Use texinfo in docstring.
> ---
>  gnu/services/base.scm | 17 +++--------------
>  1 file changed, 3 insertions(+), 14 deletions(-)
>
> diff --git a/gnu/services/base.scm b/gnu/services/base.scm
> index b3f2d2e8b8..190803b780 100644
> --- a/gnu/services/base.scm
> +++ b/gnu/services/base.scm
> @@ -2211,20 +2211,9 @@ (define (udev-rules-union packages)
>    (computed-file "udev-rules" build))
>  
>  (define (udev-rule file-name contents)
> -  "Return a directory with a udev rule file FILE-NAME containing CONTENTS."
> -  (computed-file file-name
> -                 (with-imported-modules '((guix build utils))
> -                   #~(begin
> -                       (use-modules (guix build utils))
> -
> -                       (define rules.d
> -                         (string-append #$output "/lib/udev/rules.d"))
> -
> -                       (mkdir-p rules.d)
> -                       (call-with-output-file
> -                           (string-append rules.d "/" #$file-name)
> -                         (lambda (port)
> -                           (display #$contents port)))))))
> +  "Return a directory with a udev rule file @var{file-name} containing
> +@var{contents}."
> +  (file->udev-rule file-name (plain-file file-name contents)))

That one LGTM!

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.