GNU bug report logs - #66071
30.0.50; term-scroll-to-bottom-on-output missing choices

Previous Next

Full log

Message #19 received at 66071 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: 66071 <at> debbugs.gnu.org
Subject: Re: bug#66071: 30.0.50; term-scroll-to-bottom-on-output missing
 choices
Date: Mon, 18 Sep 2023 17:22:13 +0200

>>>>> On Mon, 18 Sep 2023 12:12:41 -0300, Mauro Aranda <maurooaranda <at> gmail.com> said:

    Mauro> On 18/9/23 11:20, Robert Pluim wrote:
    >> On Mon, 18 Sep 2023 09:20:07 -0300, Mauro Aranda
    Mauro>   <maurooaranda <at> gmail.com> said:
    >>      Mauro> Patch attached.
    >> 
    >>      Mauro> From d891a9f705b3b4af2aedeed645f4636535ea6c2e Mon Sep 17
    Mauro>  00:00:00 2001
    >>      Mauro> From: Mauro Aranda <maurooaranda <at> gmail.com>
    >>      Mauro> Date: Mon, 18 Sep 2023 09:19:04 -0300
    >>      Mauro> Subject: [PATCH] Fix term-scroll-to-bottom-on-output
    Mauro>  :type (Bug#66071)
    >> 
    >>      Mauro> * lisp/term.el (term-scroll-to-bottom-on-output): Add
    Mauro>  missing choices.
    >>      Mauro> ---
    >>      Mauro>  lisp/term.el | 5 ++++-
    >>      Mauro>  1 file changed, 4 insertions(+), 1 deletion(-)
    >> 
    >>      Mauro> diff --git a/lisp/term.el b/lisp/term.el
    >>      Mauro> index b8466b21332..5dd73447cfb 100644
    >>      Mauro> --- a/lisp/term.el
    >>      Mauro> +++ b/lisp/term.el
    >>      Mauro> @@ -494,7 +494,10 @@ term-scroll-to-bottom-on-output
    >> 
    >>      Mauro>  See variable `term-scroll-show-maximum-output'.
    >>      Mauro>  This variable is buffer-local."
    >>      Mauro> -  :type 'boolean
    >>      Mauro> +  :type '(choice (const :tag "Don't scroll" nil)
    >>      Mauro> +                 (const :tag "Scroll selected window
    Mauro>  only" this)
    >>      Mauro> +                 (const :tag "Scroll unselected windows"
    Mauro>  others)
    >>      Mauro> +                 (other :tag "Scroll all windows" t))
    >>      Mauro>    :group 'term)
    >> 
    >> The code (and the docstring) also mention 'all.

    Mauro> I know, that's why I put other, to catch either t or 'all, since it
    Mauro> doesn't make sense to have 2 different items for the same option. And
    Mauro> adding something to match only t or 'all didn't seem worth the trouble.

    Mauro> Am I missing something?

Both before and after your patch, the defcustom and the docstring
disagree. The docstring says 'all', but thatʼs not a value you can get
via customize.

Personally Iʼd be inclined to delete 'all' from the docstring. People
already using 'all' wonʼt notice, since the code will still recognize
it.

Robert
-- 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.