GNU bug report logs - #66071
30.0.50; term-scroll-to-bottom-on-output missing choices

Previous Next

Package: emacs;

Reported by: Mauro Aranda <maurooaranda <at> gmail.com>

Date: Mon, 18 Sep 2023 12:18:01 UTC

Severity: normal

Tags: patch

Found in version 30.0.50

Fixed in version 29.2

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #13 received at 66071 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: 66071 <at> debbugs.gnu.org
Subject: Re: bug#66071: 30.0.50; term-scroll-to-bottom-on-output missing
 choices
Date: Mon, 18 Sep 2023 16:20:50 +0200
>>>>> On Mon, 18 Sep 2023 09:20:07 -0300, Mauro Aranda <maurooaranda <at> gmail.com> said:

    Mauro> tags 66071 patch
    Mauro> quit


    Mauro> Patch attached.

    Mauro> From d891a9f705b3b4af2aedeed645f4636535ea6c2e Mon Sep 17 00:00:00 2001
    Mauro> From: Mauro Aranda <maurooaranda <at> gmail.com>
    Mauro> Date: Mon, 18 Sep 2023 09:19:04 -0300
    Mauro> Subject: [PATCH] Fix term-scroll-to-bottom-on-output :type (Bug#66071)

    Mauro> * lisp/term.el (term-scroll-to-bottom-on-output): Add missing choices.
    Mauro> ---
    Mauro>  lisp/term.el | 5 ++++-
    Mauro>  1 file changed, 4 insertions(+), 1 deletion(-)

    Mauro> diff --git a/lisp/term.el b/lisp/term.el
    Mauro> index b8466b21332..5dd73447cfb 100644
    Mauro> --- a/lisp/term.el
    Mauro> +++ b/lisp/term.el
    Mauro> @@ -494,7 +494,10 @@ term-scroll-to-bottom-on-output
 
    Mauro>  See variable `term-scroll-show-maximum-output'.
    Mauro>  This variable is buffer-local."
    Mauro> -  :type 'boolean
    Mauro> +  :type '(choice (const :tag "Don't scroll" nil)
    Mauro> +                 (const :tag "Scroll selected window only" this)
    Mauro> +                 (const :tag "Scroll unselected windows" others)
    Mauro> +                 (other :tag "Scroll all windows" t))
    Mauro>    :group 'term)

The code (and the docstring) also mention 'all.

Robert
-- 




This bug report was last modified 1 year and 238 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.