From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 18 08:17:57 2023 Received: (at submit) by debbugs.gnu.org; 18 Sep 2023 12:17:57 +0000 Received: from localhost ([127.0.0.1]:52320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiDCP-0007hN-12 for submit@debbugs.gnu.org; Mon, 18 Sep 2023 08:17:57 -0400 Received: from lists.gnu.org ([2001:470:142::17]:57906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiDCM-0007h6-Jy for submit@debbugs.gnu.org; Mon, 18 Sep 2023 08:17:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiDC7-0002Iy-VO for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 08:17:40 -0400 Received: from mail-ot1-x32e.google.com ([2607:f8b0:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qiDC6-0003io-JW for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 08:17:39 -0400 Received: by mail-ot1-x32e.google.com with SMTP id 46e09a7af769-6bdacc5ed66so2420956a34.1 for ; Mon, 18 Sep 2023 05:17:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695039457; x=1695644257; darn=gnu.org; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=DzCzqwT6wp8V6Bm58VgoNMnHkci4c9NfMw7aovUWNwo=; b=W+dUA4OnrHREqNpc0GnM8LWCZyFjUrQtTpzYHlY85duyOidqyjPrCPmrLsm2Lv5HJK D6lPA3buqLOV8PRj74HfCC6SNV/WZ8j+jv3UHzsDY6QMqQ9QmdzYNkXu12UhSbM1Q3Uk UeP9evGrXO68KTZRnPzeAnx7tdQjyZRbqw0AFhHwkfYK+p9nWK/kuy4oaIWyyel/DS6h P8T3/oX3PJitjGgkb7A9BoJQeabDqnFybwEhFn+WM159YpLK+BYhOhuxLJghIq9ZZylp O301BsL4xvWk0veFXlZ6ExTvPhkcexZTtCtHYdl8nIwI4X7+lbVR2sLb/Ecut/oghXHO ztQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695039457; x=1695644257; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=DzCzqwT6wp8V6Bm58VgoNMnHkci4c9NfMw7aovUWNwo=; b=hs15iAL/5hFUpIzMYdrYmmEoSqcBG96SaBiB4KkP1Ez7J9ERdTNSfGOh2HZJd2D2hX VHT7b+cFpTohhYDYyq+CDZSpO0QU1uiA9gpUtqfIMjxQjqWXay9vUHrdfrj58JxEEps+ do8Tg9DQVMYNS6b+wYS5SeM8HFsTYWFqeYY7bB2YHvlXHM8QXsqdG1HSVcCL8EX9LC4q 9x+ehMX50ZzxmQphpAMJMs3kGRlTDvHoTeF0ORgxcv/ClMCZoxOhV5nSQOiA+QbijWm2 6OvBnjZD6MbHKjK2bAExgi7Smv/8IxhZwa74oHXJxzeGULphCqWQ3lPNymf7rWfPcjEo p2zA== X-Gm-Message-State: AOJu0YwL/BPsHWnq3kW7h9+lWcsx5AybyNYwiWTFuX+OYioOz1XcNOgA od5/7+Z5WLMlOvlOjsxwpMXYdeQzk5JRBQ== X-Google-Smtp-Source: AGHT+IGZ/yYrl/bu8FN/jOextLt6jsxL3zaGynPLZOOnOKNqM5t2vDRi8dHXEoP8Xrgk53j/D/0yjw== X-Received: by 2002:a05:6830:3188:b0:6be:f8fc:8207 with SMTP id p8-20020a056830318800b006bef8fc8207mr7075599ots.17.1695039456624; Mon, 18 Sep 2023 05:17:36 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id h67-20020a4a5e46000000b005712505dcffsm4516590oob.32.2023.09.18.05.17.34 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Sep 2023 05:17:35 -0700 (PDT) Message-ID: <147ab958-899e-07cc-f175-52ad2d25e54b@gmail.com> Date: Mon, 18 Sep 2023 09:17:32 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Mauro Aranda Subject: 30.0.50; term-scroll-to-bottom-on-output missing choices Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::32e; envelope-from=maurooaranda@gmail.com; helo=mail-ot1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) The docstring says term-scroll-to-bottom-on-output may be set to the symbols this and others, but its :type is just a boolean. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 18 08:20:28 2023 Received: (at 66071) by debbugs.gnu.org; 18 Sep 2023 12:20:28 +0000 Received: from localhost ([127.0.0.1]:52329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiDEp-0007mo-TV for submit@debbugs.gnu.org; Mon, 18 Sep 2023 08:20:28 -0400 Received: from mail-oa1-x2f.google.com ([2001:4860:4864:20::2f]:50402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiDEm-0007mJ-PN; Mon, 18 Sep 2023 08:20:25 -0400 Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-1c0fcbf7ae4so2916644fac.0; Mon, 18 Sep 2023 05:20:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695039610; x=1695644410; darn=debbugs.gnu.org; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=lsKuGF5pCS+lJaNTJU3qKDXNtnQL4nlH5KM6h8sArpo=; b=kEPVHJDXkSq/jPJdkunpibarRDPRXFxW49eK6qBdtOZREPxllGpyKWZtDSr6RkpoO3 UVO7kcWxvSBulOPz32cEanwmwidnNjLK0CfEGWOEZgQ6ZKBoHHjW1iyHU0G6aHK5RIVb 2gIo0SL9A0F/VKnfjULJLEs79HAmX9JfoHHVi9p/jGT36ekNExy+8yQfhd2TrX/VidIB CmMMch9QnrjJL1L7yX5O41cctEpmEqMEv1FTTjgSZW5DeEwqDC5W1a+jck2zfI9bGWgj x8x3SdPRpbeOBfyIkH2yf75W5pA3GyiZNVC3wqW08+ApCWgWsPLZkTxnDYLa94luMW4g 5scw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695039610; x=1695644410; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=lsKuGF5pCS+lJaNTJU3qKDXNtnQL4nlH5KM6h8sArpo=; b=u8sa0xDuG78T47BNCE5bRzL50MjrWrdJwqirDxFKmyO+SjavZLqXuodZQAT4wGrFj5 Qya0H/A3nTaq3KGwlR1C2EdXPwiNJRXS50QrqY72OmJaKKlvUtDm+ZsnjaymgrbiSsct WbK6Tond7vFe75Za3wT5RPegkotRxrmowQpMwTojqMZ/kjXO0bsoswjSkIMRGyuZ4Zqw Ltovi2k66N9IFgjRjQ9646ST6r9Xc1mkKYU0frFSQlWvUIPFv6tDOIq6RvoVtfzsM6j3 YNkti5pLeB+QIGMTYseuHj0VsEY7UQMVrOcIevSF2/O+AExbo+KQiLAO0U4RyoJySrRj sI9g== X-Gm-Message-State: AOJu0Yyaq8JvmLts0hKWzu17f6rk+Jg/MsoFJDl6i6gg9K9ZVzPYmdlA qhK966L2+Qxc13jQspxEYiZtwxBE49euKg== X-Google-Smtp-Source: AGHT+IEYkz29+UrjcieLYKY1r4VnsWn8ZCcao0cm/sVCOzz4BrMgXSbmWrW6lIhT9dRxqTYpK6oVuQ== X-Received: by 2002:a05:6870:505:b0:1cc:c744:d320 with SMTP id j5-20020a056870050500b001ccc744d320mr10074651oao.53.1695039610350; Mon, 18 Sep 2023 05:20:10 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id j4-20020a9d7d84000000b006b9cc67386fsm4043878otn.66.2023.09.18.05.20.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Sep 2023 05:20:09 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------ucaFfAQEmzkHrV6AS0c2Ye0q" Message-ID: Date: Mon, 18 Sep 2023 09:20:07 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#66071: 30.0.50; term-scroll-to-bottom-on-output missing choices Content-Language: en-US From: Mauro Aranda To: 66071@debbugs.gnu.org References: <147ab958-899e-07cc-f175-52ad2d25e54b@gmail.com> In-Reply-To: <147ab958-899e-07cc-f175-52ad2d25e54b@gmail.com> X-Spam-Score: -1.5 (-) X-Debbugs-Envelope-To: 66071 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) This is a multi-part message in MIME format. --------------ucaFfAQEmzkHrV6AS0c2Ye0q Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit tags 66071 patch quit Patch attached. --------------ucaFfAQEmzkHrV6AS0c2Ye0q Content-Type: text/x-patch; charset=UTF-8; name="0001-Fix-term-scroll-to-bottom-on-output-type-Bug-66071.patch" Content-Disposition: attachment; filename*0="0001-Fix-term-scroll-to-bottom-on-output-type-Bug-66071.patc"; filename*1="h" Content-Transfer-Encoding: base64 RnJvbSBkODkxYTlmNzA1YjNiNGFmMmFlZGVlZDY0NWY0NjM2NTM1ZWE2YzJlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IE1vbiwgMTggU2VwIDIwMjMgMDk6MTk6MDQgLTAzMDAKU3ViamVjdDog W1BBVENIXSBGaXggdGVybS1zY3JvbGwtdG8tYm90dG9tLW9uLW91dHB1dCA6dHlwZSAoQnVn IzY2MDcxKQoKKiBsaXNwL3Rlcm0uZWwgKHRlcm0tc2Nyb2xsLXRvLWJvdHRvbS1vbi1vdXRw dXQpOiBBZGQgbWlzc2luZyBjaG9pY2VzLgotLS0KIGxpc3AvdGVybS5lbCB8IDUgKysrKy0K IDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYg LS1naXQgYS9saXNwL3Rlcm0uZWwgYi9saXNwL3Rlcm0uZWwKaW5kZXggYjg0NjZiMjEzMzIu LjVkZDczNDQ3Y2ZiIDEwMDY0NAotLS0gYS9saXNwL3Rlcm0uZWwKKysrIGIvbGlzcC90ZXJt LmVsCkBAIC00OTQsNyArNDk0LDEwIEBAIHRlcm0tc2Nyb2xsLXRvLWJvdHRvbS1vbi1vdXRw dXQKIAogU2VlIHZhcmlhYmxlIGB0ZXJtLXNjcm9sbC1zaG93LW1heGltdW0tb3V0cHV0Jy4K IFRoaXMgdmFyaWFibGUgaXMgYnVmZmVyLWxvY2FsLiIKLSAgOnR5cGUgJ2Jvb2xlYW4KKyAg OnR5cGUgJyhjaG9pY2UgKGNvbnN0IDp0YWcgIkRvbid0IHNjcm9sbCIgbmlsKQorICAgICAg ICAgICAgICAgICAoY29uc3QgOnRhZyAiU2Nyb2xsIHNlbGVjdGVkIHdpbmRvdyBvbmx5IiB0 aGlzKQorICAgICAgICAgICAgICAgICAoY29uc3QgOnRhZyAiU2Nyb2xsIHVuc2VsZWN0ZWQg d2luZG93cyIgb3RoZXJzKQorICAgICAgICAgICAgICAgICAob3RoZXIgOnRhZyAiU2Nyb2xs IGFsbCB3aW5kb3dzIiB0KSkKICAgOmdyb3VwICd0ZXJtKQogCiAoZGVmY3VzdG9tIHRlcm0t c2Nyb2xsLXNuYXAtdG8tYm90dG9tIHQKLS0gCjIuMzQuMQoK --------------ucaFfAQEmzkHrV6AS0c2Ye0q-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 18 10:21:10 2023 Received: (at 66071) by debbugs.gnu.org; 18 Sep 2023 14:21:10 +0000 Received: from localhost ([127.0.0.1]:53955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiF7e-0006KM-2i for submit@debbugs.gnu.org; Mon, 18 Sep 2023 10:21:10 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:59508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiF7a-0006Je-NP for 66071@debbugs.gnu.org; Mon, 18 Sep 2023 10:21:09 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-40472c3faadso44864485e9.2 for <66071@debbugs.gnu.org>; Mon, 18 Sep 2023 07:20:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695046852; x=1695651652; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=T3TdTalh1vFEsrmD6dc/iI8fh56tdYIhUplyS5MqUpc=; b=ERtx0oVZTM+Yk3bS4vQLZf7IuRmSUyuIH0fpaInUAPrpnv/SP4UxleuVJBOlwKR3Mp oRgGbrcgnZdCIDApaZYco2QqgPaSFfsj3Y0g6FutHxUEJuVv+R6hKxePWbJzjpDL+UyD 6QFJs6OYfve/RllD0H4PVwN6ihhEBs/gK8FOy04tojf6jA5BaTn+BOXSwIyZBEPK5Gff XIVd0DlCKvyY4PDVij6do9TLMsVN7j/tzOM6nXdo6mTKDtsu9Q497QU8GSiTd+9YhP3A eHrn1j6kYoY+jUSdwEn+onIM0y/CL06wKSDcKAtsWBsJRrniWVtsAeKZSCnH7MOn5hNO y0uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695046852; x=1695651652; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T3TdTalh1vFEsrmD6dc/iI8fh56tdYIhUplyS5MqUpc=; b=Yx9vOAMN0cUbXOfuZH/PWu7j8OqTAsswHZATyDILeJntR7USNcH4Gkia8CaTuyObjd Jdc5jAAF7sTYnMA6X/9xYT/s5QcT8KmIlFqf6bDEKU32e6+eIhD2RbZm9WLQM1sw3G2K ygAUMCvtMcnNcqeI7aCz7tAF8jwq/Jx71/IgVY3194wOgQ7s99OZ4+qQmN7Odjyb8DVE 18Cy+XqMLvXP5WabEZLtjk2ZZt8tQfr33uGzgtmeMwEMDNLvPPWU/u//CQTnfFi9aQkP WszEm/VOwTlFhHo3tp6kPEqdHtTU1QPDsOPYhHfUM2ynB/KrFPqmMDp+3We58vIS/gXe m0iw== X-Gm-Message-State: AOJu0YwBf3oc93bWWzNK7OCQSWDG36zH4o9S689OSBPWnFft006BGNlo hQx/91Fd/XsBb6bDDpmyeAWUllVMaZ3WcA== X-Google-Smtp-Source: AGHT+IEvx6Jo/F8SQ4cPQ80ucIbSyRd/gKje9PdkWGXjlP+lS9Vjnc1MrKG/RlSVCc3kTf1F6TnFMA== X-Received: by 2002:a1c:4b0f:0:b0:3fe:2011:a7ce with SMTP id y15-20020a1c4b0f000000b003fe2011a7cemr7799974wma.6.1695046851921; Mon, 18 Sep 2023 07:20:51 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:d837:9a8f:f5d9:8bdc]) by smtp.gmail.com with ESMTPSA id r4-20020adfdc84000000b0031753073abcsm12705732wrj.36.2023.09.18.07.20.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 07:20:51 -0700 (PDT) From: Robert Pluim To: Mauro Aranda Subject: Re: bug#66071: 30.0.50; term-scroll-to-bottom-on-output missing choices In-Reply-To: (Mauro Aranda's message of "Mon, 18 Sep 2023 09:20:07 -0300") References: <147ab958-899e-07cc-f175-52ad2d25e54b@gmail.com> Date: Mon, 18 Sep 2023 16:20:50 +0200 Message-ID: <871qevk1fh.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66071 Cc: 66071@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 18 Sep 2023 09:20:07 -0300, Mauro Aranda said: Mauro> tags 66071 patch Mauro> quit Mauro> Patch attached. Mauro> From d891a9f705b3b4af2aedeed645f4636535ea6c2e Mon Sep 17 00:00:00 2001 Mauro> From: Mauro Aranda Mauro> Date: Mon, 18 Sep 2023 09:19:04 -0300 Mauro> Subject: [PATCH] Fix term-scroll-to-bottom-on-output :type (Bug#66071) Mauro> * lisp/term.el (term-scroll-to-bottom-on-output): Add missing choices. Mauro> --- Mauro> lisp/term.el | 5 ++++- Mauro> 1 file changed, 4 insertions(+), 1 deletion(-) Mauro> diff --git a/lisp/term.el b/lisp/term.el Mauro> index b8466b21332..5dd73447cfb 100644 Mauro> --- a/lisp/term.el Mauro> +++ b/lisp/term.el Mauro> @@ -494,7 +494,10 @@ term-scroll-to-bottom-on-output Mauro> See variable `term-scroll-show-maximum-output'. Mauro> This variable is buffer-local." Mauro> - :type 'boolean Mauro> + :type '(choice (const :tag "Don't scroll" nil) Mauro> + (const :tag "Scroll selected window only" this) Mauro> + (const :tag "Scroll unselected windows" others) Mauro> + (other :tag "Scroll all windows" t)) Mauro> :group 'term) The code (and the docstring) also mention 'all. Robert -- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 18 11:13:01 2023 Received: (at 66071) by debbugs.gnu.org; 18 Sep 2023 15:13:01 +0000 Received: from localhost ([127.0.0.1]:54057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiFvo-0008Kw-U0 for submit@debbugs.gnu.org; Mon, 18 Sep 2023 11:13:01 -0400 Received: from mail-oi1-x230.google.com ([2607:f8b0:4864:20::230]:49562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiFvm-0008KX-Bm for 66071@debbugs.gnu.org; Mon, 18 Sep 2023 11:13:00 -0400 Received: by mail-oi1-x230.google.com with SMTP id 5614622812f47-3adcec86a8cso854417b6e.3 for <66071@debbugs.gnu.org>; Mon, 18 Sep 2023 08:12:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695049964; x=1695654764; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=k6qxSgf1geUkY3RIbwQIw7YAWlvbdAO4kD5LING4QOY=; b=fh/RL1ih6f0yU6GRQRYjy2u0LgP4mGYe+kPepgMaLXdezZ7zoCZ+lGZLpxteYFVCj/ JiFhQTRD5sc9CrT5otsP575xMtVJ4B+KE6M3GsKwgFyn7poteeQVsiKTSXfKnrCTEGpT f303MBnoUM9tQOwEvrqCdBEy88bzRos83VnCjKiLO++lgzWSLSvQJLmod5DLaYUPYcJT BIaqrSGyBRJJVYKXzE2ptcQT/H2ucCyrxAtUKQkTACSPja6WAsfgldbSlMVX9nUsu1IY 9GkA03xAddiJR35lfyR/OeDsQnhPsozNsOloOg/YpWxFg2gayagfSWZ47jwWU1L6WoMc Xk9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695049964; x=1695654764; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=k6qxSgf1geUkY3RIbwQIw7YAWlvbdAO4kD5LING4QOY=; b=FbdoHU0pdicall05lKay1xnS7Ul1RvjQT9D6yc4SJyfYPovwrZpxPEtTxlJo53lYbv HRnKhZbKEBn/g7WmpeBp/fRzLgIMcmOjd5NgKFreHNOAUUr2RAj0W4F32fc0LN7gWX5o XCZI4VQQvLCSKsTkSTOa2V1/jnrpK3PHEfxlxnYSNJAu/4pF4mMGgxqfD489JW34fPLR ROL+n5vPOBbJ3C9S+EZwtO+pkTGzW8Ql+NvX2HnIyzi2H+aOToZmryvOa1qi0JBhWdva QKOiIlMG/pGQG0in3KunRPbXcll4qN9riBOgXf843sYrbrqK5oW4SSC3p94IJFrILHGz whvg== X-Gm-Message-State: AOJu0YzjI+lPCsnT2ACVmnA1z67F+JTqvEHf0QEPk7YAzdkg1UfqGYDt t5N2/NUG0P/PdvXHAEcCzGk= X-Google-Smtp-Source: AGHT+IGw4Ib+YBr/SHs+Hp8b6G3nJn8HIbX7gJePAdsHZF0xvCwNTa/9qt6fYD5jQjOCA/KTdFW0JA== X-Received: by 2002:a05:6808:1b2c:b0:3a4:6a:6363 with SMTP id bx44-20020a0568081b2c00b003a4006a6363mr12616704oib.14.1695049964168; Mon, 18 Sep 2023 08:12:44 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id l23-20020a056808021700b003adbd352e28sm2235692oie.58.2023.09.18.08.12.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Sep 2023 08:12:43 -0700 (PDT) Message-ID: <53e55fdd-598d-efd3-e3ac-9cc19334b47c@gmail.com> Date: Mon, 18 Sep 2023 12:12:41 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#66071: 30.0.50; term-scroll-to-bottom-on-output missing choices Content-Language: en-US To: Robert Pluim References: <147ab958-899e-07cc-f175-52ad2d25e54b@gmail.com> <871qevk1fh.fsf@gmail.com> From: Mauro Aranda In-Reply-To: <871qevk1fh.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.5 (-) X-Debbugs-Envelope-To: 66071 Cc: 66071@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) On 18/9/23 11:20, Robert Pluim wrote: > On Mon, 18 Sep 2023 09:20:07 -0300, Mauro Aranda said: >     Mauro> Patch attached. > >     Mauro> From d891a9f705b3b4af2aedeed645f4636535ea6c2e Mon Sep 17 00:00:00 2001 >     Mauro> From: Mauro Aranda >     Mauro> Date: Mon, 18 Sep 2023 09:19:04 -0300 >     Mauro> Subject: [PATCH] Fix term-scroll-to-bottom-on-output :type (Bug#66071) > >     Mauro> * lisp/term.el (term-scroll-to-bottom-on-output): Add missing choices. >     Mauro> --- >     Mauro>  lisp/term.el | 5 ++++- >     Mauro>  1 file changed, 4 insertions(+), 1 deletion(-) > >     Mauro> diff --git a/lisp/term.el b/lisp/term.el >     Mauro> index b8466b21332..5dd73447cfb 100644 >     Mauro> --- a/lisp/term.el >     Mauro> +++ b/lisp/term.el >     Mauro> @@ -494,7 +494,10 @@ term-scroll-to-bottom-on-output > >     Mauro>  See variable `term-scroll-show-maximum-output'. >     Mauro>  This variable is buffer-local." >     Mauro> -  :type 'boolean >     Mauro> +  :type '(choice (const :tag "Don't scroll" nil) >     Mauro> +                 (const :tag "Scroll selected window only" this) >     Mauro> +                 (const :tag "Scroll unselected windows" others) >     Mauro> +                 (other :tag "Scroll all windows" t)) >     Mauro>    :group 'term) > > The code (and the docstring) also mention 'all. I know, that's why I put other, to catch either t or 'all, since it doesn't make sense to have 2 different items for the same option. And adding something to match only t or 'all didn't seem worth the trouble. Am I missing something? From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 18 11:22:30 2023 Received: (at 66071) by debbugs.gnu.org; 18 Sep 2023 15:22:30 +0000 Received: from localhost ([127.0.0.1]:54092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiG50-0000H9-FH for submit@debbugs.gnu.org; Mon, 18 Sep 2023 11:22:30 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:60671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiG4z-0000Gp-1e for 66071@debbugs.gnu.org; Mon, 18 Sep 2023 11:22:29 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-404732a0700so46811355e9.0 for <66071@debbugs.gnu.org>; Mon, 18 Sep 2023 08:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695050534; x=1695655334; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=dxNxe/Q67TeWsudDNz6gSV31rSNKkqPZlwATnFg9Z5Y=; b=VPbpmLBfrE0KlmoNRg7rpl2z95do1ijlVfmGmYD2AK9yirBokFsvwJDYRfFgezrZ+r 1PSoONShRO91LXkUY17qOFeZTTvc6VWJ0w1appwELGWTIu8yV/81E45wls3Fb+wu2E/g rjNXDFbIJHhtkEPApjoH542dO9mkLqxupgP/hjuVNXcfdU0euv3Z5stlp9NRRF5Asv2f chohj1pqK/CpsyAzSx15q9xevGLhg31O85GYnZmzSiYYNH+1K4rU+E70ee+EhHBXqB4l VVB8mx8nBnOwN/KG88J12a99iwqiZzP+IcU1ry/6/AROIuXWJ+RoCGStvGPkaPZwMu9X vOvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695050534; x=1695655334; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dxNxe/Q67TeWsudDNz6gSV31rSNKkqPZlwATnFg9Z5Y=; b=jbc32qQ1QcsyW7xkPnRV31r4jXifUjLQlD06N3LPqV/q5ejfBNJpaRzgEflg9oSbg9 G8it+etFluocrLGD4/TZEAFhlEDg4/dlXKv1V9JG6bOjxAqs8HE+wgcCylSrtpHjS9bE KXOO6xoegZvj81eLw8fl+wepwWSfnv5Caboops3WaXI9cUJNMLZahAmUzUXMFXfzQWIy l4xxLhTKVvd9wLkDxgI8DBQNjtLkE8vtdbH1h8ydc2t8982GeTCO9y9y5nY3BwXDSvEq YLVfEpiyMyh/wddtOKJEJSaZokG8CGwN0Wk8ioieGtcd27h/iimx5pvXzJje1R9rcUx1 5aig== X-Gm-Message-State: AOJu0YxuQO6if3WPyldML8zlABU7M52y3C0tdsMGP5M1jl6/nFiFeEUG lIeJSliNAzYFnaeyIrX85j8bEZlGos/Fzw== X-Google-Smtp-Source: AGHT+IE7ZTxFmeMeFGJ1uvG0d0NdenRm+/oCDt4W6eqisfmBOBnZ7byAjAZYim3sdcaVxu9Le6V/ow== X-Received: by 2002:a5d:5a12:0:b0:320:7fa:c71e with SMTP id bq18-20020a5d5a12000000b0032007fac71emr7209978wrb.15.1695050534220; Mon, 18 Sep 2023 08:22:14 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:d837:9a8f:f5d9:8bdc]) by smtp.gmail.com with ESMTPSA id e7-20020a056000194700b00317b063590fsm12776032wry.55.2023.09.18.08.22.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 08:22:13 -0700 (PDT) From: Robert Pluim To: Mauro Aranda Subject: Re: bug#66071: 30.0.50; term-scroll-to-bottom-on-output missing choices In-Reply-To: <53e55fdd-598d-efd3-e3ac-9cc19334b47c@gmail.com> (Mauro Aranda's message of "Mon, 18 Sep 2023 12:12:41 -0300") References: <147ab958-899e-07cc-f175-52ad2d25e54b@gmail.com> <871qevk1fh.fsf@gmail.com> <53e55fdd-598d-efd3-e3ac-9cc19334b47c@gmail.com> Date: Mon, 18 Sep 2023 17:22:13 +0200 Message-ID: <87wmwnik0q.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66071 Cc: 66071@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 18 Sep 2023 12:12:41 -0300, Mauro Aranda said: Mauro> On 18/9/23 11:20, Robert Pluim wrote: >> On Mon, 18 Sep 2023 09:20:07 -0300, Mauro Aranda Mauro> said: >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> Patch attached. >>=20 >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> From d891a9f705b3b4af2aedeed645f4636= 535ea6c2e Mon Sep 17 Mauro> 00:00:00 2001 >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> From: Mauro Aranda >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> Date: Mon, 18 Sep 2023 09:19:04 -0300 >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> Subject: [PATCH] Fix term-scroll-to-= bottom-on-output Mauro> :type (Bug#66071) >>=20 >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> * lisp/term.el (term-scroll-to-botto= m-on-output): Add Mauro> missing choices. >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> --- >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro>=C2=A0 lisp/term.el | 5 ++++- >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro>=C2=A0 1 file changed, 4 insertions(+= ), 1 deletion(-) >>=20 >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> diff --git a/lisp/term.el b/lisp/ter= m.el >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> index b8466b21332..5dd73447cfb 100644 >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> --- a/lisp/term.el >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> +++ b/lisp/term.el >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> @@ -494,7 +494,10 @@ term-scroll-to-= bottom-on-output >>=20 >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro>=C2=A0 See variable `term-scroll-show= -maximum-output'. >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro>=C2=A0 This variable is buffer-local." >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> -=C2=A0 :type 'boolean >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> +=C2=A0 :type '(choice (const :tag "= Don't scroll" nil) >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (const :tag= "Scroll selected window Mauro> only" this) >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (const :tag= "Scroll unselected windows" Mauro> others) >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (other :tag= "Scroll all windows" t)) >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro>=C2=A0=C2=A0=C2=A0 :group 'term) >>=20 >> The code (and the docstring) also mention 'all. Mauro> I know, that's why I put other, to catch either t or 'all, since= it Mauro> doesn't make sense to have 2 different items for the same option= . And Mauro> adding something to match only t or 'all didn't seem worth the t= rouble. Mauro> Am I missing something? Both before and after your patch, the defcustom and the docstring disagree. The docstring says 'all', but that=CA=BCs not a value you can get via customize. Personally I=CA=BCd be inclined to delete 'all' from the docstring. People already using 'all' won=CA=BCt notice, since the code will still recognize it. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 18 11:29:55 2023 Received: (at 66071) by debbugs.gnu.org; 18 Sep 2023 15:29:55 +0000 Received: from localhost ([127.0.0.1]:54116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiGCA-0000Vf-P6 for submit@debbugs.gnu.org; Mon, 18 Sep 2023 11:29:55 -0400 Received: from mail-oa1-x36.google.com ([2001:4860:4864:20::36]:55602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiGC6-0000VO-3G for 66071@debbugs.gnu.org; Mon, 18 Sep 2023 11:29:53 -0400 Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-1c8e9d75ce1so2358524fac.3 for <66071@debbugs.gnu.org>; Mon, 18 Sep 2023 08:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695050976; x=1695655776; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2wbARctrhZlC/MmqLgjYa4KYV/mAkPxGMJ8cqXhMIRo=; b=NyFyRnYQ1hq7V6fLiZ4xJ6sTYFOQtk0ccO92PuTeLdaqY0QLASeASb+afr2kGfqGm3 POuS8UjMaev/6DvkPvsuBpITn6CvXeYQG/jpsaUiOzE6JyzhSZEKqVLy67NuuLcV39Jh unf5/o65ISV9WV9QQXhBr66oN7wZ6YxlRijNy6IfdzQPRUWlVi+hYcyZ4CM/MutMrFdi wBGdDE1cvEAujHRGaA6aktq0ZFEx6EE8IvuheA6A6vDQEYaG4ASw94gnG1rVKUay+zV1 VUCDtahP/MXay8QfVB+8/1OBR1mtNRPdCS/J6LLMQxx2lUjxgnwGOyjVXe8Y6LtNbrmN V8Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695050976; x=1695655776; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2wbARctrhZlC/MmqLgjYa4KYV/mAkPxGMJ8cqXhMIRo=; b=ev8aFLRJ7RXmAQKXd4FRpoiYHx6ehZK2CJ1zsxbnRaqHwksxQxs5MmkNxfo8aZ4iOh cqlhFlMEEc2Kw77fgK3FYdNimdGEdJPtDj5pWXH0iDFs6AIMVSXyDF5dwzu1b8xzCwQk Dfhtx3ZxyF5LdjSv0bUdnfS9awnSJHWTq9t4z+dVAQDKmfAYex314sOTiTrO5bg0l5T/ zBkLK56l+Jw/3G2PrpyjiOYVrmM+aDVgy/hZoQV+N0YwNdagjBDPW9tNHrXHBMXkSW9D 5Gavx1LiSdN2C9InRwRe3kUG/NAhsJ8nIsTcIQeelH92PSwJXq3HIi6XTOclFUKEUsOE a27w== X-Gm-Message-State: AOJu0Yz9Bs+P28Ud1A0G/y/++W6tM99dfkA1qJ/APaDBkAfdpXQG78mV O8Mmg+4ZSDyWLf/vXiAtIY8= X-Google-Smtp-Source: AGHT+IGh0uhsNTLBfL9mvQgiECzuwL0B98xl8qJota90kmTRFdzUL+5XeAbGal03O07SM7+MDkTWsg== X-Received: by 2002:a05:6870:6192:b0:1c8:39a6:77a9 with SMTP id a18-20020a056870619200b001c839a677a9mr9551892oah.31.1695050975846; Mon, 18 Sep 2023 08:29:35 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id r21-20020a056870625500b001d4f1ec39b3sm5026011oak.23.2023.09.18.08.29.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Sep 2023 08:29:35 -0700 (PDT) Message-ID: <6098e8a4-71bf-19e3-b274-387cca582ab4@gmail.com> Date: Mon, 18 Sep 2023 12:29:30 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#66071: 30.0.50; term-scroll-to-bottom-on-output missing choices Content-Language: en-US To: Robert Pluim References: <147ab958-899e-07cc-f175-52ad2d25e54b@gmail.com> <871qevk1fh.fsf@gmail.com> <53e55fdd-598d-efd3-e3ac-9cc19334b47c@gmail.com> <87wmwnik0q.fsf@gmail.com> From: Mauro Aranda In-Reply-To: <87wmwnik0q.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.5 (-) X-Debbugs-Envelope-To: 66071 Cc: 66071@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) On 18/9/23 12:22, Robert Pluim wrote: >>>>>> On Mon, 18 Sep 2023 12:12:41 -0300, Mauro Aranda said: > >     Mauro> On 18/9/23 11:20, Robert Pluim wrote: >     >> On Mon, 18 Sep 2023 09:20:07 -0300, Mauro Aranda >     Mauro>   said: >     >>      Mauro> Patch attached. >     >> >     >>      Mauro> From d891a9f705b3b4af2aedeed645f4636535ea6c2e Mon Sep 17 >     Mauro>  00:00:00 2001 >     >>      Mauro> From: Mauro Aranda >     >>      Mauro> Date: Mon, 18 Sep 2023 09:19:04 -0300 >     >>      Mauro> Subject: [PATCH] Fix term-scroll-to-bottom-on-output >     Mauro>  :type (Bug#66071) >     >> >     >>      Mauro> * lisp/term.el (term-scroll-to-bottom-on-output): Add >     Mauro>  missing choices. >     >>      Mauro> --- >     >>      Mauro>  lisp/term.el | 5 ++++- >     >>      Mauro>  1 file changed, 4 insertions(+), 1 deletion(-) >     >> >     >>      Mauro> diff --git a/lisp/term.el b/lisp/term.el >     >>      Mauro> index b8466b21332..5dd73447cfb 100644 >     >>      Mauro> --- a/lisp/term.el >     >>      Mauro> +++ b/lisp/term.el >     >>      Mauro> @@ -494,7 +494,10 @@ term-scroll-to-bottom-on-output >     >> >     >>      Mauro>  See variable `term-scroll-show-maximum-output'. >     >>      Mauro>  This variable is buffer-local." >     >>      Mauro> -  :type 'boolean >     >>      Mauro> +  :type '(choice (const :tag "Don't scroll" nil) >     >>      Mauro> +                 (const :tag "Scroll selected window >     Mauro>  only" this) >     >>      Mauro> +                 (const :tag "Scroll unselected windows" >     Mauro>  others) >     >>      Mauro> +                 (other :tag "Scroll all windows" t)) >     >>      Mauro>    :group 'term) >     >> >     >> The code (and the docstring) also mention 'all. > >     Mauro> I know, that's why I put other, to catch either t or 'all, since it >     Mauro> doesn't make sense to have 2 different items for the same option. And >     Mauro> adding something to match only t or 'all didn't seem worth the trouble. > >     Mauro> Am I missing something? > > Both before and after your patch, the defcustom and the docstring > disagree. The docstring says 'all', but thatʼs not a value you can get > via customize. > > Personally Iʼd be inclined to delete 'all' from the docstring. People > already using 'all' wonʼt notice, since the code will still recognize > it. That's fine by me, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 24 07:39:24 2023 Received: (at submit) by debbugs.gnu.org; 24 Sep 2023 11:39:24 +0000 Received: from localhost ([127.0.0.1]:41182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkNSN-0006y9-Uw for submit@debbugs.gnu.org; Sun, 24 Sep 2023 07:39:24 -0400 Received: from lists.gnu.org ([2001:470:142::17]:51756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkNSJ-0006xh-U1 for submit@debbugs.gnu.org; Sun, 24 Sep 2023 07:39:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkNS2-0002yj-QU for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2023 07:39:02 -0400 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkNS0-0004Sd-3W for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2023 07:39:01 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1qkNRx-0006iG-7f for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2023 13:38:57 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Mauro Aranda Subject: Re: bug#66071: 30.0.50; term-scroll-to-bottom-on-output missing choices Date: Sun, 24 Sep 2023 08:38:51 -0300 Message-ID: <5843bd17-61a0-c67c-1abb-7d2224475c10@gmail.com> References: <147ab958-899e-07cc-f175-52ad2d25e54b@gmail.com> <871qevk1fh.fsf@gmail.com> <53e55fdd-598d-efd3-e3ac-9cc19334b47c@gmail.com> <87wmwnik0q.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------a0L0bACR9inRcu4NW6BwV03h" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Content-Language: en-US In-Reply-To: <87wmwnik0q.fsf@gmail.com> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -9 X-Spam_score: -1.0 X-Spam_bar: - X-Spam_report: (-1.0 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-1.473, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit Cc: 66071@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------a0L0bACR9inRcu4NW6BwV03h Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 18/9/23 12:22, Robert Pluim wrote: >>>>>> On Mon, 18 Sep 2023 12:12:41 -0300, Mauro Aranda said: > > Mauro> On 18/9/23 11:20, Robert Pluim wrote: > >> On Mon, 18 Sep 2023 09:20:07 -0300, Mauro Aranda > Mauro> said: > >> Mauro> Patch attached. > >> > >> Mauro> From d891a9f705b3b4af2aedeed645f4636535ea6c2e Mon Sep 17 > Mauro> 00:00:00 2001 > >> Mauro> From: Mauro Aranda > >> Mauro> Date: Mon, 18 Sep 2023 09:19:04 -0300 > >> Mauro> Subject: [PATCH] Fix term-scroll-to-bottom-on-output > Mauro> :type (Bug#66071) > >> > >> Mauro> * lisp/term.el (term-scroll-to-bottom-on-output): Add > Mauro> missing choices. > >> Mauro> --- > >> Mauro> lisp/term.el | 5 ++++- > >> Mauro> 1 file changed, 4 insertions(+), 1 deletion(-) > >> > >> Mauro> diff --git a/lisp/term.el b/lisp/term.el > >> Mauro> index b8466b21332..5dd73447cfb 100644 > >> Mauro> --- a/lisp/term.el > >> Mauro> +++ b/lisp/term.el > >> Mauro> @@ -494,7 +494,10 @@ term-scroll-to-bottom-on-output > >> > >> Mauro> See variable `term-scroll-show-maximum-output'. > >> Mauro> This variable is buffer-local." > >> Mauro> - :type 'boolean > >> Mauro> + :type '(choice (const :tag "Don't scroll" nil) > >> Mauro> + (const :tag "Scroll selected window > Mauro> only" this) > >> Mauro> + (const :tag "Scroll unselected windows" > Mauro> others) > >> Mauro> + (other :tag "Scroll all windows" t)) > >> Mauro> :group 'term) > >> > >> The code (and the docstring) also mention 'all. > > Mauro> I know, that's why I put other, to catch either t or 'all, since it > Mauro> doesn't make sense to have 2 different items for the same option. And > Mauro> adding something to match only t or 'all didn't seem worth the trouble. > > Mauro> Am I missing something? > > Both before and after your patch, the defcustom and the docstring > disagree. The docstring says 'all', but thatʼs not a value you can get > via customize. > > Personally Iʼd be inclined to delete 'all' from the docstring. People > already using 'all' wonʼt notice, since the code will still recognize > it. > > Robert I've incorporated your suggestion in the attached patch. --------------a0L0bACR9inRcu4NW6BwV03h Content-Type: text/x-patch; charset=UTF-8; name="0001-Fix-term-scroll-to-bottom-on-output-type-Bug-66071.patch" Content-Disposition: attachment; filename*0="0001-Fix-term-scroll-to-bottom-on-output-type-Bug-66071.patc"; filename*1="h" Content-Transfer-Encoding: base64 RnJvbSBkOWY3ZGEzY2U1MjRhOTYwM2M4MDhmNTFlMzRhZjk5NDYwMjIzNGQ5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IE1vbiwgMTggU2VwIDIwMjMgMDk6MTk6MDQgLTAzMDAKU3ViamVjdDog W1BBVENIXSBGaXggdGVybS1zY3JvbGwtdG8tYm90dG9tLW9uLW91dHB1dCA6dHlwZSAoQnVn IzY2MDcxKQoKKiBsaXNwL3Rlcm0uZWwgKHRlcm0tc2Nyb2xsLXRvLWJvdHRvbS1vbi1vdXRw dXQpOiBBZGQgbWlzc2luZyBjaG9pY2VzLgpEb24ndCBhZHZlcnRpc2UgdGhlIHZhbHVlIGFs bCBhbnltb3JlLgotLS0KIGxpc3AvdGVybS5lbCB8IDkgKysrKysrKy0tCiAxIGZpbGUgY2hh bmdlZCwgNyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xp c3AvdGVybS5lbCBiL2xpc3AvdGVybS5lbAppbmRleCBiODQ2NmIyMTMzMi4uYjI4NzVlNGEx N2YgMTAwNjQ0Ci0tLSBhL2xpc3AvdGVybS5lbAorKysgYi9saXNwL3Rlcm0uZWwKQEAgLTQ4 Niw3ICs0ODYsNyBAQCB0ZXJtLWNoYXItbW9kZS1wb2ludC1hdC1wcm9jZXNzLW1hcmsKIAog KGRlZmN1c3RvbSB0ZXJtLXNjcm9sbC10by1ib3R0b20tb24tb3V0cHV0IG5pbAogICAiQ29u dHJvbHMgd2hldGhlciBpbnRlcnByZXRlciBvdXRwdXQgY2F1c2VzIHdpbmRvdyB0byBzY3Jv bGwuCi1JZiBuaWwsIHRoZW4gZG8gbm90IHNjcm9sbC4gIElmIHQgb3IgYGFsbCcsIHNjcm9s bCBhbGwgd2luZG93cyBzaG93aW5nIGJ1ZmZlci4KK0lmIG5pbCwgdGhlbiBkbyBub3Qgc2Ny b2xsLiAgSWYgdCwgc2Nyb2xsIGFsbCB3aW5kb3dzIHNob3dpbmcgYnVmZmVyLgogSWYgYHRo aXMnLCBzY3JvbGwgb25seSB0aGUgc2VsZWN0ZWQgd2luZG93LgogSWYgYG90aGVycycsIHNj cm9sbCBvbmx5IHRob3NlIHRoYXQgYXJlIG5vdCB0aGUgc2VsZWN0ZWQgd2luZG93LgogCkBA IC00OTQsNyArNDk0LDEyIEBAIHRlcm0tc2Nyb2xsLXRvLWJvdHRvbS1vbi1vdXRwdXQKIAog U2VlIHZhcmlhYmxlIGB0ZXJtLXNjcm9sbC1zaG93LW1heGltdW0tb3V0cHV0Jy4KIFRoaXMg dmFyaWFibGUgaXMgYnVmZmVyLWxvY2FsLiIKLSAgOnR5cGUgJ2Jvb2xlYW4KKyAgOnR5cGUg JyhjaG9pY2UgKGNvbnN0IDp0YWcgIkRvbid0IHNjcm9sbCIgbmlsKQorICAgICAgICAgICAg ICAgICAoY29uc3QgOnRhZyAiU2Nyb2xsIHNlbGVjdGVkIHdpbmRvdyBvbmx5IiB0aGlzKQor ICAgICAgICAgICAgICAgICAoY29uc3QgOnRhZyAiU2Nyb2xsIHVuc2VsZWN0ZWQgd2luZG93 cyIgb3RoZXJzKQorICAgICAgICAgICAgICAgICA7OyBXZSBhbHNvIHJlY29nbml6ZSBgYWxs JywgYnV0IHdlIGRvbid0IGFkdmVydGlzZSBpdAorICAgICAgICAgICAgICAgICA7OyBhbnlt b3JlLiAgKEJ1ZyM2NjA3MSkKKyAgICAgICAgICAgICAgICAgKG90aGVyIDp0YWcgIlNjcm9s bCBhbGwgd2luZG93cyIgdCkpCiAgIDpncm91cCAndGVybSkKIAogKGRlZmN1c3RvbSB0ZXJt LXNjcm9sbC1zbmFwLXRvLWJvdHRvbSB0Ci0tIAoyLjM0LjEKCg== --------------a0L0bACR9inRcu4NW6BwV03h-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 30 19:37:11 2023 Received: (at 66071-done) by debbugs.gnu.org; 30 Sep 2023 23:37:11 +0000 Received: from localhost ([127.0.0.1]:60046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmjWI-0003wy-NQ for submit@debbugs.gnu.org; Sat, 30 Sep 2023 19:37:10 -0400 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]:44066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmjWH-0003wi-7r for 66071-done@debbugs.gnu.org; Sat, 30 Sep 2023 19:37:09 -0400 Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-50433d8385cso23185045e87.0 for <66071-done@debbugs.gnu.org>; Sat, 30 Sep 2023 16:36:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696117007; x=1696721807; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=RPpQRWqxBK95OtqPqDD3BWimQzIqwjVCa8Y1xgbYcRw=; b=lozeTPvvYdMzDBXEOl805A7csSaci2pZ8l3p5f53d3dvTdzomv/xTAYS805ZdNnzqx QkQN+aL0CAOka8WXGgVt9zm0rGkAMMtj5JRMBzPJll1XVmb559yevXxiK+nd85ssFSwl RfyPIccR1HEWVSLs8j3u4QbNC6Ldrk3HJW0TGOZwmHVN9RQeiIqCzkXmwG/KpvfSKpxZ +wbxutMc1ma7x6HDR5dLOnQNVWLK8Xu/3cFbLrjablbK5Z67KW3mxPgTLe0mcC7cF22G nD8P/SrO8B6I+ZF0VSqF1bSPGNr4zXlI8ZCSA4UIYZkLeIav/hf19wqzfMYqH1QmtgkI 7Q9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696117007; x=1696721807; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RPpQRWqxBK95OtqPqDD3BWimQzIqwjVCa8Y1xgbYcRw=; b=hMblU5WTqE3xNz7Cp847keFbTlZGVeTo3BjBbztFIKj13xuqATv5ZJwWTi3RwjLWn8 MAdRagcYAorWE3LjXKG5qGLAB9yIIvHQ3Ubjfbg8yntvrEZYgHaBb0ELbcoZCCX2hwrc riLuuXEfP1n2FaceyPILcf5XrzNs40xsGkqMO5P+uzYSMo59tNVRdJdjaT/SXS9YnJDd pOC1ib06mhW9/fjat9ghaA0NrMcoHxm5+Rs9SAisHWq2A+KaEhlHggMpZIF0fzEvni+r PZ5lPZEEO1hRnPnZpHxJMY8P24rrb3cBzLiF0do6y7GY8da3LspOap7/QkrvURCHSFM6 f/7Q== X-Gm-Message-State: AOJu0YyXio7hGFJNK/1HEeJP8VbQLCO4Nj7d2VhJFRZz45RBPFCM8Pdx gYWx4S9yj8QYWpjTKbsimWHM0KPD47xg80pILbhEE0ZH X-Google-Smtp-Source: AGHT+IHE2Imu0muNCOEavjYP5v4DQvX1xsfvSFdQSzJ2Rxsivbirke2CcyYXSd4XWvphvaDx2M0s/YfT6sK8RB/AH6Q= X-Received: by 2002:a19:a40a:0:b0:503:9c2:e44e with SMTP id q10-20020a19a40a000000b0050309c2e44emr6491251lfc.55.1696117007418; Sat, 30 Sep 2023 16:36:47 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 30 Sep 2023 16:36:47 -0700 From: Stefan Kangas In-Reply-To: <5843bd17-61a0-c67c-1abb-7d2224475c10@gmail.com> (Mauro Aranda's message of "Sun, 24 Sep 2023 08:38:51 -0300") References: <147ab958-899e-07cc-f175-52ad2d25e54b@gmail.com> <871qevk1fh.fsf@gmail.com> <53e55fdd-598d-efd3-e3ac-9cc19334b47c@gmail.com> <87wmwnik0q.fsf@gmail.com> <5843bd17-61a0-c67c-1abb-7d2224475c10@gmail.com> MIME-Version: 1.0 Date: Sat, 30 Sep 2023 16:36:47 -0700 Message-ID: Subject: Re: bug#66071: 30.0.50; term-scroll-to-bottom-on-output missing choices To: Mauro Aranda Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66071-done Cc: 66071-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 29.2 Mauro Aranda writes: > I've incorporated your suggestion in the attached patch. Thanks, installed on emacs-29. [1: 47770b0eca4]: 2023-10-01 01:35:23 +0200 Fix term-scroll-to-bottom-on-output :type https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=47770b0eca4ba94f6b2a5dd740ff42023c8159c4 From unknown Mon Jun 23 07:50:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 29 Oct 2023 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator