Subject: Re: bug#66068: 30.0.50; xwidget-webkit-browse-url makes Emacs abort

From: Po Lu <[email-masked]>
Date: Sat, 14 Sep 2024 20:11:51 +0800

Eli Zaretskii <[email-masked]> writes:

> Ping! Po Lu, could you please respond?
>
>> Cc: [email-masked]
>> Date: Sat, 07 Sep 2024 12:32:02 +0300
>> From: Eli Zaretskii <[email-masked]>
>> 
>> > Date: Wed, 4 Sep 2024 12:23:28 +0100 (BST)
>> > From: Peter Oliver <[email-masked]>
>> > 
>> > If my understanding of this bug is correct, newer versions of WebKitGTK reliably crash Emacs, and no-one has been in touch with the WebKitGTK developers, so there are no plans to fix that.
>> > 
>> > If that’s the case, how about this attached patch to disable this feature with problematic versions of the library?
>> > 
>> > From 262ea1bb8c47f703819f2df4d920a1f15f2c35b9 Mon Sep 17 00:00:00 2001
>> > From: Peter Oliver <[email-masked]>
>> > Date: Wed, 4 Sep 2024 12:12:50 +0100
>> > Subject: [PATCH] Disable xwidgets with recent webkitgtk versions (Bug#66068)
>> > 
>> > * configure.ac: Accept only webkit2gtk-4.* versions less than 2.41.92.
>> > ---
>> >  configure.ac | 5 +++--
>> >  1 file changed, 3 insertions(+), 2 deletions(-)
>> > 
>> > diff --git a/configure.ac b/configure.ac
>> > index 28361be4211..1d0ea314f6a 100644
>> > --- a/configure.ac
>> > +++ b/configure.ac
>> > @@ -4511,10 +4511,11 @@ AC_DEFUN
>> >  if test "$with_xwidgets" != "no"; then
>> >    if test "$USE_GTK_TOOLKIT" = "GTK3" && test "$window_system" != "none"; then
>> >      WEBKIT_REQUIRED=2.12
>> > -    WEBKIT_MODULES="webkit2gtk-4.1 >= $WEBKIT_REQUIRED"
>> > +    WEBKIT_BROKEN=2.41.92
>> > +    WEBKIT_MODULES="webkit2gtk-4.1 >= $WEBKIT_REQUIRED webkit2gtk-4.1 < $WEBKIT_BROKEN"
>> >      EMACS_CHECK_MODULES([WEBKIT], [$WEBKIT_MODULES])
>> >      if test "$HAVE_WEBKIT" = "no"; then
>> > -      WEBKIT_MODULES="webkit2gtk-4.0 >= $WEBKIT_REQUIRED"
>> > +      WEBKIT_MODULES="webkit2gtk-4.0 >= $WEBKIT_REQUIRED webkit2gtk-4.0 < $WEBKIT_BROKEN"
>> >        EMACS_CHECK_MODULES([WEBKIT], [$WEBKIT_MODULES])
>> >      fi
>> >      HAVE_XWIDGETS=$HAVE_WEBKIT
>> > -- 
>> > 2.46.0
>> > 
>> 
>> Po Lu, any objections to this patch?

IMHO if recent WebKitGTK releases are to be rejected, xwidgets should
also be disabled on Mac OS, till they are available on up-to-date free
systems again.  But I have no objections to this patch, strictly
speaking.