GNU bug report logs - #66052
[PATCH gnome-team 0/1] Update tracker, and ignore i686 missing tests

Previous Next

Full log

View this message in rfc822 format

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>,66052 <at> debbugs.gnu.org
Cc: rg <at> raghavgururajan.name, maxim.cournoyer <at> gmail.com
Subject: [bug#66052] [PATCH gnome-team v2] gnu: tracker: Update to 3.6.0.
Date: Sun, 17 Sep 2023 13:29:18 +0200

* gnu/packages/gnome.scm (tracker): Update to 3.6.0.
[#:phases]: Add 'disable-i686-failing-tests'.
---

So, I can add a reply here, below the ---?

> You can (and probably should) make this into a ‘disable-failing-tests’ or
> inline it into an existing one.  Otherwise LGTM but waiting for CI to test.

This is only for i686, I want to keep all tests for x86_64. So, it’s named
'disable-i686-failing-tests'.

I would not hold my breath for CI. Looking at the qa-frontpage repository, I
suspect the base for all QA builds is always master (it invokes "git tag
base-for-issue-*" without a specific branch name), so it will likely fail.

Best regards,

Vivien

 gnu/packages/gnome.scm | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 2077478ff2..e38aa6622a 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -9387,7 +9387,7 @@ (define-public gnome-autoar
 (define-public tracker
   (package
     (name "tracker")
-    (version "3.5.3")
+    (version "3.6.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "mirror://gnome/sources/tracker/"
@@ -9395,7 +9395,7 @@ (define-public tracker
                                   "tracker-" version ".tar.xz"))
               (sha256
                (base32
-                "1vi878f95a2nlvqz46ph6f05hywjb2ni0znqavhdkrbvi6qchrhl"))))
+                "1whdqidxmagsc35pmz9kcc5vs3bmvbkmnis7prnx3zxs37z2qnaj"))))
     (build-system meson-build-system)
     (arguments
      (list
@@ -9417,6 +9417,20 @@ (define-public tracker
               (substitute* "utils/trackertestutils/__main__.py"
                 (("/bin/bash")
                  (search-input-file inputs "bin/bash")))))
+          #$@(if (target-x86-32?)
+                 ;; On 32-bit systems, the far away dates are incorrect, and
+                 ;; the floats are not parsed exactly.
+                 (list
+                  #~(add-after 'unpack 'disable-i686-failing-tests
+                      (lambda _
+                        (substitute* "tests/libtracker-sparql/tracker-statement-test.c"
+                          (("g_assert_cmpfloat *\\((.*), ==, ([0-9.e-]+)\\);" total actual expected)
+                           (string-append "g_assert_cmpfloat_with_epsilon ("
+                                          actual ", " expected ", 1e-12);")))
+                        (substitute* "tests/core/tracker-sparql-test.c"
+                          (("\\{ \"datetime/direct-1\", .* \\},")
+                           "/* datetime test disabled */")))))
+                 '())
           (add-before 'configure 'set-shell
             (lambda _
               (setenv "SHELL" (which "bash"))))

base-commit: e9ff5d51e3297089e66c124195e1f1b42dbded65
-- 
2.41.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.