From unknown Thu Jun 19 14:06:02 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#66043 <66043@debbugs.gnu.org> To: bug#66043 <66043@debbugs.gnu.org> Subject: Status: [PATCH 0/2] Update bcachefs-tools to 1.2 and restyle package Reply-To: bug#66043 <66043@debbugs.gnu.org> Date: Thu, 19 Jun 2025 21:06:02 +0000 retitle 66043 [PATCH 0/2] Update bcachefs-tools to 1.2 and restyle package reassign 66043 guix-patches submitter 66043 Ahmad Draidi severity 66043 normal tag 66043 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 17 02:29:08 2023 Received: (at submit) by debbugs.gnu.org; 17 Sep 2023 06:29:08 +0000 Received: from localhost ([127.0.0.1]:48899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhlHI-00067r-0s for submit@debbugs.gnu.org; Sun, 17 Sep 2023 02:29:08 -0400 Received: from lists.gnu.org ([2001:470:142::17]:54150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhlHE-00067K-OA for submit@debbugs.gnu.org; Sun, 17 Sep 2023 02:29:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhlGy-0003mO-Ed for guix-patches@gnu.org; Sun, 17 Sep 2023 02:28:48 -0400 Received: from rainycloud.ext.redscript.org ([103.105.48.212]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qhlGw-0004Cc-3L for guix-patches@gnu.org; Sun, 17 Sep 2023 02:28:48 -0400 Received: from localhost.localdomain (bba-86-99-176-46.alshamil.net.ae [86.99.176.46]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by rainycloud.ext.redscript.org (Postfix) with ESMTPSA id 53F5271D; Sun, 17 Sep 2023 06:28:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redscript.org; s=mail1-rsa; t=1694932116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=lF8nfwTJE86Z1KEEODjxPwcbCN66Kl3xr8OkQor/SAI=; b=GswlY7BSONNWRyzEgOz00qpKI63Im9ykqXgMECzCDQg7aPCH4JD39lCPmK/chp4ThQcmUa ykd+o/Mlxdg/woi2cjj8QWCICCRWxoXfF7ubWc9SnssAGJIRccyEytAYTDq9btReLjqWHV oL3C45fcfjyzwEg35SxxaEmZ/WkWwzpZWrgf5YD4NxnAPIXZau7H7azRD9YSi0yafxq9OT 0kq/26tVu/LLrMZhT+TXh7TJvPd5BZzWFbG+F0NZXFqcZ3nrWFKPeDhWx7y4cH2gw1cM9Y kcqqG7vAODs9gJqpaRdySUaHXKZpZJPDwIiN3OFJ7UwR4P99+jTQqryswnzDyGfYUAld2S K1dvKdVO8haR0vmTnhwHL1F7MTLptvo4xCDzQuLgkcz4PZSQJ7AVjQRiOpBN4K9fpa8zLk 25eNJB7Lsxtfwx6tjhUTtCGyQgkfs+E/VEmQ7g/MIiRiwhWQ6WI958PH+Zu4mxi6FhcHRk X8+lYKKw5ZvddGBd6YyakB8jYnZPIs72dZcQeQKtOstRGf/jyoMUMlHfR3Vntxu2+9oFHH xXxL4ulV1wIk06Pfg3/jYJbtY0YirwMLNgNjW6t2VKpejedTMhhlUjJkXb9dw33By537Pi 7gWhVaQpUO3CM2Hc4Zfbb8SugAYK77h4hfMb8wTwtN+ZSeMqWgY30= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=redscript.org; s=mail1-ed25519; t=1694932116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=lF8nfwTJE86Z1KEEODjxPwcbCN66Kl3xr8OkQor/SAI=; b=d4f0Lfl2Y2fNgghfvHWLBEvbVcj7Cnin+cO1rhBcs5xNIX2LItho6/ap1aUOCX3CimTBch IMH6ErzXUGqIEAAQ== From: Ahmad Draidi To: guix-patches@gnu.org Subject: [PATCH 0/2] Update bcachefs-tools to 1.2 and restyle package Date: Sun, 17 Sep 2023 10:27:48 +0400 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=103.105.48.212; envelope-from=a.r.draidi@redscript.org; helo=rainycloud.ext.redscript.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Ahmad Draidi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Hello Guix, Who else is excited for bcachefs being merged upstream soon? :) This patch series updates bcachefs-tools to version 1.2 and restyles the package since we removed a level of parentheses. Ahmad Draidi (2): gnu: bcachefs-tools: Update to 1.2. gnu: bcachefs-tools: Restyle format. gnu/packages/file-systems.scm | 165 +++++++++++++++++----------------- 1 file changed, 84 insertions(+), 81 deletions(-) base-commit: 9b78699744b0c4c8af28820cc4f0d59b9d317ead -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 17 02:39:13 2023 Received: (at 66043) by debbugs.gnu.org; 17 Sep 2023 06:39:13 +0000 Received: from localhost ([127.0.0.1]:48917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhlR3-0006Om-7v for submit@debbugs.gnu.org; Sun, 17 Sep 2023 02:39:13 -0400 Received: from rainycloud.ext.redscript.org ([2402:28c0:4:1081::1]:51772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhlR0-0006OP-AA for 66043@debbugs.gnu.org; Sun, 17 Sep 2023 02:39:12 -0400 Received: from localhost.localdomain (bba-86-99-176-46.alshamil.net.ae [86.99.176.46]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by rainycloud.ext.redscript.org (Postfix) with ESMTPSA id CAEAB71D; Sun, 17 Sep 2023 06:38:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redscript.org; s=mail1-rsa; t=1694932735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C23FIy7eDhig6tRFFlW/lgHPzM7cJjex45Uoqnwxmj0=; b=ectH8JPzXCAWMPSv7gxa0C1aEIN+wJoS4qm65Ea68xsFa+D5ezXGRXepvVIyl3HsCUtvQw 7sF8HzRAh82xtseWCOLxDGIfAa6Hf5/kH4DFALsbdkVluqNMg3KhCbCsaGESYskWl1PiKx RDPMsq/w1Pnyu913OfsnU7cfjGjTt76hymFmrahQz79xVlJrLaY2cQoFnBJ9OYdwsGOw+p 4I7m5yS+POJB89KwzYtMbfujlUaaP1F5PiONwNS58WpY4521v+9FwHa4JIAgsX2vUeVKP+ 8JtFBy9YOBIwNW93NDlrrnBctmsl/VsdN4FPiCzsvxvJYjhd5SKEWZlVXQJK/6PT4Kpalc Wm1pfNv02u5UD0nbk6FPJvk0Z8t8OWyLdCgQWrs0EgQHjEGnb1SBby4p7Fb22/CPQAKmZS Z2xiX6YtP6jG7yRKfi56KfAX3Pnq2XLo/+45A5efqF8f6pKITUV3efZdsPfusow2tK8PSo 46Zb5XAV/TmxKT3tOpX4xD5Vv+fRUsMHYFQOO27Xs2Dn7w3eVqI3x1tgWs8+M1deE3WOKF D69WOyKeIOiGWkozl7MV3IasYP4+AWauUV9/iX8n4gC9vkGYqtzI4O/82Hab7j76eYdLNW AUhYdxxOc+TWYTXXOCEqcAwG2gZr7jFpl/6uJ8zTHQuj+3k6QWc1Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=redscript.org; s=mail1-ed25519; t=1694932735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C23FIy7eDhig6tRFFlW/lgHPzM7cJjex45Uoqnwxmj0=; b=LYNK5SwUpM2h9Qxb45YKS6x4+F0rVWRXJ+vVtkfi3rRXU6Y3KzvO+cAMiEPADbqGncm9g7 BiU75eC5GBTLWgAg== From: Ahmad Draidi To: 66043@debbugs.gnu.org Subject: [PATCH 1/2] gnu: bcachefs-tools: Update to 1.2. Date: Sun, 17 Sep 2023 10:38:00 +0400 Message-ID: <07551578b686f549623e635e87fe0b29301191d4.1694931512.git.a.r.draidi@redscript.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66043 Cc: Ahmad Draidi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/file-systems.scm (bcachefs-tools): Update to 1.2. [source]: Use version instead of commit. --- gnu/packages/file-systems.scm | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/gnu/packages/file-systems.scm b/gnu/packages/file-systems.scm index 0d98e23e93..efa26a199a 100644 --- a/gnu/packages/file-systems.scm +++ b/gnu/packages/file-systems.scm @@ -575,20 +575,18 @@ (define-public gphotofs (license license:gpl2+))) (define-public bcachefs-tools - (let ((commit "c8bec83e307f28751c433ba1d3f648429fb5a34c") - (revision "17")) (package (name "bcachefs-tools") - (version (git-version "0.1" revision commit)) + (version "1.2") (source (origin (method git-fetch) (uri (git-reference (url "https://evilpiepirate.org/git/bcachefs-tools.git") - (commit commit))) + (commit (string-append "v" version)))) (file-name (git-file-name name version)) (sha256 - (base32 "0b1avy5mw3r3ppfs3n9cq4zb74yl45nd5l69r6hi27z9q5bc3nv8")))) + (base32 "0wgqclkkdkqis3aq6wp0kcn1bsynybm3dnpcf7vlcvx85kdmcxg8")))) (build-system gnu-build-system) (arguments (list #:make-flags @@ -664,7 +662,7 @@ (define-public bcachefs-tools In addition, bcachefs provides all the functionality of bcache, a block-layer caching system, and lets you assign different roles to each device based on its performance and other characteristics.") - (license license:gpl2+)))) + (license license:gpl2+))) (define-public bcachefs-tools/static (package -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 17 02:39:18 2023 Received: (at 66043) by debbugs.gnu.org; 17 Sep 2023 06:39:18 +0000 Received: from localhost ([127.0.0.1]:48919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhlR7-0006Ox-J1 for submit@debbugs.gnu.org; Sun, 17 Sep 2023 02:39:18 -0400 Received: from rainycloud.ext.redscript.org ([2402:28c0:4:1081::1]:51780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhlR2-0006OU-AD for 66043@debbugs.gnu.org; Sun, 17 Sep 2023 02:39:13 -0400 Received: from localhost.localdomain (bba-86-99-176-46.alshamil.net.ae [86.99.176.46]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by rainycloud.ext.redscript.org (Postfix) with ESMTPSA id 9714A86E; Sun, 17 Sep 2023 06:38:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redscript.org; s=mail1-rsa; t=1694932739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QbbTcweI924GT8kPSIoBCgbMkged0a61iA+X/99HL38=; b=UJd8YKPpS3sTUihao7H1ycUyU1vKQegEDs1OEo+tOuVC13heL4VNfjjiH4vxhvfBw+Koch U8ORJ1vT2nZJvwhKnVqHe2xXFaX6OXQMkOYIBijRrFpoQkkAZH/GpkQ23toD6dW/EK2Hyf Zvadp9RJKHx473ZI8uI6ElAn5G6vFLtddNkwpMxIXerAu8TsmtIsFyPHsfbKKurKx59GCV wGfpWUfAUpgcJm8GCWUOvLUlI/iQLBi5wPKrpHQVf1YGobF7USF7sQicmJTUSOEdVr3y2w msmLAIZDJY+HtZKfiQWpsxtUsiXAnq3aBSvlH+b94X+1cQKl0iKoiozJ7jN0DZ/5SsmJNm uLi4fQJae0QVz4O8R1cs4Qizm3qYvwFEYsTwkeuiG3wZnzk+NDwNFhjvSICh6hgWkKBxtf OOBeQJQYslovMcK6wtQpJs5cGqSPcJYghpSiaCscgAcTTNlvSd/42oiP5Po/kx3Lt7xl6T rpn6ql8H2RAXa9ta66wPGMFbpQ7CiMPdDP0B4AxNx3nwN++VWKzlnbnRmsfaGk6psKl0N+ qWEb8wSD5aJo86y//MVvcF2K5INndO6t5jAKABeJWh6DHip5TIjLcZzz0dsiJshQwBsAKo HuKwlKaFwN5YfkIhZrf5wuimA0aOcdOeEay+CS9iMESE+wMeLClsA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=redscript.org; s=mail1-ed25519; t=1694932739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QbbTcweI924GT8kPSIoBCgbMkged0a61iA+X/99HL38=; b=uwAMa0QeEEB5WSBWRl5JXGDo+5i1z/BaR+UHT6EPWeRBwn/S1mT3HUYYv6xXOTVIxTwt1L vb7OPGlKEGG4sIBw== From: Ahmad Draidi To: 66043@debbugs.gnu.org Subject: [PATCH 2/2] gnu: bcachefs-tools: Restyle format. Date: Sun, 17 Sep 2023 10:38:01 +0400 Message-ID: <3e7fa3295d876267df6babbb9a6578a4891822b2.1694931512.git.a.r.draidi@redscript.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66043 Cc: Ahmad Draidi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/file-systems.scm (bcachefs-tools): Reformat with 'guix style' and manually break some long lines. --- gnu/packages/file-systems.scm | 163 ++++++++++++++++++---------------- 1 file changed, 84 insertions(+), 79 deletions(-) diff --git a/gnu/packages/file-systems.scm b/gnu/packages/file-systems.scm index efa26a199a..58fb1b5363 100644 --- a/gnu/packages/file-systems.scm +++ b/gnu/packages/file-systems.scm @@ -575,84 +575,89 @@ (define-public gphotofs (license license:gpl2+))) (define-public bcachefs-tools - (package - (name "bcachefs-tools") - (version "1.2") - (source - (origin - (method git-fetch) - (uri (git-reference - (url "https://evilpiepirate.org/git/bcachefs-tools.git") - (commit (string-append "v" version)))) - (file-name (git-file-name name version)) - (sha256 - (base32 "0wgqclkkdkqis3aq6wp0kcn1bsynybm3dnpcf7vlcvx85kdmcxg8")))) - (build-system gnu-build-system) - (arguments - (list #:make-flags - #~(list (string-append "VERSION=" #$version) ; ‘v…-nogit’ otherwise - (string-append "PREFIX=" #$output) - "INITRAMFS_DIR=$(PREFIX)/share/initramfs-tools" - (string-append "CC=" #$(cc-for-target)) - (string-append "PKG_CONFIG=" #$(pkg-config-for-target)) - ;; ‘This will be less of an option in the future, as more - ;; code gets rewritten in Rust.’ - "NO_RUST=better") - #:phases - #~(modify-phases %standard-phases - (delete 'configure) ; no configure script - (replace 'check - ;; The test suite is moribund upstream (‘never been useful’), - ;; but let's keep running it as a sanity check until then. - (lambda* (#:key tests? make-flags #:allow-other-keys) - (when tests? - ;; We must manually build the test_helper first. - (apply invoke "make" "tests" make-flags) - (invoke (string-append - #$(this-package-native-input "python-pytest") - "/bin/pytest") "-k" - ;; These fail (‘invalid argument’) on kernels - ;; with a previous bcachefs version. - (string-append "not test_format and " - "not test_fsck and " - "not test_list and " - "not test_list_inodes and " - "not test_list_dirent"))))) - (add-after 'install 'patch-shell-wrappers - ;; These are overcomplicated wrappers that invoke readlink(1) - ;; to exec the appropriate bcachefs(8) subcommand. We can - ;; simply patch in the latter file name directly, and do. - (lambda _ - (let ((sbin/ (string-append #$output "/sbin/"))) - (substitute* (find-files sbin/ (lambda (file stat) - (not (elf-file? file)))) - (("SDIR=.*") "") - (("\\$\\{SDIR.*}/") sbin/)))))))) - (native-inputs - (cons* pkg-config - ;; For generating documentation with rst2man. - python - python-docutils - ;; For tests. - python-pytest - (if (member (%current-system) (package-supported-systems valgrind)) - (list valgrind) - '()))) - (inputs - (list eudev - keyutils - libaio - libscrypt - libsodium - liburcu - `(,util-linux "lib") - lz4 - zlib - `(,zstd "lib"))) - (home-page "https://bcachefs.org/") - (synopsis "Tools to create and manage bcachefs file systems") - (description - "The bcachefs-tools are command-line utilities for creating, checking, + (package + (name "bcachefs-tools") + (version "1.2") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://evilpiepirate.org/git/bcachefs-tools.git") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0wgqclkkdkqis3aq6wp0kcn1bsynybm3dnpcf7vlcvx85kdmcxg8")))) + (build-system gnu-build-system) + (arguments + (list #:make-flags #~(list (string-append "VERSION=" + #$version) ;‘v…-nogit’ otherwise + (string-append "PREFIX=" + #$output) + "INITRAMFS_DIR=$(PREFIX)/share/initramfs-tools" + (string-append "CC=" + #$(cc-for-target)) + (string-append "PKG_CONFIG=" + #$(pkg-config-for-target)) + ;; ‘This will be less of an option in the future, as more + ;; code gets rewritten in Rust.’ + "NO_RUST=better") + #:phases #~(modify-phases %standard-phases + (delete 'configure) ;no configure script + (replace 'check + ;; The test suite is moribund upstream (‘never been + ;; useful’), but let's keep running it as a sanity + ;; check until then. + (lambda* (#:key tests? make-flags #:allow-other-keys) + (when tests? + ;; We must manually build the test_helper first. + (apply invoke "make" "tests" make-flags) + (invoke (string-append #$(this-package-native-input + "python-pytest") + "/bin/pytest") "-k" + ;; These fail (‘invalid argument’) on kernels + ;; with a previous bcachefs version. + (string-append "not test_format and " + "not test_fsck and " + "not test_list and " + "not test_list_inodes and " + "not test_list_dirent"))))) + (add-after 'install 'patch-shell-wrappers + ;; These are overcomplicated wrappers that invoke readlink(1) + ;; to exec the appropriate bcachefs(8) subcommand. We can + ;; simply patch in the latter file name directly, and do. + (lambda _ + (let ((sbin/ (string-append #$output "/sbin/"))) + (substitute* (find-files sbin/ + (lambda (file stat) + (not (elf-file? file)))) + (("SDIR=.*") + "") + (("\\$\\{SDIR.*}/") + sbin/)))))))) + (native-inputs (cons* pkg-config + ;; For generating documentation with rst2man. + python + python-docutils + ;; For tests. + python-pytest + (if (member (%current-system) + (package-supported-systems valgrind)) + (list valgrind) + '()))) + (inputs (list eudev + keyutils + libaio + libscrypt + libsodium + liburcu + `(,util-linux "lib") + lz4 + zlib + `(,zstd "lib"))) + (home-page "https://bcachefs.org/") + (synopsis "Tools to create and manage bcachefs file systems") + (description + "The bcachefs-tools are command-line utilities for creating, checking, and otherwise managing bcachefs file systems. Bcachefs is a @acronym{CoW, copy-on-write} file system supporting native @@ -662,7 +667,7 @@ (define-public bcachefs-tools In addition, bcachefs provides all the functionality of bcache, a block-layer caching system, and lets you assign different roles to each device based on its performance and other characteristics.") - (license license:gpl2+))) + (license license:gpl2+))) (define-public bcachefs-tools/static (package -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 25 06:59:38 2023 Received: (at submit) by debbugs.gnu.org; 25 Sep 2023 10:59:38 +0000 Received: from localhost ([127.0.0.1]:44407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkjJR-0008I2-Tn for submit@debbugs.gnu.org; Mon, 25 Sep 2023 06:59:38 -0400 Received: from lists.gnu.org ([2001:470:142::17]:52412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkjJD-0008HW-Eq for submit@debbugs.gnu.org; Mon, 25 Sep 2023 06:59:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkjIu-0002Cm-Rt for guix-patches@gnu.org; Mon, 25 Sep 2023 06:59:05 -0400 Received: from mira.cbaines.net ([212.71.252.8]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qkjIt-0007wQ-CY for guix-patches@gnu.org; Mon, 25 Sep 2023 06:59:04 -0400 Received: from localhost (unknown [217.155.61.229]) by mira.cbaines.net (Postfix) with ESMTPSA id 7D43A27BBE2; Mon, 25 Sep 2023 11:59:01 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id ebdca1ba; Mon, 25 Sep 2023 10:59:01 +0000 (UTC) References: User-agent: mu4e 1.10.5; emacs 28.2 From: Christopher Baines To: Ahmad Draidi Subject: Re: [bug#66043] [PATCH 0/2] Update bcachefs-tools to 1.2 and restyle package Date: Mon, 25 Sep 2023 11:58:36 +0100 In-reply-to: Message-ID: <87bkdq5xjf.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: 66043-done@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Ahmad Draidi via Guix-patches via writes: > Hello Guix, > > Who else is excited for bcachefs being merged upstream soon? :) > > This patch series updates bcachefs-tools to version 1.2 and restyles the > package since we removed a level of parentheses. > > Ahmad Draidi (2): > gnu: bcachefs-tools: Update to 1.2. > gnu: bcachefs-tools: Restyle format. > > gnu/packages/file-systems.scm | 165 +++++++++++++++++----------------- > 1 file changed, 84 insertions(+), 81 deletions(-) Thanks for the patches Ahmad, I've pushed them to master as a5477e3a82114ce2909e63a07c7e6df6da617821. Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmURZ/RfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XeG7w//VcwSk1GWotyi8d6U5+ungMB/Rm7tYijH WLUeVJz0TqZkkifQ0VJkHZuVDF92Y84EkiuPNFiHL5IIqu08qsSzNIo3pyR2Z4HO Za/6iHb8RmHaXzlW93UCgPXy2wI5mddO9RCf5+Ov6yGobofiZnf/BMqCC7U4FPta XHWMU8G0a5DKy7SOOZ8F0jx54ERO/E1gk+ps7IHa9iKNN5BIBulWqB564ti80fDR i7vZ/H/tqX0gYMk5NvSwIaH3cQ0ABbCNUuiJXbolTrpQu0DGyyiToAC48g+Lyk4a +KbxANdGpeAoRDnMZJJF8fgfGeSpvN9pzau65lZjjP2XtCWuh8gEg228+H2bBTuK D2f0x43zS4oaZaGiPoJ58G6MJYdCrc1dnHHz/miKVMjetC+eGTPDATrCMEgYdunW CT2uorA0FccLnmmdguJ7B3YE3293Nf7wxgur1pus+0FlTYzMLjvah7j7gD5pCb66 MSUejS3Y1LbfShuzNxTaLzPrEeG8E5Q+enEeRp9yHD002hY1e/KRmaoyJuDvZbXZ 8vtOn71UEzpGdvO5liBbFACTZSDRnVrPoaq3eWn1FGKKx2rYEjDFu+TJHybDgej/ WAnrv7BIcPp33gBDW0PSZRrSOYTR+DLqaCzJcoN+q2F0FxRzdOD66gCrzKNFfpul ZhJhSsZWbjY= =UPqM -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 26 17:41:29 2023 Received: (at 66043) by debbugs.gnu.org; 26 Sep 2023 21:41:29 +0000 Received: from localhost ([127.0.0.1]:49988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlFo9-0004OT-97 for submit@debbugs.gnu.org; Tue, 26 Sep 2023 17:41:29 -0400 Received: from tobias.gr ([80.241.217.52]:47590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlFo3-0004OH-Pe for 66043@debbugs.gnu.org; Tue, 26 Sep 2023 17:41:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=AQIlK+ZeQg63l A8xyaE2e3QS9W5B4cUOrHzbSDLWa2A=; h=references:in-reply-to:subject:cc: to:from:date; d=tobias.gr; b=fRIxBG2XXK1i/e6GHy3ALVFY10OAEpnekD7utp/J+ Fz1JbKxpDM9+Qc+MDMgwP9ODCvDn44YBJnuiZsZtIUMPR+lJF4pG0gDY7O7zNQF1HcBWw1 Z5AK/1xfTtxjTF8r/z7hI3mveqO2wSNW++3KCOhkO9Tah4xKA/R/rnPHquBnGo2igzazmy Rkifc+OCbnzISUO/d2rrg21wL6XI53jmJapGZT9FsJ4O9pyBOsIzgPk9DG8jtK1/fjLhFG kDS1fjnTuvZialISDq4GL42NN7ZCecpff01TZqKxiemNle6OcW+E18T7oRDh8q8by7X1ha Saj2FvjtyvzkvpQlRZAtQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTP id 5cee0ab7; Tue, 26 Sep 2023 21:41:07 +0000 (UTC) MIME-Version: 1.0 Date: Tue, 26 Sep 2023 23:41:07 +0200 From: Tobias Geerinckx-Rice To: Ahmad Draidi Subject: Re: [bug#66043] [PATCH 2/2] gnu: bcachefs-tools: Restyle format. In-Reply-To: <3e7fa3295d876267df6babbb9a6578a4891822b2.1694931512.git.a.r.draidi@redscript.org> References: <3e7fa3295d876267df6babbb9a6578a4891822b2.1694931512.git.a.r.draidi@redscript.org> Message-ID: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66043 Cc: 66043@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi! Thanks for taking care of the bcachefs-tools package! > Who else is excited for bcachefs being merged upstream soon? :) /me raises hand. Four years of sometimes-painful rebases will not be missed. On 2023-09-17 8:38, Ahmad Draidi via Guix-patches via wrote: > * gnu/packages/file-systems.scm (bcachefs-tools): Reformat with 'guix > style' > and manually break some long lines. I don't think ‘guix style’ improved things anywhere, but hunks like - (list #:make-flags - #~(list (string-append "VERSION=" #$version) ; ‘v…-nogit’ otherwise - (string-append "PREFIX=" #$output) - "INITRAMFS_DIR=$(PREFIX)/share/initramfs-tools" - (string-append "CC=" #$(cc-for-target)) - (string-append "PKG_CONFIG=" #$(pkg-config-for-target)) - ;; ‘This will be less of an option in the future, as more - ;; code gets rewritten in Rust.’ - "NO_RUST=better") + (list #:make-flags #~(list (string-append "VERSION=" + #$version) ;‘v…-nogit’ otherwise + (string-append "PREFIX=" + #$output) + "INITRAMFS_DIR=$(PREFIX)/share/initramfs-tools" + (string-append "CC=" + #$(cc-for-target)) + (string-append "PKG_CONFIG=" + #$(pkg-config-for-target)) + ;; ‘This will be less of an option in the future, as more + ;; code gets rewritten in Rust.’ + "NO_RUST=better") are particularly regressive. This is of course not your fault at all and should be fixed in ‘guix style’, but I do intend on reverting this change when I upgrade bcachefs-tools to the next git snapshot ;-) Bcachefs is still improving fast enough that I think it's okay to package snapshots, at least until 6.7 lands. Using outdated tools on a newer kernel generally fails outright, and once corrupted my file system. Kind regards, T G-R Sent from a Web browser. Excuse or enjoy my brevity. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 29 15:09:54 2023 Received: (at 66043) by debbugs.gnu.org; 29 Sep 2023 19:09:54 +0000 Received: from localhost ([127.0.0.1]:57219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmIru-0005lh-3L for submit@debbugs.gnu.org; Fri, 29 Sep 2023 15:09:54 -0400 Received: from rainycloud.ext.redscript.org ([103.105.48.212]:56818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmGNI-0006Vq-8V for 66043@debbugs.gnu.org; Fri, 29 Sep 2023 12:30:03 -0400 Received: from [127.0.0.1] (bba-2-49-3-67.alshamil.net.ae [2.49.3.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by rainycloud.ext.redscript.org (Postfix) with ESMTPSA id E74E24D6B; Fri, 29 Sep 2023 16:29:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redscript.org; s=mail1-rsa; t=1696004972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rFGqd/lpSkqIIS1l51lRKga3y39KKIwL3AEN2eYJ8Xc=; b=dW+mvg84Dz0PyeCUlse1KZDRT/vyDCv/VlQrnzL8ef6N9Xq8s3b1QOSpUxvHAgxwMVgX0M 4NjwoLVVUuA6ZfsN+l83N3ynhTINWZRAJuKoxIwvW1vY4dYk5aQjzQKbrAS1NuGKZyK79/ wqw76PSkAIdZsKvNE7zASnh936iIFY1kqYfXt42dY4/CHRMh5oIALXJry1oSUGsmRaYy6P KjX25Rx4EcQCelTTlV4oyMx0S0dLS25BVIOJLQN0n8MCLry30MaPVq7sjEUNykaeqPemUt E2dmkyhgGU7ZZNzToE5IkY/aj3Lcpu7VPI4M10yHCmeTBkdSEaYl7Jr8ALyy7WYUn7XImz 9kqMxLWiBu+F8/YLuiC2nPktyizMOWO0fd1CV7Ei0sRRjHuAPcaW4Vjz4t4oXLRDA4EGJW Xmi4rKa8NxWv90To+bImH95dxG2rFuY2XdtHqr851Kyuuky1Pog9R0a14mbJ8wF1MxvXRi 5L3pz1rPqqLc0zjZkS0K13/EXmIjyDKCqsaUSnkXgDWskkwgBGyO6RGyQffEaqaFTAi2NV ccp2XvGe3O5GnJYVMLvVIyz3y3ljosv50JzFt14gNHakyJOHfky9sS+OhSHGLZ6xmOZBHo x5ZLV6KBa11VSxYbB39TLtTlSrXME6cryJBv0IIAX9gkoaKCbxWlM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=redscript.org; s=mail1-ed25519; t=1696004972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rFGqd/lpSkqIIS1l51lRKga3y39KKIwL3AEN2eYJ8Xc=; b=4/RcjbihxbfsvotcvDIyDdKtnzHltjE/nwCo0bpgng8hBMwESGg4Jw+W30X4M0xSqJRC5X IXwb5hFUMIbobPBg== Date: Fri, 29 Sep 2023 20:29:27 +0400 From: A To: Tobias Geerinckx-Rice , Ahmad Draidi Subject: Re: [bug#66043] [PATCH 2/2] gnu: bcachefs-tools: Restyle format. User-Agent: K-9 Mail for Android In-Reply-To: References: <3e7fa3295d876267df6babbb9a6578a4891822b2.1694931512.git.a.r.draidi@redscript.org> Message-ID: <9CB5E275-7489-4809-911F-73A481820A74@redscript.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66043 X-Mailman-Approved-At: Fri, 29 Sep 2023 15:09:40 -0400 Cc: 66043@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Tobias, On 27 September 2023 01:41:07 GMT+04:00, Tobias Geerinckx-Rice wrote: >Hi! > >Thanks for taking care of the bcachefs-tools package! > >> Who else is excited for bcachefs being merged upstream soon? :) > >/me raises hand=2E Four years of sometimes-painful rebases will not be m= issed=2E I find it reassuring that a Guix maintainer is a long time bcachefs user= =2E :) > >On 2023-09-17 8:38, Ahmad Draidi via Guix-patches via wrote: >> * gnu/packages/file-systems=2Escm (bcachefs-tools): Reformat with 'guix= style' >> and manually break some long lines=2E > >I don't think =E2=80=98guix style=E2=80=99 improved things anywhere, but = hunks like > >- (list #:make-flags >- #~(list (string-append "VERSION=3D" #$version) ; =E2=80=98v= =E2=80=A6-nogit=E2=80=99 otherwise >- (string-append "PREFIX=3D" #$output) >- "INITRAMFS_DIR=3D$(PREFIX)/share/initramfs-tools" >- (string-append "CC=3D" #$(cc-for-target)) >- (string-append "PKG_CONFIG=3D" #$(pkg-config-for-ta= rget)) >- ;; =E2=80=98This will be less of an option in the f= uture, as more >- ;; code gets rewritten in Rust=2E=E2=80=99 >- "NO_RUST=3Dbetter") >+ (list #:make-flags #~(list (string-append "VERSION=3D" >+ #$version) ;=E2=80=98v=E2= =80=A6-nogit=E2=80=99 otherwise >+ (string-append "PREFIX=3D" >+ #$output) >+ "INITRAMFS_DIR=3D$(PREFIX)/share/initramfs-to= ols" >+ (string-append "CC=3D" >+ #$(cc-for-target)) >+ (string-append "PKG_CONFIG=3D" >+ #$(pkg-config-for-target)) >+ ;; =E2=80=98This will be less of an option in= the future, as more >+ ;; code gets rewritten in Rust=2E=E2=80=99 >+ "NO_RUST=3Dbetter") > >are particularly regressive=2E > >This is of course not your fault at all and should be fixed in =E2=80=98g= uix style=E2=80=99, but I do intend on reverting this change when I upgrade= bcachefs-tools to the next git snapshot ;-) I had to remove the extra indentation caused by the parentheses, while kee= ping as much of my opinion out of styling as possible=2E It doesn't help wi= th my OCD that the Guix patch submission checklist asks to run 'guix style'= =2E :D Perhaps I should look at 'guix style' code sometime=2E > >Bcachefs is still improving fast enough that I think it's okay to package= snapshots, at least until 6=2E7 lands=2E Using outdated tools on a newer = kernel generally fails outright, and once corrupted my file system=2E > >Kind regards, > >T G-R Thanks, and keep up the great work! > >Sent from a Web browser=2E Excuse or enjoy my brevity=2E From unknown Thu Jun 19 14:06:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 28 Oct 2023 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator