GNU bug report logs - #66038
[PATCH] gnu: muchsync: Update to 7.

Previous Next

Full log

View this message in rfc822 format

From: Christopher Baines <mail <at> cbaines.net>
To: Hendursaga <hendursaga <at> aol.com>
Cc: 66038-done <at> debbugs.gnu.org, 66038 <at> debbugs.gnu.org
Subject: [bug#66038] [PATCH] gnu: muchsync: Update to 7.
Date: Mon, 25 Sep 2023 18:54:12 +0100

[Message part 1 (text/plain, inline)]

Hendursaga <hendursaga <at> aol.com> writes:

> Christopher Baines <mail <at> cbaines.net> writes:
>
>> Thanks for the patch. I've tweaked the patch to remove the indentation
>> changes, as I wasn't sure those were intentional[...]
>
> I ran it through `guix style` as I thought one was supposed to do.
> Should I have added something to the ChangeLog message to make that more
> clear, perhaps?

Something to the commit message maybe, and it can also be useful to keep
stylistic changes and functional changes in separate commits. So you
would have a "apply guix style" commit and a "update to X" commit.

> I don't think I've replied to a "done" issue before, so I hope my
> automagically generated Cc's are appropriate!

Yep, I think it's fine.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.