GNU bug report logs - #66020
[PATCH] Reduce GC churn in read_process_output

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#66020: closed ([PATCH] Reduce GC churn in read_process_output)
Date: Sun, 09 Jun 2024 01:41:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 9 Jun 2024 03:12:16 +0300
with message-id <15f746d0-e635-47a0-a613-2ea31523966a <at> gutov.dev>
and subject line Re: bug#66020: (bug#64735 spin-off): regarding the default for read-process-output-max
has caused the debbugs.gnu.org bug report #66020,
regarding [PATCH] Reduce GC churn in read_process_output
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
66020: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66020
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Reduce GC churn in read_process_output
Date: Sat, 16 Sep 2023 04:26:11 +0300

[Message part 3 (text/plain, inline)]

As suggested, I'm filing this in a new bug report for wider review.

The updated patch attached.

The previous discussion was in bug#64735, and the benchmarks (which more 
or less hold for the new patch as well) can be viewed here (last table): 
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64735#506. Except the new 
version somehow performs a little better at read-process-output-max=4096 
as well, despite seemingly doing more.

Let me know if I DRYed this too much, or if there are better names for 
the extracted common routines, or etc. Or for the new variable 
(read-process-output-fast).

[read_and_insert_process_output_v2.diff (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Eli Zaretskii <eliz <at> gnu.org>, Stefan Kangas <stefankangas <at> gmail.com>
Cc: eggert <at> cs.ucla.edu, monnier <at> iro.umontreal.ca, 66020-done <at> debbugs.gnu.org
Subject: Re: bug#66020: (bug#64735 spin-off): regarding the default for
 read-process-output-max
Date: Sun, 9 Jun 2024 03:12:16 +0300

On 08/06/2024 15:11, Eli Zaretskii wrote:
>> From: Stefan Kangas<stefankangas <at> gmail.com>
>> Date: Sun, 26 May 2024 16:27:19 -0700
>> Cc:66020 <at> debbugs.gnu.org,monnier <at> iro.umontreal.ca
>>
>> Eli Zaretskii<eliz <at> gnu.org>  writes:
>>
>>> I'll try to recollect the discussion and review the patches one of
>>> these days.
>>>
>>> Paul, your input (as well as that of everybody else on the CC list)
>>> will be most welcome.
>> FWIW, I'd be in favor of raising `read-process-output-max' to something
>> like 40960 (as Eli suggested in this thread), or perhaps some power of 2
>> close to that like 32768 or 65536.
>>
>> This is based on it being seemingly faster in the benchmarks in this
>> thread, and me having used that locally for 2-3 years and noting no
>> adverse effects.
>>
>> See also the discussion here:
>> https://lists.gnu.org/r/emacs-devel/2021-03/msg01461.html
>>
>> (I didn't review patch 1 and 2, so no opinion on those.)
> I guess we can install all 3 patches and see if anything breaks.

Thank you, now pushed to master.

For read-process-output-max, I chose the higher of the powers of two, 
but please feel free to amend.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.