GNU bug report logs - #65979
incorrect “guix hash” for FastQC

Previous Next

Full log

Message #14 received at 65979 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: 65979 <at> debbugs.gnu.org
Subject: Re: bug#65979: incorrect “guix hash” for FastQC
Date: Tue, 26 Sep 2023 15:34:47 +0200

(Oops, now I see you had already found the reason.)

Simon Tournier <zimon.toutoune <at> gmail.com> skribis:

> What do we fix?  The procedure vcs-file? or fixed-output computation?

There are two things are:

  1. ‘vcs-file?’, used by ‘guix hash -rx’;

  2. ‘git-fetch’, which does (delete-file-recursively ".git").

Clearly #2 is correct (it’s perfectly fine to have a ‘.svn’ directory in
a Git repo), whereas #1 is an approximation that, in corner cases like
this one, gives the wrong answer.

My take is that it’s OK to keep ‘vcs-file?’ as is: the best we could do
would be to add complicated heuristics in the hope corner cases like
this one would be better dealt with, but it wouldn’t be bullet-proof
anyway.

WDYT?

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.