GNU bug report logs - #65924
git searches coreutils and util-linux commands in PATH

Previous Next

Full log

View this message in rfc822 format

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 65924 <at> debbugs.gnu.org, Simon Tournier <zimon.toutoune <at> gmail.com>
Subject: bug#65924: [PATCH core-updates 1/3] gnu: git: Remove labels and use gexps.
Date: Sun, 15 Oct 2023 15:55:35 -0400

Hi Ludovic,

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi!
>
> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:
>
>> * gnu/packages/version-control.scm (git)
>> [native-inputs, inputs]: Remove labels.
>> [arguments]: Use gexps.  Use gexp variables input searching procedures where
>> it makes sense.
>
> [...]
>
>> +                ;; Tell 'git-send-email' where perl modules are.
>> +                (wrap-program git-se*
>> +                  `("PERL5LIB" ":" prefix
>> +                    ,(search-path-as-list
>> +                      '("lib/perl5/site_perl")
>> +                      '#$(delete-duplicates
>> +                          (append-map
>> +                           (compose last package-transitive-propagated-inputs)
>> +                           (list (this-package-input "perl-authen-sasl")
>> +                                 (this-package-input "perl-net-smtp-ssl")
>> +                                 (this-package-input "perl-io-socket-ssl")))))))
>> +                ;; Tell 'gitweb.cgi' where perl modules are.
>> +                (wrap-program (string-append out "/share/gitweb/gitweb.cgi")
>> +                  `("PERL5LIB" ":" prefix
>> +                    ,(search-path-as-list
>> +                      '("lib/perl5/site_perl")
>> +                      '#$(delete-duplicates
>> +                          (append-map
>> +                           (compose last package-transitive-propagated-inputs)
>> +                           (list (this-package-input "perl-cgi")))))))
>
> I wonder if this could be simplified, but I don’t have a good idea.
>
> Otherwise LGTM!

Thanks; this was merged some days ago to core-updates.  We can still
refine it though.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.