Subject: bug#65924: git searches coreutils and util-linux commands in PATH

From: Simon Tournier <[email-masked]>
Date: Thu, 14 Sep 2023 00:27:54 +0200

Hi Maxim,

On Wed, 13 Sep 2023 at 14:00, Maxim Cournoyer <[email-masked]> wrote:

> The 'git' command should be wrapped to include these in its PATH.

--8<---------------cut here---------------start------------->8---
$ guix size git-minimal
[...]
total: 147.8 MiB

$ guix size git-minimal util-linux coreutils
[...]
total: 195.4 MiB
--8<---------------cut here---------------end--------------->8---

It increases the size by 33% which is not nothing. :-)

Is it only the subcommand git-submodule which is broken?  Probably not.

--8<---------------cut here---------------start------------->8---
$ find $(guix build git-minimal --no-grafts) -type f -exec grep -H git-sh-setup {} \; | cut -f1 -d':' | xargs -I {} basename {}
grep: /gnu/store/y3vdq2pdkljrw63xxnc2vb6lz07ycar6-git-minimal-2.41.0/bin/scalar: binary file matches
grep: /gnu/store/y3vdq2pdkljrw63xxnc2vb6lz07ycar6-git-minimal-2.41.0/bin/git: binary file matches
grep: /gnu/store/y3vdq2pdkljrw63xxnc2vb6lz07ycar6-git-minimal-2.41.0/libexec/git-core/scalar: binary file matches
grep: /gnu/store/y3vdq2pdkljrw63xxnc2vb6lz07ycar6-git-minimal-2.41.0/libexec/git-core/git: binary file matches
git-submodule
git-filter-branch
git-merge-resolve
git-mergetool
git-merge-octopus
git-merge-one-file
git-web--browse
git-web--browse
git-quiltimport
--8<---------------cut here---------------end--------------->8---

The question could be: is worth to add 33% for these commands?

Cheers,
simon