Subject: Re: bug#65924: [PATCH core-updates 1/3] gnu: git: Remove labels and use gexps.

From: Ludovic Courtès <[email-masked]>
Date: Sat, 14 Oct 2023 18:51:24 +0200

Hi!

Maxim Cournoyer <[email-masked]> skribis:

> * gnu/packages/version-control.scm (git)
> [native-inputs, inputs]: Remove labels.
> [arguments]: Use gexps.  Use gexp variables input searching procedures where
> it makes sense.

[...]

> +                ;; Tell 'git-send-email' where perl modules are.
> +                (wrap-program git-se*
> +                  `("PERL5LIB" ":" prefix
> +                    ,(search-path-as-list
> +                      '("lib/perl5/site_perl")
> +                      '#$(delete-duplicates
> +                          (append-map
> +                           (compose last package-transitive-propagated-inputs)
> +                           (list (this-package-input "perl-authen-sasl")
> +                                 (this-package-input "perl-net-smtp-ssl")
> +                                 (this-package-input "perl-io-socket-ssl")))))))
> +                ;; Tell 'gitweb.cgi' where perl modules are.
> +                (wrap-program (string-append out "/share/gitweb/gitweb.cgi")
> +                  `("PERL5LIB" ":" prefix
> +                    ,(search-path-as-list
> +                      '("lib/perl5/site_perl")
> +                      '#$(delete-duplicates
> +                          (append-map
> +                           (compose last package-transitive-propagated-inputs)
> +                           (list (this-package-input "perl-cgi")))))))

I wonder if this could be simplified, but I don’t have a good idea.

Otherwise LGTM!

Ludo’.