Subject: Re: bug#65924: git searches coreutils and util-linux commands in PATH

From: Ludovic Courtès <[email-masked]>
Date: Wed, 04 Oct 2023 18:14:27 +0200

Hi,

Maxim Cournoyer <[email-masked]> skribis:

> Attempting to use git-minimal in a --pure environment, I stumbled upon:
>
> /gnu/store/grc79ijx09nygvjh67cpk3g405nzr801-profile/libexec/git-core/git-submodule: line 7: basename: command not found
> /gnu/store/grc79ijx09nygvjh67cpk3g405nzr801-profile/libexec/git-core/git-submodule: line 7: sed: command not found
> /gnu/store/grc79ijx09nygvjh67cpk3g405nzr801-profile/libexec/git-core/git-sh-setup: line 77: basename: command not found
> /gnu/store/grc79ijx09nygvjh67cpk3g405nzr801-profile/libexec/git-core/git-sh-setup: line 77: sed: command not found
> /gnu/store/grc79ijx09nygvjh67cpk3g405nzr801-profile/libexec/git-core/git-sh-setup: line 292: uname: command not found
> /gnu/store/grc79ijx09nygvjh67cpk3g405nzr801-profile/libexec/git-core/git-submodule: line 613: sed: command not found
> /gnu/store/grc79ijx09nygvjh67cpk3g405nzr801-profile/libexec/git-core/git-submodule: line 613: cmd_: command not found
> ☒ git clone exited 127
>
> The 'git' command should be wrapped to include these in its PATH.

I think we should add coreutils-minimal and sed (or gash-utils?) to the
‘git-submodule’ wrapper that already exists.

Closure size is a concern, as Simon notes.  Longer-term we should make
coreutils-minimal more minimal, perhaps by stripping it of l10n data.

But first: let’s fix this so we can address
<https://issues.guix.gnu.org/66305>.

Ludo’.