GNU bug report logs - #65919
29.1; build without xinput does not get focused when hovering over window

Previous Next

Full log

Message #35 received at 65919 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Po Lu <luangruo <at> yahoo.com>, Amin Bandali <bandali <at> gnu.org>
Cc: 65919 <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi <at> gnus.org>,
 Ivan Popovych <ivan <at> ipvych.com>, Bob Rogers <rogers <at> rgrjr.com>
Subject: Re: bug#65919: 29.1; build without xinput does not get focused when
 hovering over window
Date: Thu, 14 Sep 2023 22:06:17 -0700

Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text
editors" <bug-gnu-emacs <at> gnu.org> writes:

>> FYI your e1a730017d6 patch introduces the following compiler warning:
>>
>> process.c: In function ‘child_signal_notify’:
>> process.c:7436:54: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
>>  7436 |     /* emacs_perror ("writing to child signal FD") */;
>>       |                                                      ^
>
> Thanks.  Does this silence the warning?

AFAIU, the point here is to fix a warning in

    if (emacs_write (fd, &dummy, 1) != 1)
      /* emacs_perror ("writing to child signal FD") */;

for which the easiest solution should be

    emacs_write (fd, &dummy, 1);

This avoids having to disable -Wempty-body everywhere, which IMO doesn't
seems justified just to silence this one warning.

What am I missing?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.