GNU bug report logs - #65919
29.1; build without xinput does not get focused when hovering over window

Previous Next

Full log

View this message in rfc822 format

From: Po Lu <luangruo <at> yahoo.com>
To: Amin Bandali <bandali <at> gnu.org>
Cc: 65919 <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi <at> gnus.org>, Ivan Popovych <ivan <at> ipvych.com>, Bob Rogers <rogers <at> rgrjr.com>
Subject: bug#65919: 29.1; build without xinput does not get focused when hovering over window
Date: Fri, 15 Sep 2023 12:37:59 +0800

Amin Bandali <bandali <at> gnu.org> writes:

> Hello,
>
> Po Lu writes:
>
>> This should be fixed on the master branch.  [...]
>
> FYI your e1a730017d6 patch introduces the following compiler warning:
>
> process.c: In function ‘child_signal_notify’:
> process.c:7436:54: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
>  7436 |     /* emacs_perror ("writing to child signal FD") */;
>       |                                                      ^

Thanks.  Does this silence the warning?

diff --git a/configure.ac b/configure.ac
index 7ca75be996d..3b5f3c1c37a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1776,6 +1776,9 @@ AC_DEFUN
   # Emacs doesn't need this paranoia.
   nw="$nw -Wbidi-chars=any,ucn"
 
+  # Or this hysteria, which impedes commentary within if statements.
+  nw="$nw -Wempty-body"
+
   if test "$emacs_cv_clang" = yes; then
     nw="$nw -Wdouble-promotion"
     nm="$nm -Wunknown-pragmas"

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.