GNU bug report logs - #65916
[PATCH] gnu: python-hicmatrix: Fix "'build': uncaught exception".

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
Subject: bug#65916: closed (Re: [bug#65916] [PATCH] gnu: python-hicmatrix:
 Fix "'build': uncaught exception".)
Date: Wed, 13 Sep 2023 20:23:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#65916: [PATCH] gnu: python-hicmatrix: Fix "'build': uncaught exception".

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 65916 <at> debbugs.gnu.org.

-- 
65916: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65916
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
Cc: 65916-done <at> debbugs.gnu.org
Subject: Re: [bug#65916] [PATCH] gnu: python-hicmatrix: Fix "'build':
 uncaught exception".
Date: Wed, 13 Sep 2023 22:21:32 +0200

Hi, thanks for the patch.

> * gnu/packages/bioinformatics.scm (python-hicmatrix): Add new phase
> 'fix-references that remove the * character from the name of the
> requirements.
> ---
>  gnu/packages/bioinformatics.scm | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
> index e24d70e569..06ff34e877 100644
> --- a/gnu/packages/bioinformatics.scm
> +++ b/gnu/packages/bioinformatics.scm
> @@ -16228,7 +16228,11 @@ (define-public python-hicmatrix
>      (arguments
>       (list
>        #:phases
> -      '(modify-phases %standard-phases
> +      #~(modify-phases %standard-phases
> +         (add-after 'unpack 'fix-references
> +           (lambda _
> +              (substitute* "setup.py"
> +                ((".\\*\"") ".0\""))))

I simplified this to remove the “.0”, renamed the phase because it isn’t
about fixing references, and removed the gexp.

-- 
Ricardo

[Message part 3 (message/rfc822, inline)]

From: Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
To: <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: python-hicmatrix: Fix "'build': uncaught exception".
Date: Wed, 13 Sep 2023 15:39:18 +0200

* gnu/packages/bioinformatics.scm (python-hicmatrix): Add new phase
'fix-references that remove the * character from the name of the
requirements.
---
 gnu/packages/bioinformatics.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index e24d70e569..06ff34e877 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -16228,7 +16228,11 @@ (define-public python-hicmatrix
     (arguments
      (list
       #:phases
-      '(modify-phases %standard-phases
+      #~(modify-phases %standard-phases
+         (add-after 'unpack 'fix-references
+           (lambda _
+              (substitute* "setup.py"
+                ((".\\*\"") ".0\""))))
          (replace 'check
            (lambda* (#:key tests? #:allow-other-keys)
              (when tests?

base-commit: 9996896dc252a02ba3b17473a685ce8957237546
-- 
2.41.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.