From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 13 06:45:26 2023 Received: (at submit) by debbugs.gnu.org; 13 Sep 2023 10:45:27 +0000 Received: from localhost ([127.0.0.1]:60921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgNN8-0001Ig-Jq for submit@debbugs.gnu.org; Wed, 13 Sep 2023 06:45:26 -0400 Received: from lists.gnu.org ([2001:470:142::17]:33292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgNN6-0001IT-L3 for submit@debbugs.gnu.org; Wed, 13 Sep 2023 06:45:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgNMv-00056G-Sj for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 06:45:13 -0400 Received: from mout.gmx.net ([212.227.17.22]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgNMt-0004A3-CT for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 06:45:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1694601907; x=1695206707; i=jimjoe@gmx.net; bh=6Exk1U+HKKLF9HMigk3UGVygVzSgzfr59HGVHluM07Q=; h=X-UI-Sender-Class:From:To:Subject:Date; b=niNr+Kk5/uS93sHhT3ieLgeVPHs+bcxv8wsjnhizDmE8oqKPo3OFECxDYZk8ToXYXKfdZuiOsKh nhCiSIZeGLORfob05f2HUlggb3Isw6QEgPMJQdx3kOvtlHUJcEtaLDr8Y5dfVupk6all9VdLGmoX7 6zp1d3myyUVbOdcyL0r6DBch1iirGrnDJt59O/eR284xs7rsKt/y3SNJ7bpfWOIpMgap8lQqsAhEH BhbIeg/fyiVrVK19SQYAhfCOenXzm8JCm/v7K64T+gCvLtzI12S7694VCqG4KjZFSOtKjT8MXo24C 1rwdRPZeRx63DpvzkP/2iVh6sqYmngOSv2FA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from user-Inspiron-15-5518 ([117.216.19.225]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1M5QJJ-1qhCqc07OP-001PRK for ; Wed, 13 Sep 2023 12:45:07 +0200 From: James Thomas To: bug-gnu-emacs@gnu.org Subject: Exclude current buffer from eww-switch-to-buffer Date: Wed, 13 Sep 2023 16:15:03 +0530 Message-ID: <87y1ha1he8.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:m/LdzBXJeGJeESWg9jFBHC/wEF72IkWEDPbhbXY/lt0vBMsJ/OZ W5fczixaFOmLLeviAfWavgCm0LUFE7//ir2JhHxYchNn3mYTI27GXSFonzNi5jtn210deqb iBAyoPkAeIdnbTKeYhPy0fH0wMF1f5UDAsCWZ4hT34aMFce2opEQBFLw+/adCX9lObEZ6Ca rZ9bBFEowzQYZFhMJ9wTQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:lnZO0cyidy0=;7yvQ9NGB+VGDa2Ru033CSGVfgEB uEDi6ofsVKF2ajqK41PDddTs4NA5zlxj2aqk9V3dxONBdSDSKR4YV0Ev3uqRbohbVF1Rzq7Br UWIqbpMg8DnrujY1bY4GA9ILAg+ru+LRTip4eZF9LLvyb+5aJVlC8jWT9t7xQQl/tJRvn4PdG CdzmCt+ERXGrPFHbktWVXOrJnA9QkbODxq5QBGxZt8SGwiGPEf+9cvFTeaqYYfjIjzcWksnXP V78fTp5Y+GZqZpqPfQW3CrcL/16gvH+CVlng+0viojlLTzWoHvI41A1SYD3gWiqzfLa3a3phS 3xrxKJzcCyrbSjKidCNI+wRwV8otrE/7+IQCudvyJCucsm2XU0XQ9NRknqk01uWqVYEZiO8ZC v/BtYmHriZIVUSptXixK7B695dXMI7mmhA/GBejws7LWRbNespysjRM727f1ESXyrdk+93msG jx0/ZeoM4zAa03QgUzIOHHbbfy9r++LmSTpPh9LZM4blohJyNvZ7iM/fx7AETq9W4aI3C6fDi T9f/O0NEXd4Oddpw7Mf0nw3p8a7ZltAJMYmPgHo3VJMgMMA7Xu2KCkK0iiypRmsblhp7X1DnI OY4j5wSyLMeoXTziBDQYcie6NMTt/8riljYTasp6rpRwZQp7o+v1yQc1KQdCS3w6etweGolRN +K+pJtz/ZK3USo1geIFKk7qltHqG+Sxn4OslFwdBoMMrKfsdlo26161IPz1pz4B6ixK+IVi2O eILl5oUXzisDS1ofBf7vGZrNDMbyt8JbZ3D2O3tnPn8vFRlJqtsZMUmYkecpFQVrGKSPIX2sZ W1IkwJCJxTAf02TXy/WNQplMagKxTuECdPLYbxopyB/8V293K6uTe41ZpzbGbcCxDOfBRxPTJ x5GmkZ5Ld/RVXnPSQEqTrDQ+RBprHnWiqDR6tzISn4B9UAwTNB8I0cxLLH+wC+9Gu+3CKucd5 OebQ1Okxl1UbhZjlfMmWA9IOE50= Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=212.227.17.22; envelope-from=jimjoe@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Tags: patch, notabug This patch excludes the current buffer from the completion list of the above command. The main motivation is avoiding one cycling keystroke in icomplete. For eg. a use-case of cycling visits between the last 3 visited eww buffers: Currently (to visit each buffer in succession), after pressing s, one would have to cycle thrice in icomplete before pressing C-j. With this patch, it would only need to be done twice (a mnemonic to remember the number of times to cycle could be 'the last 2 *other* buffers' rather than 'the last 3 buffers' it is currently). Moreover, if you remember that the target eww buffer was the last n-th buffer you opened, you may now simply cycle n times. Eg. n is 1 for the previous buffer. * lisp/net/eww.el (eww-switch-to-buffer): diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 4ddda216afc..e43ef2bfe8b 100644 =2D-- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -2062,7 +2062,8 @@ eww-switch-to-buffer (let ((completion-extra-properties '(:annotation-function (lambda (buf) (with-current-buffer buf - (format " %s" (eww-current-url))))))) + (format " %s" (eww-current-url)))))) + (curbuf (current-buffer))) (pop-to-buffer-same-window (read-buffer "Switch to EWW buffer: " (cl-loop for buf in (nreverse (buffer-list)) @@ -2070,9 +2071,10 @@ eww-switch-to-buffer return buf) t (lambda (bufn) - (with-current-buffer - (if (consp bufn) (cdr bufn) (get-buffer bufn)) - (derived-mode-p 'eww-mode))))))) + (setq bufn (if (consp bufn) (cdr bufn) (get-buffer bu= fn))) + (and (with-current-buffer bufn + (derived-mode-p 'eww-mode)) + (not (eq bufn curbuf)))))))) (defun eww-toggle-fonts () "Toggle whether to use monospaced or font-enabled layouts." =2D- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 15 06:51:31 2023 Received: (at control) by debbugs.gnu.org; 15 Sep 2023 10:51:31 +0000 Received: from localhost ([127.0.0.1]:42212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh6Q7-0004K4-BN for submit@debbugs.gnu.org; Fri, 15 Sep 2023 06:51:31 -0400 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]:56372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh6Q5-0004Js-Ib for control@debbugs.gnu.org; Fri, 15 Sep 2023 06:51:30 -0400 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2bfc8c02e82so28628161fa.0 for ; Fri, 15 Sep 2023 03:51:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694775077; x=1695379877; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=o/UyJynncCmS/c/+EnxCOi3ab4l/47XbXZaQ90WKGO8=; b=dZCowZAYB4Dxy8Pw7aNpyXU/rHu5SjfCwL3oMPC7Rh5IHA9X47XkbjkBg/5NwRyvJe HPCNo81b0a3FZn/QU43KnI5pNUECwogWtp2TwbvKKlW5B6+84vWv/feF38vaePZnX2vA EDXHlrfDxCIcp+U9H+8r5CZL7zOqnz7fKnhOMMQRjiI8sEgeJX05/z8cuPrtWkaHcPi0 s5o/MlWTrWJPbKaSTVDLwyQlbUS5T6G0JfdK9cNpBtQ8pn9l9/SgfxEO0fRQ/bVyFykZ s4jcSzt8vUOnuhPhn/jOSp2XTE9IMI77p/fKf2WKQwuj70xE1QnGm3omMyvLrYRckCnO vI9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694775077; x=1695379877; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=o/UyJynncCmS/c/+EnxCOi3ab4l/47XbXZaQ90WKGO8=; b=ZRq+IYHTHl+vhb8ls9r1oNr51Z704/1SIzRUEgQWCdXNShC/zJg0R43EFy5pWtL4T6 Q1F+IHevQcw/SMiTiMhHt62ScoTkhLhkoEjWiAMnDEsmzg7eNfyUKiT1BKjWcQrZtt9d j2CQ9KdJ51GpELx/RZsOpRFxPTfPjnZgRwVnxv2AJ0b3XFgoGVswD1GFaSI5Zsb80Q25 yKOJwWoNMm65UuzIrLTV7ogI6v1wdsLwpzkuSEtGKClgvXndmzhZffF1TWfDtXZJyXFX LBJpeP+VVR6a1sWK2LW5REUMX4ws0vkOxTkq8LJ6u0raHi/W4YrR/IP5IeLIRV4lNBzA X7zA== X-Gm-Message-State: AOJu0YzlAertQ655h1+vZyrZVPHnLp+PtvpqB6B4r+2AmWL4I/Vw1i4H ytdvaji5ArnsqxtW66m51/9ru6GHMvGopEWbArqUEOMu X-Google-Smtp-Source: AGHT+IHcmBkGkxz7lKw5mTC5ECktuU8NzYB3U/E6t9+4UVHqyhg6KbpJCfAEUoPZJmpCDRFsHmbWJwU7c1+9f9ZXEcQ= X-Received: by 2002:a2e:9c4d:0:b0:2bf:7905:12c3 with SMTP id t13-20020a2e9c4d000000b002bf790512c3mr1128086ljj.40.1694775077047; Fri, 15 Sep 2023 03:51:17 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 15 Sep 2023 03:51:14 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Fri, 15 Sep 2023 03:51:14 -0700 Message-ID: Subject: control message for bug #65914 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 65914 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 15 07:48:16 2023 Received: (at control) by debbugs.gnu.org; 15 Sep 2023 11:48:16 +0000 Received: from localhost ([127.0.0.1]:42287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh7J2-0002k5-AY for submit@debbugs.gnu.org; Fri, 15 Sep 2023 07:48:16 -0400 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]:46136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh7Iz-0002jA-0A for control@debbugs.gnu.org; Fri, 15 Sep 2023 07:48:15 -0400 Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-502e0b7875dso3450666e87.0 for ; Fri, 15 Sep 2023 04:48:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694778480; x=1695383280; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=E39+0az1WIi4CWTkNd5UeMZwwVNlUKz039e6fHFeunU=; b=DJRKCgjdMC2hTuzIDMQptE6DwyUJwsSy7WhiqhaFiOFS6HK0eGt7U+ItA+yVsJyZnU ST3FhwsvNJrKa9ugiTWcFHkothYoLV3ZcKWXb+zf4sRSAHsxZA3atpddrizasGVlWHJn mL3pMeLLeb68i/rnDp6XZwdJThO/kQ5xzXnDmftiiXcv6PzbvkvaxFDxeDKoblABvjVg beJYCfzIXWeXumHBsoqsVDu1uAagsUFTeXMTyyh73UYcjaMcNTE2OnD7GarefW2QpIhU 7jgUo/ycY9LYB5An6IdjC4s1lzLF/BdVYCP3OAvUlRGuCm/BTNBUrs0ZGCWRomwv5Znt FlYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694778480; x=1695383280; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=E39+0az1WIi4CWTkNd5UeMZwwVNlUKz039e6fHFeunU=; b=keSKuWF1t2JOtIQYYXuWyAGKMno9tnMQGcAceWtCoOT1qF/ekS2U2XMFLsbcuXe0Yo pZb+J1/Bjgc0EUKzqY4eO5fZbhSuBXm3I0PQKOo5QyNc8AnmhP0Z9vr1NFP5zQj0zG77 2ipLm95aLmyF+ND1EJni1JXubBKYwtYeZwWwpTP92KiatGhGHLInM9juQ2Uf4kQKiyh+ TVbGt8/Ik5hRulxFYIurYJDluoGbfiUQaEiHXPdAdU2SMuLfqvjxgB1POX40bxiRJL5R k01jY0z4da42pAnubLabnnoRiicEpoxfzf/lsk0y432nNxdutKxhYDf2t71a1rVC8hGB h+Vg== X-Gm-Message-State: AOJu0Yzwj9baxiCEO45WNVpRcLfzcb273XCjLmjSP46y/+7MV/2zR5Nq bsqbt1pGo+vfW4Ty580fR9ScvQjfs/TGQ+fvJ/nOpwvI X-Google-Smtp-Source: AGHT+IHaETcJrG3Xeaum0kecN0khW1QNOVb2JSUkFC5aXz2WUWVZseWEz/EczqyV1rw/9Vjsbdw3iHrX7+Jv7jmcyo4= X-Received: by 2002:a05:6512:2025:b0:4fd:d9dd:7a1a with SMTP id s5-20020a056512202500b004fdd9dd7a1amr1168880lfs.31.1694778480459; Fri, 15 Sep 2023 04:48:00 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 15 Sep 2023 04:48:00 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Fri, 15 Sep 2023 04:48:00 -0700 Message-ID: Subject: control message for bug #65914 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 65914 - notabug quit From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 15 08:05:41 2023 Received: (at 65914) by debbugs.gnu.org; 15 Sep 2023 12:05:41 +0000 Received: from localhost ([127.0.0.1]:42305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh7Zt-0005ti-69 for submit@debbugs.gnu.org; Fri, 15 Sep 2023 08:05:41 -0400 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]:42360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh7Zo-0005tM-Qu for 65914@debbugs.gnu.org; Fri, 15 Sep 2023 08:05:39 -0400 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-500bbe3ef0eso2478135e87.1 for <65914@debbugs.gnu.org>; Fri, 15 Sep 2023 05:05:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694779524; x=1695384324; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=waRYSJD1MfSxz20SGcjIzM6G3mVrYiLZx0Nx4rkFuaw=; b=O/HgMQTR30OX+sIF0SvbjV2Gn/ugwLCRpT7oBTygP8/roiCB7+NOSzPqQjiRpdNq+4 iV1vtmIUW3PeqCX7sGnFmyXgORWx2pS9I+sfbdiXHxM9zO3pBf9HgqtDMFsRJQGt6lX4 rMTk6F8cjgZ/H1+z3xUkD/G0zhOS9YYHZIc9s6jzaW7/bqKSr7weH4qJMtNu7zUJZfck 3/apP+YRbTuBYBxufnsai6eHvEy457glYqKo63wYWvqHZERfxN4pbbmg8krlgpqzxKeR q67ozXzCnPcMK9y5fU/hjEnIg+bTqWgeMda/TJ4f2da9gbtVVORXyHCI8pPpw6qTLcBl 0Z6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694779524; x=1695384324; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=waRYSJD1MfSxz20SGcjIzM6G3mVrYiLZx0Nx4rkFuaw=; b=pub6/HhKWHa/Jl1DAnYYDUIkiQMu5638/NKhJ7hC92r6T2BthL8kpx4VF61GQatzDl f06/fFdfn6uaPYALxX+vfmHCexFiefNckBOI3UrYWQ1oBlTffgA4y74OZPPdbmRgAZJp vd+Nbj/OkLhtLP8p24+y/rG2WxRF7EVcFT5ehdkFARKARd3olGXrCIKRRE4KNR1I25VE nkdbnX+DPNhWk04gqYJjvEMDr2tuVk+OxYSdDrI0jLBQmLZ/y+im0gJx7CMZgSk7DUUr S5ceAe6U9/X0hAr9zjVf3a3WWK7a82UStMA11Izq7R825GkIqa9YmHCcXEWgkrHPRPE9 F14w== X-Gm-Message-State: AOJu0YxxLHJghwmk2KqVPuiSs9KArwRqH8z2ITRjswKSPog4v9aggnTI 1MbyopT+c+KQLf9rXkU/xIJARYBh7rf9n60RPTfzeOFr X-Google-Smtp-Source: AGHT+IFDC69Tq8Ioy3auK0L3UxfYkf5RWQPpVVa1OpOXoXtnAtssYTIK1LZKQLouL3Jx8Xm1tq77VCODsKoO1RtsqkY= X-Received: by 2002:a05:6512:33c8:b0:502:e235:20c7 with SMTP id d8-20020a05651233c800b00502e23520c7mr757740lfg.20.1694779524400; Fri, 15 Sep 2023 05:05:24 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 15 Sep 2023 05:05:23 -0700 From: Stefan Kangas In-Reply-To: <87y1ha1he8.fsf@gmx.net> (James Thomas's message of "Wed, 13 Sep 2023 16:15:03 +0530") References: <87y1ha1he8.fsf@gmx.net> MIME-Version: 1.0 Date: Fri, 15 Sep 2023 05:05:23 -0700 Message-ID: Subject: Re: bug#65914: Exclude current buffer from eww-switch-to-buffer To: James Thomas Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65914 Cc: 65914@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) James Thomas writes: > Tags: patch, notabug [BTW, we typically don't use the "notabug" for patches.] > This patch excludes the current buffer from the completion list of the > above command. The main motivation is avoiding one cycling keystroke in > icomplete. > > For eg. a use-case of cycling visits between the last 3 visited eww > buffers: > Currently (to visit each buffer in succession), after pressing s, one > would have to cycle thrice in icomplete before pressing C-j. With this > patch, it would only need to be done twice (a mnemonic to remember the > number of times to cycle could be 'the last 2 *other* buffers' rather > than 'the last 3 buffers' it is currently). > > Moreover, if you remember that the target eww buffer was the last n-th > buffer you opened, you may now simply cycle n times. Eg. n is 1 for the > previous buffer. Thanks, I would like to install this patch. Could you please send the patch as an attachment instead? We prefer that patches are created with a command like `git format-patch -1'. Please also include: - The bug number of this bug in the commit message, like so: Bug#65914 - A ChangeLog entry, as described in the CONTRIBUTE file. That would make it easier for us to review and install this patch. Thanks in advance. > * lisp/net/eww.el (eww-switch-to-buffer): > > diff --git a/lisp/net/eww.el b/lisp/net/eww.el > index 4ddda216afc..e43ef2bfe8b 100644 > --- a/lisp/net/eww.el > +++ b/lisp/net/eww.el > @@ -2062,7 +2062,8 @@ eww-switch-to-buffer > (let ((completion-extra-properties > '(:annotation-function (lambda (buf) > (with-current-buffer buf > - (format " %s" (eww-current-url))))))) > + (format " %s" (eww-current-url)))))) > + (curbuf (current-buffer))) > (pop-to-buffer-same-window > (read-buffer "Switch to EWW buffer: " > (cl-loop for buf in (nreverse (buffer-list)) > @@ -2070,9 +2071,10 @@ eww-switch-to-buffer > return buf) > t > (lambda (bufn) > - (with-current-buffer > - (if (consp bufn) (cdr bufn) (get-buffer bufn)) > - (derived-mode-p 'eww-mode))))))) > + (setq bufn (if (consp bufn) (cdr bufn) (get-buffer bufn))) > + (and (with-current-buffer bufn > + (derived-mode-p 'eww-mode)) > + (not (eq bufn curbuf)))))))) > > (defun eww-toggle-fonts () > "Toggle whether to use monospaced or font-enabled layouts." > > -- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 15 20:32:21 2023 Received: (at 65914) by debbugs.gnu.org; 16 Sep 2023 00:32:22 +0000 Received: from localhost ([127.0.0.1]:45091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhJEQ-0007VU-8p for submit@debbugs.gnu.org; Fri, 15 Sep 2023 20:32:21 -0400 Received: from mout.gmx.net ([212.227.17.21]:43415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhJEJ-0007VB-UQ for 65914@debbugs.gnu.org; Fri, 15 Sep 2023 20:32:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1694824318; x=1695429118; i=jimjoe@gmx.net; bh=Llt8meqJ+gYAmlp1weuOnyTWcvvD2AKaPHcvKL5UKGc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=AfJHSnjfPXmS+Ru0xSZGnljLK4BDwnPcZoH9F2M/emGaP2qIxkP08NrKlfDB0a/pPnU04zz8/UO 6j2KuSAoZRLP/Fc9jjElHLKsDfI4zE3wUuOX7FyzTyN/MTK9lgahiA8gwZyTETumZ5w3IUElLx524 itU00i4lGM1rRnLXpI0yYLDQxufW9tshUuYn2eQDEbcM8Vn8E7QU4bkFOMyPHduLaed9vu/5STxGV QuIgoyP2BO/djKReee5dy5HCIRw0eR0Ibadn5RWiTFKKSeZsmwwIJua6306Dfum7uDRNnvC9iyMdE I+xLjVdC9RLDdu78tT/+bUPZJdPHjuRtQz/A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from user-Inspiron-15-5518 ([59.182.118.17]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1M1Ycl-1qkL5y40PT-003A0L; Sat, 16 Sep 2023 02:31:58 +0200 From: James Thomas To: Stefan Kangas Subject: Re: bug#65914: Exclude current buffer from eww-switch-to-buffer In-Reply-To: (Stefan Kangas's message of "Fri, 15 Sep 2023 05:05:23 -0700") References: <87y1ha1he8.fsf@gmx.net> Date: Sat, 16 Sep 2023 06:01:53 +0530 Message-ID: <87il8bargm.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:4knP64+7XJC8zl4bbL9NDi5lA95MnyYJP/iicn041jjj2r8JqmE A0gXsoAl//I3l0dZFOfW8fGUNlM8HQYinyvxl+w9hTy7M7ZfohflSeBKoi5yGGop63EMpwO 51oZRJ6uOzgqSnsGn9q8BufEWJuId+OfvqCvVXx0qx3AeBOPJOOHMjsNOViGeUcFoTJLGxN y/JDvH6Ka4ojYZzdj8CPg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:HSlaC+yY+Ng=;eR4WxshLeD38MkDWnJ0FlgF7ClW OhdpyX/jR+7djTc0ArSI2xF2PWlBub+W0jjjLk3Sr9khXXODgAJK3hDBL850IJWEiDQz1GtGd ekTHRb8wdlpbzSXDR/JPKYfrPe8smJE3ueTcmZuLW9qoXQ2stZbq1NWevQT5JPB9cV5ZLGNjZ 3EO8eB4/Q/Z4lC8zyzKS+3h3PeCWA3IDJo/mXS3w0+qCDny9tvR87eHPzwYRmfOz/KGQSpCcK ob2f169+Apt/hdV5FdDPuCc/NL6q++k95O440ggQDqJwti1gzJoHqGg4dmLXbGxV4Tg9pOqXC JFSuJ0cdlynBmezuXey29MjXq8PrdkMc8aeib+cYNR9nTpvyRvfUPB0t03193voDMqJycMte+ N5pAYfvQsrtLWbKtw7slsGomfjUuxj5X1QokB+SzcKhUIzPftM94kOwtHDNh8INH2HeNX+eUq igSqW7RlndVEWu1zQSS8J5clh07rNHG+mrv+rGYegc74TPnBZHGTBP1/FSgAUbKBxsm5QCUOW 4fqMpgknHiNtWpDe7Bl0ejX2ErpN0H6XMJOq4ccQsf7ILKk2sr6oIDdwSY2mATSTvw/IsxOHF tp9RoaGy3idrYSZ2YS1IL34SV3fHq0G+bEs+dfx7wW4IWPmksxyLlA5BiGXp8lwuclh0HPMmP he7Xe8GRcPgLE4zEftkf+D6atvQolhh4l9PD+CQFHbBaBQpoVkdPoXT/o7ErnitJmn5vEPJV8 5km05ko204eIeuYdS4tbnMEhzHdADSDAxdTtSl+63UQGxSsHEUk2PNxSeJkGWtWkp0KKxc7XU zMR5LM2CJHQLwUvcPcT0w/j4d9qLLmHB1fTOa7OQR2U1dP5jECErjvJyL8uiJpe7x7pWnlw/C TVxk7+9IUdd3QdpJCyHdYRGpC3SkpXQrSq4882BkDdGqkPpVuDa1FH1pfNSCySrbgGoHgm2qr 313ZfVVtLYqjdrvYbLzB6PEnsOg= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 65914 Cc: 65914@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Stefan Kangas wrote: > Thanks, I would like to install this patch. > > Could you please send the patch as an attachment instead? We prefer > that patches are created with a command like `git format-patch -1'. > > Please also include: > > - The bug number of this bug in the commit message, like so: Bug#65914 > > - A ChangeLog entry, as described in the CONTRIBUTE file. > > That would make it easier for us to review and install this patch. > Thanks in advance. PFA: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Description: [PATCH] Exclude current buffer from eww-switch-to-buffer Content-Transfer-Encoding: quoted-printable =46rom 229b3e5be1df7c753410e840d6ea9c36f822fefd Mon Sep 17 00:00:00 2001 From: James Thomas Date: Sat, 16 Sep 2023 05:50:58 +0530 Subject: [PATCH] Exclude current buffer from eww-switch-to-buffer Exclude the current buffer from the completion list of eww-switch-to-buffer; to avoid an extra cycling keystroke (Bug#65914). * lisp/net/eww.el (eww-switch-to-buffer): =2D-- lisp/net/eww.el | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 4ddda216afc..e43ef2bfe8b 100644 =2D-- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -2062,7 +2062,8 @@ eww-switch-to-buffer (let ((completion-extra-properties '(:annotation-function (lambda (buf) (with-current-buffer buf - (format " %s" (eww-current-url))))))) + (format " %s" (eww-current-url)))))) + (curbuf (current-buffer))) (pop-to-buffer-same-window (read-buffer "Switch to EWW buffer: " (cl-loop for buf in (nreverse (buffer-list)) @@ -2070,9 +2071,10 @@ eww-switch-to-buffer return buf) t (lambda (bufn) - (with-current-buffer - (if (consp bufn) (cdr bufn) (get-buffer bufn)) - (derived-mode-p 'eww-mode))))))) + (setq bufn (if (consp bufn) (cdr bufn) (get-buffer bu= fn))) + (and (with-current-buffer bufn + (derived-mode-p 'eww-mode)) + (not (eq bufn curbuf)))))))) (defun eww-toggle-fonts () "Toggle whether to use monospaced or font-enabled layouts." =2D- 2.34.1 --=-=-= Content-Type: text/plain -- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 01 12:54:04 2023 Received: (at 65914-done) by debbugs.gnu.org; 1 Oct 2023 16:54:04 +0000 Received: from localhost ([127.0.0.1]:35220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmzhk-0006c8-33 for submit@debbugs.gnu.org; Sun, 01 Oct 2023 12:54:04 -0400 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]:45433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmzhi-0006bZ-EC for 65914-done@debbugs.gnu.org; Sun, 01 Oct 2023 12:54:03 -0400 Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-5045cb9c091so18088688e87.3 for <65914-done@debbugs.gnu.org>; Sun, 01 Oct 2023 09:53:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696179220; x=1696784020; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=cddUw3NMt36oZxc96vTHdRfJUYoBAbgieq8pjYn9dro=; b=Gz/6xOP8s9jZXVu9XGg+qKok3+idPISCxiiv1QAq2V4UxKUaJQSXHuvVQPxdXAWMQr YwzDEhOPqrqqZjnSQw5EXgBoVN6KIVF8aiaFmhECi0O+buYBzmlle8b1whgmd9jfmk0w RCCa4wSBTHD036mVfDHayDCJVEd7EI7L3e4NMkrbBFgPutugwpYbMHlsN2xyF1S2UAiZ zVX6MngJGP+9Td7ZOKGoTCfU+luUityDt75e4CVqDLmRQ8UkItIlTgMbxfrqleZn8NnZ EJ8XRoEhNz5C2f+AAqAq3UCKLfXIIJ9cHh0cLOIul1kJ7IDr+4tLol2BC8XXT2xXcM3z L7Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696179220; x=1696784020; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cddUw3NMt36oZxc96vTHdRfJUYoBAbgieq8pjYn9dro=; b=bf34oyiQUXNOW/CC0SIZeC+A0YaY3I0I0BgFg6cGErqUUoLOo+2mHWELUyezNQE1iW HFqm+VeWcZpoC/Ccpbm/HMP+qQ5A9QoW/00IP2IFKsAJQqV2E0BqpFQPO6cgj9CQXrgr E6G29TKv59lUsy6rtX86yDP0dh2MeG2o86M7yYTD/I8z9ngJfkUa3z1pVkQsjvh02Jnp dm0XoOOfCJpuSHHNzVKv7Zhz0nBDxNYAowrTO/jHaWn0Vpa1OLc/MlW/k4/p8+dsX9MY OO0elX628UM7rNwm32HNWGa9HZzIQUIBJ5Pbig1ltZT63ZNimj0kzTagqTtVn0QSqU92 KJNg== X-Gm-Message-State: AOJu0YxgTmDTi8b1kgNpPOytSJ3Xo7lM51lrvC4VmJXmndMwk1LOsSSq N6gZXstDMabJU79hZg5bnJ/6MD5ED1HSWqrM/zv7tP8oX+s= X-Google-Smtp-Source: AGHT+IHtp9CXBn5X3PgW5qYt0QPrTFb05UlLK8578pkskow/p/Jv3+/6QHms2nTggzrI7hdK/s4ZCNIvPOSVGUQAnTM= X-Received: by 2002:ac2:44cb:0:b0:503:389d:1cc1 with SMTP id d11-20020ac244cb000000b00503389d1cc1mr8148294lfm.22.1696179220329; Sun, 01 Oct 2023 09:53:40 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 1 Oct 2023 09:53:39 -0700 From: Stefan Kangas In-Reply-To: <87il8bargm.fsf@gmx.net> References: <87y1ha1he8.fsf@gmx.net> <87il8bargm.fsf@gmx.net> MIME-Version: 1.0 Date: Sun, 1 Oct 2023 09:53:39 -0700 Message-ID: Subject: Re: bug#65914: Exclude current buffer from eww-switch-to-buffer To: James Thomas Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65914-done Cc: 65914-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 30.1 James Thomas writes: > Stefan Kangas wrote: > >> Thanks, I would like to install this patch. >> >> Could you please send the patch as an attachment instead? We prefer >> that patches are created with a command like `git format-patch -1'. >> >> Please also include: >> >> - The bug number of this bug in the commit message, like so: Bug#65914 >> >> - A ChangeLog entry, as described in the CONTRIBUTE file. >> >> That would make it easier for us to review and install this patch. >> Thanks in advance. > > PFA: Installed on master [1: 5d9dbf17cf6]. Thanks again for the patch! [1: 5d9dbf17cf6]: 2023-10-01 18:51:18 +0200 Exclude current buffer from eww-switch-to-buffer https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5d9dbf17cf6123ad24d8f9193818ac64606e3a45 From unknown Fri Aug 15 15:58:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 30 Oct 2023 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator