Subject: Re: [PATCH v2] gnu: Make vice tunable.

From: Csepp <[email-masked]>
Date: Mon, 18 Sep 2023 14:17:25 +0200

Ludovic Courtès <[email-masked]> writes:

> Hi,
>
> raingloom <[email-masked]> skribis:
>
>> From: Csepp <[email-masked]>
>>
>> * gnu/packages/emulators.scm (vice)[properties]: Set tunable? to #t.
>> ---
>>  gnu/packages/emulators.scm | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm
>> index 1d50c9ef01..0fb4a5853b 100644
>> --- a/gnu/packages/emulators.scm
>> +++ b/gnu/packages/emulators.scm
>> @@ -118,6 +118,8 @@ (define-public vice
>>    (package
>>      (name "vice")
>>      (version "3.7.1")
>> +    ;; without this it would use AVX even when it's not suported:
>
> Oh I see.  It’s a problem that ‘tunable?’ in itself doesn’t solve.
>
> The fix would be twofold: (1) remove ‘-march’ and similar compiler
> arguments that cause it to generate code that assumes AVX availability,
> and (2) add the ‘tune?’ property for those who want a fine-tuned binary.
>
> Could you look into it?
>
> Thanks,
> Ludo’.

Umm, it definitely solved it on my machine, which doesn't have AVX.
If that's not a "proper" fix, then sure, I can try looking into it more.
But it seems to me like `tunable?` is already working as intended.