GNU bug report logs - #65854
Multi-file replacement diff

Previous Next

Package: emacs;

Reported by: Juri Linkov <juri <at> linkov.net>

Date: Sun, 10 Sep 2023 17:24:01 UTC

Severity: wishlist

Tags: patch

Fixed in version 30.0.50

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

Full log


Message #55 received at 65854 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: me <at> eshelyaron.com, 65854 <at> debbugs.gnu.org
Subject: Re: bug#65854: Multi-file replacement diff
Date: Sat, 23 Sep 2023 21:56:01 +0300
> From: Juri Linkov <juri <at> linkov.net>
> Cc: me <at> eshelyaron.com,  65854 <at> debbugs.gnu.org
> Date: Sat, 23 Sep 2023 20:36:02 +0300
> 
> >> >> +                                                    However, when the file
> >> >> +is not visited in a buffer, or the buffer is not modified, still read
> >> >> +contents from the file."
> >> >
> >> > Seems to describe an implementation detail, and I don't think it
> >> > should be there.  E.g., what if the file visited by the buffer no
> >> > longer exists?
> >>
> >> If the file visited by the buffer no longer exists, then
> >> the standard error is signaled.
> >
> > Which means in that case it is better to use the buffer text, no?
> 
> Since replacement diffs are not supported in non-file buffers,
> better to signal an error for heads up.

But it _is_ a file-visiting buffer.  It's just that its file was
deleted meanwhile.




This bug report was last modified 1 year and 236 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.