Subject: Re: bug#65854: Multi-file replacement diff

From: Eli Zaretskii <[email-masked]>
Date: Fri, 15 Sep 2023 10:38:23 +0300

> From: Juri Linkov <[email-masked]>
> Cc: Eshel Yaron <[email-masked]>,  [email-masked]
> Date: Fri, 15 Sep 2023 09:40:21 +0300
> 
> +(defcustom multi-file-diff-unsaved 'use-file
> +  "A choice defining what to do with unsaved changes.

This first sentence is too general.  I suggest

  What to do with unsaved edits when showing multi-file replacements as diffs.

> +(defun multi-file-replace-regexp-as-diff (files regexp to-string &optional delimited)
> +  "Show replacements in FILES matching REGEXP with TO-STRING as diff.

  Show as diffs replacements of REGEXP with TO-STRING in FILES.

> +With a prefix argument, ask for a wildcard, and replace in files

"replace"?  Does this command perform replacements or just shows them
as diffs?  The first sentence seems to convey the latter.

> +(defun multi-buffer-replace-regexp-as-diff (buffers regexp to-string &optional delimited)
> +  "Show replacements in file BUFFERS matching REGEXP with TO-STRING as diff.
> +With a prefix argument, ask for a regexp, and replace in file buffers
> +whose names match the specified regexp."

Same comments here.

> +(defun replace-regexp-as-diff (regexp to-string &optional delimited)
> +  "Show replacements in the current file buffer matching REGEXP with TO-STRING as diff.
> +With a prefix argument, ask for a regexp, and replace in file buffers
> +whose names match the specified regexp."

And here.

Thanks.