Subject: Re: bug#65857: [PATCH v2 2/2] gnu: scilab: Set SCIHOME default to respect XDG base dirs.

From: Ludovic Courtès <[email-masked]>
Date: Thu, 05 Oct 2023 16:51:27 +0200

Hi,

Nicolas Graves <[email-masked]> skribis:

> +            (add-after 'install 'hardcode-script-inputs
> +              (lambda _
> +                (substitute* (string-append #$output "/bin/scilab")
> +                  (("grep")
> +                   (search-inputs-file #$inputs "/bin/grep"))

I’ll contradict Efraim, but hopefully they’ll pardon me: I’d write it
like so:

  (lambda* (#:key inputs #:allow-other-keys)
    (substitute* …
      (("grep")
       (search-input-file inputs "/bin/grep"))))

That way it’ll DTRT even when creating a variant of this package.

(The code above had a typo too, with “inputs” as plural.)

Could you send one last updated patch?

Thanks,
Ludo’.