GNU bug report logs - #65852
30.0.50; image-auto-resize :type has choices in wrong order

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#65852: closed (30.0.50; image-auto-resize :type has choices
 in wrong order)
Date: Sun, 10 Sep 2023 15:39:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 10 Sep 2023 08:38:03 -0700
with message-id <CADwFkmmHxiND80HPJPSbMunbF4U+R-Rog893CabB8Z0+LFyWmw <at> mail.gmail.com>
and subject line Re: bug#65852: 30.0.50; image-auto-resize :type has choices in wrong order
has caused the debbugs.gnu.org bug report #65852,
regarding 30.0.50; image-auto-resize :type has choices in wrong order
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
65852: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65852
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; image-auto-resize :type has choices in wrong order
Date: Sun, 10 Sep 2023 10:40:45 -0300

The :type for image-auto-resize looks like this:

:type '(choice (const :tag "No resizing" nil)
               (const :tag "Fit to window" fit-window)
               (other :tag "Scale down to fit window" t)
               (number :tag "Scale factor" 1))

The `other' choice should come last.  Otherwise Custom thinks that
that's the selected option, even when the value of image-auto-resize is
a number.

[Message part 3 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Mauro Aranda <maurooaranda <at> gmail.com>, 65852-done <at> debbugs.gnu.org
Cc: Mattias Engdegård <mattiase <at> acm.org>
Subject: Re: bug#65852: 30.0.50;
 image-auto-resize :type has choices in wrong order
Date: Sun, 10 Sep 2023 08:38:03 -0700

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> On 10/9/23 11:24, Stefan Kangas wrote:
>  >> I worked on something like that for elint.el, based on the wishlist on
>  >> Bug#2591: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=2591
>  >>
>  >> But I know it might be better to make it so that the byte-compiler
>  >> warns, so I never posted it.
>  >
>  > I'm not sure if elint.el is used all that much, but I might be wrong.
>
> A shame, if you ask me.  It helped me find two more options with this
> problem: font-lock-verbose and message-openpgp-header.  I attach an
> updated patch, but let me know if you prefer a separate bug report.

Thanks, pushed to master.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.