GNU bug report logs - #65852
30.0.50; image-auto-resize :type has choices in wrong order

Previous Next

Full log

Message #14 received at 65852 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>, 65852 <at> debbugs.gnu.org
Subject: Re: bug#65852: 30.0.50; image-auto-resize :type has choices in wrong
 order
Date: Sun, 10 Sep 2023 10:58:17 -0300

On 10/9/23 10:49, Stefan Kangas wrote:
> Mauro Aranda <maurooaranda <at> gmail.com> writes:
>
>> The :type for image-auto-resize looks like this:
>>
>> :type '(choice (const :tag "No resizing" nil)
>>                 (const :tag "Fit to window" fit-window)
>>                 (other :tag "Scale down to fit window" t)
>>                 (number :tag "Scale factor" 1))
>>
>> The `other' choice should come last.  Otherwise Custom thinks that
>> that's the selected option, even when the value of image-auto-resize is
>> a number.
>
> ENOPATCH

I was waiting to get a bug number assigned, so I could add it in the
commit message.  I don't know if there's any other way to do it.

> Thanks for working on this.  Is it possible to detect issues like these
> statically?

I worked on something like that for elint.el, based on the wishlist on
Bug#2591: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=2591

But I know it might be better to make it so that the byte-compiler
warns, so I never posted it.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.