From unknown Mon Aug 11 21:12:08 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#65852 <65852@debbugs.gnu.org> To: bug#65852 <65852@debbugs.gnu.org> Subject: Status: 30.0.50; image-auto-resize :type has choices in wrong order Reply-To: bug#65852 <65852@debbugs.gnu.org> Date: Tue, 12 Aug 2025 04:12:08 +0000 retitle 65852 30.0.50; image-auto-resize :type has choices in wrong order reassign 65852 emacs submitter 65852 Mauro Aranda severity 65852 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 10 09:41:14 2023 Received: (at submit) by debbugs.gnu.org; 10 Sep 2023 13:41:15 +0000 Received: from localhost ([127.0.0.1]:49280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfKgc-00077g-MG for submit@debbugs.gnu.org; Sun, 10 Sep 2023 09:41:14 -0400 Received: from lists.gnu.org ([2001:470:142::17]:55990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfKgY-00077L-R7 for submit@debbugs.gnu.org; Sun, 10 Sep 2023 09:41:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfKgM-0005zB-OT for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 09:40:58 -0400 Received: from mail-oo1-xc2f.google.com ([2607:f8b0:4864:20::c2f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfKgJ-00014g-RT for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 09:40:58 -0400 Received: by mail-oo1-xc2f.google.com with SMTP id 006d021491bc7-57359e85e9bso2001658eaf.2 for ; Sun, 10 Sep 2023 06:40:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694353254; x=1694958054; darn=gnu.org; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=eTVPm/+GKZSF5ouGY1JwRpwewEL2eGoUAG2BXrNqQ4c=; b=nklCxBflnF3AQ02Tv1Oq8jTuV0yo+BsnSONNH7ljqMAo9YAKqkQC6Mb963hf2AjVXr Rtvxj1H1x/xYSb4Ir82JHla51BTo3XEFa3IIJj/s4CQgJXAzn38i3adn4M0olFyriT9n m/qD1NxEqdv4dQOhY3/om7lasRF6ZM/2g3VHHmMOTJLRhNcSBw7lhY4UbOS9SNzEMKYI ovO8weZJae5t/M/U9ufCxLbwzhgLGgnu6Tf7TuUtKzaXnatWVBkJ531Qd7aOqw6iXS/B PQ/JuEJ2dioKR2G8IeRi3xVs3Qtom3t3RULNGup3fQISCjZ883FGrJKZeFP+EzmuV5tP 1nSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694353254; x=1694958054; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=eTVPm/+GKZSF5ouGY1JwRpwewEL2eGoUAG2BXrNqQ4c=; b=CY29YiJxyqa7ybBzi4uid9JaIun2TTjtNgM3Jo/rHhJWunWF0O9/JpElYM2C6NVrC+ ewqWKK4HtLdMOAVF06vPMX7xTZ/WesStj4J1EICqkvIbSxuhqptE4v6XkZrt2dNZPjNQ lxueUkpDmwWapQNMrnpSpyBeP5vLAAmY/hf6ahVaW5rT0q5KgMqTdF89Q8xl93q8+dCA EFLnWXd1Gz543Hfc8rEMSF4SQLXQZIGPW6Dy3oIJDVQRJp5a/+CNQVETLmX59U+sHggf f4Zru5dhV62tXWLGwHwsqGzKbpRNLo1pjkTCJGNw9FoEiR743DExGDBhdp4Qsy7/qqJ+ kU6g== X-Gm-Message-State: AOJu0Yx8HXDUBtyM2hhMmqGeFJXABSwLHHV4rIqHKsYN7vhIQspg5VaA +UM4xUw78MXrvGoEc7rcljxNS13FWuw= X-Google-Smtp-Source: AGHT+IGU23kCOEw+5AUVgczq1Ic9gE5qgE2ZhCS2zrVMI3vZ2Bf5/JeD85xvbkLDKYq5AiDuoywZaA== X-Received: by 2002:a05:6871:80e:b0:1bc:26d:6664 with SMTP id q14-20020a056871080e00b001bc026d6664mr7983888oap.16.1694353254020; Sun, 10 Sep 2023 06:40:54 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id c2-20020a056871034200b001c5a3e31474sm3000770oag.45.2023.09.10.06.40.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Sep 2023 06:40:53 -0700 (PDT) Message-ID: <081b5bd0-9652-cb7b-3c59-b07cab5e104d@gmail.com> Date: Sun, 10 Sep 2023 10:40:45 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Mauro Aranda Subject: 30.0.50; image-auto-resize :type has choices in wrong order Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::c2f; envelope-from=maurooaranda@gmail.com; helo=mail-oo1-xc2f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) The :type for image-auto-resize looks like this: :type '(choice (const :tag "No resizing" nil)                (const :tag "Fit to window" fit-window)                (other :tag "Scale down to fit window" t)                (number :tag "Scale factor" 1)) The `other' choice should come last.  Otherwise Custom thinks that that's the selected option, even when the value of image-auto-resize is a number. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 10 09:48:55 2023 Received: (at 65852) by debbugs.gnu.org; 10 Sep 2023 13:48:55 +0000 Received: from localhost ([127.0.0.1]:49299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfKo3-0007Nm-47 for submit@debbugs.gnu.org; Sun, 10 Sep 2023 09:48:55 -0400 Received: from mail-oi1-x235.google.com ([2607:f8b0:4864:20::235]:52293) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfKnz-0007NW-Qu for 65852@debbugs.gnu.org; Sun, 10 Sep 2023 09:48:53 -0400 Received: by mail-oi1-x235.google.com with SMTP id 5614622812f47-3a751d2e6ecso2816773b6e.0 for <65852@debbugs.gnu.org>; Sun, 10 Sep 2023 06:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694353722; x=1694958522; darn=debbugs.gnu.org; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=7BZ9upVu6AOP0xjW4OkjsIj5fXRsoShSJwq/NA1UqQE=; b=NxCCfeRkxzDeQOnU/adhfg2HOZiXxzamNeM5fm2aS4dZS0XChJuQHZYQLg4eltWeFc 4eV1jRB5dSXVIRsxGpJKT6ZaLTukH+KY7XdxoTOf9xLwuCNlsPS52Gxan6MLs0eUA8qX gE6YElt7ts8bShGPttnBdFo8dF5QLpoXuvuaYNXJWEKxGDFfrA9yJVQRtVf/0pVTyWmM RPYWgI8hTIBDS7XGexz82kLOQKlA4MO2sihQ50ntzuUf4IWcBKQg8Q7Dh+fvu5bCvZGi k2+z13bwq/CwgGbQEOP6IpOSyB6dB94R0QHb/m3bJlos7N2lNCsLUV3nbZ7bhClRAaFH UL7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694353722; x=1694958522; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=7BZ9upVu6AOP0xjW4OkjsIj5fXRsoShSJwq/NA1UqQE=; b=bvJMLGj05zeni4KB6lFBpT6xAxXxyt75cf1Dlv48XKgJsSwXzPpMzm5EA4066dpuit v4ctOaxBJx9P7nj0Zc+NGv1lOTYJkNqzgfBwA91NUdKfKfC8fG+vxdV0Mh8Xws97giUD xJl9ET+F3Ulbe6L97ImAhSCtJpXzbQox0vnbmxfM991mH8l7KwoXQ7WWs2iyjctYutug X2ZDz0I2DL5NExLNBBf0eXuD/Ha/oGyUYI62C+a7RArIoUOpoFxWZ+pcwU5T6Ht8QMe6 D3UmJGqzLyFQNUQeZlOwLwqFQ3DTBbRKusILlLCBs5rysKavTSoTbGptMaHmicRpfD2Y jvPQ== X-Gm-Message-State: AOJu0YyNgvZIB+D7JKzlfC0B6Id4Kup9nL3aTj7KWV6nxOjZlcZgBEwe zXRo8dCP8psC3tfzu/NzwIBuryMrFdQ= X-Google-Smtp-Source: AGHT+IFNP15cBKL0uRjqB3vS+wiQUNeNVcux5YMxjuGQmHW7YusXDg7EkGYV9D25t68Zv3OFxNVvUA== X-Received: by 2002:a54:4490:0:b0:3a0:5e17:4311 with SMTP id v16-20020a544490000000b003a05e174311mr8529123oiv.5.1694353721884; Sun, 10 Sep 2023 06:48:41 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id c19-20020a544e93000000b003a79a5cc3bfsm2367845oiy.41.2023.09.10.06.48.40 for <65852@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Sep 2023 06:48:41 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------KTRo7elIO5Mbmrw2kKv1LlUU" Message-ID: <2ef47b5b-2c03-509e-acf5-ad7d28a04166@gmail.com> Date: Sun, 10 Sep 2023 10:48:38 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#65852: 30.0.50; image-auto-resize :type has choices in wrong order Content-Language: en-US From: Mauro Aranda To: 65852@debbugs.gnu.org References: <081b5bd0-9652-cb7b-3c59-b07cab5e104d@gmail.com> In-Reply-To: <081b5bd0-9652-cb7b-3c59-b07cab5e104d@gmail.com> X-Spam-Score: -1.5 (-) X-Debbugs-Envelope-To: 65852 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) This is a multi-part message in MIME format. --------------KTRo7elIO5Mbmrw2kKv1LlUU Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit tags 65852 patch quit Patch attached. --------------KTRo7elIO5Mbmrw2kKv1LlUU Content-Type: text/x-patch; charset=UTF-8; name="0001-Fix-image-auto-resize-type-Bug-65852.patch" Content-Disposition: attachment; filename="0001-Fix-image-auto-resize-type-Bug-65852.patch" Content-Transfer-Encoding: base64 RnJvbSA1NDBiMDZjMTBiMmU4ODBkNmM3YzhkZGMzYjAwNmYyNGVmODQzODg5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IFN1biwgMTAgU2VwIDIwMjMgMTA6NDU6MDQgLTAzMDAKU3ViamVjdDog W1BBVENIXSBGaXggaW1hZ2UtYXV0by1yZXNpemUgOnR5cGUgKEJ1ZyM2NTg1MikKCiogbGlz cC9pbWFnZS1tb2RlLmVsIChpbWFnZS1hdXRvLXJlc2l6ZSk6IEFycmFuZ2UgZm9yICdvdGhl cicgdG8gYmUKdGhlIGxhc3QgY2hvaWNlLgotLS0KIGxpc3AvaW1hZ2UtbW9kZS5lbCB8IDQg KystLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9saXNwL2ltYWdlLW1vZGUuZWwgYi9saXNwL2ltYWdlLW1vZGUuZWwK aW5kZXggZGNlMzVmZjcyZGEuLmVjYzdkNzNkZDllIDEwMDY0NAotLS0gYS9saXNwL2ltYWdl LW1vZGUuZWwKKysrIGIvbGlzcC9pbWFnZS1tb2RlLmVsCkBAIC02OSw4ICs2OSw4IEBAIGlt YWdlLWF1dG8tcmVzaXplCiBSZXNpemluZyB3aWxsIGFsd2F5cyBwcmVzZXJ2ZSB0aGUgYXNw ZWN0IHJhdGlvIG9mIHRoZSBpbWFnZS4iCiAgIDp0eXBlICcoY2hvaWNlIChjb25zdCA6dGFn ICJObyByZXNpemluZyIgbmlsKQogICAgICAgICAgICAgICAgICAoY29uc3QgOnRhZyAiRml0 IHRvIHdpbmRvdyIgZml0LXdpbmRvdykKLSAgICAgICAgICAgICAgICAgKG90aGVyIDp0YWcg IlNjYWxlIGRvd24gdG8gZml0IHdpbmRvdyIgdCkKLSAgICAgICAgICAgICAgICAgKG51bWJl ciA6dGFnICJTY2FsZSBmYWN0b3IiIDEpKQorICAgICAgICAgICAgICAgICAobnVtYmVyIDp0 YWcgIlNjYWxlIGZhY3RvciIgMSkKKyAgICAgICAgICAgICAgICAgKG90aGVyIDp0YWcgIlNj YWxlIGRvd24gdG8gZml0IHdpbmRvdyIgdCkpCiAgIDp2ZXJzaW9uICIyOS4xIgogICA6Z3Jv dXAgJ2ltYWdlKQogCi0tIAoyLjM0LjEKCg== --------------KTRo7elIO5Mbmrw2kKv1LlUU-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 10 09:49:40 2023 Received: (at 65852) by debbugs.gnu.org; 10 Sep 2023 13:49:40 +0000 Received: from localhost ([127.0.0.1]:49303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfKom-0007P9-F5 for submit@debbugs.gnu.org; Sun, 10 Sep 2023 09:49:40 -0400 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]:56695) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfKok-0007Ov-Ah for 65852@debbugs.gnu.org; Sun, 10 Sep 2023 09:49:38 -0400 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2b95d5ee18dso62158641fa.1 for <65852@debbugs.gnu.org>; Sun, 10 Sep 2023 06:49:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694353768; x=1694958568; darn=debbugs.gnu.org; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:from:to:cc:subject:date:message-id :reply-to; bh=yraw8IiT0VGXfXTvyuhgwRL3hYDTK8E3XZ9PsYc9tYw=; b=BcgGlK3sZi4Z5f4aa3Tp2IB46FaNi+IDQLw29TeOaFCPAUWdJOPbT1kKmFRqyvzNye sH2VnVKVhm1Eu7tsiYQFiJ6Ma41ytWIRFnyYiXvSFKkAO9FJe7CbsVwIYa23DkKLoHkt NAzoxcof+4pIw8PnhuBJVTiE+EDvazB7OWi0cEegSFcwoU60+w852C9vkTzZevaOdoCV g54n32kqv4yIUCXPoKDbsS+t/HmfXdyCcjEcDfaALIDve7o49UBqc00EQfE7RXFSp5T0 4aadU8TQSYGSugOn+PFHXHcUJ6qGr4FmQ+ucElg7BNHsJ74xR0z0Q2tVLLOH2rQrQFe/ PEuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694353768; x=1694958568; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=yraw8IiT0VGXfXTvyuhgwRL3hYDTK8E3XZ9PsYc9tYw=; b=Hv4ELi45GIsg2rSYFhkuD7v32QOuUF3Y8AES/xIs8UhRhlJQzP6Wl9sKZy6Q78pd7Q 7lNS4hF6xKYDKAxVESU96NOVpyPZ7W22QV7vknwFM4yedltE1yS0RUHOdlrQwDIU3s/m ppoL58BA+p3t9mMwYts4tGEliJXN0UmtDhcVj1AALAwo64OhwcuQ2p6TxqK8Ujp31hrV xeIRodxjhSZPiHAGtLtHTw+caCK7cIbl4P4em6Uf+tDeSjh11h69WBIWCfW+WUn5/psi afKiCUd+SW7ngCXe501XYGqNask7uQ/kszh/I3UHJX1wG6tIst3QbtXJT02AF923VPvE c3pg== X-Gm-Message-State: AOJu0YxUkfjtV+5yxCaSUHRoe3vaADBN2CYCb9RWQSCoyhETBWTNlC6Y s9IsMkF+IggLfn8G5rRv8G7XHOh7RI+9+DLZJTs= X-Google-Smtp-Source: AGHT+IHVD5B+9N+Le6YYGg2rcgWYfCbjgJuJGvg7KgmQFNLZTc73b6Yv5kgzzVWG54MMEq+rUtVeNxnvqaKdq/rYmKA= X-Received: by 2002:a2e:b704:0:b0:2bc:b29e:8ff7 with SMTP id j4-20020a2eb704000000b002bcb29e8ff7mr6182563ljo.20.1694353768233; Sun, 10 Sep 2023 06:49:28 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 10 Sep 2023 06:49:27 -0700 From: Stefan Kangas In-Reply-To: <081b5bd0-9652-cb7b-3c59-b07cab5e104d@gmail.com> References: <081b5bd0-9652-cb7b-3c59-b07cab5e104d@gmail.com> MIME-Version: 1.0 Date: Sun, 10 Sep 2023 06:49:27 -0700 Message-ID: Subject: Re: bug#65852: 30.0.50; image-auto-resize :type has choices in wrong order To: Mauro Aranda , 65852@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65852 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > The :type for image-auto-resize looks like this: > > :type '(choice (const :tag "No resizing" nil) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 (const :tag "Fit to window" fit-window) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 (other :tag "Scale down to fit window" t) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 (number :tag "Scale factor" 1)) > > The `other' choice should come last.=C2=A0 Otherwise Custom thinks that > that's the selected option, even when the value of image-auto-resize is > a number. ENOPATCH Thanks for working on this. Is it possible to detect issues like these statically? From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 10 09:58:32 2023 Received: (at 65852) by debbugs.gnu.org; 10 Sep 2023 13:58:32 +0000 Received: from localhost ([127.0.0.1]:50991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfKxM-00082C-64 for submit@debbugs.gnu.org; Sun, 10 Sep 2023 09:58:32 -0400 Received: from mail-oo1-xc32.google.com ([2607:f8b0:4864:20::c32]:50291) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfKxI-00081x-Lz for 65852@debbugs.gnu.org; Sun, 10 Sep 2023 09:58:31 -0400 Received: by mail-oo1-xc32.google.com with SMTP id 006d021491bc7-570e005c480so2232361eaf.0 for <65852@debbugs.gnu.org>; Sun, 10 Sep 2023 06:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694354299; x=1694959099; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FCCs7PDnM0ohvF9PInyyslmfJDhpveymeZ3ozEq7WZI=; b=qETrYQ4rdly47gOQqlPyUlJN9rGZdkxp50BzH42IuaeVS6sptQLdIoMMzXeTnHQDNj F3eliFyG6ybHxzbmn9HdUluTV2cNltHTrcbTO05mrQk/ts5jAjxrQMpwC2/slZFms8yE neNPRnJaoNhAj/RJaGtL3eDdqzpeZvmLyYAsgkNEQGt148wZcDXHzQLLgP6sFigDQ0u7 ZKcHjEn1yzp9hjTJoVDWXhgonAaj3+YHs5dhth5nHTGDG9lwbw2i0MAmi8wUwMuaFVUv cN+e0HHJSXjG3fPsumNZSkXIlZDADujde9OQ+XAP3WJFfzg4KHzxE0zdC6WUZfLwtmof oxGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694354299; x=1694959099; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FCCs7PDnM0ohvF9PInyyslmfJDhpveymeZ3ozEq7WZI=; b=RpZuScy2b6u7OBFTXuwKnjX1YNluLdtSg0bUlOfLqzmQfU2ufCQsZA+ddik+VA1lRQ 7J16DVyVCwn9c/Ml2bxdkYxYXXf3NgLAAogguH4/ef76xnNuKkJ5MHrRgQ7BCzFH2qdk OqY24LaFLzoCHGtOG5WyQMSgqnWgNsB4fZ5KeNArMITgK7o0hPLVFTRsgrB1bJaTMX5C p+Xg4xt4RPvocJZqYlqvdRSG0lwJ3cZmlMb0jmmlK/jAtBb7bN45cmu6Fax1UPz/HfRi wTpgR/nRvO4BqBdXeOIOpeZncvQaMhhZZsRJqSM48q+GXKfXVR00bYpGDy/3RbF1cKKI FKZw== X-Gm-Message-State: AOJu0YyVrOLNz8ZPs0b239K5G5CxwhBrBFs/ehgq9vpho3gCi+LNqWhU 07XWAuw+ONouyl3qKL5klo8= X-Google-Smtp-Source: AGHT+IGogk7cMVDCRK/JLit8y/O6idqC3e3rwIm8vhgx8P9yekk3KkeGYNYmiYVlwVBUApopblnY3A== X-Received: by 2002:a05:6870:d60f:b0:1d5:6161:76f2 with SMTP id a15-20020a056870d60f00b001d5616176f2mr9590707oaq.27.1694354299470; Sun, 10 Sep 2023 06:58:19 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id a16-20020a056870e35000b001cd1a628c40sm3009159oae.52.2023.09.10.06.58.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Sep 2023 06:58:19 -0700 (PDT) Message-ID: <6fe31ce5-4be7-7f79-e310-52e04d869467@gmail.com> Date: Sun, 10 Sep 2023 10:58:17 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#65852: 30.0.50; image-auto-resize :type has choices in wrong order Content-Language: en-US To: Stefan Kangas , 65852@debbugs.gnu.org References: <081b5bd0-9652-cb7b-3c59-b07cab5e104d@gmail.com> From: Mauro Aranda In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.5 (-) X-Debbugs-Envelope-To: 65852 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) On 10/9/23 10:49, Stefan Kangas wrote: > Mauro Aranda writes: > >> The :type for image-auto-resize looks like this: >> >> :type '(choice (const :tag "No resizing" nil) >>                 (const :tag "Fit to window" fit-window) >>                 (other :tag "Scale down to fit window" t) >>                 (number :tag "Scale factor" 1)) >> >> The `other' choice should come last.  Otherwise Custom thinks that >> that's the selected option, even when the value of image-auto-resize is >> a number. > > ENOPATCH I was waiting to get a bug number assigned, so I could add it in the commit message.  I don't know if there's any other way to do it. > Thanks for working on this.  Is it possible to detect issues like these > statically? I worked on something like that for elint.el, based on the wishlist on Bug#2591: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=2591 But I know it might be better to make it so that the byte-compiler warns, so I never posted it. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 10 10:25:06 2023 Received: (at 65852) by debbugs.gnu.org; 10 Sep 2023 14:25:06 +0000 Received: from localhost ([127.0.0.1]:51059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfLN4-0002ua-Eh for submit@debbugs.gnu.org; Sun, 10 Sep 2023 10:25:06 -0400 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:51572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfLN1-0002ty-Em for 65852@debbugs.gnu.org; Sun, 10 Sep 2023 10:25:05 -0400 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-50079d148aeso6023433e87.3 for <65852@debbugs.gnu.org>; Sun, 10 Sep 2023 07:24:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694355893; x=1694960693; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=rmdwouE18ZpZs5RbxNPc+nbvLT1SrODb8qf3N2Xm288=; b=LkvmX/x7jVZsFY1t1y//3k1Qgh73IObhp92q9IhI/KGywnHiPcg6lulI7SRCM3ljn8 V/gmNuuNhffTHX2Oeq749HGX1LjpZcS+6m4ZK4I+FvbqU2opN5Ca6p1AQbHMpJLu3ebp LrY5vJASclLiPSCO154AMHviIzNmDHqCpUagVb4WX4tQm+HJBmgHJ2jQ8KiK6XoU6dc6 u84vVlsujrTafRD0vplZloI5p9xdYnebKbPgCsUF76yZA7UojhUh522LWZfjtMLROC5o 3PNjoDxoB6t20fSU51QBPYPCu5F+Lq9sJL1KimOM1OCguJ6qfOuFR18Y5TRlV2bxVrol XFHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694355893; x=1694960693; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=rmdwouE18ZpZs5RbxNPc+nbvLT1SrODb8qf3N2Xm288=; b=vgG62h2cXZQIvuRglo/5F9GL7lFVEQSBc2PcS1mirerd///mAJFRVW2/7sh/J10VTO XZ7RuTW4P297w1f+BifpcqQuPHkJRSh0S6RCrWkDFXQ9uUlaX1dsWQw9ei0hQeCXiOka AjscIhVtVeCZvY24FUlXCl4jhIvHC7741wpeaU2ZQzOR2GJv9CoTXiGj9N3kxgPxJRGC KYUaT06hpD8DywTzxWZymhRbsPzXihlmnI5ogMiQgmEefukBQxWSh5rvfhkseoqLXRaW jjTBQUMbWJ9JZRbuXLA2dixiIoitaSc+Uy4HayRtfGNpWuIkZw9aO3rwjHCFEGJbxsD1 i0Jg== X-Gm-Message-State: AOJu0YwPE3ovWHOPs2hU0KkoFFCITJrNIM8i6L6H9yj8Io0IlPln77Bz mpjNWRRNVfDPLI8Oai3BpsSPXY8KzmorxHGAl1Q= X-Google-Smtp-Source: AGHT+IG9HQy58vzuqH0fOJ82bfBt/FQltYUy8pH2m4k11kGgAFgvoXDh2RI24WGNTqmf63nvwUlLEoEDBNC/VsbxITc= X-Received: by 2002:a05:6512:e9c:b0:4fb:bef0:948e with SMTP id bi28-20020a0565120e9c00b004fbbef0948emr6660466lfb.5.1694355893218; Sun, 10 Sep 2023 07:24:53 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 10 Sep 2023 07:24:52 -0700 From: Stefan Kangas In-Reply-To: <6fe31ce5-4be7-7f79-e310-52e04d869467@gmail.com> References: <081b5bd0-9652-cb7b-3c59-b07cab5e104d@gmail.com> <6fe31ce5-4be7-7f79-e310-52e04d869467@gmail.com> MIME-Version: 1.0 Date: Sun, 10 Sep 2023 07:24:52 -0700 Message-ID: Subject: Re: bug#65852: 30.0.50; image-auto-resize :type has choices in wrong order To: Mauro Aranda , 65852@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65852 Cc: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > I was waiting to get a bug number assigned, so I could add it in the > commit message.=C2=A0 I don't know if there's any other way to do it. That's the only way to do it, as far as I know. Thanks for doing that, because it does save us time when installing patches. I guess it was me that was a bit quick here. > I worked on something like that for elint.el, based on the wishlist on > Bug#2591: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D2591 > > But I know it might be better to make it so that the byte-compiler > warns, so I never posted it. I'm not sure if elint.el is used all that much, but I might be wrong. Mattias, do you think it would make sense to add some warnings for defcustom types to the byte-compiler? If so, I guess we'd want to limit ourselves to flagging obvious errors. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 10 10:47:42 2023 Received: (at 65852) by debbugs.gnu.org; 10 Sep 2023 14:47:42 +0000 Received: from localhost ([127.0.0.1]:51075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfLiv-00064W-Gt for submit@debbugs.gnu.org; Sun, 10 Sep 2023 10:47:42 -0400 Received: from mail-oo1-xc2e.google.com ([2607:f8b0:4864:20::c2e]:56638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfLir-00063q-Gh for 65852@debbugs.gnu.org; Sun, 10 Sep 2023 10:47:40 -0400 Received: by mail-oo1-xc2e.google.com with SMTP id 006d021491bc7-5733710eecaso2159964eaf.1 for <65852@debbugs.gnu.org>; Sun, 10 Sep 2023 07:47:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694357247; x=1694962047; darn=debbugs.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=80/ijVxFe2qDFADnGZdqlXu2TFx9svorx0z2bstIG9U=; b=LyijnQVNvfUbDqAgnzygTwKlZ00Kuw7uRy5Hw1cgpRlO9RUvZK8NRmat8rMGmt+jv1 w2Zbem4b2jUMNRN3ffCxzljPmYdO3s0G6U7bRaSXROOn2LMXNApT2jn7RRXHZzdOzu5b ke4b7DueIvPjHYsAD8e1DGQcuOjLvAU43GR3tmTx6mMximjDqMbi4J5fWgkaKcwPI0AH foc5G5OQI3+Xj6MngOqZashV14HirCEc384l4smwm8r8zXukxYnEIdaQHHp9506pvEsm 4HscbO0RokXwpslJc8MbppF+9a1G5V6WzpJIhejQamQpFw0gbUuGQGDvBjm+zRF6bWpe Sb+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694357247; x=1694962047; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=80/ijVxFe2qDFADnGZdqlXu2TFx9svorx0z2bstIG9U=; b=B9Narx4cAd4zprPrHsw0x1TtkaAAT9kUt0bMh625103s+rEXICkvyxIv6EIewyrWmv j22D+DNbyoNh84Yjmb4egbm0hU6IdaQY4AcicGld3N7FjyTMd5jS5MJDin1fl38PFXCE DA5eswVMIy6ifJsfxE5yRKl679sT6rlplHXYRaxQ7tqzlvPK2Q2ijGiU4sfNfAAWZl2g 6xAjFDyYaGsMAqndRGK9fKyzf1ELCHcbdawm5uo0PYeoKvWYad5mCAesGbrOOJ92Mbfa Bwu+ooZ5CVRSVfhNU6r6k8Trw7BLSqYSPRwvIBWRK/agXYRKaL+K3w8QoBxOIohY/1Ih 6m/Q== X-Gm-Message-State: AOJu0YxCC1Vn5Ox75oEYWZYY6oZ/VM2hp7T/j2JFqu+1CUCN2wIGPIGq GsvjkLi70+tgB/4EbzS8gsY= X-Google-Smtp-Source: AGHT+IELQRTsvmT1usUxvzu3AOVTwgix1lthfLmjnMCwSmmwJXHDdMGIKRQdS+NkGZZOLkEhzpuYwg== X-Received: by 2002:a4a:d212:0:b0:56e:4bb5:3095 with SMTP id c18-20020a4ad212000000b0056e4bb53095mr7320388oos.5.1694357247578; Sun, 10 Sep 2023 07:47:27 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id q20-20020a056830019400b006b469ace1b1sm2387322ota.22.2023.09.10.07.47.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Sep 2023 07:47:26 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------0W04601br5UtKQcRk3qlnI0r" Message-ID: Date: Sun, 10 Sep 2023 11:47:23 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#65852: 30.0.50; image-auto-resize :type has choices in wrong order Content-Language: en-US To: Stefan Kangas , 65852@debbugs.gnu.org References: <081b5bd0-9652-cb7b-3c59-b07cab5e104d@gmail.com> <6fe31ce5-4be7-7f79-e310-52e04d869467@gmail.com> From: Mauro Aranda In-Reply-To: X-Spam-Score: -1.5 (-) X-Debbugs-Envelope-To: 65852 Cc: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) This is a multi-part message in MIME format. --------------0W04601br5UtKQcRk3qlnI0r Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/9/23 11:24, Stefan Kangas wrote: >> I worked on something like that for elint.el, based on the wishlist on >> Bug#2591: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=2591 >> >> But I know it might be better to make it so that the byte-compiler >> warns, so I never posted it. > > I'm not sure if elint.el is used all that much, but I might be wrong. A shame, if you ask me.  It helped me find two more options with this problem: font-lock-verbose and message-openpgp-header.  I attach an updated patch, but let me know if you prefer a separate bug report. --------------0W04601br5UtKQcRk3qlnI0r Content-Type: text/x-patch; charset=UTF-8; name="0001-Fix-order-of-other-choice-in-defcustom-type.patch" Content-Disposition: attachment; filename="0001-Fix-order-of-other-choice-in-defcustom-type.patch" Content-Transfer-Encoding: base64 RnJvbSBiMmQ1ZmNlY2VjNTdiNmMyYzdmMjZmZGMyYjA3MGMxNGM3ZWFjMTEyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IFN1biwgMTAgU2VwIDIwMjMgMTA6NDU6MDQgLTAzMDAKU3ViamVjdDog W1BBVENIXSBGaXggb3JkZXIgb2YgYG90aGVyJyBjaG9pY2UgaW4gZGVmY3VzdG9tIDp0eXBl CgoqIGxpc3AvZm9udC1sb2NrLmVsIChmb250LWxvY2stdmVyYm9zZSkKKiBsaXNwL2ltYWdl LW1vZGUuZWwgKGltYWdlLWF1dG8tcmVzaXplKQoqIGxpc3AvZ251cy9tZXNzYWdlLmVsICht ZXNzYWdlLW9wZW5wZ3AtaGVhZGVyKTogQXJyYW5nZSBmb3IgJ290aGVyJwp0byBiZSB0aGUg bGFzdCBjaG9pY2UuICAoQnVnIzY1ODUyKQotLS0KIGxpc3AvZm9udC1sb2NrLmVsICAgIHwg NCArKy0tCiBsaXNwL2dudXMvbWVzc2FnZS5lbCB8IDYgKysrLS0tCiBsaXNwL2ltYWdlLW1v ZGUuZWwgICB8IDQgKystLQogMyBmaWxlcyBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDcg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9mb250LWxvY2suZWwgYi9saXNwL2Zv bnQtbG9jay5lbAppbmRleCBmODgxNWMxNjk4YS4uM2RmNjNmODJmYTEgMTAwNjQ0Ci0tLSBh L2xpc3AvZm9udC1sb2NrLmVsCisrKyBiL2xpc3AvZm9udC1sb2NrLmVsCkBAIC0yOTksOCAr Mjk5LDggQEAgZm9udC1sb2NrLXZlcmJvc2UKICAgIklmIG5vbi1uaWwsIG1lYW5zIHNob3cg c3RhdHVzIG1lc3NhZ2VzIGZvciBidWZmZXIgZm9udGlmaWNhdGlvbi4KIElmIGEgbnVtYmVy LCBvbmx5IGJ1ZmZlcnMgZ3JlYXRlciB0aGFuIHRoaXMgc2l6ZSBoYXZlIGZvbnRpZmljYXRp b24gbWVzc2FnZXMuIgogICA6dHlwZSAnKGNob2ljZSAoY29uc3QgOnRhZyAibmV2ZXIiIG5p bCkKLQkJIChvdGhlciA6dGFnICJhbHdheXMiIHQpCi0JCSAoaW50ZWdlciA6dGFnICJzaXpl IikpCisJCSAoaW50ZWdlciA6dGFnICJzaXplIikKKyAgICAgICAgICAgICAgICAgKG90aGVy IDp0YWcgImFsd2F5cyIgdCkpCiAgIDpncm91cCAnZm9udC1sb2NrCiAgIDp2ZXJzaW9uICIy NC4xIikKIAwKZGlmZiAtLWdpdCBhL2xpc3AvZ251cy9tZXNzYWdlLmVsIGIvbGlzcC9nbnVz L21lc3NhZ2UuZWwKaW5kZXggZmUyNzkyN2JlN2UuLmI4ZWE1MjlkNTFjIDEwMDY0NAotLS0g YS9saXNwL2dudXMvbWVzc2FnZS5lbAorKysgYi9saXNwL2dudXMvbWVzc2FnZS5lbApAQCAt Mjg0MCwxMSArMjg0MCwxMSBAQCBtZXNzYWdlLW9wZW5wZ3AtaGVhZGVyCiAJCQkoY29uc3Qg OnRhZyAiTm8gSUQiIG5pbCkpCiAJCShjaG9pY2UgKHN0cmluZyA6dGFnICJLZXkiKQogCQkJ KGNvbnN0IDp0YWcgIk5vIEtleSIgbmlsKSkKLQkJKGNob2ljZSAob3RoZXIgOnRhZyAiTm9u ZSIgbmlsKQotCQkJKGNvbnN0IDp0YWcgIlVucHJvdGVjdGVkIiAidW5wcm90ZWN0ZWQiKQor ICAgICAgICAgICAgICAgIChjaG9pY2UgKGNvbnN0IDp0YWcgIlVucHJvdGVjdGVkIiAidW5w cm90ZWN0ZWQiKQogCQkJKGNvbnN0IDp0YWcgIlNpZ24iICJzaWduIikKIAkJCShjb25zdCA6 dGFnICJFbmNyeXB0IiAiZW5jcnlwdCIpCi0JCQkoY29uc3QgOnRhZyAiU2lnbiBhbmQgRW5j cnlwdCIgInNpZ25lbmNyeXB0IikpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIChjb25z dCA6dGFnICJTaWduIGFuZCBFbmNyeXB0IiAic2lnbmVuY3J5cHQiKQorICAgICAgICAgICAg ICAgICAgICAgICAgKG90aGVyIDp0YWcgIk5vbmUiIG5pbCkpKSkKICAgOnZlcnNpb24gIjI4 LjEiKQogCiAoZGVmdW4gbWVzc2FnZS1hZGQtb3BlbnBncC1oZWFkZXIgKCkKZGlmZiAtLWdp dCBhL2xpc3AvaW1hZ2UtbW9kZS5lbCBiL2xpc3AvaW1hZ2UtbW9kZS5lbAppbmRleCBkY2Uz NWZmNzJkYS4uZWNjN2Q3M2RkOWUgMTAwNjQ0Ci0tLSBhL2xpc3AvaW1hZ2UtbW9kZS5lbAor KysgYi9saXNwL2ltYWdlLW1vZGUuZWwKQEAgLTY5LDggKzY5LDggQEAgaW1hZ2UtYXV0by1y ZXNpemUKIFJlc2l6aW5nIHdpbGwgYWx3YXlzIHByZXNlcnZlIHRoZSBhc3BlY3QgcmF0aW8g b2YgdGhlIGltYWdlLiIKICAgOnR5cGUgJyhjaG9pY2UgKGNvbnN0IDp0YWcgIk5vIHJlc2l6 aW5nIiBuaWwpCiAgICAgICAgICAgICAgICAgIChjb25zdCA6dGFnICJGaXQgdG8gd2luZG93 IiBmaXQtd2luZG93KQotICAgICAgICAgICAgICAgICAob3RoZXIgOnRhZyAiU2NhbGUgZG93 biB0byBmaXQgd2luZG93IiB0KQotICAgICAgICAgICAgICAgICAobnVtYmVyIDp0YWcgIlNj YWxlIGZhY3RvciIgMSkpCisgICAgICAgICAgICAgICAgIChudW1iZXIgOnRhZyAiU2NhbGUg ZmFjdG9yIiAxKQorICAgICAgICAgICAgICAgICAob3RoZXIgOnRhZyAiU2NhbGUgZG93biB0 byBmaXQgd2luZG93IiB0KSkKICAgOnZlcnNpb24gIjI5LjEiCiAgIDpncm91cCAnaW1hZ2Up CiAKLS0gCjIuMzQuMQoK --------------0W04601br5UtKQcRk3qlnI0r-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 10 11:38:53 2023 Received: (at 65852) by debbugs.gnu.org; 10 Sep 2023 15:38:53 +0000 Received: from localhost ([127.0.0.1]:51123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfMWT-0007Oa-CW for submit@debbugs.gnu.org; Sun, 10 Sep 2023 11:38:53 -0400 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]:42170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfMWR-0007ON-GA for 65852@debbugs.gnu.org; Sun, 10 Sep 2023 11:38:51 -0400 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2bcc331f942so44035781fa.0 for <65852@debbugs.gnu.org>; Sun, 10 Sep 2023 08:38:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694360322; x=1694965122; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=QqaF/k02rlGM973GA+k5EfuZKE3Y+qU7Pj3mXPf1FTc=; b=dXqTIAzPadAl4vL5E4Ec7Y88O0qFBk3nLa26kSNdct7NPnu9GM7NV6fzF/044y2lag jR/meq+gUtksRYOtVebgg3ldFt8WO0SpExyST3FrAnAaFYvWMQ4EcyN0w4fZfm0oPVkQ jCIe/vHe9//0XRrIvDphi+yybAMAfMdnR/KDj9H0rhByeSQVZ2mM1JUNEcTfQiFvzR5z JcCMwDgHNYULUfhLgdnY3tf6+UiWNUepoxjslgDtlbnO4OURsO/XwoAyoFVnzkhdRiKK NzbAlxj+UgNrx7A/PI0gtPn9+jRxYiTzlbXNRARQP0tRmAd4UrOvtA/0cq6SdSnzh6Am ZS/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694360322; x=1694965122; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=QqaF/k02rlGM973GA+k5EfuZKE3Y+qU7Pj3mXPf1FTc=; b=SO5wBvxlC8XlEPhTYbB6TrLB+wlsuURpahZbC9bHplwXsaNHIsFBkOAbpiSWN7tmpW RswQ7EnqyMcGGDEhdmrDIABKQ2j1ocWXLGEJeTJeJKOfxJ/8R51JYLmwdWTvMhi1jemo GG2bEZAaDv0AEvmsR7j9f9eBN9GoDQot4193JGWnhtcwXb8eSeSqTAm0z7UF45SLASPI LqXv4ZL4CsAsTx1LYHjKnAROoa/BUbVK/RyQqq4WiXbYhrGC7E3SDd/BqpNjUDjbC8RQ yqEXZ6l7cYG2htDVYhzFYVg1K+4khY6FMl/MjodiA8X5zY1v1q5axDSw8kXv6sahHk+w cafQ== X-Gm-Message-State: AOJu0YzB83qV0UGezy/7TYC6zSmbVF0byJMQm34BHCuY5DKe2nuQ8Bc4 AiTSuM97qMWkAqHQtj6g8Pw= X-Google-Smtp-Source: AGHT+IHa+x+liypljyqJFl9q5PglywbDiovGnAA+fayAk3F96GANp0XnRkYSaK5swCAhyqrUDc8TkA== X-Received: by 2002:a05:651c:2314:b0:2b9:e705:6303 with SMTP id bi20-20020a05651c231400b002b9e7056303mr4253635ljb.4.1694360321580; Sun, 10 Sep 2023 08:38:41 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id y5-20020a2e7d05000000b002bcdeeecd11sm1093533ljc.66.2023.09.10.08.38.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Sep 2023 08:38:40 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#65852: 30.0.50; image-auto-resize :type has choices in wrong order From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Sun, 10 Sep 2023 17:38:40 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <865AB7EF-D175-4A6B-BD64-6C0EE0338D13@gmail.com> References: <081b5bd0-9652-cb7b-3c59-b07cab5e104d@gmail.com> <6fe31ce5-4be7-7f79-e310-52e04d869467@gmail.com> To: Stefan Kangas X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65852 Cc: 65852@debbugs.gnu.org, Mauro Aranda X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 10 sep. 2023 kl. 16.24 skrev Stefan Kangas : > Mattias, do you think it would make sense to add some warnings for > defcustom types to the byte-compiler? If so, I guess we'd want to = limit > ourselves to flagging obvious errors. This appears to be about checking the specified type itself. Another = frequently made mistake is having an initial value that does not match = the type. Both of these cases should indeed ideally be caught at compile time but = the design of `defcustom` makes it impossible in general. In fact it's = probably not even possible to type-check the initial value at load time. However we can check when the type and value are given as compile-time = constants, and we could postpone some of the linting to load time if it = wasn't possible earlier. This is just macro work; I don't see any reason why the byte-compiler = itself should need to be involved directly. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 10 11:38:15 2023 Received: (at 65852-done) by debbugs.gnu.org; 10 Sep 2023 15:38:15 +0000 Received: from localhost ([127.0.0.1]:51120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfMVr-0007Ng-0R for submit@debbugs.gnu.org; Sun, 10 Sep 2023 11:38:15 -0400 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]:51476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfMVp-0007NT-FD for 65852-done@debbugs.gnu.org; Sun, 10 Sep 2023 11:38:14 -0400 Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-50079d148aeso6088034e87.3 for <65852-done@debbugs.gnu.org>; Sun, 10 Sep 2023 08:38:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694360284; x=1694965084; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=5TfJ/WfXTtRXlKICJQM3bwxZ9XuotfBDmcV6RRWe0sg=; b=JaLfP4LzY/Ya2P4jP9BatYaJePGsCGGs4WObzeyw4TxBIiSfJGe4wKKBED+jQIb2aB 0zW5RNrLtf71+zR+w9mu6Ii/hrXZ29UAgFbEosN/gwUxa76nZJZuSoCnuu0EqsnVNJwj oPJKMWAVxRuVMGVO+TIyv8/FRPvMmt4FlXy3MrpGkbTzIKkxJfafuMxWNdfLHUo8f7nR rDfrfRVuOK+h4N6/jrWi14dqXTRo8PJ2ANF4qsNEvSsJt4GeDXhFrpHrHDL7sY3vOjqm Yac6REtg24x9SO6gRXDvSIrH9s461NzaFuarit0BXvl+IrdDbZdoi13j9BxQZop08HsN xvNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694360284; x=1694965084; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=5TfJ/WfXTtRXlKICJQM3bwxZ9XuotfBDmcV6RRWe0sg=; b=bDYOyYazFwCilF2Pzo/iwZnn6Prc3OGcJ0Otn8Gz+urnhm7+T1cDmZ3v8YYXbXqovE dywZ3eHa5jnimV1wu6JJETLgM1arfHmJrhJExavK4THgHgz5Vy4vO4ExG2IL2+1dfFk/ F6YRTJ+U/Z0xCyAMQJQWEODMiS1bet11XL87q41m5uDZWXp63iw5N4pVxJ519l82Duxl oZKsuaKQAnXHaCbgSZ/ZHLKU4COrAVC4GauOREbGiWn3/Gv7LY0NHu65ed9EZvJUktV3 Lo/XXa6AVw+49bS+Ac1g29/LtMXYfSOsSgxHmo8BjRQl5zi02HrFWpEWY4ejRZlg5C9n qQgA== X-Gm-Message-State: AOJu0YyhRz1St/A/mSOTW6lE632tm3kElASfVG+v/6k57E+vu+0ljQ2V TqWt/gVZY3r3HcO0ZqHfNeHVgBldHcsRqYf+Uew= X-Google-Smtp-Source: AGHT+IGWP6DhmpIYh80HuLZfBiRMokFwUE0YJj8Isqx481t5j/EdzNuIZqFcDGwWGICD8rmP71Bl8TfTTrhaHZGv+kY= X-Received: by 2002:a19:6404:0:b0:4ff:89fc:9b5b with SMTP id y4-20020a196404000000b004ff89fc9b5bmr5746454lfb.9.1694360283610; Sun, 10 Sep 2023 08:38:03 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 10 Sep 2023 08:38:03 -0700 From: Stefan Kangas In-Reply-To: References: <081b5bd0-9652-cb7b-3c59-b07cab5e104d@gmail.com> <6fe31ce5-4be7-7f79-e310-52e04d869467@gmail.com> MIME-Version: 1.0 Date: Sun, 10 Sep 2023 08:38:03 -0700 Message-ID: Subject: Re: bug#65852: 30.0.50; image-auto-resize :type has choices in wrong order To: Mauro Aranda , 65852-done@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65852-done Cc: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > On 10/9/23 11:24, Stefan Kangas wrote: > >> I worked on something like that for elint.el, based on the wishlist o= n > >> Bug#2591: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D2591 > >> > >> But I know it might be better to make it so that the byte-compiler > >> warns, so I never posted it. > > > > I'm not sure if elint.el is used all that much, but I might be wrong. > > A shame, if you ask me.=C2=A0 It helped me find two more options with thi= s > problem: font-lock-verbose and message-openpgp-header.=C2=A0 I attach an > updated patch, but let me know if you prefer a separate bug report. Thanks, pushed to master. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 12 10:42:59 2023 Received: (at 65852) by debbugs.gnu.org; 12 Sep 2023 14:42:59 +0000 Received: from localhost ([127.0.0.1]:59763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qg4bT-0007sP-DI for submit@debbugs.gnu.org; Tue, 12 Sep 2023 10:42:59 -0400 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]:46123) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qg4bO-0007s5-Bb for 65852@debbugs.gnu.org; Tue, 12 Sep 2023 10:42:57 -0400 Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-5007c8308c3so9552755e87.0 for <65852@debbugs.gnu.org>; Tue, 12 Sep 2023 07:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694529763; x=1695134563; darn=debbugs.gnu.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:from:to:cc:subject:date:message-id:reply-to; bh=aJb+0TgTRPcZFLSMYFRCth9ZcKWUMDDGX5FnxyuxnhM=; b=obAVI/84mUgqnbLP6Z9kO/Feb8WzmD4zQMqCrqN88YyDAO1GgsY2CXThTlTQzkM6st 2+hXoWOR+okjN40B/PTh56WlNiVkoHB4ejb5C9P5FcFgC4FAX7tWjvRD6LTqCKjRYTXP lxX6rXb8ULj7GP5dnr3oY2zeBjJLHR1AWzF/lqxVSpJxpyhgRn5O9wU32BmNTbQLe0bz hGbjA8uFTA1QBT+yiDZE9tXwWq/hh4hH/d6pXshLNWZK/k4cB4NRQTA14c9zaut4eqAc 1Pc4w3zdkZ18E50ppAeAUHQHiBbs6sbtiRRHQLcAIWR59oQYFIsmPu01yN+ona5Hhp38 RhGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694529763; x=1695134563; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aJb+0TgTRPcZFLSMYFRCth9ZcKWUMDDGX5FnxyuxnhM=; b=tdhGrVnm+yJm+pQOgV2KybxA/Vk8lvjsY6DrZm7ysApaxCTstzj58aJ/w2qX+h+tqQ mcTp0kNBWHGZMkXSUrXpHDfG8NGZY13w8Bj/jBsydZJzAmlVWQc6rFk05yReZAtyNv8c OEIZmKnEDvidGBy2J//scFvBQYjqCptUh6nCr7ziBWy5UMJ81iGn5hvKNnVnBL6SCKLn 4uI6c+ZBaV1q7f+tMCEBKo/vy2BSVE2sCB/VNmDIazYrMyKrhWacDiW1IBPuH0yWm1aG qTt0178SLujoM8ncpX4yk6BqF9boLUr640dc5HXhfqzOQWOSSWeGflZMEv/VIaz42TOi VR/A== X-Gm-Message-State: AOJu0YyZq0l59bnnvgEGfAIp3etcmVvAxE3u+KCzMOkbKTGmTzIKhT9t +vrTaKgh/ImE/dDI6tqHCmQ= X-Google-Smtp-Source: AGHT+IEg24PhXF1AZMcNU5MNfyXl/LVg10mrGtXL3isNhJXK1cC20LK5lIy40hYYPmN3XdlnUOV5ww== X-Received: by 2002:a05:6512:10ce:b0:500:c2d7:3ab4 with SMTP id k14-20020a05651210ce00b00500c2d73ab4mr11888390lfg.8.1694529763266; Tue, 12 Sep 2023 07:42:43 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id v15-20020ac2560f000000b005008cd93961sm1754467lfd.192.2023.09.12.07.42.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Sep 2023 07:42:42 -0700 (PDT) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Message-Id: <8490D7BE-4204-4FC3-B583-D4D0674FB075@gmail.com> Content-Type: multipart/mixed; boundary="Apple-Mail=_B32AA598-69E8-4E4F-ACCB-FFA003CFAC07" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#65852: 30.0.50; image-auto-resize :type has choices in wrong order Date: Tue, 12 Sep 2023 16:42:41 +0200 In-Reply-To: <865AB7EF-D175-4A6B-BD64-6C0EE0338D13@gmail.com> To: Stefan Kangas References: <081b5bd0-9652-cb7b-3c59-b07cab5e104d@gmail.com> <6fe31ce5-4be7-7f79-e310-52e04d869467@gmail.com> <865AB7EF-D175-4A6B-BD64-6C0EE0338D13@gmail.com> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65852 Cc: 65852@debbugs.gnu.org, Mauro Aranda X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_B32AA598-69E8-4E4F-ACCB-FFA003CFAC07 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii I now see that we have an existing defcustom check that runs very late = in the compilation. Although I prefer this kind of check to be carried out during = macro-expansion, doing so has the disadvantage that actual values aren't = always available. On the other hand, defcustom arguments are usually = constants. Anyway, I went overboard and wrote a sizeable expansion to the current = set of warnings and now also checks :type args in define-widget (see = attached patch). Try it out and tell me what you think. Maybe the regexp = check is too ad-hocky. Another warning that I rather like but may give too many false positives = is that of `const` and `other` types without an actual value which is = then assumed to be nil. This seems to be an undocumented 'feature' but = it doesn't help readability; it's often unclear whether `nil` was = intended or just a result of a forgotten value. --Apple-Mail=_B32AA598-69E8-4E4F-ACCB-FFA003CFAC07 Content-Disposition: attachment; filename=more-defcustom-warnings.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="more-defcustom-warnings.diff" Content-Transfer-Encoding: 7bit diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index 7feaf118b86..85962b7c38c 100644 --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -1618,57 +1618,6 @@ byte-compile-format-warn (dolist (elt '(format message format-message error)) (put elt 'byte-compile-format-like t)) -(defun byte-compile--defcustom-type-quoted (type) - "Whether defcustom TYPE contains an accidentally quoted value." - ;; Detect mistakes such as (const 'abc). - ;; We don't actually follow the syntax for defcustom types, but this - ;; should be good enough. - (and (consp type) - (proper-list-p type) - (if (memq (car type) '(const other)) - (assq 'quote type) - (let ((elts (cdr type))) - (while (and elts (not (byte-compile--defcustom-type-quoted - (car elts)))) - (setq elts (cdr elts))) - elts)))) - -;; Warn if a custom definition fails to specify :group, or :type. -(defun byte-compile-nogroup-warn (form) - (let ((keyword-args (cdr (cdr (cdr (cdr form))))) - (name (cadr form))) - (when (eq (car-safe name) 'quote) - (when (eq (car form) 'custom-declare-variable) - (let ((type (plist-get keyword-args :type))) - (cond - ((not type) - (byte-compile-warn-x (cadr name) - "defcustom for `%s' fails to specify type" - (cadr name))) - ((byte-compile--defcustom-type-quoted type) - (byte-compile-warn-x - (cadr name) - "defcustom for `%s' may have accidentally quoted value in type `%s'" - (cadr name) type))))) - (if (and (memq (car form) '(custom-declare-face custom-declare-variable)) - byte-compile-current-group) - ;; The group will be provided implicitly. - nil - (or (and (eq (car form) 'custom-declare-group) - (equal name ''emacs)) - (plist-get keyword-args :group) - (byte-compile-warn-x (cadr name) - "%s for `%s' fails to specify containing group" - (cdr (assq (car form) - '((custom-declare-group . defgroup) - (custom-declare-face . defface) - (custom-declare-variable . defcustom)))) - (cadr name))) - ;; Update the current group, if needed. - (if (and byte-compile-current-file ;Only when compiling a whole file. - (eq (car form) 'custom-declare-group)) - (setq byte-compile-current-group (cadr name))))))) - ;; Warn if the function or macro is being redefined with a different ;; number of arguments. (defun byte-compile-arglist-warn (name arglist macrop) @@ -3695,10 +3644,6 @@ byte-compile-form (defun byte-compile-normal-call (form) (when (and (symbolp (car form)) (byte-compile-warning-enabled-p 'callargs (car form))) - (if (memq (car form) - '(custom-declare-group custom-declare-variable - custom-declare-face)) - (byte-compile-nogroup-warn form)) (byte-compile-callargs-warn form)) (if byte-compile-generate-call-tree (byte-compile-annotate-call-tree form)) @@ -5269,6 +5214,193 @@ byte-compile-make-local-variable (pcase form (`(,_ ',var) (byte-compile--declare-var var))) (byte-compile-normal-call form)) +;; Warn about mistakes in `defcustom', `defface', `defgroup', `define-widget' + +(defvar bytecomp--cus-function) +(defvar bytecomp--cus-name) + +(defun bytecomp--cus-warn (form format &rest args) + (let* ((actual-fun (or (cdr (assq bytecomp--cus-function + '((custom-declare-group . defgroup) + (custom-declare-face . defface) + (custom-declare-variable . defcustom)))) + bytecomp--cus-function)) + (prefix (format "in %s%s: " + actual-fun + (if bytecomp--cus-name + (format " for `%s'" bytecomp--cus-name) + "")))) + (apply #'byte-compile-warn-x form (concat prefix format) args))) + +(defun bytecomp--check-cus-type (type) + (let ((invalid-types + '( + ;; Lisp type predicates, often confused with customisation types: + functionp numberp integerp fixnump natnump floatp booleanp + characterp listp stringp consp vectorp symbolp keywordp + hash-table-p facep + ;; other mistakes occasionally seen (oh yes): + or and nil t + interger intger lits bool boolen constant filename + kbd any list-of auto + ;; from botched backquoting + \, \,@ \` + ))) + (cond + ((consp type) + (let* ((head (car type)) + (tail (cdr type))) + (while (and (keywordp (car tail)) (cdr tail)) + (setq tail (cddr tail))) + (cond + ((plist-member (cdr type) :convert-widget) nil) + ((let ((tl tail)) + (and (not (keywordp (car tail))) + (progn + (while (and tl (not (keywordp (car tl)))) + (setq tl (cdr tl))) + (and tl + (progn + (bytecomp--cus-warn + tl "misplaced %s keyword in `%s' type" (car tl) head) + t)))))) + ((memq head '(choice radio)) + (unless tail + (bytecomp--cus-warn type "`%s' without any types inside" head)) + (let ((clauses tail) + (constants nil)) + (while clauses + (let* ((ty (car clauses)) + (ty-head (car-safe ty))) + (when (and (eq ty-head 'other) (cdr clauses)) + (bytecomp--cus-warn ty "`other' not last in `%s'" head)) + (when (memq ty-head '(const other)) + (let ((ty-tail (cdr ty)) + (val nil)) + (while (and (keywordp (car ty-tail)) (cdr ty-tail)) + (when (eq (car ty-tail) :value) + (setq val (cadr ty-tail))) + (setq ty-tail (cddr ty-tail))) + (when ty-tail + (setq val (car ty-tail))) + (when (member val constants) + (bytecomp--cus-warn + ty "duplicated value in `%s': `%S'" head val)) + (push val constants))) + (bytecomp--check-cus-type ty)) + (setq clauses (cdr clauses))))) + ((eq head 'string) + (let ((tag (plist-get (cdr type) :tag))) + (when (and (stringp tag) + (let ((case-fold-search t)) + (string-match-p (rx (or "regex" "regular expression")) + tag))) + (bytecomp--cus-warn + type "`string' with :tag %S should use type `regexp'?" tag)))) + ((eq head 'cons) + (unless (= (length tail) 2) + (bytecomp--cus-warn + type "`cons' requires 2 type specs, found %d" (length tail))) + (dolist (ty tail) + (bytecomp--check-cus-type ty))) + ((memq head '(list group vector set repeat)) + (unless tail + (bytecomp--cus-warn type "`%s' without type specs" head)) + (dolist (ty tail) + (bytecomp--check-cus-type ty))) + ((memq head '(alist plist)) + (let ((key-tag (memq :key-type (cdr type))) + (value-tag (memq :value-type (cdr type)))) + (when key-tag + (bytecomp--check-cus-type (cadr key-tag))) + (when value-tag + (bytecomp--check-cus-type (cadr value-tag))))) + ((memq head '(const other)) + (let* ((value-tag (memq :value (cdr type))) + (n (length tail)) + (val (car tail))) + (cond + ((or (> n 1) (and value-tag tail)) + (bytecomp--cus-warn type "`%s' with too many values" head)) + (value-tag + (setq val (cadr value-tag))) + ((and nil ; currently disabled + ;; This is a useful check but it results in perhaps + ;; a bit too many complaints. Keep it? + (null tail)) + (bytecomp--cus-warn + type "`%s' without value is implicitly nil" head) + ) + ) + (when (memq (car-safe val) '(quote function)) + (bytecomp--cus-warn type "`%s' with quoted value: %S" head val)))) + ((eq head 'quote) + (bytecomp--cus-warn type "accidentally quoted type: %s" (cadr type))) + ((memq head invalid-types) + (bytecomp--cus-warn type "`%s' is not a valid type" head)) + ((or (not (symbolp head)) (keywordp head)) + (bytecomp--cus-warn type "irregular type `%S'" head)) + ))) + ((or (not (symbolp type)) (keywordp type)) + (bytecomp--cus-warn type "irregular type `%S'" type)) + ((memq type '( list cons group vector choice radio const other + function-item variable-item set repeat restricted-sexp)) + (bytecomp--cus-warn type "`%s' without arguments" type)) + ((memq type invalid-types) + (bytecomp--cus-warn type "`%s' is not a valid type" type)) + ))) + +;; Uniform handler for multiple functions with similar arguments: +;; (NAME SOMETHING DOC KEYWORD-ARGS...) +(byte-defop-compiler-1 define-widget bytecomp--custom-declare) +(byte-defop-compiler-1 custom-declare-group bytecomp--custom-declare) +(byte-defop-compiler-1 custom-declare-face bytecomp--custom-declare) +(byte-defop-compiler-1 custom-declare-variable bytecomp--custom-declare) +(defun bytecomp--custom-declare (form) + (when (>= (length form) 4) + (let* ((name-arg (nth 1 form)) + (name (and (eq (car-safe name-arg) 'quote) + (symbolp (nth 1 name-arg)) + (nth 1 name-arg))) + (keyword-args (nthcdr 4 form)) + (fun (car form)) + (bytecomp--cus-function fun) + (bytecomp--cus-name name)) + + ;; Check :type + (when (memq fun '(custom-declare-variable define-widget)) + (let ((type-tag (memq :type keyword-args))) + (if (null type-tag) + ;; :type only mandatory for `defcustom' + (when (eq fun 'custom-declare-variable) + (bytecomp--cus-warn form "missing :type keyword parameter")) + (let ((dup-type (memq :type (cdr type-tag)))) + (when dup-type + (bytecomp--cus-warn + dup-type "duplicated :type keyword argument"))) + (let ((type-arg (cadr type-tag))) + (when (or (null type-arg) + (eq (car-safe type-arg) 'quote)) + (bytecomp--check-cus-type (cadr type-arg))))))) + + ;; Check :group + (when (cond + ((memq fun '(custom-declare-variable custom-declare-face)) + (not byte-compile-current-group)) + ((eq fun 'custom-declare-group) + (not (eq name 'emacs)))) + (unless (plist-get keyword-args :group) + (bytecomp--cus-warn form "fails to specify containing group"))) + + ;; Update current group + (when (and name + byte-compile-current-file ; only when compiling a whole file + (eq fun 'custom-declare-group)) + (setq byte-compile-current-group name)))) + + (byte-compile-normal-call form)) + + (put 'function-put 'byte-hunk-handler 'byte-compile-define-symbol-prop) (put 'define-symbol-prop 'byte-hunk-handler 'byte-compile-define-symbol-prop) (defun byte-compile-define-symbol-prop (form) --Apple-Mail=_B32AA598-69E8-4E4F-ACCB-FFA003CFAC07-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 17 11:20:37 2023 Received: (at 65852) by debbugs.gnu.org; 17 Sep 2023 15:20:37 +0000 Received: from localhost ([127.0.0.1]:51151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhtZc-0000aV-Th for submit@debbugs.gnu.org; Sun, 17 Sep 2023 11:20:37 -0400 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]:62867) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhtZb-0000aJ-Pd for 65852@debbugs.gnu.org; Sun, 17 Sep 2023 11:20:36 -0400 Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2bff936e10fso8478241fa.1 for <65852@debbugs.gnu.org>; Sun, 17 Sep 2023 08:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694964022; x=1695568822; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=lEMHcmnqMzDYCN8No51+edfQsA6YQ4gAgErM3R//q5c=; b=eJ/r2mX3dSTHBnX4vt+gGYzkDFzriqQaXQnZgyRp9ghqjGZydXC23sgAcxg74ZjR0R 2McnczzfnY1B2UK/sMrNr8S/TosQInnM+VG4hALvtrzIfeW/gZHxNwnfvjnD4NQ3cp7p xV2/Cl30j3eNYGGcvgJULb+MqjdBgFxTTXTk+Pt9V/XTiakw/8JPyDDywsCZsGlCTiGl B+13EgvNOOGR9ooeb1kdGWVBwT/yq0X3SKPrV7vCQQTtzRFuAOiUr6KVvUwm0ZOohf0g Csh0L+HwsA7X1BIXUTNMm8777ABZCp8DPnRHv0nSBk47oVttoYcywjkeWadLvQASOsPf IZuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694964022; x=1695568822; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=lEMHcmnqMzDYCN8No51+edfQsA6YQ4gAgErM3R//q5c=; b=EegyMVvUz+wXQkG+3Gibr4pyrtTvePwC4efIH4F74eWbBigtI/ODQxQBGZWySfD1ka Q3Ycj5YGPI/zVQyvqj5he6ubDdGR/sGvLLI9s31nb5OEloBj+vGJfSiehuSVnzu5kWXZ jFQj1Z8Qt80775BFwCMDokjJ6I7RZACHL1JoKKsIIUQDy9npiFV06sDJdcOGwg4Hpcb4 Qr+L/A0yyQ07PHTjVwPW3NSkcjk5/3YoXxVua0eAPKZr3aI35WJaFdazn1OU0luglrEW bEWwUG/ySTeIbMFuPkkt75FmLB/ttpTZrZtPnxmgiPXWS36IWCFj+JucK17tvYmncXwz 44iw== X-Gm-Message-State: AOJu0YxZ6DmMdtCYXbG3GfqGUHk+rPETOWMZX4S4FAH1AC1EWzfGjULQ XYrEesl8cTGkOqehqE0ISMs= X-Google-Smtp-Source: AGHT+IHxBw/1n081CaAlF30yBRa9tOQI8J1YhAXwF+ddVZovyMIP6e3UNdiL92Dks2mj4X+E/oPRgQ== X-Received: by 2002:a05:6512:340f:b0:4f8:6d9d:abe0 with SMTP id i15-20020a056512340f00b004f86d9dabe0mr2700699lfr.33.1694964021974; Sun, 17 Sep 2023 08:20:21 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id h10-20020ac25d6a000000b004f85d80ca64sm1448349lft.221.2023.09.17.08.20.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Sep 2023 08:20:21 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#65852: 30.0.50; image-auto-resize :type has choices in wrong order From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <8490D7BE-4204-4FC3-B583-D4D0674FB075@gmail.com> Date: Sun, 17 Sep 2023 17:20:20 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <7465BC99-81D1-4001-8C0D-C4E3CD26CF14@gmail.com> References: <081b5bd0-9652-cb7b-3c59-b07cab5e104d@gmail.com> <6fe31ce5-4be7-7f79-e310-52e04d869467@gmail.com> <865AB7EF-D175-4A6B-BD64-6C0EE0338D13@gmail.com> <8490D7BE-4204-4FC3-B583-D4D0674FB075@gmail.com> To: Stefan Kangas X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 65852 Cc: 65852@debbugs.gnu.org, Mauro Aranda X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) A slightly restrained version of the above patch is now on master. = Please let me know if anything needs changing. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 17 17:53:37 2023 Received: (at 65852) by debbugs.gnu.org; 17 Sep 2023 21:53:37 +0000 Received: from localhost ([127.0.0.1]:51569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhzhw-0005hW-Vc for submit@debbugs.gnu.org; Sun, 17 Sep 2023 17:53:37 -0400 Received: from mail-ot1-x32e.google.com ([2607:f8b0:4864:20::32e]:44190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhzht-0005hF-6d for 65852@debbugs.gnu.org; Sun, 17 Sep 2023 17:53:35 -0400 Received: by mail-ot1-x32e.google.com with SMTP id 46e09a7af769-6c454a5f3c7so173123a34.0 for <65852@debbugs.gnu.org>; Sun, 17 Sep 2023 14:53:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694987599; x=1695592399; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tXVYTNNPRiXs9ZLJ2SytNPrZcdkbWrVw6kSy1zPJod0=; b=brio6R0ukc6tWv4V8Lom33Weel/buDGqk8JLG7dBXLbBltosKjtJnCP2iBkA3CJxIG bPbIc8NYzrXlZLzkxnadcLCFCJV8l8bUsKaXXKXauPa9FftDSbUd1MBq5Ff55JuYOn5t iONVJMiYCoDMZhvhRiZCFBjOSb4P7AHVZ89l2n67oLOVQiDFi9d1lwNKNlZYhVQmABrf K98ZgmblamIzJj+Qqu/rwVVdsbjurUizbt110Wu9ZSTrhkqoFAMO9f9WDsA2/S09Ongs Av9FgNiaSbigKTc4fM58oYy61r5+vWUFR6DMQJwxno2AjcMMcfVUr5rJu1daK1mm1pKc uZog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694987599; x=1695592399; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tXVYTNNPRiXs9ZLJ2SytNPrZcdkbWrVw6kSy1zPJod0=; b=lCK6d4ktZHaVzvUOX526VtbUSwV7JEaKPtPVrwqJMAZZzmzpqx4wgfSb8t4Rlk9vf1 Tbmun0PwKZYcRqqrBpM6YYzLNuFXdV7MNJkLbTQ/uWRjN1oOs5UH8H3RNuZZstq7t0na uRDH+RuhbYnZ2SgB+92z1cQ3BWebaYGMcAv0yylqxjMYHprfX14UwaCSVyyiA2fhlRQk eLYjNfOMUcnJGl3J/H/fIlxFB6Sl2pk1u2pFloPcy1hjYWYck7KNwqOpf0WW/nvzz+J8 Uj3VXs3Rpi2gM8RSproci4dC4pdoiL/nrTLiuTAm0OAcaWo2Tf+nr9ReoZ4DVZ+XHUvf dsoQ== X-Gm-Message-State: AOJu0YxEvrUCkYNKlDMLdP/FPwhH4E19WH48/QwpDbr5Jzq3aILczbw0 HT9pU+TxnRDlwvbu3SbZPTM= X-Google-Smtp-Source: AGHT+IHEScsqRgj2xh1pG7VBK3D4A73PfntnoYfcGDxaJlWAxJjj2LhSQE/ZcH8qqOy4YH7a9FWVyA== X-Received: by 2002:a9d:6f04:0:b0:6b9:cba6:b246 with SMTP id n4-20020a9d6f04000000b006b9cba6b246mr8893102otq.9.1694987599457; Sun, 17 Sep 2023 14:53:19 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id v5-20020a05683011c500b006b9e872c0a0sm3601491otq.68.2023.09.17.14.53.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Sep 2023 14:53:18 -0700 (PDT) Message-ID: Date: Sun, 17 Sep 2023 18:53:15 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#65852: 30.0.50; image-auto-resize :type has choices in wrong order Content-Language: en-US To: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= , Stefan Kangas References: <081b5bd0-9652-cb7b-3c59-b07cab5e104d@gmail.com> <6fe31ce5-4be7-7f79-e310-52e04d869467@gmail.com> <865AB7EF-D175-4A6B-BD64-6C0EE0338D13@gmail.com> <8490D7BE-4204-4FC3-B583-D4D0674FB075@gmail.com> <7465BC99-81D1-4001-8C0D-C4E3CD26CF14@gmail.com> From: Mauro Aranda In-Reply-To: <7465BC99-81D1-4001-8C0D-C4E3CD26CF14@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.5 (-) X-Debbugs-Envelope-To: 65852 Cc: 65852@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) On 17/9/23 12:20, Mattias Engdegård wrote: > A slightly restrained version of the above patch is now on > master. Please let me know if anything needs changing. Thanks! I think https://debbugs.gnu.org/cgi/bugreport.cgi?bug=2591 can be closed. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 11 07:45:14 2023 Received: (at control) by debbugs.gnu.org; 11 Oct 2023 11:45:14 +0000 Received: from localhost ([127.0.0.1]:37664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqXeM-00083d-CV for submit@debbugs.gnu.org; Wed, 11 Oct 2023 07:45:14 -0400 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]:42083) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqXeK-00083M-OI for control@debbugs.gnu.org; Wed, 11 Oct 2023 07:45:13 -0400 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-50306b2920dso1046890e87.0 for ; Wed, 11 Oct 2023 04:44:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697024685; x=1697629485; darn=debbugs.gnu.org; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:sender:from:to:cc:subject:date:message-id:reply-to; bh=BMNGoxKPcRdizdKhOq5JOSUWqXRoijnsL93y5MPhfp8=; b=SrRfGsf95sxyRCzhUJSyYQ3AgaDcyy+Iep/otaWuYRXq7Ki/CWJV1sbcu7MUIVie/k qKzI3Iaapyzfl/H9M1QjnvLkQbYRsOaQLVns4JiF3e0YlKhhYWn+1QXzQ5rypcuI8UvB a8DyGT4DgIH6eWpSZakTa/q1smevs869NKNWeObAo7Z9lO3WsUfjopW4C6HVULg8zHbG rQFRNyP53vfH30d3Tl9nXOzWjjyNhwqFk01oPaRtU58I5XhsYiqnK4jjNcbqWuj9Wld2 7xhEB/U+XqS04Kw3c6QCXyIoCyieeIsQpAegOqN7AYS9DFHEYDYY1tBWL8LYbQ33H9Yp rKoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697024685; x=1697629485; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BMNGoxKPcRdizdKhOq5JOSUWqXRoijnsL93y5MPhfp8=; b=cg0BV4lZX+3kKFg/6+/lcYqlwf/bFCB0/UbXJR2babXNBjuR1/vkImnU8Qdc+osOfJ yxF6nqqh8a0aF2kvOL+t9yc+rC7JPrIjOQrkB7U/EyD/1DYgZdVPXTO7in1p6xSefItK O5a483ojRyS83XpSXz6/ZBK3x3C1qbBJE2uxB0Bqs1xgGVwrXLjQ4eQ1rEd5JNYxkvr8 RWcPcR7p50aUbIgZ9EGouFAQ3qzDt3XR/K0BP83E0oBPqgRT1hEUCKZeMzBsGtTlCeGQ W4r69KZfPNq89CpQ9zkhT1WLwd0ji4KPmYb71QrJYz1e1EGiLOZ/gANyV51wpC2rw69r L/dQ== X-Gm-Message-State: AOJu0YzmiWwwdJJXNJaTRqPeLYt5FeUP4TTSI8jEIb8M+dOJpg/eWcl+ FF1tYguC+ctWUTi/R77BFJhGPR/UtI/6CQ== X-Google-Smtp-Source: AGHT+IGwstmY8Q8fO1jhGe7d5MONlPQDNnini5PYLa7hVmq3j1TQQbo3QKYJaoVxcKazu7PZ+rN5mQ== X-Received: by 2002:a05:6512:3f29:b0:503:2941:3a14 with SMTP id y41-20020a0565123f2900b0050329413a14mr14366278lfa.27.1697024684413; Wed, 11 Oct 2023 04:44:44 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id s8-20020ac25fa8000000b0050482b29ac9sm2233490lfe.212.2023.10.11.04.44.43 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Oct 2023 04:44:43 -0700 (PDT) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: ctrl Message-Id: <5114BC01-3777-4E2D-AE6C-62EF2C5553BC@gmail.com> Date: Wed, 11 Oct 2023 13:44:42 +0200 To: control@debbugs.gnu.org X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) forcemerge 65852 2591 stop From unknown Mon Aug 11 21:12:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 08 Nov 2023 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator