GNU bug report logs - #65835
[PATCH] gnu: tensorflow-lite: Update to 2.13.0

Previous Next

Full log

Message #11 received at 65835 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Andy Tai <atai <at> atai.org>
Cc: 65835 <at> debbugs.gnu.org
Subject: Re: bug#65835: [PATCH] gnu: tensorflow-lite: Update to 2.13.0
Date: Thu, 14 Sep 2023 23:42:18 +0200

Hi,

Andy Tai <atai <at> atai.org> skribis:

> * gnu/packages/machine-learning.scm: (tensorflow-lite):
> Update to 2.13.0
> [inputs]: Add gemmlowp
> [native-inputs]: Remove gemmlowp-src
> * gnu/packages/patches/tensorflow-lite-disable-local-cmake-3rdparty-components.patch:
> New file

Overall LGTM.  Some comments…

Could you add the patch to ‘gnu/local.mk’?

> +       (patches
> +               (search-patches
> +                ;; patch to disable local cmake build code for 3rdparty
> +                ;; componentas
> +                "tensorflow-lite-disable-local-cmake-3rdparty-components.patch"))))

Please add the comment at the top of the patch itself, as reported by
‘guix lint’; also adjust indentation here as in the other files.

> +         (string-append "-Dgemmlowp_ROOT=" #$(this-package-input "gemmlowp"))
> +         )

Please move paren to the previous line.

>                  (invoke "tar" "--strip-components=1"
>                          "-xf" (assoc-ref inputs "fft2d-src")))
>  
> -              (copy-recursively (assoc-ref inputs "gemmlowp-src")
> -                                "/tmp/gemmlowp/")))
> +              ;(copy-recursively (assoc-ref inputs "gemmlowp-src")
> +              ;                  "/tmp/gemmlowp/")
> +
> +              ))

Leftover?  You can remove these two lines.

Could you send an updated patch?

Thanks in advance,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.