From unknown Sun Jun 22 17:15:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65832: [PATCH] guix: shell: Don't whitelist / by typo in `shell-authorized-directories'. Resent-From: Janneke Nieuwenhuizen Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 08 Sep 2023 20:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 65832 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: 65832@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.169420617630037 (code B ref -1); Fri, 08 Sep 2023 20:50:01 +0000 Received: (at submit) by debbugs.gnu.org; 8 Sep 2023 20:49:36 +0000 Received: from localhost ([127.0.0.1]:45749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeiQ3-0007oP-Hk for submit@debbugs.gnu.org; Fri, 08 Sep 2023 16:49:36 -0400 Received: from lists.gnu.org ([2001:470:142::17]:42208) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeiPy-0007o8-PO for submit@debbugs.gnu.org; Fri, 08 Sep 2023 16:49:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeiPq-0004jX-DA for bug-guix@gnu.org; Fri, 08 Sep 2023 16:49:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeiPp-0005v9-Hj; Fri, 08 Sep 2023 16:49:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=ynqbdq4vDN/V4O5wo06N4d9wfI9kwHKXvPI4BTHNyTo=; b=ShYb0a7sXfXzw5 byEcEYxrpuwUggChjR0VZThIlyPtFGsixueL/kWIoPiRiJd6uoTr6vuYvyxUfsQcY6xQW0SIjECtz pM1RuZs63rQXuf5SWVuG754+3jR3VJvJm6hSvaDKzuvzK19rmlk3DKAPZYl/B4nXMxUWz7tQzuWko IwVPyA4adYXpsOVMpZyc7v2SVZeqmOoSXivB719n6LDRudYWDbhMaJgahmLPcGlMEMP/YQVcew8Yp XIsmFm3PyYaksp7UVHUMfLGp1F6QjX5aV82Cm+OP/pasAx3MA/vSyotYgh+mSDynlZK5EG4o1awMK o4t+mYbBG6q7Pm9r5uVg==; From: Janneke Nieuwenhuizen Organization: AvatarAcademy.nl X-Url: http://AvatarAcademy.nl Date: Fri, 08 Sep 2023 22:49:11 +0200 Message-ID: <87tts4qtko.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Title says it all... So, i've started using direnv with envrc.el, really great! ...which meant that on top op `guix shell' pestering me with its shell-authorized-directories, I had to also type `direnv allow' all day. Anyway, I found that direnv has a whitelist, prefix even; so I looked into what guix shell might have and found that using --8<---------------cut here---------------start------------->8--- echo '-allow-all- > ~/.config/guix/shell-authorized-directories --8<---------------cut here---------------end--------------->8--- acts like an undocumented whitelist prefix for /. Find a fix attached. Greetings, Janneke --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-guix-shell-Don-t-whitelist-by-typo-in-shell-authoriz.patch Content-Transfer-Encoding: quoted-printable >From 5b7af1342f4f0d91df9de960877889d40b8c5d64 Mon Sep 17 00:00:00 2001 Message-ID: <5b7af1342f4f0d91df9de960877889d40b8c5d64.1694206063.git.jannek= e@gnu.org> From: Janneke Nieuwenhuizen Date: Wed, 6 Sep 2023 10:52:17 +0200 Subject: [PATCH] guix: shell: Don't whitelist / by typo in `shell-authorized-directories'. Fixes * guix/scripts/shell.scm (authorized-shell-directory?): After warning, continue LOOP to return valid query result for DIRECTORY. --- guix/scripts/shell.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/guix/scripts/shell.scm b/guix/scripts/shell.scm index d67152cef7..83888eee1d 100644 --- a/guix/scripts/shell.scm +++ b/guix/scripts/shell.scm @@ -1,5 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright =C2=A9 2021-2023 Ludovic Court=C3=A8s +;;; Copyright =C2=A9 2023 Janneke Nieuwenhuizen ;;; ;;; This file is part of GNU Guix. ;;; @@ -232,7 +233,8 @@ (define (authorized-shell-directory? directory) (port-line port) (port-column port)))) (warning loc (G_ "ignoring invalid file name: '~a'= ~%") - line)))))))))) + line) + (loop)))))))))) (const #f))) =20 (define (options-with-caching opts) base-commit: 4dd33fc62899134606f36f92594cf160b972f685 --=20 2.41.0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 Janneke Nieuwenhuizen | GNU LilyPond https://LilyPond.org Freelance IT https://www.JoyOfSource.com | Avatar=C2=AE https://AvatarAcade= my.com --=-=-=-- From unknown Sun Jun 22 17:15:23 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Janneke Nieuwenhuizen Subject: bug#65832: closed (Re: bug#65832: [PATCH] guix: shell: Don't whitelist / by typo in `shell-authorized-directories'.) Message-ID: References: <87ledgqtb5.fsf@gnu.org> <87tts4qtko.fsf@gnu.org> X-Gnu-PR-Message: they-closed 65832 X-Gnu-PR-Package: guix X-Gnu-PR-Keywords: patch Reply-To: 65832@debbugs.gnu.org Date: Fri, 08 Sep 2023 20:56:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1694206562-30614-1" This is a multi-part message in MIME format... ------------=_1694206562-30614-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #65832: [PATCH] guix: shell: Don't whitelist / by typo in `shell-authorized= -directories'. which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 65832@debbugs.gnu.org. --=20 65832: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D65832 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1694206562-30614-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 65832-done) by debbugs.gnu.org; 8 Sep 2023 20:55:11 +0000 Received: from localhost ([127.0.0.1]:45755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeiVS-0007wf-Ov for submit@debbugs.gnu.org; Fri, 08 Sep 2023 16:55:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeiVO-0007w0-BW for 65832-done@debbugs.gnu.org; Fri, 08 Sep 2023 16:55:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeiVG-0006wF-01; Fri, 08 Sep 2023 16:54:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=lhafqwD2pm/zJ6keIJXGd54umSJ/ag4aTIsgyYWMK0Y=; b=mH527lPgXI1giDyABDqA qQUE9Hs03OUOXhiM3F4c28Kp2MH4EvS4mahG9ipyVmwNueMOJTIb5+IHL1dpulbIxIyH6fIjfzqbC mLDIw1bPSAWIFNPKl1+Si5NgPzgWDQQxxKQVDbiA3WIxoWYYZ5lWxU9bxUKKKsa+Ms3HDkcU1PSeq lhWLWZN3y+64kT6zFrbg5gfH6ksYyJAXvymKTcA8Mcni693REjdhi17D58ATvReMql4/kRkd0bSLC NTMStm3zTXdGgLb5Xor15ghdVscE0kCWvHMuA7Wxra4RDqBf12U7KHZ+g1yOqnwftg5hCuOEYiGA8 fjPm1v4BjHJgjw==; From: Janneke Nieuwenhuizen To: 65832-done@debbugs.gnu.org Subject: Re: bug#65832: [PATCH] guix: shell: Don't whitelist / by typo in `shell-authorized-directories'. Organization: AvatarAcademy.nl References: <87tts4qtko.fsf@gnu.org> X-Url: http://AvatarAcademy.nl Date: Fri, 08 Sep 2023 22:54:54 +0200 In-Reply-To: <87tts4qtko.fsf@gnu.org> (Janneke Nieuwenhuizen's message of "Fri, 08 Sep 2023 22:49:11 +0200") Message-ID: <87ledgqtb5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65832-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Janneke Nieuwenhuizen writes: Hi! > Title says it all... [..] After discussing with the security team, pushed to master as 1ef4974be94d75d935d98399dcda44199a1fca47 Greetings, Janneke --=20 Janneke Nieuwenhuizen | GNU LilyPond https://LilyPond.org Freelance IT https://www.JoyOfSource.com | Avatar=C2=AE https://AvatarAcade= my.com ------------=_1694206562-30614-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 8 Sep 2023 20:49:36 +0000 Received: from localhost ([127.0.0.1]:45749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeiQ3-0007oP-Hk for submit@debbugs.gnu.org; Fri, 08 Sep 2023 16:49:36 -0400 Received: from lists.gnu.org ([2001:470:142::17]:42208) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeiPy-0007o8-PO for submit@debbugs.gnu.org; Fri, 08 Sep 2023 16:49:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeiPq-0004jX-DA for bug-guix@gnu.org; Fri, 08 Sep 2023 16:49:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeiPp-0005v9-Hj; Fri, 08 Sep 2023 16:49:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=ynqbdq4vDN/V4O5wo06N4d9wfI9kwHKXvPI4BTHNyTo=; b=ShYb0a7sXfXzw5 byEcEYxrpuwUggChjR0VZThIlyPtFGsixueL/kWIoPiRiJd6uoTr6vuYvyxUfsQcY6xQW0SIjECtz pM1RuZs63rQXuf5SWVuG754+3jR3VJvJm6hSvaDKzuvzK19rmlk3DKAPZYl/B4nXMxUWz7tQzuWko IwVPyA4adYXpsOVMpZyc7v2SVZeqmOoSXivB719n6LDRudYWDbhMaJgahmLPcGlMEMP/YQVcew8Yp XIsmFm3PyYaksp7UVHUMfLGp1F6QjX5aV82Cm+OP/pasAx3MA/vSyotYgh+mSDynlZK5EG4o1awMK o4t+mYbBG6q7Pm9r5uVg==; From: Janneke Nieuwenhuizen To: bug-guix@gnu.org Subject: [PATCH] guix: shell: Don't whitelist / by typo in `shell-authorized-directories'. Organization: AvatarAcademy.nl X-Url: http://AvatarAcademy.nl Date: Fri, 08 Sep 2023 22:49:11 +0200 Message-ID: <87tts4qtko.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Title says it all... So, i've started using direnv with envrc.el, really great! ...which meant that on top op `guix shell' pestering me with its shell-authorized-directories, I had to also type `direnv allow' all day. Anyway, I found that direnv has a whitelist, prefix even; so I looked into what guix shell might have and found that using --8<---------------cut here---------------start------------->8--- echo '-allow-all- > ~/.config/guix/shell-authorized-directories --8<---------------cut here---------------end--------------->8--- acts like an undocumented whitelist prefix for /. Find a fix attached. Greetings, Janneke --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-guix-shell-Don-t-whitelist-by-typo-in-shell-authoriz.patch Content-Transfer-Encoding: quoted-printable >From 5b7af1342f4f0d91df9de960877889d40b8c5d64 Mon Sep 17 00:00:00 2001 Message-ID: <5b7af1342f4f0d91df9de960877889d40b8c5d64.1694206063.git.jannek= e@gnu.org> From: Janneke Nieuwenhuizen Date: Wed, 6 Sep 2023 10:52:17 +0200 Subject: [PATCH] guix: shell: Don't whitelist / by typo in `shell-authorized-directories'. Fixes * guix/scripts/shell.scm (authorized-shell-directory?): After warning, continue LOOP to return valid query result for DIRECTORY. --- guix/scripts/shell.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/guix/scripts/shell.scm b/guix/scripts/shell.scm index d67152cef7..83888eee1d 100644 --- a/guix/scripts/shell.scm +++ b/guix/scripts/shell.scm @@ -1,5 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright =C2=A9 2021-2023 Ludovic Court=C3=A8s +;;; Copyright =C2=A9 2023 Janneke Nieuwenhuizen ;;; ;;; This file is part of GNU Guix. ;;; @@ -232,7 +233,8 @@ (define (authorized-shell-directory? directory) (port-line port) (port-column port)))) (warning loc (G_ "ignoring invalid file name: '~a'= ~%") - line)))))))))) + line) + (loop)))))))))) (const #f))) =20 (define (options-with-caching opts) base-commit: 4dd33fc62899134606f36f92594cf160b972f685 --=20 2.41.0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 Janneke Nieuwenhuizen | GNU LilyPond https://LilyPond.org Freelance IT https://www.JoyOfSource.com | Avatar=C2=AE https://AvatarAcade= my.com --=-=-=-- ------------=_1694206562-30614-1-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 11 11:49:07 2023 Received: (at control) by debbugs.gnu.org; 11 Sep 2023 15:49:07 +0000 Received: from localhost ([127.0.0.1]:54508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfj9v-0005vi-75 for submit@debbugs.gnu.org; Mon, 11 Sep 2023 11:49:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfj9s-0005uk-70 for control@debbugs.gnu.org; Mon, 11 Sep 2023 11:49:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfj9i-0005Rx-PV for control@debbugs.gnu.org; Mon, 11 Sep 2023 11:48:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to: references; bh=wU/W1wC/vA1QcBXhIKvHbKPlrpwD0iTaEhQwZ4ZMRdo=; b=YouZpSM0tLSZBh MVg00KJ8I0HTlijXSWnwTkRjo/4h/SBOf+1zn7XTEPidGu/5X5jVQclITjQuvHbijA2KGxd2ifP4H kk6aPJ9Yh1yGGfWMGuCMjrE0QyYGZqq6vuKG/jesHex2ijERXgK34lHJEnwIt7cWDiMQAAA3dAq8Q QynGQ0R1Flg6auMPrQKTcjSDlvImsgiW6ecTfj4LXYEzqg1EFD4SHQp5Fb7sMHHMx2Ak5M4N7lC+y /yj/WePzKbbQ3H2GatVIrkJl3q77GIHfC3zQUlrCrwxSzO1bBmOim1a9QgV/ZEVGbeVmQaP2gjyIZ uA4H1l6RR7cIga+NHk0w==; Date: Mon, 11 Sep 2023 17:48:38 +0200 Message-Id: <877cowsobt.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #65832 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) severity 65832 important quit From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 11 11:49:13 2023 Received: (at control) by debbugs.gnu.org; 11 Sep 2023 15:49:13 +0000 Received: from localhost ([127.0.0.1]:54512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfjA1-0005w2-GP for submit@debbugs.gnu.org; Mon, 11 Sep 2023 11:49:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfjA0-0005vh-6m for control@debbugs.gnu.org; Mon, 11 Sep 2023 11:49:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfj9q-0005TA-QP for control@debbugs.gnu.org; Mon, 11 Sep 2023 11:49:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to: references; bh=/aIHeuRFedS/H6WrQ9L+Qf2nVpErVhcVssubah/Qpmg=; b=jikHPvlbAyvM5l 7iq5EXWeZVyBeUbvS/9YY6dJ7e5XjX5dyIyVC1RLQS52SJBInevgJR/t2SEeXqiYRn6xkYH5uhQ5Z PanNA7ir8yLCaYosSPM/InKadwF8fXc7n3vtyN/WG+uu486sjDlwVXzDwQ5eafD7ybR6jcqJNnWed SWZ23EcqUIwqrBn9gZZFydPIyvrqR5XK8l7uwV3CC/5cnxc0ShCserfoPJs6cDjlZTY9rxhwiuXnR S+RChtTyd5584peWh+VBbBSS8t+3oCdW2cWTHlRHNOgFw1wtGFfcX8kKGRTUsdoJSqj1vEVAoOw0K rIsORAlYxdwca7vIb6pA==; Date: Mon, 11 Sep 2023 17:48:59 +0200 Message-Id: <875y4gsob8.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #65832 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 65832 + security quit From unknown Sun Jun 22 17:15:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#65832: [PATCH] guix: shell: Don't whitelist / by typo in `shell-authorized-directories'. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 11 Sep 2023 15:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65832 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch security To: Janneke Nieuwenhuizen Cc: 65832@debbugs.gnu.org Received: via spool by 65832-submit@debbugs.gnu.org id=B65832.169444740822943 (code B ref 65832); Mon, 11 Sep 2023 15:51:02 +0000 Received: (at 65832) by debbugs.gnu.org; 11 Sep 2023 15:50:08 +0000 Received: from localhost ([127.0.0.1]:54518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfjAt-0005xz-Rx for submit@debbugs.gnu.org; Mon, 11 Sep 2023 11:50:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfjAs-0005wx-0M for 65832@debbugs.gnu.org; Mon, 11 Sep 2023 11:50:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfjAh-0005dA-Jb; Mon, 11 Sep 2023 11:49:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=OILs2UnXottSdKg+Gj8J4NAnuRL9ETl3letFGYZKydw=; b=XjprwTadZUOn4I3gaaAq fFlnsAprdRtDeG2UucuxWmNv9imrqSppaMnlYkMn+xuB81BMkPO8C+Gk4f8AP68pjvYC6jyFM0klx IG/kj14OtdyV5IvnIlHRnt7CqqTUWoDFhx8xiXrQSkX10faQd3A9f+jWPEA1IF6ZUD1gBn8gloDV2 SgRY4yGVOLoBx4F3Vx1iwlDKtcZxPxl7i1iS389TTMTBjIPnx/aLpCJrgB7d0Y03GQEBzOo/45W5Z hFIT5SqYZSUo/gdDzlR7FEZZe+ICIIjZTj1meX2vgCmhGhsUC9dcfeaycmKcz2K14W6Ayd5epByf5 Y3y2LW4IhIcsqg==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87tts4qtko.fsf@gnu.org> Date: Mon, 11 Sep 2023 17:49:53 +0200 In-Reply-To: <87tts4qtko.fsf@gnu.org> (Janneke Nieuwenhuizen's message of "Fri, 08 Sep 2023 22:49:11 +0200") Message-ID: <871qf4so9q.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Janneke Nieuwenhuizen skribis: > From: Janneke Nieuwenhuizen > Date: Wed, 6 Sep 2023 10:52:17 +0200 > Subject: [PATCH] guix: shell: Don't whitelist / by typo in > `shell-authorized-directories'. > > Fixes > > * guix/scripts/shell.scm (authorized-shell-directory?): After warning, > continue LOOP to return valid query result for DIRECTORY. Thanks a lot for finding, reporting, and fixing this issue! Ludo=E2=80=99.