GNU bug report logs - #65792
[PATCH] gnu: rottlog: Add gawk as an input.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Skyler <skyvine <at> protonmail.com>
Subject: bug#65792: closed (Re: bug#65792: [PATCH] gnu: rottlog: Add gawk
 as an input.)
Date: Thu, 14 Sep 2023 14:55:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#65792: [PATCH] gnu: rottlog: Add gawk as an input.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 65792 <at> debbugs.gnu.org.

-- 
65792: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65792
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Skyler <skyvine <at> protonmail.com>
Cc: 65792-done <at> debbugs.gnu.org
Subject: Re: bug#65792: [PATCH] gnu: rottlog: Add gawk as an input.
Date: Thu, 14 Sep 2023 16:54:06 +0200

Hi,

Skyler <skyvine <at> protonmail.com> skribis:

> This avoids an issue where rottlog will delete the entire /tmp directory
> if gawk is not installed.
>
> * gnu/packages/admin.scm (rottlog): Add gawk input, also update the
> patch-paths build phase for awk invocations.

Applied, thank you, and thanks for explaining!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Skyler <skyvine <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: rottlog: Add gawk as an input.
Date: Thu, 07 Sep 2023 02:01:51 +0000

[Message part 4 (text/plain, inline)]

This avoids an issue where rottlog will delete the entire /tmp directory
if gawk is not installed.

* gnu/packages/admin.scm (rottlog): Add gawk input, also update the
patch-paths build phase for awk invocations.
---
gnu/packages/admin.scm | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 604cd70c02..ea437e9f26 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -1931,7 +1931,11 @@ (define-public rottlog
(lambda* (#:key inputs #:allow-other-keys)
(substitute* "rc/rc"
(("/usr/sbin/sendmail")
- (search-input-file inputs "/bin/mail")))))
+ (search-input-file inputs "/bin/mail")))
+ (with-fluids ((%default-port-encoding "ISO-8859-1"))
+ (substitute* "src/rottlog"
+ (("awk")
+ (search-input-file inputs "/bin/awk"))))))
(add-after 'build 'set-packdir
(lambda _
;; Set a default location for archived logs.
@@ -1950,7 +1954,7 @@ (define-public rottlog
(lambda _
(invoke "make" "install-info"))))))
(native-inputs (list autoconf automake texinfo util-linux)) ; for 'cal'
- (inputs (list coreutils mailutils))
+ (inputs (list coreutils gawk mailutils))
(home-page "https://www.gnu.org/software/rottlog/")
(synopsis "Log rotation and management")
(description

base-commit: e365c26a34fa485f9af46538fcea128db681c33d
--
2.41.0

[Message part 5 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.