GNU bug report logs - #65787
time-machine is doing too much network requests

Previous Next

Full log

Message #14 received at 65787 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 65787 <at> debbugs.gnu.org
Subject: Re: bug#65787: time-machine is doing too much network requests
Date: Mon, 11 Sep 2023 13:36:40 +0200

[Message part 1 (text/plain, inline)]

Oops, missing diff for clarity. :-)

On Mon, 11 Sep 2023 at 11:41, Simon Tournier <zimon.toutoune <at> gmail.com> wrote:

> If yes, here two examples:

Adding ’pk’ where ’remote-fetch’ and ’branch-lookup’ are called.

[p.patch (text/x-diff, inline)]

diff --git a/guix/git.scm b/guix/git.scm
index 1cb87a45607b..0209826c5c00 100644
--- a/guix/git.scm
+++ b/guix/git.scm
@@ -234,8 +234,10 @@ (define (resolve-reference repository ref)
   (let resolve ((ref ref))
     (match ref
       (('branch . branch)
-       (let ((oid (reference-target
-                   (branch-lookup repository branch BRANCH-REMOTE))))
+       (let ((oid (begin
+                    (pk 'branch-lookup 'NETWORK)
+                    (reference-target
+                          (branch-lookup repository branch BRANCH-REMOTE)))))
          (object-lookup repository oid)))
       (('symref . symref)
        (let ((oid (reference-name->oid repository symref)))
@@ -483,8 +485,10 @@ (define* (update-cached-checkout url
      ;; Only fetch remote if it has not been cloned just before.
      (when (and cache-exists?
                 (not (reference-available? repository ref)))
-       (remote-fetch (remote-lookup repository "origin")
-                     #:fetch-options (make-default-fetch-options)))
+       (begin
+         (pk 'remote-fetch 'NETWORK)
+         (remote-fetch (remote-lookup repository "origin")
+                       #:fetch-options (make-default-fetch-options))))
      (when recursive?
        (update-submodules repository #:log-port log-port
                           #:fetch-options (make-default-fetch-options)))

[Message part 3 (text/plain, inline)]

Cheers,
simon

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.