GNU bug report logs - #6577
turn on -Wstrict-prototypes by default

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dan Nicolaescu <dann <at> gnu.org>
Subject: bug#6577: closed (Re: bug#6577: turn on -Wstrict-prototypes by
 default)
Date: Wed, 06 Feb 2013 08:48:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#6577: turn on -Wstrict-prototypes by default

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 6577 <at> debbugs.gnu.org.

-- 
6577: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6577
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: 6577-done <at> debbugs.gnu.org
Subject: Re: bug#6577: turn on -Wstrict-prototypes by default
Date: Wed, 06 Feb 2013 03:45:53 -0500

Version: 24.3

IIUC we now have this and much more via gnulib with the
--enable-gcc-warnings option of configure.

[Message part 3 (message/rfc822, inline)]

From: Dan Nicolaescu <dann <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: turn on -Wstrict-prototypes by default
Date: Tue, 06 Jul 2010 22:59:48 -0400

This patch turns on -Wstrict-prototypes to help transition to standard C.
[Archived here so that it does not get lost].

The error and message declarations in lisp.h need to be converted to
standard C (and the definition should use variable number of
arguments), otherwise this patch results in many warnings.

But if someone wants to check this in to speed up the process...

=== modified file 'configure.in'
--- configure.in  2010-07-02 12:55:51 +0000
+++ configure.in  2010-07-02 19:31:41 +0000
@@ -757,6 +757,20 @@ CFLAGS="$SAVE_CFLAGS"
 unset has_option
 unset SAVE_CFLAGS
 
+### Use -Wstrict-prototypes if the compiler supports it
+AC_MSG_CHECKING([whether gcc understands -Wstrict-prototypes])
+SAVE_CFLAGS="$CFLAGS"
+CFLAGS="$CFLAGS -Wstrict-prototypes"
+AC_TRY_COMPILE([], [], has_option=yes, has_option=no,)
+if test $has_option = yes; then
+   C_WARNINGS_SWITCH="-Wstrict-prototypes $C_WARNINGS_SWITCH"
+fi
+AC_MSG_RESULT($has_option)
+CFLAGS="$SAVE_CFLAGS"
+unset has_option
+unset SAVE_CFLAGS
+
+
 #### Some other nice autoconf tests.
 
 dnl checks for programs

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.