GNU bug report logs - #65762
[PATCH] ; Fix error in 'tex-recenter-output-buffer'

Previous Next

Package: emacs;

Reported by: Eshel Yaron <me <at> eshelyaron.com>

Date: Tue, 5 Sep 2023 17:13:02 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#65762: closed ([PATCH] ; Fix error in 'tex-recenter-output-buffer')
Date: Wed, 06 Sep 2023 16:40:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Wed, 06 Sep 2023 19:39:10 +0300
with message-id <83edjb1ck1.fsf <at> gnu.org>
and subject line Re: bug#65762: [PATCH] ; Fix error in 'tex-recenter-output-buffer'
has caused the debbugs.gnu.org bug report #65762,
regarding [PATCH] ; Fix error in 'tex-recenter-output-buffer'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
65762: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65762
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Eshel Yaron <me <at> eshelyaron.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] ; Fix error in 'tex-recenter-output-buffer'
Date: Tue, 05 Sep 2023 19:12:41 +0200
[Message part 3 (text/plain, inline)]
Tags: patch

This fixes an issue in `tex-recenter-output-buffer` (which affect
several other commands that rely on it) where it calls `display-buffer`
and tries to select the returned window, without checking that
`display-buffer` returned non-nil.  This leads to an error when
`display-tex-shell-buffer-action` or `display-buffer-alist` are
configured to prevent the display of the *tex-shell* buffer.

[0001-Fix-error-in-tex-recenter-output-buffer.patch (text/patch, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Eli Zaretskii <eliz <at> gnu.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 65762-done <at> debbugs.gnu.org, me <at> eshelyaron.com, tsdh <at> gnu.org
Subject: Re: bug#65762: [PATCH] ; Fix error in 'tex-recenter-output-buffer'
Date: Wed, 06 Sep 2023 19:39:10 +0300
> Date: Wed, 6 Sep 2023 18:21:18 +0200
> Cc: me <at> eshelyaron.com, 65762 <at> debbugs.gnu.org
> From: martin rudalics <rudalics <at> gmx.at>
> 
>  > Martin, any further comments?
> 
> The patch looks good and should be applied.

Thanks, installed on the emacs-29 branch and closing the bug.


This bug report was last modified 1 year and 309 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.