GNU bug report logs - #65762
[PATCH] ; Fix error in 'tex-recenter-output-buffer'

Previous Next

Full log

Message #14 received at 65762 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Tassilo Horn <tsdh <at> gnu.org>, martin rudalics <rudalics <at> gmx.at>
Cc: me <at> eshelyaron.com, 65762 <at> debbugs.gnu.org
Subject: Re: bug#65762: [PATCH] ; Fix error in 'tex-recenter-output-buffer'
Date: Wed, 06 Sep 2023 15:27:14 +0300

> From: Tassilo Horn <tsdh <at> gnu.org>
> Cc: Eshel Yaron <me <at> eshelyaron.com>, 65762 <at> debbugs.gnu.org
> Date: Wed, 06 Sep 2023 13:03:26 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> Hi Eshel & Eli,
> 
> >> This fixes an issue in `tex-recenter-output-buffer` (which affect
> >> several other commands that rely on it) where it calls
> >> `display-buffer` and tries to select the returned window, without
> >> checking that `display-buffer` returned non-nil.  This leads to an
> >> error when `display-tex-shell-buffer-action` or
> >> `display-buffer-alist` are configured to prevent the display of the
> >> *tex-shell* buffer.
> >
> > Thanks.  Tassilo, any comments?
> 
> Yes, looks right in cases where display-tex-shell-buffer-action is
> display-buffer-no-window or maybe something similar is achieved by
> display-buffer-alist which would lead to errors right now.  But I'm no
> authority here, tex-mode.el is not tex.el (from auctex).

Thanks.

Martin, any further comments?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.